{"id":2225573,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225573/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260421075439.16696-9-ravi@prevas.dk/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421075439.16696-9-ravi@prevas.dk>","list_archive_url":null,"date":"2026-04-21T07:54:38","name":"[v2,8/9] drivers/core: use memdup() instead of malloc()+memcpy()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f6206d3abb5a44f943ce7f16e8fbffb91915b808","submitter":{"id":89443,"url":"http://patchwork.ozlabs.org/api/1.2/people/89443/?format=json","name":"Rasmus Villemoes","email":"ravi@prevas.dk"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.2/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260421075439.16696-9-ravi@prevas.dk/mbox/","series":[{"id":500753,"url":"http://patchwork.ozlabs.org/api/1.2/series/500753/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500753","date":"2026-04-21T07:54:32","name":"add memdup_nul(), use it and memdup() in a few places","version":2,"mbox":"http://patchwork.ozlabs.org/series/500753/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225573/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225573/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256\n header.s=selector1 header.b=DpjizCWn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.b=\"DpjizCWn\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk","phobos.denx.de;\n spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=prevas.dk;"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0F6Q1My1z1yGs\n\tfor ; Tue, 21 Apr 2026 17:56:14 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 741E48439F;\n\tTue, 21 Apr 2026 09:55:25 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id AFB7B84376; Tue, 21 Apr 2026 09:55:12 +0200 (CEST)","from GVXPR05CU001.outbound.protection.outlook.com\n (mail-swedencentralazlp170130007.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c202::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 273638435C\n for ; Tue, 21 Apr 2026 09:55:06 +0200 (CEST)","from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:681::18)\n by DU0PR10MB5995.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:3b1::12)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.32; Tue, 21 Apr\n 2026 07:55:02 +0000","from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8]) by AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8%6]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 07:55:01 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=R7xtF1O+AUXy0FePRbiWq1Q4nlEqw6E/+VInihNXopwboMdwsRb/T3icc3ca9J05ipdnn/IfNM4nXgaJBiUlHnW3Ofbl5xxRwmJsMHr3UuikqEITFABj120HCCXxMdqjJceDEmfTLiH9H+zqQvCzKDq3KWkdJYsa7cLn4NkRRPtwWd4ZXo0UJ4AGv6BqiK3mLd9gbhfnbm/J6COteb2Q/bCyMbt49naeJIvxPb9oypOJd85SLU+AADLct+n3qgfeXFB57meN9vWV6ZhRxdSsSMvzISHd6KXERyWpEinhY1LqDbnmBuNr8IOXKsbuDOE1l1L+DVIqq5CA0IIp5A0kdA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=2aqzUMss3HigyAp4pp8Dsp0yQ5opqbLCAGcj+BzAXJk=;\n b=Y4sSj/fO5r0TsA64gLDLfvBzOJQTGgdJ/7G6GzlCXCkslsoeOsRJpQg9LtMRBBuRmOXQRo7uN0Lt1VL521sAjYiD4pEsugxhjGMlMx5fGqJ92D40Kt4n78IFO02mJj2O2y308baWf5fMSegE0dx0WwqmEusbMDw+zf0Eh/uyr6X71kyugF66AH5sx0gv+3Ud459PmbZX2qkHz8EMsNUOPlNNPhDIMSo4Q2yvajTiPNERHXF98fdZpMfZVOOLbUGcSyUq4bQTAMTbjb0+IJkvXzBQ7uRQpYWR4ZXa3lclbWGV/7flvI+xvCAUF0aoukpcbZkb8m+6po2TTMn0VEn/ug==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk;\n dkim=pass header.d=prevas.dk; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=2aqzUMss3HigyAp4pp8Dsp0yQ5opqbLCAGcj+BzAXJk=;\n b=DpjizCWn7Tg/3wdb49xhrNYtOPjMLXK3IpabnCpBN151IMeQ8YspsmaV2OYUqxldnmgtQfjL5n00UJUPcxMZJfsy8WztVK+ivn/9XsEqUyqpAUrdRDV1kUO/EfV035szVt0LcV2nkPUTYkyx5SfP/5CNYlqWD55p3bEfjoosRYU=","From":"Rasmus Villemoes ","To":"u-boot@lists.denx.de","Cc":"Tom Rini , Simon Glass ,\n Rasmus Villemoes ","Subject":"[PATCH v2 8/9] drivers/core: use memdup() instead of\n malloc()+memcpy()","Date":"Tue, 21 Apr 2026 09:54:38 +0200","Message-ID":"<20260421075439.16696-9-ravi@prevas.dk>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260421075439.16696-1-ravi@prevas.dk>","References":"<20260421075439.16696-1-ravi@prevas.dk>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"CPBP307CA0011.DNKP307.PROD.OUTLOOK.COM (2603:10a6:380:1::6)\n To AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:681::18)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS5PR10MB8243:EE_|DU0PR10MB5995:EE_","X-MS-Office365-Filtering-Correlation-Id":"06b57b99-819a-47f9-9202-08de9f7b4ac1","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|52116014|376014|1800799024|366016|38350700014|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n RHJfyW/pk+BxrvAbguuGqtoqRXfzGcMtETOp+JCiiBZtqD54LCpniY7aTVYkZBkrOx4Lk4L2Fh3N47J3IW7mL9tWLnA5WRlpKpMYNhlBUr/yo0sCzyLR/SBlBN/j+TOwhtVPgO90LgiOWoN2wfJ/GYhEDlxLltlczg6qvUm+AOuBCmrgW4Hh0OBGFnOy1rodWrVUI9EWOA1YyPnMlRc2kgJC9KrQei0iMKg9iAnkLtgg/PB17fVng8XJzaseqIbHDeznSeTiAhDB550Y7U0dzkpvCoRBGntbpCIW4LgHWMVZq95/E1SuQKKkYAevhcz4A6CvK/oGqtidXjoqtYL/2qzSaBuZeMyBg4STgvkn8Wd/4Bk59z5UilyW0CyLQOTp6SrufDR0qPAAVkYC8BrMzD9CwDrOFRGP/DtproLQGuO5+FI1QGRCdlvUCOkiXCZ+GQbOA6c4qxkUIC1OXM5rZIRELNEd4kfNQIZfIqC4/2fThKWefyDdw9TVSb0WZNOwb6PTzERqFHmC534ge4wAKlxgmGtJUoasZ+FQ8nD5Ugfwa1vWXoy0/4PYe1BH/tdEuW7TGhgOS8JFODUtQUiNRQxjVp+R+9GIBLSM10yCsnFATXn+b2ibiIZGf7bcyi9h+u1HB2WRVCqikxK1edLLki674+9LFWfxeagpOpGKpb9c5f7sP1/ByZ/htjOLSyA7g3L5bRi6yVcH0UDKDxegUnDpjuf6KYNTNORDbgPJ/19E0mZ6/xCyKIg+N7OGcKvxkwXUpK0Qd+wvbCq07vbDRjH/L+2hb6kYxGUNZvAFyGY=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n jr8sj5FDKAbt1qWrqwPWGj1NoJa7iblAHTXKQE8qDhF2qbO9z8+uuEsnGEB1Ow+1iQQV5D1kDRu0S+ZSnFA/Mb4UEqYdqDO/oOVyGUs9YZT/nWkkWSWCLd5oIfoA9xuqiMY4Qx60z6QZo17VWf8JFIstdzo/PWoiJgkS2n7FknuAT5Gf1uiy6kf4ydlH+7esiZ8hfaNVBaOFY8hVtzHONyASoqD+GHEW1usR6cuXpbha/AhO3JV2NqsvutAB8LBufNRSXFsTLL/Iy8iorenqLoNG1c9B99HpeJiWZz0K+bSrWYZyi16TCMTQVOhzWc2X+lb9k4nKOEXq/w5LJ2zA6rHBgXzc7knkNh7fdjA85br8cmzpSVJJSFX0KWb3utkzGoRscz1h4k6x/kZo760jm98ARvacAiR9L6yJvXfuN6znwXToyjmfZBmDMP7tdx832yDOa+W33+3A8gpSpLmks5F5IZoa9FOWskvXzcwTkIdcS914l8dLo75NufmT09fP8wejfRyMWHAQeu9ZU2mM+pOCR5zpIN2qhRUsZMA7jPFUPF7lYol5k3Z1+0a+pAOYGPT2Klxmt55qX8iT+0VYBA0ptcqksLzo21LStZ2tfjoTFl0e7he+EOm8k/1LwMopC8bsB3NLkGlCqENRfqj/CiY+l+KxuWjMRHtZ715TTiaVjH1u9H2GfnbEX+9+WBYjoKOqnuVprp2etLFgEgAScaAvXKgwpf+Xt5231mingIZsl6QU9yp/QW/FS+/Rh6k7Qot3E8jeSBRzJMC6Kcnt3IJMuqHqSjovVQvo2q7Kz5s4cutwKzz2OiRF2ODYdFyqJOATtv8D0JIur7+R5sKe2bDy3kMwOg7QoalAFPrmqlV/Gx8pk3I20bbIgoJRIXhKbvfCMFOhmrwhNXc7H6XMBWHYL6iTrF48Pb4h70jsWU00ay1zA0iuzk/6uo2i5OyWO/5Il17Ezd5cnfn6BhQS9UEmGHPgJWHTFjuMLVqUMTm8Nda0ku6Tb+es5NWR+Vz2liN+gfHZwXtypnm0JgWXo6ULBv2pbwb5MEGRu3wvTut2RNtq9fQbvHcTC5+zySHMWL7RIg8TsyJjg458YuL0yydtLkHqMjGjRc+YJIO6vQN2nyLLYAMd5bWAOvXR6yu0bhPP5oSFL4W3w24bJfq4z6m4hxG/aiFe/4pVZCKh9uWjSVUjygwHBLXnlPk7I4NXf+V9lJjEdYBLAhQ9OAidtxzrknANB6cUPwPLHIPmTrd/8ASxS1L+N+r5nBXwthFZuhIIthKkSUGkllU6n3PfD1PlddsY0tdbwQzg8Iu09DZRbgqbIa9pwMW+9VTWBWJ/zcMQBUqGgvA5T+38wDj5HB5j+39gAyG/t9Mm+cuWjFKz2T4Yc2Qbngip4eCcG55iTc26dvS2U+hbRORanO9q6MxQK/BMW9lntdI2Cj9O1hL8uJTxPcKLu+x93vWOCqJ1CQING30ZIcTePA37+NO9uZdOcskgeUw9RbdkIIHsuzbKamYtcuNAYw9JXYhRyro3s/0BobVUWws/og/mA5gMv2ft9gEUUiBqsyotSi59HKAVZY+pAFoOI6eHIGi0wqvQEI2eSfaUAQPl2JHXutIRtk+kb1m4DCILBBBzyThTLzDl5tg1DykvjDAK3Qnh7UjQSOh9hRaQ9fzlnwjbPy1IxBhnXpSmopKBxqL2ypY8v0Xfus9YRfNMylNn7Pkdgc2g6OTwlf66wBnTcnZsM7OFe1uzNPU1HQuA+1aem8dg0X4=","X-OriginatorOrg":"prevas.dk","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 06b57b99-819a-47f9-9202-08de9f7b4ac1","X-MS-Exchange-CrossTenant-AuthSource":"AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 07:55:01.8866 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"d350cf71-778d-4780-88f5-071a4cb1ed61","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n FnzrpJMr6RcWsgSDnFMiWzw2dcW+S9tg3gh9hKMQtYkd4nhjYzJ6nF8mS++3jPZZGRYGN2iKXOjGs23uiUfNdmLL5RODx+o9AUbm4LkMijw=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DU0PR10MB5995","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Use memdup() instead of open-coding it.\n\nIn the dm_setup_inst() case, there was never any reason to use\ncalloc(), as the whole allocation is definitely initialized via the\nimmediately following memcpy().\n\nReviewed-by: Simon Glass \nSigned-off-by: Rasmus Villemoes \n---\n drivers/core/acpi.c | 3 +--\n drivers/core/ofnode.c | 3 +--\n drivers/core/root.c | 3 +--\n 3 files changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/core/acpi.c b/drivers/core/acpi.c\nindex 4763963914b..6a431171c8d 100644\n--- a/drivers/core/acpi.c\n+++ b/drivers/core/acpi.c\n@@ -154,10 +154,9 @@ static int add_item(struct acpi_ctx *ctx, struct udevice *dev,\n \tif (!item->size)\n \t\treturn 0;\n \tif (type != TYPE_OTHER) {\n-\t\titem->buf = malloc(item->size);\n+\t\titem->buf = memdup(start, item->size);\n \t\tif (!item->buf)\n \t\t\treturn log_msg_ret(\"mem\", -ENOMEM);\n-\t\tmemcpy(item->buf, start, item->size);\n \t}\n \titem_count++;\n \tlog_debug(\"* %s: Added type %d, %p, size %x\\n\",\ndiff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c\nindex 3a36b6fdd03..12511f10aa9 100644\n--- a/drivers/core/ofnode.c\n+++ b/drivers/core/ofnode.c\n@@ -1750,10 +1750,9 @@ int ofnode_write_prop(ofnode node, const char *propname, const void *value,\n \t\tvoid *newval;\n \n \t\tif (copy) {\n-\t\t\tnewval = malloc(len);\n+\t\t\tnewval = memdup(value, len);\n \t\t\tif (!newval)\n \t\t\t\treturn log_ret(-ENOMEM);\n-\t\t\tmemcpy(newval, value, len);\n \t\t\tvalue = newval;\n \t\t}\n \t\tret = of_write_prop(ofnode_to_np(node), propname, len, value);\ndiff --git a/drivers/core/root.c b/drivers/core/root.c\nindex d43645f34dd..1f32f33b295 100644\n--- a/drivers/core/root.c\n+++ b/drivers/core/root.c\n@@ -81,10 +81,9 @@ static int dm_setup_inst(void)\n \t\t/* Now allocate space for the priv/plat data, and copy it in */\n \t\tsize = __priv_data_end - __priv_data_start;\n \n-\t\tbase = calloc(1, size);\n+\t\tbase = memdup(__priv_data_start, size);\n \t\tif (!base)\n \t\t\treturn log_msg_ret(\"priv\", -ENOMEM);\n-\t\tmemcpy(base, __priv_data_start, size);\n \t\tgd_set_dm_priv_base(base);\n \t}\n \n","prefixes":["v2","8/9"]}