{"id":2225516,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225516/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>","list_archive_url":null,"date":"2026-04-21T06:16:12","name":"[v2,2/5] gpu: nova-core: use warn_on_err macro","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"31e00a1a6c27215c8188124799befb58aa65cca0","submitter":{"id":13521,"url":"http://patchwork.ozlabs.org/api/1.2/people/13521/?format=json","name":"Alexandre Courbot","email":"acourbot@nvidia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com/mbox/","series":[{"id":500739,"url":"http://patchwork.ozlabs.org/api/1.2/series/500739/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=500739","date":"2026-04-21T06:16:10","name":"gpu: nova-core: run unload sequence upon unbinding","version":2,"mbox":"http://patchwork.ozlabs.org/series/500739/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225516/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225516/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=a622oRNz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52813-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"a622oRNz\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=40.93.201.22","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g0C030F8Rz1yCv\n\tfor ; Tue, 21 Apr 2026 16:20:35 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C3D843048099\n\tfor ; Tue, 21 Apr 2026 06:16:29 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8C95237EFFB;\n\tTue, 21 Apr 2026 06:16:29 +0000 (UTC)","from CY3PR05CU001.outbound.protection.outlook.com\n (mail-westcentralusazon11013022.outbound.protection.outlook.com\n [40.93.201.22])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E36E223336;\n\tTue, 21 Apr 2026 06:16:28 +0000 (UTC)","from CH2PR12MB3990.namprd12.prod.outlook.com (2603:10b6:610:28::18)\n by CYYPR12MB8749.namprd12.prod.outlook.com (2603:10b6:930:c6::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.15; Tue, 21 Apr\n 2026 06:16:25 +0000","from CH2PR12MB3990.namprd12.prod.outlook.com\n ([fe80::7de1:4fe5:8ead:5989]) by CH2PR12MB3990.namprd12.prod.outlook.com\n ([fe80::7de1:4fe5:8ead:5989%4]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026\n 06:16:25 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776752189; cv=fail;\n b=e2VBL6DlcNBE/MGS7r6BREr+Cvzv0za4AxAxXGOt/1QQ7oHZ5tUIQ3hZF9/i9DJf2ma+IM0Ra+KT3BwSiPzyJmeYbkqAuDORSoTK5eA/gXGaPbumzO4z8gJEM7KvtWmOt4JsIwP7HaPW1mUN44EIbZaMEZc9BUSoIFMdBw3HViI=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=OLiDd83FtLPvc+KBtunYx4XrFYlijkgvMAYEIKJbw4Rb8z/EHFimm4xyybXBdTFhsMshot6eR0prXd2Qn+JGk4n2KrQxwWc9bGlg4sBUFwPxE6IpAYySoupTlSUGFnve9sN769Y7159BUAHp3wsDf7AmTRkDxjY5/q/KiYJ1Vtbg5WU/LBlkFKsMjiWFlZHrrpp4kAMh+AZEiw37YkTwkR3xYKzrLJIXAPrhseliCfdweCE6g/esA0wYCtLzu1pzpayJbhIFrbqpoY6sJ4qRwfvJ2eG2JI+ezzfm65u83EcNrLd0J5preVZcD3dCXGxe1ccwFYTUnEWaR6F3Rha6Rg=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776752189; c=relaxed/simple;\n\tbh=Jj+IC2t/PZbeTCtMc6F5Wofmogp69pO2PC175yz6xX4=;\n\th=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To:\n\t To:Cc:MIME-Version;\n b=qr/fta5GOfN6wWfPMhc1f548Vs8yVl3+3lbySTJ+nlBxx5TIoXVBoPLa8hYRVaPp+4H8BafYYSV/mUBKfkxNRYb1RlCfwv8dKrHVwGju7nu/fH3cTZQHMn0IjLiB8T3C8F9j5jDij2qXIvtCXRVXpd2gMWD1AK+mzDxKMcmyUmg=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=kAzLwaziRXkvaxR8YooA4xbA/aXdhKtnWKSUvoKNonw=;\n b=yFyxF+G1Lq0LYWG493qFLgl/ykX+daftt1gcp62kpb+ogBv2ua0Z9InQNmIZdce3rBs2Den+1xiqDrkVhP4yFdwxXDEVE+Zrf/jUl0NkGxQd3WaV/WmlSKbMHtF8i0ipMRN6PPXMR1wRvCA+AUVLUD/oTR4D4+X7SHrY7aM+4bD54vilFXXb+5+WZtBcWBbKVy2Li18eYLynWj+vTjZpNrVUqgoDDxYaqSBufbk7zAbFFMmKN8YTS7lCOvatKVbvU8nJdk3erLN3+VkdKrqa3ydYe8hHzUK8Lfo7ajA30Xb8GazwZn3nwYg0/nZxYaBlcAGUmE/YoV21U8ybZkMOQw=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=a622oRNz; arc=fail smtp.client-ip=40.93.201.22","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kAzLwaziRXkvaxR8YooA4xbA/aXdhKtnWKSUvoKNonw=;\n b=a622oRNznyG0HgiYsfu65sXUsIt6BVP+F4L60auVWTogiN7h1EQrcg7xUQFDdKQUaJ20y+1ROCFeZ6a9wkPYBDNBUos+0/zy6IhpGbv0VvUcjXDAobXIWg7Nzpf9wipMF9SLEvqrf5yIK8Cw/zB/cFuRzYtGYFRoEvkRb3ZGDRw3Dv+k4sa0ztO37hu945WsWFJca/apuJQMT+79fCaU07nyCkfz5NpYwxVPhtOZv5LfGrAUTD1AykDySUFSVCTwi9KvUCL3Ado93rcpTq2ZSKPOwLruiwfiay+Dzb6RvLTc2K8DZoggEPEqifNYvP7FBbrfoz48jhcp1Sahix2//g==","From":"Alexandre Courbot ","Date":"Tue, 21 Apr 2026 15:16:12 +0900","Subject":"[PATCH v2 2/5] gpu: nova-core: use warn_on_err macro","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260421-nova-unload-v2-2-2fe54963af8b@nvidia.com>","References":"<20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>","In-Reply-To":"<20260421-nova-unload-v2-0-2fe54963af8b@nvidia.com>","To":"Danilo Krummrich , Alice Ryhl ,\n David Airlie , Simona Vetter ,\n Bjorn Helgaas ,\n =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ,\n Miguel Ojeda , Gary Guo , =?utf-8?q?Bj?=\n\t=?utf-8?q?=C3=B6rn_Roy_Baron?= ,\n Benno Lossin , Andreas Hindborg ,\n Trevor Gross , Boqun Feng ","Cc":"John Hubbard ,\n Alistair Popple ,\n Joel Fernandes , Timur Tabi ,\n Eliot Courtney , nouveau@lists.freedesktop.org,\n dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,\n linux-pci@vger.kernel.org, rust-for-linux@vger.kernel.org,\n Alexandre Courbot ","X-Mailer":"b4 0.15.2","X-ClientProxiedBy":"TY4P286CA0102.JPNP286.PROD.OUTLOOK.COM\n (2603:1096:405:380::16) To CH2PR12MB3990.namprd12.prod.outlook.com\n (2603:10b6:610:28::18)","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"CH2PR12MB3990:EE_|CYYPR12MB8749:EE_","X-MS-Office365-Filtering-Correlation-Id":"cc2302ee-db66-49bf-c580-08de9f6d8412","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|376014|7416014|1800799024|10070799003|366016|921020|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n\t865ThFFxgAeFuB4pffWlcfTXFUqV/1fz7PIzfTfnAKiNDdmpEEhc42b47fWbRMigajfVK4xOiVzJfuyGUd68kE9eAHxmmRtZuPLsDgmGBlx4AVEriZ/baDe1Ckcbh/8oVcij5qPLCNzKsVmojCKU9niBm5JeHgrWyTkYXlazAdAPw/I8njqb2mv+zW0jzQjbiId0Eqhv9q35Sw8ueoloqvietRKLLfReILnKE8f6i/t9KVGGpM6/XVXDWOtA3GXR7ZJeVD/mqJiKOjdeHq5EEDk5FK5YnZKSzhYi32NwOHY7wPFrDGo61lhxnoGZ577lojSY7BNrDDg1pQ+8IiU65cEY1N12osDPxFrikVdpjz5oxXWKdjgml15A8gOSgVfAybnGt4JCYIxsdb4hAy+tEUEcgdRYgOml7Ti+U2iqq7rjTpoxB5RKoZO2rM++2N3gNGj+9kUS4+k5BaQRelkz8D+d1+TEJzryh9RtPKyJa1i9AGxUwmYWwuxNydXpLbfR3vrwpBTa3ptBW6+sYKEfA1PiTwVHzUZzlc8lBHctixmNsAcNU+SC7dRVDUdzkZCUO0zVCwbllL5bhoSEoJQQ92TKYjpS26ukpUZB509vmSoFgwoggY/NedHYzD50BMByVQFXHw27/33FkO2ccY17JmveXlbiad+hv1jJSbFTIpArY/dqDjBI/ye48yH245B0Fg5rtQPpX049bR74W8AgDQzMKNNN3ip+qJ0m3HMBkhm+YV4QslQF97HD4+INt/WbzeAWnnG7VMuOkNl75AYASg==","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR12MB3990.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(1800799024)(10070799003)(366016)(921020)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?XOWwKzS2+osgIWUp0ITUc22r1C1D?=\n\t=?utf-8?q?X1dtfMiQrLPk85Wb5Tjg2t6ioeXQNJgqRFtqIfbvyl2q8rp76wR6sRnuUj0aoGLLw?=\n\t=?utf-8?q?2Sj9M/XkH/6r3nUEImqrh6pyMnoNOe6DaaFn0U4OCchyee2ztdvgzoUpSO5YAtOAE?=\n\t=?utf-8?q?CbXjx6nZoWnPaMQeZNRhKFqhIBuCAvPExtp33wwN4Iu6BkW0Ddmb574JkwbG4/g1a?=\n\t=?utf-8?q?qORc7ZKH8H0LIho2EBnu9Ygl/vj7tl37EWhf0BYA1Qh84h/FmGbS9fe1B+SbgO5TR?=\n\t=?utf-8?q?e+pPQhf6ja9g/cCYtcCm3Q41UWbFlGIA7Ik0DsofdBJhm/yuIoHQZ7hW1whTMED4G?=\n\t=?utf-8?q?L1UaO+exadrwKDzHWhDK1/wPMpGMd4Mka03gZWVyncQ9Qn7w0DxPLiKEP5KdbB6qG?=\n\t=?utf-8?q?r3VjHLfgHxlIBPMuJY/GVTSB3Eb/dFJ8SWJ7etk3gv613d68CtA4qgVwa8BMxnd+d?=\n\t=?utf-8?q?mud4fjVxdAiqWsyuXKl9gKlYdrjRLvRneK014zN9yEGRB8dAwiM6d2EUySHFlwb1F?=\n\t=?utf-8?q?/JFBDd64H+8jceCoZ0/gx85ls4uvDMibn8uFHigYZ9Y9EiQFk4cJzHdltwwEC4EFt?=\n\t=?utf-8?q?swJ8RF4syLVJQNgP1J3/rkRZ3yNkVNSw5p8h86mEgnuxfRse0lYEZwWh5jF3oPp/A?=\n\t=?utf-8?q?yP1aCjJXzcUbE5/Ow6CcPFuPP2tRo+Xx36ciKfuOf4q2zE4MhBMYpkwS1x4cnT7cA?=\n\t=?utf-8?q?Lxxi1USrZhm8zZ1JDFf5OKtiCsyIaBkkjM8BQFFnBPgrJmOTswQSzofJ7kFpiD0co?=\n\t=?utf-8?q?/mHCXMcnnYeXKLw4+bEtgnQFThVN4B8/ny/tlL0cbxzj0D0Ic0ujz8og+yEXGiBS8?=\n\t=?utf-8?q?fWKHuyUk6mCWf5FDqi3JG/os16sGHTD1laAuNbw7KvIi1OIn9TDRikf1MOnp6Lxf1?=\n\t=?utf-8?q?086wz5su7Fc0xGTAGcHMIiXhTBb2Wy6MUyuKwo5Ih2Xzvs+UKw0td/TkL8mQeCWUy?=\n\t=?utf-8?q?JWxmUmvA+iKB+5MbTSOuEXPBdkvCy/K+Q5XGx04NwhtEC6oedh/NSwSfF8k+vJpmD?=\n\t=?utf-8?q?OBly++TkdXuh4lJ29uSsLg1LDIDB0uMqDwX74QkV7L0eeIjoNbuRvHd6mm8/Oz1Yd?=\n\t=?utf-8?q?+9gr7D9CDwOI1ERfvfxXy/jV3l1apkrdQ511TmoNbpQDR7sD0oGfHNgGtxG1RzWw+?=\n\t=?utf-8?q?jEcuAfohB0V4ZwfSZHA13r6OsysbG07bF5Ab9ttdA1m3E9lznoJ7XKzJ0eDytYnSO?=\n\t=?utf-8?q?Mces7BpK/8nOCS8Yk6rsV6FyCQ21C/S36S4ifuycaF3Zw339dNqfAhQ8aSCY1igtC?=\n\t=?utf-8?q?qTvKqUKCvtlwGbPx2xZk8C1Rl4H9drWUas5EjmbBhjpUZ53EmKncp40tkRzJ+KAlJ?=\n\t=?utf-8?q?cX8a4sSXk5QMYsUa+O8V5oMc1ww3/jV9VYk2vkwbON1sZymrti7dhpzdcjxfW9leu?=\n\t=?utf-8?q?stpOWYoce8rNUxemIASYK3GevPWBJtSE2OljnpcYdfMz9I4HyoZvb6A2y08e8iPg7?=\n\t=?utf-8?q?l/s3RCcCht+I4pozof2r2TWDA4N3eIJxcuvACE5az9mnPnIOoU7WS2OYWsyjfcCBq?=\n\t=?utf-8?q?JNsfnEVK2AV9tlUp+N5fHSYWIX9nKzx+crOLz5EfsgFrtUoes3ccDD2p1tXoujRry?=\n\t=?utf-8?q?dkqT75OCZzBkpeIt5Dw7V8/q8PJh/W+Ez2izGuuFNuUqe2wMnYpdkG/ZTkfgvFWRf?=\n\t=?utf-8?q?v3GHM1F/l/KH0qqFESGSMAcRcswM7Wn+6KEsVRRjZXJ76PxC5Dr6mDbySQEhgsPtV?=\n\t=?utf-8?q?iJxAcKHOLbDs4Gki0?=","X-MS-Exchange-AntiSpam-MessageData-1":"aGproGQ30nAB1A==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n cc2302ee-db66-49bf-c580-08de9f6d8412","X-MS-Exchange-CrossTenant-AuthSource":"CH2PR12MB3990.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"21 Apr 2026 06:16:25.0595\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 92nHmB+0vKlWj9xHgYhggdkWBZksSpJophkIOpFaWsUEtaOO3u3SH6HTbN1GnDOnXimZlREy434H2Xc8ZfiYkQ==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CYYPR12MB8749"},"content":"Use the warn_on_err macro in the unbind sequence, and refactor it to\nearly-exit on the failure path as we will need to use the bar for other\npurposes.\n\nSigned-off-by: Alexandre Courbot \n---\n drivers/gpu/nova-core/gpu.rs | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs\nindex 0f6fe9a1b955..1701c2600538 100644\n--- a/drivers/gpu/nova-core/gpu.rs\n+++ b/drivers/gpu/nova-core/gpu.rs\n@@ -279,10 +279,10 @@ pub(crate) fn new<'a>(\n ///\n /// Note: This method must only be called from `Driver::unbind`.\n pub(crate) fn unbind(&self, dev: &device::Device) {\n- kernel::warn_on!(self\n- .bar\n- .access(dev)\n- .inspect(|bar| self.sysmem_flush.unregister(bar))\n- .is_err());\n+ let Ok(bar) = kernel::warn_on_err!(self.bar.access(dev)) else {\n+ return;\n+ };\n+\n+ self.sysmem_flush.unregister(bar);\n }\n }\n","prefixes":["v2","2/5"]}