{"id":2225323,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225323/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420202032.714884-3-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420202032.714884-3-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:20:23","name":"[v2,02/10] vhost: use consistent naming for backend handlers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4d0f6df88eefbf8fa90eadbc68477bbfb79fe2a9","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.2/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420202032.714884-3-vsementsov@yandex-team.ru/mbox/","series":[{"id":500676,"url":"http://patchwork.ozlabs.org/api/1.2/series/500676/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500676","date":"2026-04-20T20:20:24","name":"vhost-user: VHOST_USER_PROTOCOL_F_GPA_ADDRESSES","version":2,"mbox":"http://patchwork.ozlabs.org/series/500676/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225323/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225323/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=XR+dSqgG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxj84m3tz1yCv\n\tfor ; Tue, 21 Apr 2026 06:21:48 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEv74-00064i-P7; Mon, 20 Apr 2026 16:20:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEv6r-000609-AS\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:20:45 -0400","from forwardcorp1b.mail.yandex.net ([178.154.239.136])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEv6n-0006Na-QK\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:20:45 -0400","from mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net\n [IPv6:2a02:6b8:c0c:c00c:0:640:e0de:0])\n by forwardcorp1b.mail.yandex.net (Yandex) with ESMTPS id 3C000805E6;\n Mon, 20 Apr 2026 23:20:39 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-80.iva.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id XKYwe10MOSw0-ogOWU9hW; Mon, 20 Apr 2026 23:20:38 +0300"],"X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776716438;\n bh=Lzt97Sdzbosd8ah6Nzek9EVLzTq2J3EisHziWG/rcKI=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=XR+dSqgGpUIrYdsHOhKA3LfQuQZcKSVFH8+ImEDL0EiVXTLY/vuyTyMC/KVrRHyIw\n dufSZaQOwfQiv7ajQsQp5+o0GSUtR9KsVX8+4ZTBXpgL7HAgaU94iS7z7HsRvNPg/t\n o3Dt8FL6Wk7tFPsLjyHzRcOsXiq0QW1IfMDVwpJY=","From":"Vladimir Sementsov-Ogievskiy ","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, qemu-devel@nongnu.org, vsementsov@yandex-team.ru,\n d-tatianin@yandex-team.ru","Subject":"[PATCH v2 02/10] vhost: use consistent naming for backend handlers","Date":"Mon, 20 Apr 2026 23:20:23 +0300","Message-ID":"<20260420202032.714884-3-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420202032.714884-1-vsementsov@yandex-team.ru>","References":"<20260420202032.714884-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.136;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1b.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Most of handlers start from simply .vhost_, except for these\nfour, starting from .vhost_backend_. Let's rename them to be\nconsistent.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \n---\n hw/virtio/vhost-backend.c | 6 +++---\n hw/virtio/vhost-user.c | 8 ++++----\n hw/virtio/vhost-vdpa.c | 6 +++---\n hw/virtio/vhost.c | 14 +++++++-------\n include/hw/virtio/vhost-backend.h | 17 ++++++++---------\n 5 files changed, 25 insertions(+), 26 deletions(-)","diff":"diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c\nindex fea88afc39a..caeadd069b0 100644\n--- a/hw/virtio/vhost-backend.c\n+++ b/hw/virtio/vhost-backend.c\n@@ -358,9 +358,9 @@ static void vhost_kernel_set_iotlb_callback(struct vhost_dev *dev,\n \n const VhostOps kernel_ops = {\n .backend_type = VHOST_BACKEND_TYPE_KERNEL,\n- .vhost_backend_init = vhost_kernel_init,\n- .vhost_backend_cleanup = vhost_kernel_cleanup,\n- .vhost_backend_memslots_limit = vhost_kernel_memslots_limit,\n+ .vhost_init = vhost_kernel_init,\n+ .vhost_cleanup = vhost_kernel_cleanup,\n+ .vhost_memslots_limit = vhost_kernel_memslots_limit,\n .vhost_net_set_backend = vhost_kernel_net_set_backend,\n .vhost_scsi_set_endpoint = vhost_kernel_scsi_set_endpoint,\n .vhost_scsi_clear_endpoint = vhost_kernel_scsi_clear_endpoint,\ndiff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c\nindex 6978d8ee947..78ffb25d6b1 100644\n--- a/hw/virtio/vhost-user.c\n+++ b/hw/virtio/vhost-user.c\n@@ -3115,10 +3115,10 @@ void vhost_user_qmp_status(struct vhost_dev *dev, VirtioStatus *status)\n \n const VhostOps user_ops = {\n .backend_type = VHOST_BACKEND_TYPE_USER,\n- .vhost_backend_init = vhost_user_backend_init,\n- .vhost_backend_cleanup = vhost_user_backend_cleanup,\n- .vhost_backend_memslots_limit = vhost_user_memslots_limit,\n- .vhost_backend_no_private_memslots = vhost_user_no_private_memslots,\n+ .vhost_init = vhost_user_backend_init,\n+ .vhost_cleanup = vhost_user_backend_cleanup,\n+ .vhost_memslots_limit = vhost_user_memslots_limit,\n+ .vhost_no_private_memslots = vhost_user_no_private_memslots,\n .vhost_set_log_base = vhost_user_set_log_base,\n .vhost_set_mem_table = vhost_user_set_mem_table,\n .vhost_set_vring_addr = vhost_user_set_vring_addr,\ndiff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c\nindex 9c7634e2439..93474624898 100644\n--- a/hw/virtio/vhost-vdpa.c\n+++ b/hw/virtio/vhost-vdpa.c\n@@ -1590,8 +1590,8 @@ static bool vhost_vdpa_force_iommu(struct vhost_dev *dev)\n \n const VhostOps vdpa_ops = {\n .backend_type = VHOST_BACKEND_TYPE_VDPA,\n- .vhost_backend_init = vhost_vdpa_init,\n- .vhost_backend_cleanup = vhost_vdpa_cleanup,\n+ .vhost_init = vhost_vdpa_init,\n+ .vhost_cleanup = vhost_vdpa_cleanup,\n .vhost_set_log_base = vhost_vdpa_set_log_base,\n .vhost_set_vring_addr = vhost_vdpa_set_vring_addr,\n .vhost_set_vring_num = vhost_vdpa_set_vring_num,\n@@ -1602,7 +1602,7 @@ const VhostOps vdpa_ops = {\n .vhost_get_features = vhost_vdpa_get_features,\n .vhost_set_owner = vhost_vdpa_set_owner,\n .vhost_set_vring_endian = NULL,\n- .vhost_backend_memslots_limit = vhost_vdpa_memslots_limit,\n+ .vhost_memslots_limit = vhost_vdpa_memslots_limit,\n .vhost_set_mem_table = vhost_vdpa_set_mem_table,\n .vhost_set_features = vhost_vdpa_set_features,\n .vhost_reset_device = vhost_vdpa_reset_device,\ndiff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex 4d42f8bda41..ffd7d404cc7 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -58,7 +58,7 @@ unsigned int vhost_get_max_memslots(void)\n struct vhost_dev *hdev;\n \n QLIST_FOREACH(hdev, &vhost_devices, entry) {\n- max = MIN(max, hdev->vhost_ops->vhost_backend_memslots_limit(hdev));\n+ max = MIN(max, hdev->vhost_ops->vhost_memslots_limit(hdev));\n }\n return max;\n }\n@@ -69,7 +69,7 @@ unsigned int vhost_get_free_memslots(void)\n struct vhost_dev *hdev;\n \n QLIST_FOREACH(hdev, &vhost_devices, entry) {\n- unsigned int r = hdev->vhost_ops->vhost_backend_memslots_limit(hdev);\n+ unsigned int r = hdev->vhost_ops->vhost_memslots_limit(hdev);\n unsigned int cur_free = r - hdev->mem->nregions;\n \n if (unlikely(r < hdev->mem->nregions)) {\n@@ -664,8 +664,8 @@ static bool vhost_section(struct vhost_dev *dev, MemoryRegionSection *section)\n */\n if ((memory_region_get_fd(section->mr) < 0 ||\n !qemu_ram_is_shared(section->mr->ram_block)) &&\n- dev->vhost_ops->vhost_backend_no_private_memslots &&\n- dev->vhost_ops->vhost_backend_no_private_memslots(dev)) {\n+ dev->vhost_ops->vhost_no_private_memslots &&\n+ dev->vhost_ops->vhost_no_private_memslots(dev)) {\n trace_vhost_reject_section(mr->name, 2);\n return false;\n }\n@@ -1674,7 +1674,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n r = vhost_set_backend_type(hdev, backend_type);\n assert(r >= 0);\n \n- r = hdev->vhost_ops->vhost_backend_init(hdev, opaque, errp);\n+ r = hdev->vhost_ops->vhost_init(hdev, opaque, errp);\n if (r < 0) {\n goto fail;\n }\n@@ -1691,7 +1691,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n goto fail;\n }\n \n- limit = hdev->vhost_ops->vhost_backend_memslots_limit(hdev);\n+ limit = hdev->vhost_ops->vhost_memslots_limit(hdev);\n if (limit < MEMORY_DEVICES_SAFE_MAX_MEMSLOTS &&\n memory_devices_memslot_auto_decision_active()) {\n error_setg(errp, \"some memory device (like virtio-mem)\"\n@@ -1809,7 +1809,7 @@ void vhost_dev_cleanup(struct vhost_dev *hdev)\n g_free(hdev->mem);\n g_free(hdev->mem_sections);\n if (hdev->vhost_ops) {\n- hdev->vhost_ops->vhost_backend_cleanup(hdev);\n+ hdev->vhost_ops->vhost_cleanup(hdev);\n }\n assert(!hdev->log);\n \ndiff --git a/include/hw/virtio/vhost-backend.h b/include/hw/virtio/vhost-backend.h\nindex 57497e197aa..aab6bf3ef7e 100644\n--- a/include/hw/virtio/vhost-backend.h\n+++ b/include/hw/virtio/vhost-backend.h\n@@ -51,10 +51,9 @@ struct vhost_scsi_target;\n struct vhost_iotlb_msg;\n struct vhost_virtqueue;\n \n-typedef int (*vhost_backend_init)(struct vhost_dev *dev, void *opaque,\n- Error **errp);\n-typedef int (*vhost_backend_cleanup)(struct vhost_dev *dev);\n-typedef int (*vhost_backend_memslots_limit)(struct vhost_dev *dev);\n+typedef int (*vhost_init)(struct vhost_dev *dev, void *opaque, Error **errp);\n+typedef int (*vhost_cleanup)(struct vhost_dev *dev);\n+typedef int (*vhost_memslots_limit)(struct vhost_dev *dev);\n \n typedef int (*vhost_net_set_backend_op)(struct vhost_dev *dev,\n struct vhost_vring_file *file);\n@@ -131,7 +130,7 @@ typedef int (*vhost_crypto_create_session_op)(struct vhost_dev *dev,\n typedef int (*vhost_crypto_close_session_op)(struct vhost_dev *dev,\n uint64_t session_id);\n \n-typedef bool (*vhost_backend_no_private_memslots_op)(struct vhost_dev *dev);\n+typedef bool (*vhost_no_private_memslots_op)(struct vhost_dev *dev);\n \n typedef int (*vhost_get_inflight_fd_op)(struct vhost_dev *dev,\n uint16_t queue_size,\n@@ -166,10 +165,10 @@ typedef int (*vhost_check_device_state_op)(struct vhost_dev *dev, Error **errp);\n \n typedef struct VhostOps {\n VhostBackendType backend_type;\n- vhost_backend_init vhost_backend_init;\n- vhost_backend_cleanup vhost_backend_cleanup;\n- vhost_backend_memslots_limit vhost_backend_memslots_limit;\n- vhost_backend_no_private_memslots_op vhost_backend_no_private_memslots;\n+ vhost_init vhost_init;\n+ vhost_cleanup vhost_cleanup;\n+ vhost_memslots_limit vhost_memslots_limit;\n+ vhost_no_private_memslots_op vhost_no_private_memslots;\n vhost_net_set_backend_op vhost_net_set_backend;\n vhost_net_set_mtu_op vhost_net_set_mtu;\n vhost_scsi_set_endpoint_op vhost_scsi_set_endpoint;\n","prefixes":["v2","02/10"]}