{"id":2225314,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225314/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-18-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420200339.708640-18-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:03:32","name":"[v6,17/22] vhost: move busyloop timeout initialization to vhost_virtqueue_init()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"79d1944b643d4a767713e0c22e007e2a44a4a8f3","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.2/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-18-vsementsov@yandex-team.ru/mbox/","series":[{"id":500672,"url":"http://patchwork.ozlabs.org/api/1.2/series/500672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672","date":"2026-04-20T20:03:18","name":"vhost refactoring and fixes","version":6,"mbox":"http://patchwork.ozlabs.org/series/500672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225314/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225314/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=ywciq/40;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxN967dMz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 21 Apr 2026 06:07:05 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wEur2-0001lX-6s; Mon, 20 Apr 2026 16:04:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqx-0001Z8-Ma\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:19 -0400","from forwardcorp1d.mail.yandex.net ([178.154.239.200])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <vsementsov@yandex-team.ru>)\n id 1wEuqw-00020F-4t\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:19 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id D2D598075D;\n Mon, 20 Apr 2026 23:04:16 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-sfRtE90u; Mon, 20 Apr 2026 23:04:16 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715456;\n bh=9H42VfdWXv4YR9fUBy+45ZxRHJLalt72HE6C4geWja4=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=ywciq/407nKvyyLDStnLQ5Civcs8456EvORmQY77lwg8a6AH2ZM3LryjPlUpp33x3\n cPNvayL0jsKAErcRu8YFlpq7NUDGyTNPevoMQwbpfkHAT9F7IwBSfjeLvtD8ZQPVja\n Z0FvLGDFsnQK+64eN0M/AYgQOyEZSlbFbuBBBIcI=","From":"Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz <raphael.s.norwitz@gmail.com>","Subject":"[PATCH v6 17/22] vhost: move busyloop timeout initialization to\n vhost_virtqueue_init()","Date":"Mon, 20 Apr 2026 23:03:32 +0300","Message-ID":"<20260420200339.708640-18-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","References":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.200;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Let's all per-virtqueue initializations be in one place.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>\nReviewed-by: Raphael Norwitz <raphael.s.norwitz@gmail.com>\nReviewed-by: Daniil Tatianin <d-tatianin@yandex-team.ru>\n---\n hw/virtio/vhost.c | 25 ++++++++++++-------------\n 1 file changed, 12 insertions(+), 13 deletions(-)","diff":"diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex 7f370f393e9..55ce7ae977f 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1496,7 +1496,8 @@ static void vhost_virtqueue_error_notifier(EventNotifier *n)\n }\n \n static int vhost_virtqueue_init(struct vhost_dev *dev,\n-                                struct vhost_virtqueue *vq, int n)\n+                                struct vhost_virtqueue *vq, int n,\n+                                bool busyloop_timeout)\n {\n     int vhost_vq_index = dev->vhost_ops->vhost_get_vq_index(dev, n);\n     struct vhost_vring_file file = {\n@@ -1533,6 +1534,14 @@ static int vhost_virtqueue_init(struct vhost_dev *dev,\n                                    vhost_virtqueue_error_notifier);\n     }\n \n+    if (busyloop_timeout) {\n+        r = vhost_virtqueue_set_busyloop_timeout(dev, n, busyloop_timeout);\n+        if (r < 0) {\n+            VHOST_OPS_DEBUG(r, \"Failed to set busyloop timeout\");\n+            goto fail_err;\n+        }\n+    }\n+\n     return 0;\n \n fail_err:\n@@ -1611,24 +1620,14 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n     }\n \n     for (i = 0; i < hdev->nvqs; ++i, ++n_initialized_vqs) {\n-        r = vhost_virtqueue_init(hdev, hdev->vqs + i, hdev->vq_index + i);\n+        r = vhost_virtqueue_init(hdev, hdev->vqs + i, hdev->vq_index + i,\n+                                 busyloop_timeout);\n         if (r < 0) {\n             error_setg_errno(errp, -r, \"Failed to initialize virtqueue %d\", i);\n             goto fail;\n         }\n     }\n \n-    if (busyloop_timeout) {\n-        for (i = 0; i < hdev->nvqs; ++i) {\n-            r = vhost_virtqueue_set_busyloop_timeout(hdev, hdev->vq_index + i,\n-                                                     busyloop_timeout);\n-            if (r < 0) {\n-                error_setg_errno(errp, -r, \"Failed to set busyloop timeout\");\n-                goto fail;\n-            }\n-        }\n-    }\n-\n     virtio_features_copy(hdev->_features_ex, features);\n \n     hdev->memory_listener = (MemoryListener) {\n","prefixes":["v6","17/22"]}