{"id":2225303,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225303/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-19-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420200339.708640-19-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:03:33","name":"[v6,18/22] vhost: vhost_dev_init(): simplify features initialization","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3f92f27c283bb34e39f1806689f39102bf7d805b","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.2/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-19-vsementsov@yandex-team.ru/mbox/","series":[{"id":500672,"url":"http://patchwork.ozlabs.org/api/1.2/series/500672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672","date":"2026-04-20T20:03:18","name":"vhost refactoring and fixes","version":6,"mbox":"http://patchwork.ozlabs.org/series/500672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225303/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225303/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=Yo9hkl0p;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxLr52hRz1yCv\n\tfor ; Tue, 21 Apr 2026 06:05:56 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEur2-0001lv-NW; Mon, 20 Apr 2026 16:04:24 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEur0-0001gF-4g\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:22 -0400","from forwardcorp1d.mail.yandex.net\n ([2a02:6b8:c41:1300:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEuqy-00020p-EV\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:21 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id B97898075E;\n Mon, 20 Apr 2026 23:04:18 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-i8DFrlwM; Mon, 20 Apr 2026 23:04:17 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715458;\n bh=vyElk3FXLNKWSELumKfi8IPDAq8aQq0zwO2Sd49gLCs=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=Yo9hkl0pAj+aU4PtUgTEnzd4COY8bEZ4ONuImVPL/ZWkQw+Z/S1nXBBNVw1bNYx4O\n AkGvXniSpr/D4+cVfjC5qWju5QqGX+ziKpCC4uvrng1tJseFg1jFgfeFsl9u8yCXbQ\n Jb3k5gbU3Ijl18ZKqQ9AHSiXdAyi+GpOdIJcqzKg=","From":"Vladimir Sementsov-Ogievskiy ","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz ","Subject":"[PATCH v6 18/22] vhost: vhost_dev_init(): simplify features\n initialization","Date":"Mon, 20 Apr 2026 23:03:33 +0300","Message-ID":"<20260420200339.708640-19-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","References":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Drop extra variable and extra function parameter passing, initialize\ndev._features directly.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nReviewed-by: Daniil Tatianin \nReviewed-by: Raphael Norwitz \n---\n hw/virtio/vhost.c | 14 +++++---------\n 1 file changed, 5 insertions(+), 9 deletions(-)","diff":"diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex 55ce7ae977f..93c6a5f5e9a 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1560,18 +1560,17 @@ static void vhost_virtqueue_cleanup(struct vhost_virtqueue *vq)\n }\n }\n \n-static int vhost_dev_get_features(struct vhost_dev *hdev,\n- uint64_t *features)\n+static int vhost_dev_init_features(struct vhost_dev *hdev)\n {\n uint64_t features64;\n int r;\n \n if (hdev->vhost_ops->vhost_get_features_ex) {\n- return hdev->vhost_ops->vhost_get_features_ex(hdev, features);\n+ return hdev->vhost_ops->vhost_get_features_ex(hdev, hdev->_features_ex);\n }\n \n r = hdev->vhost_ops->vhost_get_features(hdev, &features64);\n- virtio_features_from_u64(features, features64);\n+ virtio_features_from_u64(hdev->_features_ex, features64);\n return r;\n }\n \n@@ -1579,7 +1578,6 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n VhostBackendType backend_type, uint32_t busyloop_timeout,\n Error **errp)\n {\n- uint64_t features[VIRTIO_FEATURES_NU64S];\n unsigned int used, reserved, limit;\n int i, r, n_initialized_vqs = 0;\n \n@@ -1600,9 +1598,9 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n goto fail;\n }\n \n- r = vhost_dev_get_features(hdev, features);\n+ r = vhost_dev_init_features(hdev);\n if (r < 0) {\n- error_setg_errno(errp, -r, \"vhost_get_features failed\");\n+ error_setg_errno(errp, -r, \"vhost_init_features failed\");\n goto fail;\n }\n \n@@ -1628,8 +1626,6 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n }\n }\n \n- virtio_features_copy(hdev->_features_ex, features);\n-\n hdev->memory_listener = (MemoryListener) {\n .name = \"vhost\",\n .begin = vhost_begin,\n","prefixes":["v6","18/22"]}