{"id":2225301,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225301/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-17-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420200339.708640-17-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:03:31","name":"[v6,16/22] vhost: simplify vhost_dev_init() error-path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2e273622ddb25e0d3ee89d3187afcd16c391d954","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.2/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-17-vsementsov@yandex-team.ru/mbox/","series":[{"id":500672,"url":"http://patchwork.ozlabs.org/api/1.2/series/500672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672","date":"2026-04-20T20:03:18","name":"vhost refactoring and fixes","version":6,"mbox":"http://patchwork.ozlabs.org/series/500672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225301/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225301/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=XACxuPAd;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxKy6CL5z1yCv\n\tfor ; Tue, 21 Apr 2026 06:05:10 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEur1-0001l2-Nx; Mon, 20 Apr 2026 16:04:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEuqw-0001SR-2P\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:18 -0400","from forwardcorp1d.mail.yandex.net ([178.154.239.200])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEuqu-000203-HZ\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:17 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 3F3E38071E;\n Mon, 20 Apr 2026 23:04:15 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-0TxfyeRG; Mon, 20 Apr 2026 23:04:14 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715454;\n bh=LWaZ2xUEjmtd/ow6Imr4cQ0Z/NL5RAS13aeCcPFAeGQ=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=XACxuPAd70yQk9yYkeCDEXY+r7qdWHJbT6V2O8bi8cTQypd1922mjFvpkCjxa+rCm\n VFXhjLTiT9se5ANwigdNypjf9O7XB7G+lMM/AB7w3b0OC6GOVoxD1syrBhDn6aTLvU\n uFahJbVfOkjqEx8uTV909S8RCW5zazsDUmSPPswo=","From":"Vladimir Sementsov-Ogievskiy ","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz ","Subject":"[PATCH v6 16/22] vhost: simplify vhost_dev_init() error-path","Date":"Mon, 20 Apr 2026 23:03:31 +0300","Message-ID":"<20260420200339.708640-17-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","References":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.200;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"No reason to rollback setting up busyloop timeout on failure.\nWe don't do such rollback for other things we setup in backend.\nAlso, look at vhost_net_init() in hw/net/vhost_net.c: we may fail\nafter successfully called vhost_dev_init(), and in this case we'll\njust call vhost_dev_cleanup(), which doesn't rollback busyloop\ntimeout.\n\nSo, let's keep it simple.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nAcked-by: Raphael Norwitz \nReviewed-by: Daniil Tatianin \n---\n hw/virtio/vhost.c | 12 +++---------\n 1 file changed, 3 insertions(+), 9 deletions(-)","diff":"diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c\nindex c71b18cfc8d..7f370f393e9 100644\n--- a/hw/virtio/vhost.c\n+++ b/hw/virtio/vhost.c\n@@ -1624,7 +1624,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n busyloop_timeout);\n if (r < 0) {\n error_setg_errno(errp, -r, \"Failed to set busyloop timeout\");\n- goto fail_busyloop;\n+ goto fail;\n }\n }\n }\n@@ -1664,7 +1664,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n if (hdev->migration_blocker != NULL) {\n r = migrate_add_blocker_normal(&hdev->migration_blocker, errp);\n if (r < 0) {\n- goto fail_busyloop;\n+ goto fail;\n }\n }\n \n@@ -1696,17 +1696,11 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,\n \" than current number of used (%d) and reserved (%d)\"\n \" memory slots for memory devices.\", limit, used, reserved);\n r = -EINVAL;\n- goto fail_busyloop;\n+ goto fail;\n }\n \n return 0;\n \n-fail_busyloop:\n- if (busyloop_timeout) {\n- while (--i >= 0) {\n- vhost_virtqueue_set_busyloop_timeout(hdev, hdev->vq_index + i, 0);\n- }\n- }\n fail:\n hdev->nvqs = n_initialized_vqs;\n vhost_dev_cleanup(hdev);\n","prefixes":["v6","16/22"]}