{"id":2225297,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225297/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-20-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420200339.708640-20-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:03:34","name":"[v6,19/22] hw/virtio/virtio-bus: refactor virtio_bus_set_host_notifier()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"36f796c007533ae7f8d9dd2d3eb4b41e8c136121","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.2/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-20-vsementsov@yandex-team.ru/mbox/","series":[{"id":500672,"url":"http://patchwork.ozlabs.org/api/1.2/series/500672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672","date":"2026-04-20T20:03:18","name":"vhost refactoring and fixes","version":6,"mbox":"http://patchwork.ozlabs.org/series/500672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225297/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225297/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=DT1/7gb2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxKM5w5Qz1yD4\n\tfor ; Tue, 21 Apr 2026 06:04:39 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEur9-0001vp-KV; Mon, 20 Apr 2026 16:04:31 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEur1-0001kH-DY\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:23 -0400","from forwardcorp1d.mail.yandex.net ([178.154.239.200])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEuqz-00021n-St\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:23 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id 5C32E80778;\n Mon, 20 Apr 2026 23:04:20 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-14GazpNW; Mon, 20 Apr 2026 23:04:19 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715459;\n bh=Cy9Kfz7LJW3sOr7QWA68FHIr1PIHJhZFd5ELVkaKPk4=;\n h=Cc:Message-ID:References:Date:In-Reply-To:Subject:To:From;\n b=DT1/7gb23Gp+wlYc0luFQR7iZqgMraePV85BhDIEZAL+sN9fwy/ZhrI8qsudfpcvz\n JjjpwZmmLgL0vzJPTH/s42CNtZdML0YAoSmQk912bwyucJ4XbM3asghE1yilRs6UJH\n txeyTUGlLmY97cBMrw5vL6KAJ+UYoOLWM8/H5/Ac=","From":"Vladimir Sementsov-Ogievskiy ","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru, d-tatianin@yandex-team.ru,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Raphael Norwitz ","Subject":"[PATCH v6 19/22] hw/virtio/virtio-bus: refactor\n virtio_bus_set_host_notifier()","Date":"Mon, 20 Apr 2026 23:03:34 +0300","Message-ID":"<20260420200339.708640-20-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","References":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=178.154.239.200;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The logic kept as is. Refactor to simplify further changes.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nReviewed-by: Philippe Mathieu-Daudé \nReviewed-by: Raphael Norwitz \nReviewed-by: Daniil Tatianin \n---\n hw/virtio/virtio-bus.c | 18 ++++++++----------\n 1 file changed, 8 insertions(+), 10 deletions(-)","diff":"diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c\nindex cef944e0158..9b545acda31 100644\n--- a/hw/virtio/virtio-bus.c\n+++ b/hw/virtio/virtio-bus.c\n@@ -298,20 +298,18 @@ int virtio_bus_set_host_notifier(VirtioBusState *bus, int n, bool assign)\n __func__, strerror(-r), r);\n return r;\n }\n- r = k->ioeventfd_assign(proxy, notifier, n, true);\n- if (r < 0) {\n- error_report(\"%s: unable to assign ioeventfd: %d\", __func__, r);\n- virtio_bus_cleanup_host_notifier(bus, n);\n- }\n- } else {\n- k->ioeventfd_assign(proxy, notifier, n, false);\n }\n \n- if (r == 0) {\n- virtio_queue_set_host_notifier_enabled(vq, assign);\n+ r = k->ioeventfd_assign(proxy, notifier, n, assign);\n+ if (r < 0 && assign) {\n+ error_report(\"%s: unable to assign ioeventfd: %d\", __func__, r);\n+ virtio_bus_cleanup_host_notifier(bus, n);\n+ return r;\n }\n \n- return r;\n+ virtio_queue_set_host_notifier_enabled(vq, assign);\n+\n+ return 0;\n }\n \n void virtio_bus_cleanup_host_notifier(VirtioBusState *bus, int n)\n","prefixes":["v6","19/22"]}