{"id":2225295,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225295/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-10-vsementsov@yandex-team.ru/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420200339.708640-10-vsementsov@yandex-team.ru>","list_archive_url":null,"date":"2026-04-20T20:03:24","name":"[v6,09/22] vhost-user: keep QIOChannelSocket for backend channel","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"d09b5e9755833a8ca8f0572d9fa34b80d419abda","submitter":{"id":84116,"url":"http://patchwork.ozlabs.org/api/1.2/people/84116/?format=json","name":"Vladimir Sementsov-Ogievskiy","email":"vsementsov@yandex-team.ru"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260420200339.708640-10-vsementsov@yandex-team.ru/mbox/","series":[{"id":500672,"url":"http://patchwork.ozlabs.org/api/1.2/series/500672/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500672","date":"2026-04-20T20:03:18","name":"vhost refactoring and fixes","version":6,"mbox":"http://patchwork.ozlabs.org/series/500672/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225295/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225295/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=yandex-team.ru header.i=@yandex-team.ru\n header.a=rsa-sha256 header.s=default header.b=hyQWB2qs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex-team.ru"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzxKC35Jwz1yD4\n\tfor ; Tue, 21 Apr 2026 06:04:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wEuqx-0001Y4-Gu; Mon, 20 Apr 2026 16:04:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEuql-0001LU-Ax\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:09 -0400","from forwardcorp1d.mail.yandex.net\n ([2a02:6b8:c41:1300:1:45:d181:df01])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wEuqi-0001oR-JF\n for qemu-devel@nongnu.org; Mon, 20 Apr 2026 16:04:07 -0400","from mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:94a9:0:640:a3fa:0])\n by forwardcorp1d.mail.yandex.net (Yandex) with ESMTPS id CDC5D80786;\n Mon, 20 Apr 2026 23:04:02 +0300 (MSK)","from vsementsov-lin (unknown [2a02:6bf:8080:54b::1:34])\n by mail-nwsmtp-smtp-corp-main-68.klg.yp-c.yandex.net (smtpcorp) with ESMTPSA\n id f3YMX10K1Sw0-Dpvbel3I; Mon, 20 Apr 2026 23:04:02 +0300"],"Precedence":"bulk","X-Yandex-Fwd":"1","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.ru;\n s=default; t=1776715442;\n bh=z7NzS2BOltO1smLgMQemP3Hs/WnVs4xBnAPGQOKC/zU=;\n h=Message-ID:Date:In-Reply-To:Cc:Subject:References:To:From;\n b=hyQWB2qsYq5I8xbu0kEStJIqOTB+WPxzzOVpniK3+9ZlG4AGe+iCo7F6hs8Fxaq7V\n ALIGy+lNlJz0K+xFWThXM/EW1TH8mKZY/2dcZoklbFfynlfO0X9Mwj4+9i0IgpIHLT\n KvatKxAIPDmG7s/bpGq0/uZXG55qLYBM5mNCOBoE=","From":"Vladimir Sementsov-Ogievskiy ","To":"mst@redhat.com","Cc":"sgarzare@redhat.com, raphael@enfabrica.net, qemu-devel@nongnu.org,\n vsementsov@yandex-team.ru, yc-core@yandex-team.ru,\n d-tatianin@yandex-team.ru, Raphael Norwitz ","Subject":"[PATCH v6 09/22] vhost-user: keep QIOChannelSocket for backend\n channel","Date":"Mon, 20 Apr 2026 23:03:24 +0300","Message-ID":"<20260420200339.708640-10-vsementsov@yandex-team.ru>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","References":"<20260420200339.708640-1-vsementsov@yandex-team.ru>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a02:6b8:c41:1300:1:45:d181:df01;\n envelope-from=vsementsov@yandex-team.ru; helo=forwardcorp1d.mail.yandex.net","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Keep QIOChannelSocket pointer instead of more generic\nQIOChannel. No real difference for now, but it would\nbe simpler to migrate socket fd in further commit.\n\nSigned-off-by: Vladimir Sementsov-Ogievskiy \nAcked-by: Raphael Norwitz \nReviewed-by: Daniil Tatianin \n---\n hw/virtio/vhost-user.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c\nindex 68dd89cd8f8..31eaf65430e 100644\n--- a/hw/virtio/vhost-user.c\n+++ b/hw/virtio/vhost-user.c\n@@ -239,7 +239,7 @@ struct vhost_user {\n struct vhost_dev *dev;\n /* Shared between vhost devs of the same virtio device */\n VhostUserState *user;\n- QIOChannel *backend_ioc;\n+ QIOChannelSocket *backend_sioc;\n GSource *backend_src;\n NotifierWithReturn postcopy_notifier;\n struct PostCopyFD postcopy_fd;\n@@ -1796,8 +1796,8 @@ static void close_backend_channel(struct vhost_user *u)\n g_source_destroy(u->backend_src);\n g_source_unref(u->backend_src);\n u->backend_src = NULL;\n- object_unref(OBJECT(u->backend_ioc));\n- u->backend_ioc = NULL;\n+ object_unref(OBJECT(u->backend_sioc));\n+ u->backend_sioc = NULL;\n }\n \n static gboolean backend_read(QIOChannel *ioc, GIOCondition condition,\n@@ -1909,7 +1909,6 @@ static int vhost_setup_backend_channel(struct vhost_dev *dev)\n bool reply_supported =\n vhost_user_has_protocol_feature(dev, VHOST_USER_PROTOCOL_F_REPLY_ACK);\n Error *local_err = NULL;\n- QIOChannel *ioc;\n \n if (!vhost_user_has_protocol_feature(\n dev, VHOST_USER_PROTOCOL_F_BACKEND_REQ)) {\n@@ -1922,15 +1921,15 @@ static int vhost_setup_backend_channel(struct vhost_dev *dev)\n return -saved_errno;\n }\n \n- ioc = QIO_CHANNEL(qio_channel_socket_new_fd(sv[0], &local_err));\n- if (!ioc) {\n+ u->backend_sioc = qio_channel_socket_new_fd(sv[0], &local_err);\n+ if (!u->backend_sioc) {\n error_report_err(local_err);\n return -ECONNREFUSED;\n }\n- u->backend_ioc = ioc;\n- u->backend_src = qio_channel_add_watch_source(u->backend_ioc,\n- G_IO_IN | G_IO_HUP,\n- backend_read, dev, NULL, NULL);\n+ u->backend_src = qio_channel_add_watch_source(QIO_CHANNEL(u->backend_sioc),\n+ G_IO_IN | G_IO_HUP,\n+ backend_read, dev,\n+ NULL, NULL);\n \n if (reply_supported) {\n msg.hdr.flags |= VHOST_USER_NEED_REPLY_MASK;\n@@ -2350,7 +2349,7 @@ static int vhost_user_backend_cleanup(struct vhost_dev *dev)\n close(u->postcopy_fd.fd);\n u->postcopy_fd.handler = NULL;\n }\n- if (u->backend_ioc) {\n+ if (u->backend_sioc) {\n close_backend_channel(u);\n }\n g_free(u->region_rb);\n","prefixes":["v6","09/22"]}