{"id":2225274,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2225274/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260420192520.1444749-5-rs@ti.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260420192520.1444749-5-rs@ti.com>","list_archive_url":null,"date":"2026-04-20T19:25:18","name":"[PATCHv4,4/6] efi_selftest_memory: check for duplicates first","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"da0f9363d32d580d85e2574334ebbd352fbde8ac","submitter":{"id":88727,"url":"http://patchwork.ozlabs.org/api/1.2/people/88727/?format=json","name":"Randolph Sapp","email":"rs@ti.com"},"delegate":{"id":68728,"url":"http://patchwork.ozlabs.org/api/1.2/users/68728/?format=json","username":"xypron","first_name":"Heinrich","last_name":"Schuchardt","email":"xypron.glpk@gmx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260420192520.1444749-5-rs@ti.com/mbox/","series":[{"id":500668,"url":"http://patchwork.ozlabs.org/api/1.2/series/500668/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500668","date":"2026-04-20T19:25:18","name":"various memory related fixups","version":1,"mbox":"http://patchwork.ozlabs.org/series/500668/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2225274/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2225274/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256\n header.s=selector1 header.b=NT0m+ZMr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=ti.com header.i=@ti.com header.b=\"NT0m+ZMr\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=quarantine dis=none) header.from=ti.com","phobos.denx.de; spf=pass smtp.mailfrom=rs@ti.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fzwSP5j31z1yHB\n\tfor ; Tue, 21 Apr 2026 05:25:41 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B332A84394;\n\tMon, 20 Apr 2026 21:25:32 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id BA68A84376; Mon, 20 Apr 2026 21:25:31 +0200 (CEST)","from BN8PR05CU002.outbound.protection.outlook.com\n (mail-eastus2azlp170110003.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c110::3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id E828E84319\n for ; Mon, 20 Apr 2026 21:25:28 +0200 (CEST)","from MW4PR04CA0316.namprd04.prod.outlook.com (2603:10b6:303:82::21)\n by CH0PR10MB5177.namprd10.prod.outlook.com (2603:10b6:610:df::17)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.33; Mon, 20 Apr\n 2026 19:25:25 +0000","from MWH0EPF000C6193.namprd02.prod.outlook.com\n (2603:10b6:303:82:cafe::b0) by MW4PR04CA0316.outlook.office365.com\n (2603:10b6:303:82::21) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9791.48 via Frontend Transport; Mon,\n 20 Apr 2026 19:25:25 +0000","from lewvzet201.ext.ti.com (198.47.23.195) by\n MWH0EPF000C6193.mail.protection.outlook.com (10.167.249.107) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9791.48 via Frontend Transport; Mon, 20 Apr 2026 19:25:25 +0000","from DLEE215.ent.ti.com (157.170.170.118) by lewvzet201.ext.ti.com\n (10.4.14.104) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Apr\n 2026 14:25:23 -0500","from DLEE200.ent.ti.com (157.170.170.75) by DLEE215.ent.ti.com\n (157.170.170.118) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Mon, 20 Apr\n 2026 14:25:23 -0500","from lelvem-mr05.itg.ti.com (10.180.75.9) by DLEE200.ent.ti.com\n (157.170.170.75) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend\n Transport; Mon, 20 Apr 2026 14:25:23 -0500","from rs-desk.dhcp.ti.com (rs-desk.dhcp.ti.com [128.247.81.39])\n by lelvem-mr05.itg.ti.com (8.18.1/8.18.1) with ESMTP id 63KJPNh73399024;\n Mon, 20 Apr 2026 14:25:23 -0500"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SPF_PERMERROR autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=Z6SA/U15tf5ETBpLFTHsc3fRQPYskuGURPgI7vtZGIty5yxIgdvWIH1xIKE0NNGqOHHkabUMeAUpW3SLQ71lSIOoq933JIIStRF4DIoKeX+OmOhCA1662mx23vLilcdZL36zzi0I6YVdb5p3/Xvw1lbisXvL6LB1BthTYeeF4ZstJSuolFxo6y8Z5DgAYbSEN4Qx1D42B1qgOPue3nWS+jb6YJTPFC/kIZdiXv73/2og9br5BUAXdlTAW+QN2IeypmDOQO6dBSD6mDEPlxOnpNohtWc652MTr+zcJrA5HO0bbyZCgQ7s/3XnzS0EKSWesVCs6eYDQDUaG2hLtZ4TAg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=l5cKaYWEXpJkj+DHzenphJ9FKgkoigICiqjvva2Nupk=;\n b=Yi1SkXhLRn68Wo1+ZW3o78eNc6XUMgJzlARBDUgGfZhrPUAPD7JX0Rultx3N1lMO9aViJmg3xPOfg54kQXByKq3sGq9YbSUpGdNZLhQniXM7WFjp0wX/r+KtF+ukGQgu2A+FFK92z4I+zFBaHbK8dxrOp7VFK0vvSFkTHeI/mNuZ8g0wS9B69NwJm79E0XQBZg0IkqAgfPkRqYnVxyPmpixcQJba27b7TFAWkk6quPL7uwST5Tnw+gCG+CtKcJLHxm8kj/C5JEXWKvFfAFkaeOrC/FL36pHji3wst8CDScZGeBnAp435u+s+ixWtwdxXgnRLWjexDgbNodiu4Vu3fA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 198.47.23.195) smtp.rcpttodomain=lists.denx.de smtp.mailfrom=ti.com;\n dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=ti.com;\n dkim=none (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=l5cKaYWEXpJkj+DHzenphJ9FKgkoigICiqjvva2Nupk=;\n b=NT0m+ZMr7Y4SG/6ipLpHZu7WwN3UXXSNuXde5kHJRq9IuC+r+JRJ0INL5QtWHuLHEupSHK5vqELBirTJJHZOImhSt5/tN3z6oZO5BV+ydzLozhRFFwmY1OkN0P8Igrd07vTTt/jHbBc49lfuLYxac55VS3fKQ3GRPc2zlLow/TI=","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 198.47.23.195)\n smtp.mailfrom=ti.com; dkim=none (message not signed) header.d=none;\n dmarc=pass\n action=none header.from=ti.com;","Received-SPF":"Pass (protection.outlook.com: domain of ti.com designates\n 198.47.23.195 as permitted sender) receiver=protection.outlook.com;\n client-ip=198.47.23.195; helo=lewvzet201.ext.ti.com; pr=C","From":"","To":", ,\n , , ,\n , , ,\n ","CC":"","Subject":"[PATCHv4 4/6] efi_selftest_memory: check for duplicates first","Date":"Mon, 20 Apr 2026 14:25:18 -0500","Message-ID":"<20260420192520.1444749-5-rs@ti.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260420192520.1444749-1-rs@ti.com>","References":"<20260420192520.1444749-1-rs@ti.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-C2ProcessedOrg":"333ef613-75bf-4e12-a4b1-8e3623f5dcea","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"MWH0EPF000C6193:EE_|CH0PR10MB5177:EE_","X-MS-Office365-Filtering-Correlation-Id":"7db252f5-9fdb-49a1-3bf2-08de9f1292bc","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|82310400026|36860700016|1800799024|376014|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n GkakkK6cF49auu1lNNtwNJWeN0/jMOtOtARA9iveUnC/REK78CcgrxnnhJ4DlRC0S8kVr2P/Jj+w9AGy0LUpvzhF5f6Nr6yPrdtgpkFrnOk4ilreK76Po8GhXoZwOs1h9+ltNtGqeBw1T4LNaxURKOdmOb/9P5jrQ1V0aYxflBuK9dlay5N/h7cizR0d3rw6KA1SeWnPia2JhPi3JVb+0oXbQRAcxL21WromnOzHxkrq9HahXoZBahx/a//uP6fgnv6+hMXxjPsFva+6HpQAsgOJ+m7Q8jvCvPLzQeyfYGd0DFkSV+JXINyZrIhk0FnKHJD6PabiF9xvSZ/j/SBdPG4UEqZEA+XKx3KzZHxMTrgURYoTi1FHKn5A3/ReFU0Y7Os5d/eJkDaXu1ZWZzpmaM+NSXummP/TFQkr6s4NYEfwzscv+1pcexynL7yyyjtOH2HPqKB52uCefvJRFypj5JWrr1dRTTGEQywQ15nI4i695God82KjedYkdwvUuCpOwKRdQecl1IBmnouFVYuuRD9JCl6/wDOStkgy2WdQ9Zhv7CRV26OwABzfD+2JZT96kDN2Bvui9TlGu0eEYrrrgJgOEygIXXYcRINZ7w/ihwgjQ0benUiJzfTUTnGGgYCdcjUKIEaXuAYO6nhVDCl2F2rBau8dGL8ef8GzW+CBHK1fT+OEh1MqzVUVKQIoJboG139ovLeyAufIUj2p14e6N0IKNwB9nFmJdCEg2N7cvXQsSq6TmsunS+iEYjvc1tLaLNW8NcUvr2VCtHaytHvr6w==","X-Forefront-Antispam-Report":"CIP:198.47.23.195; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:lewvzet201.ext.ti.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(82310400026)(36860700016)(1800799024)(376014)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n DNr+iD2XjEnwuaUz8E8bFQwHFskjLj7liQ3U2OK7rneqlZ+LzDra/EN0KoYRDZHwuZwiJtwi4JGBIFn7kuhRUV38LMpLfDGX9S890t3PDsd0/ga43vcXsUQoFMsSRhjM0zAnJb02vFR7NuBRMHWO75adpe42DvXYsqgRZ5Q6dxH0YSxcQpBzhtzYdxO5eVzIbMLIecmb1r1AFhUzQyVZ2pTXssO6ueq8YZ+oJIQXBxlhdqKwBOgOZyDVzOoUA8kiFnEE+mAmv84Q0Xpk4FZ8HT54P2JOtRSt0uftVkUEkeHYMbzitWo4E4sNYmykUogNprOm2HwIWzD+MAwxYzXpA29sZ698NMl46O1K4FO2mRdIgm+O8RatSlA84qKRJobu6AAUu9Yp8NS6j84JmS9pa8pry/hS6LZRZsjc2en4DJv1vDsbqH7Gpi9fsAoCX9Mi","X-OriginatorOrg":"ti.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"20 Apr 2026 19:25:25.1881 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 7db252f5-9fdb-49a1-3bf2-08de9f1292bc","X-MS-Exchange-CrossTenant-Id":"e5b49634-450b-4709-8abb-1e2b19b982b7","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=e5b49634-450b-4709-8abb-1e2b19b982b7; Ip=[198.47.23.195];\n Helo=[lewvzet201.ext.ti.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n MWH0EPF000C6193.namprd02.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CH0PR10MB5177","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Randolph Sapp \n\nCheck for duplicate memory mappings before reporting any incorrect\nattributes. Could be that second allocation has the correct type while\nthe first doesn't. Knowing there is a duplicate in this scenario is\nmore helpful than just reporting the first mismatch.\n\nSigned-off-by: Randolph Sapp \nReviewed-by: Ilias Apalodimas \nReviewed-by: Simon Glass \n---\n lib/efi_selftest/efi_selftest_memory.c | 21 ++++++++++-----------\n 1 file changed, 10 insertions(+), 11 deletions(-)","diff":"diff --git a/lib/efi_selftest/efi_selftest_memory.c b/lib/efi_selftest/efi_selftest_memory.c\nindex 4d32a280061..7320964c129 100644\n--- a/lib/efi_selftest/efi_selftest_memory.c\n+++ b/lib/efi_selftest/efi_selftest_memory.c\n@@ -60,7 +60,7 @@ static int find_in_memory_map(efi_uintn_t map_size,\n \t\t\t u64 addr, int memory_type)\n {\n \tefi_uintn_t i;\n-\tbool found = false;\n+\tstruct efi_mem_desc *match = NULL;\n \n \tfor (i = 0; map_size; ++i, map_size -= desc_size) {\n \t\tstruct efi_mem_desc *entry = &memory_map[i];\n@@ -72,24 +72,23 @@ static int find_in_memory_map(efi_uintn_t map_size,\n \n \t\tif (addr >= entry->physical_start &&\n \t\t addr < entry->physical_start +\n-\t\t\t (entry->num_pages << EFI_PAGE_SHIFT)) {\n-\t\t\tif (found) {\n+\t\t\t\t (entry->num_pages << EFI_PAGE_SHIFT)) {\n+\t\t\tif (match) {\n \t\t\t\tefi_st_error(\"Duplicate memory map entry\\n\");\n \t\t\t\treturn EFI_ST_FAILURE;\n \t\t\t}\n-\t\t\tfound = true;\n-\t\t\tif (memory_type != entry->type) {\n-\t\t\t\tefi_st_error\n-\t\t\t\t\t(\"Wrong memory type %d, expected %d\\n\",\n-\t\t\t\t\t entry->type, memory_type);\n-\t\t\t\treturn EFI_ST_FAILURE;\n-\t\t\t}\n+\t\t\tmatch = entry;\n \t\t}\n \t}\n-\tif (!found) {\n+\tif (!match) {\n \t\tefi_st_error(\"Missing memory map entry\\n\");\n \t\treturn EFI_ST_FAILURE;\n \t}\n+\tif (memory_type != match->type) {\n+\t\tefi_st_error(\"Wrong memory type %d, expected %d\\n\", match->type,\n+\t\t\t memory_type);\n+\t\treturn EFI_ST_FAILURE;\n+\t}\n \treturn EFI_ST_SUCCESS;\n }\n \n","prefixes":["PATCHv4","4/6"]}