{"id":2224648,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224648/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260417173105.1648172-16-peter.maydell@linaro.org/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.2/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417173105.1648172-16-peter.maydell@linaro.org>","list_archive_url":null,"date":"2026-04-17T17:31:03","name":"[15/17] hw/core: Implement cpu_get_phys_addr_attrs_debug() with cpu_translate_for_debug()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"09de98b8e738c63ce2fe537851a24aac15346233","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.2/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260417173105.1648172-16-peter.maydell@linaro.org/mbox/","series":[{"id":500379,"url":"http://patchwork.ozlabs.org/api/1.2/series/500379/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=500379","date":"2026-04-17T17:30:52","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500379/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224648/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224648/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=sz3z9UdO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy28g3jxxz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 18 Apr 2026 03:35:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-ppc-bounces@nongnu.org>)\n\tid 1wDn34-0007KU-2l; Fri, 17 Apr 2026 13:32:10 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wDn2k-0006vI-Ob\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 13:31:56 -0400","from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)\n id 1wDn2f-0002NA-0V\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 13:31:48 -0400","by mail-wr1-x42d.google.com with SMTP id\n ffacd0b85a97d-43d7e23defbso624654f8f.0\n for <qemu-ppc@nongnu.org>; Fri, 17 Apr 2026 10:31:44 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4ffa8sm5819650f8f.35.2026.04.17.10.31.41\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 10:31:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776447103; x=1777051903; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Mjdw55nvUmDEoZC6Zfcjvd3ZPIFn9XfgQXXNer13HYA=;\n b=sz3z9UdOQD5jqbwweL59/qtGEIowTsxd5PXnzmESRR6dZGdszmFLUByU5JWPh1aEkJ\n 8Kc2ok2qflCZkJC/eYGhYSZanS+aa48ayJSVbjYE5lM7xeUJxTnTLRIGaT5DgrnG4FKj\n b5tzB9G6+lSA8Y0VLxI2PRxHduTCjUJ0IiOHAV25ettwt/pkIa4uYD+JLkipSWlqYzv1\n wWRY8BuHSZlT7huvziV9buSX3b8rfP9enFLVAIuZzlVRonOAy6jRfx+RNHm8HZsSEJ5C\n o1/GdwVQZ9So9eLsyzDROhwHtkeaHnn4dKAqyV7MUQA75cShJ/MMGOHDsWJLfOT7bRiq\n S2Aw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776447103; x=1777051903;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=Mjdw55nvUmDEoZC6Zfcjvd3ZPIFn9XfgQXXNer13HYA=;\n b=EbhNSGUI5uxU6FPUO2stUZ7e4JNlNb+Z8Oq4XwCzrIJR/+or6NIfDVIaCXnEVEciud\n EpKCPGQqFtgWNhO5VcuneiXKuSLn2orSI0dLAtJcVixtUIi0fdn+i/RYtF40R1qME5WA\n Q7Yfky9BRfL3f9bOk4x07BLPIz39qBvwUVwc+y4nof1Dip9Tyz4XjpAVyJMwxKj7msVH\n oJ7x5YdlqOgmu3qs0ZPohyIfyV/qenBNzAWr+sbJjsi1laX/zhz+uaekorVt5WQDzj7Q\n 16iT/iIR5Z361xd3PcAmnu34DMO+lqmxcpEUO+LHcwTEvSnoQGzgh05M24/f2nKQqK6F\n V71A==","X-Gm-Message-State":"AOJu0YxzzAirtFN/+/SMOnmTH5/+2tSMfxUMF92VD+dIRInOhU+LifYI\n pdsWr2Y/P9ZK/qgTlS9/3xN5O4SblLjT9MyyXg6xwGwmxpptM2bsEDHllflzzYtkXKY=","X-Gm-Gg":"AeBDieuoaIxL1sjhnPWczkH8z6r5oxMi6Yctj4ANpjSMDlUGUuT78dQhAcZJDtXKQUe\n Td3ymDltl2lUeYaZNXHJ6+Cb/PpMx6uLNt5wQhueR2w+/Qx88cj+g+juKSxdNkAaWK/tiWXk1nN\n tYa6oXoBPYu9zwPfj7huQhaYiVhj6Ha5oX7AXam2nWEsj8+BUuVmgB8O2Q8/EUs8tiGl7FyYSP1\n iPHkNak/cC0S9yIDm9P/hyRUb+TA659mTJL3lCabSMWqBjVoTdpXeo1Bk08Dka2hQzv/y0fRF9/\n g4YzfcTj/izKshze+bQO5tWXBaVq6oNjeaeRnnEjThRnJGI9KcBczMc84hBymzEBy2x3XJ96r8T\n Fjpxt8VusueLxQZXDAM5j4XvDYegFD2f/klV16kFUnFgiySoKGVmQLmNtWvliqTYcg5HtweLXfw\n F5zZ5gpz8sfBI8nF7WKGyHryBQjo3PqwiuJ1IGGjieCzQTk4xDjNG55MgsfoQAOmtplZHbIIc4I\n 1xsxdnzcxOzgftuOHqoH23JkoqhokkU4yoD4EEtHQ==","X-Received":"by 2002:a5d:584c:0:b0:43d:7403:4b57 with SMTP id\n ffacd0b85a97d-43fe3db3ca7mr5903786f8f.10.1776447103468;\n Fri, 17 Apr 2026 10:31:43 -0700 (PDT)","From":"Peter Maydell <peter.maydell@linaro.org>","To":"qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","Cc":"qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,\n Yanan Wang <wangyanan55@huawei.com>, Zhao Liu <zhao1.liu@intel.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n \"Dr. David Alan Gilbert\" <dave@treblig.org>,\n =?utf-8?q?Alex_Benn=C3=A9e?= <alex.bennee@linaro.org>,\n Alexandre Iooss <erdnaxe@crans.org>, Mahmoud Mandour <ma.mandourr@gmail.com>,\n Peter Xu <peterx@redhat.com>, \"Edgar E. Iglesias\" <edgar.iglesias@gmail.com>,\n Jiaxun Yang <jiaxun.yang@flygoat.com>, Nicholas Piggin <npiggin@gmail.com>,\n Chinmay Rath <rathc@linux.ibm.com>, Glenn Miles <milesg@linux.ibm.com>,\n Palmer Dabbelt <palmer@dabbelt.com>,\n Alistair Francis <alistair.francis@wdc.com>, Weiwei Li <liwei1518@gmail.com>,\n Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>,\n Liu Zhiwei <zhiwei_liu@linux.alibaba.com>,\n Chao Liu <chao.liu.zevorn@gmail.com>, Ilya Leoshkevich <iii@linux.ibm.com>,\n David Hildenbrand <david@kernel.org>,\n Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,\n Artyom Tarasenko <atar4qemu@gmail.com>","Subject":"[PATCH 15/17] hw/core: Implement cpu_get_phys_addr_attrs_debug() with\n cpu_translate_for_debug()","Date":"Fri, 17 Apr 2026 18:31:03 +0100","Message-ID":"<20260417173105.1648172-16-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260417173105.1648172-1-peter.maydell@linaro.org>","References":"<20260417173105.1648172-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42d;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<qemu-ppc.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-ppc>","List-Post":"<mailto:qemu-ppc@nongnu.org>","List-Help":"<mailto:qemu-ppc-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-ppc>,\n <mailto:qemu-ppc-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Implement cpu_get_phys_addr_attrs_debug() with\ncpu_translate_for_debug(), so that CPUs can implement only the\ntranslate_for_debug method and have all of the wrapper functions\ncpu_translate_for_debug(), cpu_get_phys_addr_attrs_debug() and\ncpu_get_phys_addr_debug() work.\n\nSigned-off-by: Peter Maydell <peter.maydell@linaro.org>\n---\n hw/core/cpu-system.c | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)","diff":"diff --git a/hw/core/cpu-system.c b/hw/core/cpu-system.c\nindex cab65d549a..be5cb48126 100644\n--- a/hw/core/cpu-system.c\n+++ b/hw/core/cpu-system.c\n@@ -90,19 +90,14 @@ bool cpu_translate_for_debug(CPUState *cpu, vaddr addr,\n hwaddr cpu_get_phys_addr_attrs_debug(CPUState *cpu, vaddr addr,\n                                      MemTxAttrs *attrs)\n {\n-    hwaddr paddr;\n+    TranslateForDebugResult result;\n \n-    if (cpu->cc->sysemu_ops->get_phys_addr_attrs_debug) {\n-        paddr = cpu->cc->sysemu_ops->get_phys_addr_attrs_debug(cpu, addr,\n-                                                               attrs);\n-    } else {\n-        /* Fallback for CPUs which don't implement the _attrs_ hook */\n-        *attrs = MEMTXATTRS_UNSPECIFIED;\n-        paddr = cpu->cc->sysemu_ops->get_phys_addr_debug(cpu, addr);\n+    if (!cpu_translate_for_debug(cpu, addr, &result)) {\n+        return -1;\n     }\n-    /* Indicate that this is a debug access. */\n-    attrs->debug = 1;\n-    return paddr;\n+\n+    *attrs = result.attrs;\n+    return result.physaddr;\n }\n \n hwaddr cpu_get_phys_addr_debug(CPUState *cpu, vaddr addr)\n","prefixes":["15/17"]}