{"id":2224618,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224618/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260417173105.1648172-6-peter.maydell@linaro.org/","project":{"id":69,"url":"http://patchwork.ozlabs.org/api/1.2/projects/69/?format=json","name":"QEMU powerpc development","link_name":"qemu-ppc","list_id":"qemu-ppc.nongnu.org","list_email":"qemu-ppc@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417173105.1648172-6-peter.maydell@linaro.org>","list_archive_url":null,"date":"2026-04-17T17:30:53","name":"[05/17] target/x86: Make get_phys_page_attrs_debug handle non-page-aligned addrs","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a52791bd400a72a92d531fb48b5d73ef14d4eb30","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.2/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-ppc/patch/20260417173105.1648172-6-peter.maydell@linaro.org/mbox/","series":[{"id":500379,"url":"http://patchwork.ozlabs.org/api/1.2/series/500379/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-ppc/list/?series=500379","date":"2026-04-17T17:30:52","name":"Handle sub-page granularity in cpu_memory_rw_debug()","version":1,"mbox":"http://patchwork.ozlabs.org/series/500379/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224618/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224618/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=Pk/sCSTQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy2540ZVNz1yDF\n\tfor ; Sat, 18 Apr 2026 03:32:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDn2u-00078f-LW; Fri, 17 Apr 2026 13:32:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDn2L-0006kE-2o\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 13:31:30 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDn2F-00023W-Tq\n for qemu-ppc@nongnu.org; Fri, 17 Apr 2026 13:31:22 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488afb0427eso11675765e9.1\n for ; Fri, 17 Apr 2026 10:31:18 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e4ffa8sm5819650f8f.35.2026.04.17.10.31.14\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 10:31:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776447077; x=1777051877; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=zwAS7ZT+4GzIr0Ax+jfMns5onR8BsHM96TfH2Ah3gOw=;\n b=Pk/sCSTQWMV8Ubx4sHHac9RGirQNpPqCxE+HVSVHiS/SEmKY6cph9xy8PIO4uLBlHP\n X74i2zpM5kThNHpOBUe5L4SL56inAvM+7jaPXbfZT4F1yGTYl9zKCs0ozK1xPzdWOE8W\n 0myznrJi+zspWkn4eiFNLH3rH7tKPg/kWDb7pLZpf3X6n3sfh+NE535qO4chpBPXlTo6\n q5osqA4KMl/BV5T3BGltfzYjHgKyI1+g64Y8A4TGCG2ksxgIWQtqU8hEq3FdI+Q7IVeT\n SN7CLsBSoPABKWtvL9c1Kns2CwPudATycY/RMa4uZ6ArsWJw8uks2CqxIcbreD6DIRh1\n QVLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776447077; x=1777051877;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=zwAS7ZT+4GzIr0Ax+jfMns5onR8BsHM96TfH2Ah3gOw=;\n b=IIBsXS1BKhPUQMhoCDeOjRhYrH/4WYP9Rf/BaHyn9u/Jf3gZLEUxYmLrdHqm4WKUtH\n XibpSl/hfkdIOh4oz8RA02TxcS1+EKOioRQZG8B+A9d0gAfeoNdrNVJ/pPnUC4b8cYd8\n bMuDAt67ZidQKKPrzLa7bt9LtF/6hlf9T7lGJ1OBXnDqSHrTz7HOKihPtFVL9D4Z8vlX\n CzeUIxcCFDzGTckV8D9e9E4u4Idnxo++8thhAV1D8TQT6NAlVfMxBVinE/HtiYk/AeFN\n wg010y82YLEBPACMee35qZ0tXKet0rnMeF9GJaECPFsmeROlZBi+57yLkBUJtQJ3MgNB\n Aj9Q==","X-Gm-Message-State":"AOJu0YwpYQP1lu5pZbc3UNOtcmx9Vx6sSPS+XFqBoPKrEmvJIdeecgD/\n J0J3kKeNvKsf+3mJ81VlZK4xqGRX2xnLGWVnJ/88kugQJZ9npf1UNEO9bVQL4bfG70s=","X-Gm-Gg":"AeBDieuyE84Po/0TdPvcw3JAxPjoMoylgAc78/+j8eI+Ldw3WFcSSsf45oT+bP2Nlsw\n ZQJgwJkuW4swL0QzLn6qtMTYrIDtjfNFSMBDkY3+C9Xo6NYzhy4k4NCchl28yme7eWRP6c2Crsu\n OYLQpQ6r0hMfwAkSkoPPLyNplzjoj/oOVM+SeE8XMKuD3TOBHwZ1Iasf2RmMHtGj36AAae3LR/N\n XhqwChxW5Wwf1NmhHT6qAAzNUv7ed6xeOVY4tGASYww9BlJ9I/e8SOmoJC9DwE6yUh7GNK8JOcd\n 6wX1NlCjjEg7yjrRd5l8zts54am7PgNrf5H0CWreJRUq1yk2bE53utARIUorxVP97BJEcVNxEip\n s7Qa3gM8hADAZrauANW0nQWVAoPNvqe7znoqP+yJEJJj2Tcrrc/BDVO/JUxljHP+xWZXpu/C4AS\n 6l3Q/myTInjVTVt/JAIOIr40/VquElXDHyi6bnyi9cnmti6u849DnmjNcbLzQH5rV8CTQlyPZ5x\n rMexZBgEJOngJax3zLScliN+RyGF0LHveelhGBZPw==","X-Received":"by 2002:a05:600d:8447:b0:487:338:b4f3 with SMTP id\n 5b1f17b1804b1-488fb778734mr47380405e9.17.1776447075887;\n Fri, 17 Apr 2026 10:31:15 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","Cc":"qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Marcel Apfelbaum ,\n Yanan Wang , Zhao Liu ,\n Paolo Bonzini ,\n Richard Henderson ,\n \"Dr. David Alan Gilbert\" ,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n Alexandre Iooss , Mahmoud Mandour ,\n Peter Xu , \"Edgar E. Iglesias\" ,\n Jiaxun Yang , Nicholas Piggin ,\n Chinmay Rath , Glenn Miles ,\n Palmer Dabbelt ,\n Alistair Francis , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , Ilya Leoshkevich ,\n David Hildenbrand ,\n Mark Cave-Ayland ,\n Artyom Tarasenko ","Subject":"[PATCH 05/17] target/x86: Make get_phys_page_attrs_debug handle\n non-page-aligned addrs","Date":"Fri, 17 Apr 2026 18:30:53 +0100","Message-ID":"<20260417173105.1648172-6-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260417173105.1648172-1-peter.maydell@linaro.org>","References":"<20260417173105.1648172-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-ppc@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Currently our implementations of SysemuCPUOps::get_phys_page_debug\nand SysemuCPUOps::get_phys_page_attrs_debug are a mix of \"accepts a\nnon-page-aligned virtual address and returns the corresponding\nnon-page-aligned physical address\" and \"only returns a page-aligned\nphysical address\". This is awkward for callsites, which in practice\nall want the physical address for an arbitrary virtual address and\nhave to work around the possibility of getting a page-aligned\naddress, and it doesn't account for protection being possibly on a\nsub-page-sized granularity. We want to standardize on the\nimplementation having to handle non-page-aligned addresses.\n\nFor x86 this is simple: we just need to stop rounding down the\ninput address to a TARGET_PAGE boundary when calculating the\nresult to return.\n\nSigned-off-by: Peter Maydell \n---\n target/i386/helper.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/target/i386/helper.c b/target/i386/helper.c\nindex c397a6fde5..108b02396d 100644\n--- a/target/i386/helper.c\n+++ b/target/i386/helper.c\n@@ -372,7 +372,7 @@ hwaddr x86_cpu_get_phys_page_attrs_debug(CPUState *cs, vaddr addr,\n out:\n #endif\n pte &= PG_ADDRESS_MASK & ~(page_size - 1);\n- page_offset = (addr & TARGET_PAGE_MASK) & (page_size - 1);\n+ page_offset = addr & (page_size - 1);\n return pte | page_offset;\n }\n \n","prefixes":["05/17"]}