{"id":2224605,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224605/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260417172712.1015232-2-torbjorn.svensson@foss.st.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417172712.1015232-2-torbjorn.svensson@foss.st.com>","list_archive_url":null,"date":"2026-04-17T17:27:09","name":"[07/30] Change `struct mkdeps` to `class mkdeps` to align tags","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"808f4a2f58bc1392d67da077be5b132d1e5040bd","submitter":{"id":84848,"url":"http://patchwork.ozlabs.org/api/1.2/people/84848/?format=json","name":"Torbjörn SVENSSON","email":"torbjorn.svensson@foss.st.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260417172712.1015232-2-torbjorn.svensson@foss.st.com/mbox/","series":[{"id":500377,"url":"http://patchwork.ozlabs.org/api/1.2/series/500377/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500377","date":"2026-04-17T17:25:07","name":"Align struct/class forward declaration with implementation","version":1,"mbox":"http://patchwork.ozlabs.org/series/500377/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224605/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224605/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=e5s3bOBn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=e5s3bOBn","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","sourceware.org; spf=pass smtp.mailfrom=foss.st.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=40.107.130.6"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy2012sCtz1yCv\n\tfor ; Sat, 18 Apr 2026 03:28:01 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 68F204CD203A\n\tfor ; Fri, 17 Apr 2026 17:27:59 +0000 (GMT)","from MRWPR03CU001.outbound.protection.outlook.com\n (mail-francesouthazon11011006.outbound.protection.outlook.com [40.107.130.6])\n by sourceware.org (Postfix) with ESMTPS id 566904AA397A\n for ; Fri, 17 Apr 2026 17:27:31 +0000 (GMT)","from AS4P189CA0031.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::11)\n by DU4PR10MB8610.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:56c::7) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr\n 2026 17:27:27 +0000","from AMS0EPF000001B7.eurprd05.prod.outlook.com\n (2603:10a6:20b:5dd:cafe::6d) by AS4P189CA0031.outlook.office365.com\n (2603:10a6:20b:5dd::11) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.52 via Frontend Transport; Fri,\n 17 Apr 2026 17:27:27 +0000","from smtpO365.st.com (164.130.1.60) by\n AMS0EPF000001B7.mail.protection.outlook.com (10.167.16.171) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Fri, 17 Apr 2026 17:27:26 +0000","from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com\n (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 17 Apr\n 2026 19:30:16 +0200","from jkgcxl0012.jkg.st.com (10.74.22.122) by STKDAG1NODE2.st.com\n (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 17 Apr\n 2026 19:27:26 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 68F204CD203A","OpenDKIM Filter v2.11.0 sourceware.org 566904AA397A"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 566904AA397A","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 566904AA397A","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776446851; cv=pass;\n b=VlWrNN8q+36ewwVINffZWzH66/xEDImTXiT2sAzPRC4wmYCk3bdNMp1caUSPoeZlF+WyrgJewnryX01hMvQVhrnMcWC31Hn5Keg2QBIP0nvo4df6IgzU1ccoDrLHQfTSgI2B43vfNbhlenHAHNUF/nsUUMlnaTQMWnXTIRG2jMs=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=uA2yR9dWMInWeZ0SWn9s1XsYer7j6wm39zUHWTVvBo/ftdvQtNpTnjO3IltOGSDZZFZLuoJ6+X9FV6VRm31gnZzk9p4MiLLTSXNJhZpt5oRzz0I4YoBqw8Jl1khiYI2kmgO/7LIA9xWJfvVu4tPlbheWAQuyiFonbYluFtTlKleCQcSCaihE9VOsuI2qz6OY3e8mfDICiWDx5zGxq7cs7p2gUTKlWOeWsRC/96dYHtAAMLgsViOoip6oLH9F7aTs6WGSEywJqFRswk8sHrlyQ/olH4CaJyCTvnU9nNlkjZEskHHsUGpFd93V65Z8+nGM1kRc0mkC8+MXpUbvKed02w=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776446851; c=relaxed/simple;\n bh=bbL5uHyDK7xlhx9zoQ32hSYo5V89q97q2+CrXmt6ROk=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=h3xDzJI4J+go9S/I0uuo3H26w5s0muEzDiEk1Em21IIqGt2QVxNqakpDDuPR4M1KoHA/kJGRTrTvFEgCd76oPwV5a9Mralcd6m4LOO6/lmJ+02OjXRUNWXM24SMHsBqUBGTTc0HpmuBXUNyVS4K9qTowuGGGljh+uetx695+5wg=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=tLA25ejXzypWdkQVzvDWopgxCKdPhxoG2NYeIdbcH+I=;\n b=R2E2FWG0XvpwAr+M/jOIBRfTdmmJD8E07JKj8HJBGRF72mS2cN9UYd/VUG45tTgS4WCVa8+9dgzQLOZxYkxGLOt1ZZENDKwzOwL6V4im7/9xLOrzAUXxSxleYmLKQ5uYMiFa5MCtdMMzMM44wIRQIshczKhR8sZeLfn1sJV9+mSgrRQPgHdVjAWTygx0Ivoy5mUN/K1ae6sX3Lc8tESrBx8YNDBJp/KyefeDDQ5/onVEc+fWhog+BHWLsclcgwVe3U2e4uFBDnVJtZadXwJPBqmVhEIFu/06OV5wYNvK5LeH2/ftI7hjkN8jXSBX3EgWMJS5qPrFyAxw/zRiJAJhhA=="],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 164.130.1.60) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=foss.st.com;\n dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com;\n dkim=none (message not signed); arc=none (0)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=tLA25ejXzypWdkQVzvDWopgxCKdPhxoG2NYeIdbcH+I=;\n b=e5s3bOBn4TZPvG/DOThD3ThEmjMoyUJ5IRvsuH3HKz7pwvORCF7H2lTqg7PQX8DvsyihkE8tlK7nAkLTaA+Vy12J2XkS1yr5pUu0LsmFVrVxwnAAjhnQrPTuiiy+oKfdRepqV/1APtHtPPVm/r6b6HQ8Jab8D2wR5Q1qWDX+oxatkSDc+jWHmn2R2vQTqslDik+mbNTw+Yd6EyFWseQnnv6rr3Wq+QXAIUHP8tetTQK3pS3u5ahbA281bWFluDaViNKDArDMJ5/omvlZ0BxKb+d2FaSXdCTPc5Gtg7EdNCSNe115a8pkpgEfCw+8iUeg0fiLrhKALX40gNePw5fnsQ==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.60)\n smtp.mailfrom=foss.st.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com;\n client-ip=164.130.1.60; helo=smtpO365.st.com;","From":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","To":"","CC":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","Subject":"[PATCH 07/30] Change `struct mkdeps` to `class mkdeps` to align tags","Date":"Fri, 17 Apr 2026 19:27:09 +0200","Message-ID":"<20260417172712.1015232-2-torbjorn.svensson@foss.st.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260417172712.1015232-1-torbjorn.svensson@foss.st.com>","References":"<20260417172506.1015169-2-torbjorn.svensson@foss.st.com>\n <20260417172712.1015232-1-torbjorn.svensson@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8bit","X-Originating-IP":"[10.74.22.122]","X-ClientProxiedBy":"ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com\n (10.75.128.133)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AMS0EPF000001B7:EE_|DU4PR10MB8610:EE_","X-MS-Office365-Filtering-Correlation-Id":"f37512ee-b623-4c20-1110-08de9ca69877","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|36860700016|82310400026|376014|1800799024|42112799006|22082099003|56012099003|18002099003|11006099003;","X-Microsoft-Antispam-Message-Info":"\n c+oSRedGDXCnZ9ASvYiT8AQOWC+D639aBP+jQthX9SEtu0kepOYGCgPQyyyP6MgUEms3+GebP/pqOzKW0IuqwkzD3VzFvR5K+tSHgWSszs0m38jnBgtuizsJy9VknKBEIVMWxr+YlYGdO9i5NaVEzqgTRU3ufLNQZameEYTYnLj3T51vKWhQdPu6dRbvysxkw/RTuNCEzxfbPfmkC/58iHK1Jl10YJBxL6bvRDrcz9mCP7afAKt4id4f3zvcJnGgvWFLK5jvNOwR7z0Nrc90n6Qcg8COvmuGjTVnbOYAchAJAP5UjBZ+52VPw3EvHUVWJjeuu/7muyl1cRaejo9c3/mGYjVim2JBQvBjeMU45FIm8+0RKIi78Du/BUjgsTBo9LzalTkzQ9LqsFJ+6JkAKczUDeLS6HN+9FFn6Egmuw+xorawRKkYXa4In4AgUn4HmpbWXz1a8YeT9Oa6qsWos+h8I/YDrpZKV6hUB6R5zW0m39zvEtg2/+p/pYGsWDx9KmIMDkX7CNPLsPkaD+76iBDmSMvKAAJGPr7m2dJ0gwiWy+81ZbObO8QS0P5CavsqyB0tYym3CKHImIJIS3GCyRfiSBDxObAyWum1NgMwi6jglGM/ydACrHrxp6N/Z+X3XRp8GHkRrFl0suSkYcJqAATEWSKiE8zIPCmWaI87OhHma8pUGwy+YCj+cV42Ukg7fVb+eHyrQHh6vHLuk5hSaXBmOeVCRftwWsJCf5O7cAwEjlccNvnClQL7huOzFJSCWE/+dbBJWzylNF1RbAB08w==","X-Forefront-Antispam-Report":"CIP:164.130.1.60; CTRY:IT; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(42112799006)(22082099003)(56012099003)(18002099003)(11006099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n fcPKzkLZtFd8RSucr1wZZFS/iMFt8jzBSXcaEWHi4QySk1LYwHHwfJTHtG7RtLRP0Mf7DyKBbeLxmHaSoDaClnNUfh5lqWZcojz9J0WADSoh7a4VpscHsmETDbALliZ0aSMR0n8P83cKaG4YKDOKfCADb3o90z+5SD1l0W/cGYf6DuBZT4JSFbbPWCN05At8vIxE5GpnGsiWlTWDOYA6Bd1JvThPvEkEbVBj1qJMcCSfD1JQcsBiXlnmV2N1ArBU8UKTCpga3D+G7JgX/E6tzLQCg/aTv/K5kU2BpFvd406OrL+8otn+sZlm4Q/g7Rkw+Hb9NWqHjmQyIDZI+k2cmtg79mUBw5fPBOG6kySisbBkhnQjI7pbJBB8i9POYI1N4sjwPnE5DRN7Dgli2OFbztyZV2lQSeH5f5a/k5kR3bpeQhIr8CR4djrIkukd7t4W","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Apr 2026 17:27:26.8714 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n f37512ee-b623-4c20-1110-08de9ca69877","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.60];\n Helo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n AMS0EPF000001B7.eurprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DU4PR10MB8610","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"Building GCC with clang gives warnings like:\nwarning: struct 'mkdeps' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]\n\nlibcpp/ChangeLog:\n\n\t* include/mkdeps.h: Change `struct mkdeps` to `class mkdeps`.\n\t* mkdeps.cc: Likewise.\n\nSigned-off-by: Torbjörn SVENSSON \n---\n libcpp/include/mkdeps.h | 8 ++++----\n libcpp/mkdeps.cc | 8 ++++----\n 2 files changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/libcpp/include/mkdeps.h b/libcpp/include/mkdeps.h\nindex e92e9941eb1..d9e96102759 100644\n--- a/libcpp/include/mkdeps.h\n+++ b/libcpp/include/mkdeps.h\n@@ -52,15 +52,15 @@ extern void deps_add_target (class mkdeps *, const char *, int);\n extern void deps_add_default_target (class mkdeps *, const char *);\n \n /* Adds a module target. The module name and cmi name are copied. */\n-extern void deps_add_module_target (struct mkdeps *, const char *module,\n+extern void deps_add_module_target (class mkdeps *, const char *module,\n \t\t\t\t const char *cmi, bool is_header,\n \t\t\t\t bool is_exported);\n \n /* Adds a module dependency. The module name is copied. */\n-extern void deps_add_module_dep (struct mkdeps *, const char *module);\n+extern void deps_add_module_dep (class mkdeps *, const char *module);\n \n /* Add a structured dependency target. */\n-extern void fdeps_add_target (struct mkdeps *, const char *, bool);\n+extern void fdeps_add_target (class mkdeps *, const char *, bool);\n \n /* Add a dependency (appears on the right side of the colon) to the\n deps list. Dependencies will be printed in the order that they\n@@ -73,7 +73,7 @@ extern void deps_add_dep (class mkdeps *, const char *);\n extern void deps_write (const cpp_reader *, FILE *, unsigned int);\n \n /* Write out a deps buffer to a specified file in P1689R5 format. */\n-extern void deps_write_p1689r5 (const struct mkdeps *, FILE *);\n+extern void deps_write_p1689r5 (const class mkdeps *, FILE *);\n \n /* Write out a deps buffer to a file, in a form that can be read back\n with deps_restore. Returns nonzero on error, in which case the\ndiff --git a/libcpp/mkdeps.cc b/libcpp/mkdeps.cc\nindex 748aa9c7baf..f8f34d69ab3 100644\n--- a/libcpp/mkdeps.cc\n+++ b/libcpp/mkdeps.cc\n@@ -305,7 +305,7 @@ deps_add_default_target (class mkdeps *d, const char *tgt)\n used to associate the structured dependency information with that rule as\n needed. */\n void\n-fdeps_add_target (struct mkdeps *d, const char *o, bool is_primary)\n+fdeps_add_target (class mkdeps *d, const char *o, bool is_primary)\n {\n o = apply_vpath (d, o);\n if (is_primary)\n@@ -359,7 +359,7 @@ deps_add_vpath (class mkdeps *d, const char *vpath)\n name. */\n \n void\n-deps_add_module_target (struct mkdeps *d, const char *m,\n+deps_add_module_target (class mkdeps *d, const char *m,\n \t\t\tconst char *cmi, bool is_header_unit, bool is_exported)\n {\n gcc_assert (!d->module_name);\n@@ -373,7 +373,7 @@ deps_add_module_target (struct mkdeps *d, const char *m,\n /* Add a new module dependency. M is the module name. */\n \n void\n-deps_add_module_dep (struct mkdeps *d, const char *m)\n+deps_add_module_dep (class mkdeps *d, const char *m)\n {\n d->modules.push (xstrdup (m));\n }\n@@ -586,7 +586,7 @@ p1689r5_write_vec (const mkdeps::vec &vec, FILE *fp)\n TODO: move `json.h` to libiberty. */\n \n void\n-deps_write_p1689r5 (const struct mkdeps *d, FILE *fp)\n+deps_write_p1689r5 (const class mkdeps *d, FILE *fp)\n {\n fputs (\"{\\n\", fp);\n \n","prefixes":["07/30"]}