{"id":2224604,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224604/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260417172621.1015209-3-torbjorn.svensson@foss.st.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417172621.1015209-3-torbjorn.svensson@foss.st.com>","list_archive_url":null,"date":"2026-04-17T17:26:19","name":"[03/30] Change `struct data_in` to `class data_in` to align tags","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ac4b0447ca55902314acc3250795dc9b45ee1308","submitter":{"id":84848,"url":"http://patchwork.ozlabs.org/api/1.2/people/84848/?format=json","name":"Torbjörn SVENSSON","email":"torbjorn.svensson@foss.st.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260417172621.1015209-3-torbjorn.svensson@foss.st.com/mbox/","series":[{"id":500377,"url":"http://patchwork.ozlabs.org/api/1.2/series/500377/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=500377","date":"2026-04-17T17:25:07","name":"Align struct/class forward declaration with implementation","version":1,"mbox":"http://patchwork.ozlabs.org/series/500377/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224604/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224604/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=b3CkAq/a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=foss.st.com header.i=@foss.st.com header.a=rsa-sha256\n header.s=selector2 header.b=b3CkAq/a","sourceware.org;\n dmarc=pass (p=none dis=none) header.from=foss.st.com","sourceware.org; spf=pass smtp.mailfrom=foss.st.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=52.101.69.39"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fy1zz1nkKz1yCv\n\tfor ; Sat, 18 Apr 2026 03:27:59 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 20BD24D8D1F3\n\tfor ; Fri, 17 Apr 2026 17:27:57 +0000 (GMT)","from AM0PR83CU005.outbound.protection.outlook.com\n (mail-westeuropeazon11010039.outbound.protection.outlook.com [52.101.69.39])\n by sourceware.org (Postfix) with ESMTPS id 61A944D108D5\n for ; Fri, 17 Apr 2026 17:26:39 +0000 (GMT)","from AS9P194CA0017.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::33)\n by AS5PR10MB8295.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:655::6)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr\n 2026 17:26:36 +0000","from AMS0EPF000001B5.eurprd05.prod.outlook.com\n (2603:10a6:20b:46d:cafe::8d) by AS9P194CA0017.outlook.office365.com\n (2603:10a6:20b:46d::33) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.52 via Frontend Transport; Fri,\n 17 Apr 2026 17:26:36 +0000","from smtpO365.st.com (164.130.1.60) by\n AMS0EPF000001B5.mail.protection.outlook.com (10.167.16.169) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9769.17 via Frontend Transport; Fri, 17 Apr 2026 17:26:36 +0000","from STKDAG1NODE2.st.com (10.75.128.133) by smtpO365.st.com\n (10.250.44.72) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 17 Apr\n 2026 19:29:26 +0200","from jkgcxl0012.jkg.st.com (10.74.22.122) by STKDAG1NODE2.st.com\n (10.75.128.133) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Fri, 17 Apr\n 2026 19:26:35 +0200"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 20BD24D8D1F3","OpenDKIM Filter v2.11.0 sourceware.org 61A944D108D5"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 61A944D108D5","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 61A944D108D5","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776446799; cv=pass;\n b=WHUTk+88SPDlD+BuXuSm9Q5pPtGKheIhEVK2coVLYWxtilkr5YYrh0WWTmXA53gGkJfH8sRXmdGX8r30coFsJKz0c+SSdUklwIN2a2HUMB7C+G2I/gLqbwq5hu66Kr6prmpUKesBKRInUN9XLxYvCGUgdxzCJC7fUxwE7cp1J18=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=MpWjrAqaxZ/0k8107OLABQm2+chEGPI+egooOYzjeAOrQBSieOWkuFGKzvILTDNucazIqp9oTh+dYeRkPXfL4rTMCGPw7eojFAWINhfHzeJb5bUSdfCwuHpEkrilJqRvwWKnx8m9LpmqTFQqPbjXaYf/2Ht4tCaDgeuRzde5m5aLAzFOr1Md9sVd9bhf0uAf2hvJYmrqWVzZbEhqBfS+5UCOB8J1S0BLuTAGe9EJWqTbWaHO+QgWCfF/4GBHlIRFsLSWZWs+BP3eHJsB78QLb2Ch8lXKz4vYQnyu7K5bRVEJVKf9MWMoLz8lt/elp/67iyBUQQ8Fw2scOQwTfngjdw=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776446799; c=relaxed/simple;\n bh=bi1s8n86csEHVBiylSM6RjoTXmSLj14vr2XK4tcum5U=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=AqxMNQF/01jEJV9y4kuOfgVBiEd46K5WlTcmzkVG1j5jpcisl8GBufMyYeUjoWtPTbWo/dPwoIWmQ5qxDPv+v2kwV43IjuwhUFEOb2meA7bpl/0WuFsdnIizdPaQSg7dltb7VdCs72KXjHkTApnQKefVvLnxbETQnoHI5wtcqCQ=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RLtAmUDYNFq2YeGLzNQ8+DLZLkqu5ieLZ0I05F2T0yA=;\n b=ZOKGzn+cQd5ZwhUWJBSjesoTbeDqwz6h8Zgs/jvd6R98HGSlFRNU3/LZ0ocrFtTKuEfqqsxV+54uDveEm5URS6nZe9uZUWKFQl7AW6h9MBIMY4jpRu4g4K8EpxRghY8MHtrIn+HNstKT/GUnYDs08tRdMlnx9XXTkrosFrbJ7ojUjs5TBl0KWShNRgl179j8rVBi5zd9LxurlWc7/X+Q9gVQ+EdElLd4QsX4BVGBnFhb4RcsKg2xvdb7RlkLpXop9H4I7meNW2WC/m/3YBsCa/EW9rP8hYq/AbBel+xvxsov8BtKwWVNr5os87xdZ29RsJtcUjfrhYsYCtnBs4szgw=="],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.microsoft.com 1; spf=fail (sender ip is\n 164.130.1.60) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=foss.st.com;\n dmarc=fail (p=none sp=none pct=100) action=none header.from=foss.st.com;\n dkim=none (message not signed); arc=none (0)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RLtAmUDYNFq2YeGLzNQ8+DLZLkqu5ieLZ0I05F2T0yA=;\n b=b3CkAq/aqN3VtsQGomLJAbFfdTyGxSrxSOtK+2DUXprVSSUrTKVA2lvce93GMUB71dk1rhHhCD89tnBttQ6zyQckjvVpm+vbXzzMxA0oNCB/dQBU7SF9mE2H2y8O38FDpB4lLBcNlB/MARHbatKBdDgFm0vNSTW8HT8kAAjIkDm0yCDE2QnqG/Gu5MSQVIpelsKXBC5KsAs0g4JG1kIJ2uPJkpJrJbEzcrmLXbyEmChY6JA6RNGog1a2sdwWsA5OS82dhxsdsXIycKi/j7Lm9IsbCaFeNxpO4kvVH0LCQ0WE8o0Tjkpv84qaV+UTyIshb21tuEQy3CFfR/xftkgyfA==","X-MS-Exchange-Authentication-Results":"spf=fail (sender IP is 164.130.1.60)\n smtp.mailfrom=foss.st.com; dkim=none (message not signed)\n header.d=none;dmarc=fail action=none header.from=foss.st.com;","Received-SPF":"Fail (protection.outlook.com: domain of foss.st.com does not\n designate 164.130.1.60 as permitted sender) receiver=protection.outlook.com;\n client-ip=164.130.1.60; helo=smtpO365.st.com;","From":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","To":"","CC":"=?utf-8?q?Torbj=C3=B6rn_SVENSSON?= ","Subject":"[PATCH 03/30] Change `struct data_in` to `class data_in` to align\n tags","Date":"Fri, 17 Apr 2026 19:26:19 +0200","Message-ID":"<20260417172621.1015209-3-torbjorn.svensson@foss.st.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260417172621.1015209-1-torbjorn.svensson@foss.st.com>","References":"<20260417172506.1015169-2-torbjorn.svensson@foss.st.com>\n <20260417172621.1015209-1-torbjorn.svensson@foss.st.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"8bit","X-Originating-IP":"[10.74.22.122]","X-ClientProxiedBy":"ENXCAS1NODE2.st.com (10.75.128.138) To STKDAG1NODE2.st.com\n (10.75.128.133)","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AMS0EPF000001B5:EE_|AS5PR10MB8295:EE_","X-MS-Office365-Filtering-Correlation-Id":"e3022472-70ed-413a-a6b3-08de9ca67a4e","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|82310400026|42112799006|36860700016|376014|1800799024|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n 1DD4ClQBME2FNPS6EUxZd+1157aBDLHd1xBLxqvPNvwGDIOqDBZpm4pn1t0nMVztKKvqUPwIrZcNoTFq9II0IGDgcXxsmjUZjZn1T/SrNBFN0lotbaTK5ax7FYg9PlqUEL1FzXb0L3+m2gisxqgJoMjqUur/xaYr0gl/y5tVni3nLrqA+Koswm0xdjeZAwenIWzBf/KuCu70gxY30wOGJsmcArZg9k6R8kAyWxznoAEtcHg9flOClG2Dy4YVMZvwzb31NzwYEcnQaIHGM3jkKXkegc1L+4XT0P/HfdqOlTW7qB43FaGP9iK1753tUIMsrlGVJOYc1R6806R5vNJIlLUySd9oHN9So02YHq68Sx4gQZ6hzypr6SDuA88wORCcans1kyEEJEBpPupkZlwMDkyqQKwvVUsgaPFX+lp/0FmvbGIPY7fX2G0FFfRvWGrSPu0gg/jSsFSXhZBu4mPPZq9A4ORUW5i/xkl1gVWTtWizTCb4Aze+CEbYpyZTUkGYZSJ0CcKucTZtR3PKzOJqtuAxo0SFXaa2x5EXPoTeSJ/jtKPOx0eMrRWnYxc84uSeL7LnhQlUyc9b0QlQ6dy01dkivboGjEgOJfrYgPowkYg51yCYevm1dEQzWZVoAj9jD68lX97d9rMYUzLFVx8jG+QG0CBjyQ933/510jGH3pyh5d/pfEv44EmACzTPauKE4Wux0LIDdmbJII6Vta7GEMmJ/M6FsnPLlULuk3YUQHEoAFYK4Cx4e3vxPW/Gnmq4RudZklSXhTPVE7T/ttETwA==","X-Forefront-Antispam-Report":"CIP:164.130.1.60; CTRY:IT; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:smtpO365.st.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230040)(82310400026)(42112799006)(36860700016)(376014)(1800799024)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n XnbT7q2act9/HPa26rJx4+RO021VXilXzR1GCJkL9zfmxYsSHO/2QQdfSw1CHsWQ6Jr4PoXyqlK6Ae2cO+s6ZvbJOrmwljDZLpdPd2n55Bj7zBW/ahAI0GQQWUkr9Rz3fY9DJAb2D4nxEAdcrGy23ypvJ71flvHf0eGKMiMn/crK0gRHlYC9U0CmSvkuCBI87KWdMP66bpwm5C3JVJXqVeMURfGJQNrvgbwyK/9qSh2uc8D/ZxDfFh2MmqOXkvzteMs5RJC5ii4GYBp2J/BG18WW9NUATR6GI2wOY6cXb9ZfWRtF9GE71ylAvcKYXjeFTGn21I512WIuIwOtevNOE91SrXDYSpOzv+zEcnsTLceRN5v/N/fjMOosOItYntEOIUj2bnFCwq3c0016EI5ZcUJIWs338kwLPTge+4U2N5Ykr89NOXE4STSBCqJ6vlMf","X-OriginatorOrg":"foss.st.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Apr 2026 17:26:36.2738 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n e3022472-70ed-413a-a6b3-08de9ca67a4e","X-MS-Exchange-CrossTenant-Id":"75e027c9-20d5-47d5-b82f-77d7cd041e8f","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=75e027c9-20d5-47d5-b82f-77d7cd041e8f; Ip=[164.130.1.60];\n Helo=[smtpO365.st.com]","X-MS-Exchange-CrossTenant-AuthSource":"\n AMS0EPF000001B5.eurprd05.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"AS5PR10MB8295","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"Building GCC with clang gives warnings like:\nwarning: struct 'data_in' was previously declared as a class; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Wmismatched-tags]\n\ngcc/ChangeLog:\n\n\t* ipa-modref.cc: Change `struct data_in` to `class data_in`.\n\t* ipa-sra.cc: Likewise.\n\t* optc-save-gen.awk: Likewise.\n\nSigned-off-by: Torbjörn SVENSSON \n---\n gcc/ipa-modref.cc | 4 ++--\n gcc/ipa-sra.cc | 4 ++--\n gcc/optc-save-gen.awk | 4 ++--\n 3 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/gcc/ipa-modref.cc b/gcc/ipa-modref.cc\nindex b18ddfc41fa..af508d75d06 100644\n--- a/gcc/ipa-modref.cc\n+++ b/gcc/ipa-modref.cc\n@@ -3575,7 +3575,7 @@ write_modref_records (modref_records_lto *tt, struct output_block *ob)\n \n static void\n read_modref_records (tree decl,\n-\t\t lto_input_block *ib, struct data_in *data_in,\n+\t\t lto_input_block *ib, class data_in *data_in,\n \t\t modref_records **nolto_ret,\n \t\t modref_records_lto **lto_ret)\n {\n@@ -3833,7 +3833,7 @@ read_section (struct lto_file_decl_data *file_data, const char *data,\n const int cfg_offset = sizeof (struct lto_function_header);\n const int main_offset = cfg_offset + header->cfg_size;\n const int string_offset = main_offset + header->main_size;\n- struct data_in *data_in;\n+ class data_in *data_in;\n unsigned int i;\n unsigned int f_count;\n \ndiff --git a/gcc/ipa-sra.cc b/gcc/ipa-sra.cc\nindex 5c8bc7c069c..3dfc93fe723 100644\n--- a/gcc/ipa-sra.cc\n+++ b/gcc/ipa-sra.cc\n@@ -2947,7 +2947,7 @@ isra_read_edge_summary (struct lto_input_block *ib, cgraph_edge *cs)\n \n static void\n isra_read_node_info (struct lto_input_block *ib, cgraph_node *node,\n-\t\t struct data_in *data_in)\n+\t\t class data_in *data_in)\n {\n isra_func_summary *ifs = func_sums->get_create (node);\n unsigned param_desc_count = streamer_read_uhwi (ib);\n@@ -3010,7 +3010,7 @@ isra_read_summary_section (struct lto_file_decl_data *file_data,\n const int cfg_offset = sizeof (struct lto_function_header);\n const int main_offset = cfg_offset + header->cfg_size;\n const int string_offset = main_offset + header->main_size;\n- struct data_in *data_in;\n+ class data_in *data_in;\n unsigned int i;\n unsigned int count;\n \ndiff --git a/gcc/optc-save-gen.awk b/gcc/optc-save-gen.awk\nindex 775c5db5df0..15cd5b57e48 100644\n--- a/gcc/optc-save-gen.awk\n+++ b/gcc/optc-save-gen.awk\n@@ -1213,7 +1213,7 @@ print \"}\";\n print \"\";\n print \"/* Stream in target options */\";\n print \"void\";\n-print \"cl_target_option_stream_in (struct data_in *data_in ATTRIBUTE_UNUSED,\";\n+print \"cl_target_option_stream_in (class data_in *data_in ATTRIBUTE_UNUSED,\";\n print \" struct bitpack_d *bp ATTRIBUTE_UNUSED,\";\n print \" struct cl_target_option *ptr ATTRIBUTE_UNUSED)\";\n print \"{\";\n@@ -1420,7 +1420,7 @@ print \"}\";\n print \"\";\n print \"/* Stream in optimization options */\";\n print \"void\";\n-print \"cl_optimization_stream_in (struct data_in *data_in ATTRIBUTE_UNUSED,\";\n+print \"cl_optimization_stream_in (class data_in *data_in ATTRIBUTE_UNUSED,\";\n print \" struct bitpack_d *bp ATTRIBUTE_UNUSED,\";\n print \" struct cl_optimization *ptr ATTRIBUTE_UNUSED)\";\n print \"{\";\n","prefixes":["03/30"]}