{"id":2224548,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224548/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417145907.696307-4-poros@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417145907.696307-4-poros@redhat.com>","list_archive_url":null,"date":"2026-04-17T14:59:07","name":"[iwl-net,v7,3/3] ice: add dpll peer notification for paired SMA and U.FL pins","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3d9dd33401668a3dc7f1df89824ff44a076f58fd","submitter":{"id":74657,"url":"http://patchwork.ozlabs.org/api/1.2/people/74657/?format=json","name":"Petr Oros","email":"poros@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417145907.696307-4-poros@redhat.com/mbox/","series":[{"id":500359,"url":"http://patchwork.ozlabs.org/api/1.2/series/500359/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500359","date":"2026-04-17T14:59:04","name":"ice: fix missing dpll notifications for SW pins","version":7,"mbox":"http://patchwork.ozlabs.org/series/500359/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224548/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224548/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=hWiM7pVG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxyj41tWqz1yD3\n\tfor ; Sat, 18 Apr 2026 00:59:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id A132880E0C;\n\tFri, 17 Apr 2026 14:59:50 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id btPOs-vokVWY; Fri, 17 Apr 2026 14:59:48 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id CE7BE80DFF;\n\tFri, 17 Apr 2026 14:59:48 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 526D4396\n for ; Fri, 17 Apr 2026 14:59:47 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 43D0460E00\n for ; Fri, 17 Apr 2026 14:59:47 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id DcVAfNXLDXHZ for ;\n Fri, 17 Apr 2026 14:59:46 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 2830460DFF\n for ; Fri, 17 Apr 2026 14:59:45 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-367-ewrOrWXhNW-TpdYCXsSPuA-1; Fri,\n 17 Apr 2026 10:59:38 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id C187119560B1; Fri, 17 Apr 2026 14:59:34 +0000 (UTC)","from ShadowPeak.redhat.com (unknown [10.44.32.76])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7F13E3000C1E; Fri, 17 Apr 2026 14:59:29 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org CE7BE80DFF","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2830460DFF"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776437988;\n\tbh=gbpFvcWrWZxCHOudUuz8MQpAoKeJ9RTgsaIS867Lomg=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=hWiM7pVGDTujqB8+DEFwaGriadTGbAvK3mkV1M59zNlYJXIFdTUj/RxVO2p/Am/om\n\t MCNzNb4YgRoo5Vgkkhc1jEW6uN7ObvRmFXIqsVBq8ido+/zSSETU5AUkfFj4ikMGzF\n\t Scn5vUsHQgLEl3DyQV0zjgDtMfORk3EqCyk6V6bvvokd4VTr8owt947jT+DUdFWS7U\n\t RjOszniO4dd6h3l/283gCMpp6bTQWr6pKOWRtlmFhWyCbra5LPPp4c5NkfbhXcYlR3\n\t jYKareHpGKg8GLI+YzYVDdSEXDixAbv5Rhrsu8paqJXXgng158WGOsennbHxIOYMut\n\t aGfYTsw5gQf1Q==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 2830460DFF","X-MC-Unique":"ewrOrWXhNW-TpdYCXsSPuA-1","X-Mimecast-MFC-AGG-ID":"ewrOrWXhNW-TpdYCXsSPuA_1776437975","From":"Petr Oros ","To":"netdev@vger.kernel.org","Date":"Fri, 17 Apr 2026 16:59:07 +0200","Message-ID":"<20260417145907.696307-4-poros@redhat.com>","In-Reply-To":"<20260417145907.696307-1-poros@redhat.com>","References":"<20260417145907.696307-1-poros@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-MFC-PROC-ID":"t0fTB0h0mmPAcCe_0kBFCB-wRm5PRMEOQT0H1iJPJmg_1776437975","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776437985;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=gbpFvcWrWZxCHOudUuz8MQpAoKeJ9RTgsaIS867Lomg=;\n b=Nwhj2PQhcjEQlc0U5GIWsZriE1tQaNqxbkwvdPVcFtzsoW2sr8QdAg6HxXQ0uC5HQyUdjV\n fWPLp504+Vj4pjfO/y6LXJ6kReONOaEWJ39clr5QABK5LLOuvy4aFptUYfgsE+U+YXHReg\n g9sd4BKxpxoDIAyrHoFf+UkExA42mnI=","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=Nwhj2PQh"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v7 3/3] ice: add dpll peer\n notification for paired SMA and U.FL pins","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Ivan Vecera ,\n Vadim Fedorenko , Jiri Pirko ,\n Rinitha S ,\n Przemek Kitszel ,\n Eric Dumazet ,\n Arkadiusz Kubalewski ,\n Aleksandr Loktionov ,\n Andrew Lunn ,\n Tony Nguyen ,\n Simon Horman , intel-wired-lan@lists.osuosl.org,\n Jacob Keller , Jakub Kicinski ,\n Paolo Abeni , \"David S. Miller\" ,\n linux-kernel@vger.kernel.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"SMA and U.FL pins share physical signal paths in pairs (SMA1/U.FL1 and\nSMA2/U.FL2). When one pin's state changes via a PCA9575 GPIO write,\nthe paired pin's state also changes, but no notification is sent for\nthe peer pin. Userspace consumers monitoring the peer via dpll netlink\nsubscribe never learn about the update.\n\nAdd ice_dpll_sw_pin_notify_peer() which sends a change notification for\nthe paired SW pin. Call it from ice_dpll_pin_sma_direction_set(),\nice_dpll_sma_pin_state_set(), and ice_dpll_ufl_pin_state_set() after\npf->dplls.lock is released. Use __dpll_pin_change_ntf() because\ndpll_lock is still held by the dpll netlink layer (dpll_pin_pre_doit).\n\nFixes: 2dd5d03c77e2 (\"ice: redesign dpll sma/u.fl pins control\")\nSigned-off-by: Petr Oros \n---\n drivers/net/ethernet/intel/ice/ice_dpll.c | 32 +++++++++++++++++++++++\n 1 file changed, 32 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/ice/ice_dpll.c b/drivers/net/ethernet/intel/ice/ice_dpll.c\nindex 11b942b83500fb..be72a076f7a15c 100644\n--- a/drivers/net/ethernet/intel/ice/ice_dpll.c\n+++ b/drivers/net/ethernet/intel/ice/ice_dpll.c\n@@ -1154,6 +1154,32 @@ ice_dpll_input_state_get(const struct dpll_pin *pin, void *pin_priv,\n \t\t\t\t extack, ICE_DPLL_PIN_TYPE_INPUT);\n }\n \n+/**\n+ * ice_dpll_sw_pin_notify_peer - notify the paired SW pin after a state change\n+ * @d: pointer to dplls struct\n+ * @changed: the SW pin that was explicitly changed (already notified by dpll core)\n+ *\n+ * SMA and U.FL pins share physical signal paths in pairs (SMA1/U.FL1 and\n+ * SMA2/U.FL2). When one pin's routing changes via the PCA9575 GPIO\n+ * expander, the paired pin's state may also change. Send a change\n+ * notification for the peer pin so userspace consumers monitoring the\n+ * peer via dpll netlink learn about the update.\n+ *\n+ * Context: Called from dpll_pin_ops callbacks after pf->dplls.lock is\n+ * released. Uses __dpll_pin_change_ntf() because dpll_lock is\n+ * still held by the dpll netlink layer.\n+ */\n+static void ice_dpll_sw_pin_notify_peer(struct ice_dplls *d,\n+\t\t\t\t\tstruct ice_dpll_pin *changed)\n+{\n+\tstruct ice_dpll_pin *peer;\n+\n+\tpeer = (changed >= d->sma && changed < d->sma + ICE_DPLL_PIN_SW_NUM) ?\n+\t\t&d->ufl[changed->idx] : &d->sma[changed->idx];\n+\tif (peer->pin)\n+\t\t__dpll_pin_change_ntf(peer->pin);\n+}\n+\n /**\n * ice_dpll_sma_direction_set - set direction of SMA pin\n * @p: pointer to a pin\n@@ -1344,6 +1370,8 @@ ice_dpll_ufl_pin_state_set(const struct dpll_pin *pin, void *pin_priv,\n \n unlock:\n \tmutex_unlock(&pf->dplls.lock);\n+\tif (!ret)\n+\t\tice_dpll_sw_pin_notify_peer(&pf->dplls, p);\n \n \treturn ret;\n }\n@@ -1462,6 +1490,8 @@ ice_dpll_sma_pin_state_set(const struct dpll_pin *pin, void *pin_priv,\n \n unlock:\n \tmutex_unlock(&pf->dplls.lock);\n+\tif (!ret)\n+\t\tice_dpll_sw_pin_notify_peer(&pf->dplls, sma);\n \n \treturn ret;\n }\n@@ -1657,6 +1687,8 @@ ice_dpll_pin_sma_direction_set(const struct dpll_pin *pin, void *pin_priv,\n \tmutex_lock(&pf->dplls.lock);\n \tret = ice_dpll_sma_direction_set(p, direction, extack);\n \tmutex_unlock(&pf->dplls.lock);\n+\tif (!ret)\n+\t\tice_dpll_sw_pin_notify_peer(&pf->dplls, p);\n \n \treturn ret;\n }\n","prefixes":["iwl-net","v7","3/3"]}