{"id":2224546,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224546/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417145907.696307-2-poros@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417145907.696307-2-poros@redhat.com>","list_archive_url":null,"date":"2026-04-17T14:59:05","name":"[iwl-net,v7,1/3] dpll: export __dpll_pin_change_ntf() for use under dpll_lock","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"450f724c0f22ca87a40ce5ff5156abae5bf380fd","submitter":{"id":74657,"url":"http://patchwork.ozlabs.org/api/1.2/people/74657/?format=json","name":"Petr Oros","email":"poros@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260417145907.696307-2-poros@redhat.com/mbox/","series":[{"id":500359,"url":"http://patchwork.ozlabs.org/api/1.2/series/500359/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500359","date":"2026-04-17T14:59:04","name":"ice: fix missing dpll notifications for SW pins","version":7,"mbox":"http://patchwork.ozlabs.org/series/500359/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224546/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224546/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=M+5Ox4+2;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxyhm07Ttz1yD3\n\tfor ; Sat, 18 Apr 2026 00:59:36 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 5380E81516;\n\tFri, 17 Apr 2026 14:59:34 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9QrjE_AM-WrK; Fri, 17 Apr 2026 14:59:32 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 864D781510;\n\tFri, 17 Apr 2026 14:59:32 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 58263396\n for ; Fri, 17 Apr 2026 14:59:31 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 3DD1C60E00\n for ; Fri, 17 Apr 2026 14:59:31 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 0lt_m_ET6IiS for ;\n Fri, 17 Apr 2026 14:59:30 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 305ED60DFF\n for ; Fri, 17 Apr 2026 14:59:29 +0000 (UTC)","from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-614-VBRlW-aeM8mSJhpR2IRytQ-1; Fri,\n 17 Apr 2026 10:59:25 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 2313818001F8; Fri, 17 Apr 2026 14:59:23 +0000 (UTC)","from ShadowPeak.redhat.com (unknown [10.44.32.76])\n by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id C9CB73000C1D; Fri, 17 Apr 2026 14:59:17 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 864D781510","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 305ED60DFF"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776437972;\n\tbh=5K+oeeXrE8xykNoFcyiPqhE8KgPg7MMpfj1docSwu6w=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=M+5Ox4+2QIQEbHDNzTobpoPOcWAgcoc1tiwwejU0RceMFQQB91oFNEGYtZMebS2CS\n\t DhQzz0Iozj/j29F/68SfbdxEWbviEtpewaYAjyPr044E387Nj5avSgRv/VDGO7DcjJ\n\t xS6Sfq/03WaJvsW3QiFR1eezD3HhwQNPhLPLA2tmgLXMjTI/VXzHEtblhyTUvWDOKc\n\t LFjnkneG2LPwnTplgnXb+65RK9wGSgcNk8n/8uCNK7TyDNQDMWQFNz1IHfa4Aj6GWV\n\t 9qAJF+Z6VGUub06lZFjCmljaUnsMZgXWWQXCV2qiGTyF2WdvcS5QwaF4RnnNcKloI7\n\t YN1DeOKN8V5rA==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 305ED60DFF","X-MC-Unique":"VBRlW-aeM8mSJhpR2IRytQ-1","X-Mimecast-MFC-AGG-ID":"VBRlW-aeM8mSJhpR2IRytQ_1776437963","From":"Petr Oros ","To":"netdev@vger.kernel.org","Date":"Fri, 17 Apr 2026 16:59:05 +0200","Message-ID":"<20260417145907.696307-2-poros@redhat.com>","In-Reply-To":"<20260417145907.696307-1-poros@redhat.com>","References":"<20260417145907.696307-1-poros@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-MFC-PROC-ID":"ueZox7JpX1dB7pqtWtCkm3-cVi1N0vDBSUrQbb1zhKY_1776437963","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776437968;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=5K+oeeXrE8xykNoFcyiPqhE8KgPg7MMpfj1docSwu6w=;\n b=QsWeyqiKAxXq4cKhRApVjvXb/DWlJxxw+io61eB6qWUhP32bK9Bs6JlI1fzunrL/sbLfBh\n p8sSLYU8LWEvC/m2s23LuFKg1ml3BD/DEIXyUmlCpiMbJhIvAoJOD0PDsI/Q+tE/YW7h7b\n YjeORacFoZ3c8GPKBLJwtPlVXeZevCY=","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=QsWeyqiK"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v7 1/3] dpll: export\n __dpll_pin_change_ntf() for use under dpll_lock","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Ivan Vecera ,\n Vadim Fedorenko ,\n Rinitha S ,\n Przemek Kitszel ,\n Jiri Pirko ,\n Eric Dumazet ,\n Arkadiusz Kubalewski ,\n Aleksandr Loktionov ,\n Andrew Lunn ,\n Tony Nguyen ,\n Simon Horman , intel-wired-lan@lists.osuosl.org,\n Jacob Keller , Jakub Kicinski ,\n Paolo Abeni , \"David S. Miller\" ,\n linux-kernel@vger.kernel.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Ivan Vecera \n\nExport __dpll_pin_change_ntf() so that drivers can send pin change\nnotifications from within pin callbacks, which are already called\nunder dpll_lock. Using dpll_pin_change_ntf() in that context would\ndeadlock.\n\nAdd lockdep_assert_held() to catch misuse without the lock held.\n\nAcked-by: Vadim Fedorenko \nSigned-off-by: Ivan Vecera \nSigned-off-by: Petr Oros \n---\n drivers/dpll/dpll_netlink.c | 10 ++++++++++\n drivers/dpll/dpll_netlink.h | 2 --\n include/linux/dpll.h | 1 +\n 3 files changed, 11 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/dpll/dpll_netlink.c b/drivers/dpll/dpll_netlink.c\nindex af7ce62ec55ca8..0ff1658c2dc1ba 100644\n--- a/drivers/dpll/dpll_netlink.c\n+++ b/drivers/dpll/dpll_netlink.c\n@@ -900,11 +900,21 @@ int dpll_pin_delete_ntf(struct dpll_pin *pin)\n \treturn dpll_pin_event_send(DPLL_CMD_PIN_DELETE_NTF, pin);\n }\n \n+/**\n+ * __dpll_pin_change_ntf - notify that the pin has been changed\n+ * @pin: registered pin pointer\n+ *\n+ * Context: caller must hold dpll_lock. Suitable for use inside pin\n+ * callbacks which are already invoked under dpll_lock.\n+ * Return: 0 if succeeds, error code otherwise.\n+ */\n int __dpll_pin_change_ntf(struct dpll_pin *pin)\n {\n+\tlockdep_assert_held(&dpll_lock);\n \tdpll_pin_notify(pin, DPLL_PIN_CHANGED);\n \treturn dpll_pin_event_send(DPLL_CMD_PIN_CHANGE_NTF, pin);\n }\n+EXPORT_SYMBOL_GPL(__dpll_pin_change_ntf);\n \n /**\n * dpll_pin_change_ntf - notify that the pin has been changed\ndiff --git a/drivers/dpll/dpll_netlink.h b/drivers/dpll/dpll_netlink.h\nindex dd28b56d27c56d..a9cfd55f57fc42 100644\n--- a/drivers/dpll/dpll_netlink.h\n+++ b/drivers/dpll/dpll_netlink.h\n@@ -11,5 +11,3 @@ int dpll_device_delete_ntf(struct dpll_device *dpll);\n int dpll_pin_create_ntf(struct dpll_pin *pin);\n \n int dpll_pin_delete_ntf(struct dpll_pin *pin);\n-\n-int __dpll_pin_change_ntf(struct dpll_pin *pin);\ndiff --git a/include/linux/dpll.h b/include/linux/dpll.h\nindex b7277a8b484d26..f8037f1ab20b60 100644\n--- a/include/linux/dpll.h\n+++ b/include/linux/dpll.h\n@@ -286,6 +286,7 @@ int dpll_pin_ref_sync_pair_add(struct dpll_pin *pin,\n \n int dpll_device_change_ntf(struct dpll_device *dpll);\n \n+int __dpll_pin_change_ntf(struct dpll_pin *pin);\n int dpll_pin_change_ntf(struct dpll_pin *pin);\n \n int register_dpll_notifier(struct notifier_block *nb);\n","prefixes":["iwl-net","v7","1/3"]}