{"id":2224528,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224528/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/eee27aa38501fb359aed227cb121ed552edbaa72.1776426683.git.poros@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"","list_archive_url":null,"date":"2026-04-17T14:29:45","name":"[iwl-net,v2,4/4] iavf: add VIRTCHNL_OP_ADD_VLAN to success completion handler","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e89b256897a116676ba504093dfcea22b4ae33b8","submitter":{"id":74657,"url":"http://patchwork.ozlabs.org/api/1.2/people/74657/?format=json","name":"Petr Oros","email":"poros@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/eee27aa38501fb359aed227cb121ed552edbaa72.1776426683.git.poros@redhat.com/mbox/","series":[{"id":500351,"url":"http://patchwork.ozlabs.org/api/1.2/series/500351/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500351","date":"2026-04-17T14:29:41","name":"iavf: fix VLAN filter state machine races","version":2,"mbox":"http://patchwork.ozlabs.org/series/500351/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224528/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224528/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=lGTMzURz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxy3716nSz1yCv\n\tfor ; Sat, 18 Apr 2026 00:30:27 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9B4DF8145C;\n\tFri, 17 Apr 2026 14:30:25 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id QN3TnkFkYlR5; Fri, 17 Apr 2026 14:30:24 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id D8A0780B20;\n\tFri, 17 Apr 2026 14:30:24 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id B8239396\n for ; Fri, 17 Apr 2026 14:30:22 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 9DFDE81441\n for ; Fri, 17 Apr 2026 14:30:22 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id kPlf_M1R_rko for ;\n Fri, 17 Apr 2026 14:30:21 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 86E7880887\n for ; Fri, 17 Apr 2026 14:30:21 +0000 (UTC)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-99-RMI_5dtWPXyyCSXpo-w3Xg-1; Fri,\n 17 Apr 2026 10:30:14 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 4BA7C1955DDB; Fri, 17 Apr 2026 14:30:12 +0000 (UTC)","from ShadowPeak.redhat.com (unknown [10.44.32.76])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 7DBCB180047F; Fri, 17 Apr 2026 14:30:07 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org D8A0780B20","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 86E7880887"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776436224;\n\tbh=qRDouEYakfTZkhMNAyg/NTmNR2IdKqr6QrkWdzUnTo4=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=lGTMzURzuO0TXCj1lVBEwZDmH5jEBmKfAV0BB+FQyio8bOn1tAIIlLnQOxQU+m03y\n\t TRcownFQfrZ3YwyDAC3tLXjlqPuIiDS7VB+/aQsX/vyFRQH+MtAITATZ003ovWtuF6\n\t i8l65Ag225CV/6LPsdUMAL9Rq6WKfKG8LRvWtFD5ZcCxOPI/WxmTKUcnPYJZwc0c3K\n\t hYqiP0+E+exQzXud1tSN6vEe0EyQIPz6LQVU1ZCdqhM9B4Z3buRYP2oVyfbysXKgEb\n\t 089W/5wMANVWQ0C7/I16uXqKZNjp50+qtWUqSksEWDU5rYxGnsVg3kb20XQegKNk+a\n\t RuwvhSHQmgk9w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 86E7880887","X-MC-Unique":"RMI_5dtWPXyyCSXpo-w3Xg-1","X-Mimecast-MFC-AGG-ID":"RMI_5dtWPXyyCSXpo-w3Xg_1776436212","From":"Petr Oros ","To":"netdev@vger.kernel.org","Date":"Fri, 17 Apr 2026 16:29:45 +0200","Message-ID":"\n ","In-Reply-To":"","References":"","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-MFC-PROC-ID":"eRsrKLe7hKQYJd2Wty8FLflTil0iOhXUiINBtG_p6fg_1776436212","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776436220;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=qRDouEYakfTZkhMNAyg/NTmNR2IdKqr6QrkWdzUnTo4=;\n b=HIsSvCsAleBiIhwDNG6QuhhHatbfTdpHqMVw4bX7EAo4TPwaeihmmpdtvdHh0O1fdS2ASN\n lAZUla7wj6+tMVH7EyLDKmF0fV4JoS2KbnxjXq3INuc0T+Nu9MPNa+KoSsH/1TdHHcVKvB\n wJkPPsitHn9ybdZYnFkOkoF+PYdYqpk=","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp1.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=HIsSvCsA"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v2 4/4] iavf: add\n VIRTCHNL_OP_ADD_VLAN to success completion handler","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Przemyslaw Patynowski ,\n Aaron Brown ,\n Przemek Kitszel ,\n Mitch Williams ,\n Eric Dumazet , \"David S. Miller\" ,\n Aleksandr Loktionov ,\n Andrew Lunn ,\n Tony Nguyen ,\n Jesse Brandeburg , jacob.e.keller@intel.com,\n Jakub Kicinski ,\n Jedrzej Jagielski ,\n Paolo Abeni ,\n Rafal Romanowski ,\n linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"The V1 ADD_VLAN opcode had no success handler; filters sent via V1\nstayed in ADDING state permanently. Add a fallthrough case so V1\nfilters also transition ADDING -> ACTIVE on PF confirmation.\n\nCritically, add an `if (v_retval) break` guard: the error switch in\niavf_virtchnl_completion() does NOT return after handling errors,\nit falls through to the success switch. Without this guard, a\nPF-rejected ADD would incorrectly mark ADDING filters as ACTIVE,\ncreating a driver/HW mismatch where the driver believes the filter\nis installed but the PF never accepted it.\n\nFor V2, this is harmless: iavf_vlan_add_reject() in the error\nblock already kfree'd all ADDING filters, so the success handler\nfinds nothing to transition.\n\nFixes: 968996c070ef (\"iavf: Fix VLAN_V2 addition/rejection\")\nSigned-off-by: Petr Oros \nReviewed-by: Aleksandr Loktionov \nTested-by: Rafal Romanowski \n---\n drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\nindex 93ca79c3e3b535..4f2defd2331b17 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n@@ -2876,9 +2876,13 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,\n \t\tspin_unlock_bh(&adapter->adv_rss_lock);\n \t\t}\n \t\tbreak;\n+\tcase VIRTCHNL_OP_ADD_VLAN:\n \tcase VIRTCHNL_OP_ADD_VLAN_V2: {\n \t\tstruct iavf_vlan_filter *f;\n \n+\t\tif (v_retval)\n+\t\t\tbreak;\n+\n \t\tspin_lock_bh(&adapter->mac_vlan_list_lock);\n \t\tlist_for_each_entry(f, &adapter->vlan_filter_list, list) {\n \t\t\tif (f->state == IAVF_VLAN_ADDING)\n","prefixes":["iwl-net","v2","4/4"]}