{"id":2224525,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224525/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/6540626e6ac177033834b1679fc0ab5601a4ed55.1776426683.git.poros@redhat.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<6540626e6ac177033834b1679fc0ab5601a4ed55.1776426683.git.poros@redhat.com>","list_archive_url":null,"date":"2026-04-17T14:29:42","name":"[iwl-net,v2,1/4] iavf: rename IAVF_VLAN_IS_NEW to IAVF_VLAN_ADDING","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fb76a3b09024df05f5ca6a370b1655790e117985","submitter":{"id":74657,"url":"http://patchwork.ozlabs.org/api/1.2/people/74657/?format=json","name":"Petr Oros","email":"poros@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/6540626e6ac177033834b1679fc0ab5601a4ed55.1776426683.git.poros@redhat.com/mbox/","series":[{"id":500351,"url":"http://patchwork.ozlabs.org/api/1.2/series/500351/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=500351","date":"2026-04-17T14:29:41","name":"iavf: fix VLAN filter state machine races","version":2,"mbox":"http://patchwork.ozlabs.org/series/500351/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224525/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224525/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Vpd0l8wj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxy2q2BT0z1yCv\n\tfor ; Sat, 18 Apr 2026 00:30:11 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 7277480A85;\n\tFri, 17 Apr 2026 14:30:09 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id C8YlqWBAgs4Y; Fri, 17 Apr 2026 14:30:08 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9EF6D80887;\n\tFri, 17 Apr 2026 14:30:08 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 6355E396\n for ; Fri, 17 Apr 2026 14:30:07 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 49843405D3\n for ; Fri, 17 Apr 2026 14:30:07 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bQniEDRXCt1a for ;\n Fri, 17 Apr 2026 14:30:06 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 3AB38405CC\n for ; Fri, 17 Apr 2026 14:30:05 +0000 (UTC)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-59-LEoEvaA2MJG6zhlnIHLu1g-1; Fri,\n 17 Apr 2026 10:29:59 -0400","from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 0BDF119560A2; Fri, 17 Apr 2026 14:29:57 +0000 (UTC)","from ShadowPeak.redhat.com (unknown [10.44.32.76])\n by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 76428180047F; Fri, 17 Apr 2026 14:29:52 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9EF6D80887","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3AB38405CC"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776436208;\n\tbh=9XufRVi0wGB5ho91Fnl2bIgfWqQRanSan8O19a66JEE=;\n\th=From:To:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t Cc:From;\n\tb=Vpd0l8wjcHKLrmjLBAD3abbDnyBurJD67jw5ui6eih1L6vgANfcAOGv1ym0Rz4cBz\n\t glo+FNgLPXlJeA5rbjV653u/pUqFplGzZaul7F0sqi3ih6CKyvAN57Tf1MQiyC2wZz\n\t 63UPlrzLI/tzaz369Cm8I+HUugFWieTJ2SW8krJOk2Jp45cnjtPABnKzFCi22xwZCk\n\t D9EhYE2b+RjuV8aO9Pc9KEXhFUZ60HwXfREJh5tq/UKMwJ6OIN7tJTJfCTfIN3fSL6\n\t o5eC0+bMj6bS2NIXYNhf6BQ3SCRKBWEL1v2M8iiEmoR/+HlRASnubjEnHum8XsThSy\n\t fEVcLndjkcKBw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=poros@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 3AB38405CC","X-MC-Unique":"LEoEvaA2MJG6zhlnIHLu1g-1","X-Mimecast-MFC-AGG-ID":"LEoEvaA2MJG6zhlnIHLu1g_1776436197","From":"Petr Oros ","To":"netdev@vger.kernel.org","Date":"Fri, 17 Apr 2026 16:29:42 +0200","Message-ID":"\n <6540626e6ac177033834b1679fc0ab5601a4ed55.1776426683.git.poros@redhat.com>","In-Reply-To":"","References":"","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.93","X-Mimecast-MFC-PROC-ID":"TiOwIcmyfK2emxO8jymREQqNYFwBb5CBPUi5a_qm7js_1776436197","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1776436205;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=9XufRVi0wGB5ho91Fnl2bIgfWqQRanSan8O19a66JEE=;\n b=R9qRTM1nsmPo0dxvZuZ+LTnlLXugXIoLBfQ1H7CAjYjdMnuajDJ48TvQWv3RHRltB8PE/9\n h4MUrnqgvjwwo0tTA8GdyJOj6/Ag5a9Y+uSsopNjbNk1R7K0EDPWVRHnX2S//8ED7niUga\n cU+LIsNyozx31T3AbSiRoIrsqNB8qdU=","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp2.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=R9qRTM1n"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v2 1/4] iavf: rename\n IAVF_VLAN_IS_NEW to IAVF_VLAN_ADDING","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Przemyslaw Patynowski ,\n Aaron Brown ,\n Przemek Kitszel ,\n Mitch Williams ,\n Eric Dumazet , \"David S. Miller\" ,\n Aleksandr Loktionov ,\n Andrew Lunn ,\n Tony Nguyen ,\n Jesse Brandeburg , jacob.e.keller@intel.com,\n Jakub Kicinski ,\n Jedrzej Jagielski ,\n Paolo Abeni ,\n Rafal Romanowski ,\n linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Rename the IAVF_VLAN_IS_NEW state to IAVF_VLAN_ADDING to better\ndescribe what the state represents: an ADD request has been sent to\nthe PF and is waiting for a response.\n\nThis is a pure rename with no behavioral change, preparing for a\ncleanup of the VLAN filter state machine.\n\nSigned-off-by: Petr Oros \nReviewed-by: Aleksandr Loktionov \nTested-by: Rafal Romanowski \n---\n drivers/net/ethernet/intel/iavf/iavf.h | 2 +-\n drivers/net/ethernet/intel/iavf/iavf_virtchnl.c | 8 ++++----\n 2 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/iavf/iavf.h b/drivers/net/ethernet/intel/iavf/iavf.h\nindex e9fb0a0919e376..47a862ca5e2c3f 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf.h\n+++ b/drivers/net/ethernet/intel/iavf/iavf.h\n@@ -158,7 +158,7 @@ struct iavf_vlan {\n enum iavf_vlan_state_t {\n \tIAVF_VLAN_INVALID,\n \tIAVF_VLAN_ADD,\t\t/* filter needs to be added */\n-\tIAVF_VLAN_IS_NEW,\t/* filter is new, wait for PF answer */\n+\tIAVF_VLAN_ADDING,\t/* ADD sent to PF, waiting for response */\n \tIAVF_VLAN_ACTIVE,\t/* filter is accepted by PF */\n \tIAVF_VLAN_DISABLE,\t/* filter needs to be deleted by PF, then marked INACTIVE */\n \tIAVF_VLAN_INACTIVE,\t/* filter is inactive, we are in IFF_DOWN */\ndiff --git a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\nindex a52c100dcbc56d..6b06ae872a0cdf 100644\n--- a/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/iavf/iavf_virtchnl.c\n@@ -746,7 +746,7 @@ static void iavf_vlan_add_reject(struct iavf_adapter *adapter)\n \n \tspin_lock_bh(&adapter->mac_vlan_list_lock);\n \tlist_for_each_entry_safe(f, ftmp, &adapter->vlan_filter_list, list) {\n-\t\tif (f->state == IAVF_VLAN_IS_NEW) {\n+\t\tif (f->state == IAVF_VLAN_ADDING) {\n \t\t\tlist_del(&f->list);\n \t\t\tkfree(f);\n \t\t\tadapter->num_vlan_filters--;\n@@ -812,7 +812,7 @@ void iavf_add_vlans(struct iavf_adapter *adapter)\n \t\t\tif (f->state == IAVF_VLAN_ADD) {\n \t\t\t\tvvfl->vlan_id[i] = f->vlan.vid;\n \t\t\t\ti++;\n-\t\t\t\tf->state = IAVF_VLAN_IS_NEW;\n+\t\t\t\tf->state = IAVF_VLAN_ADDING;\n \t\t\t\tif (i == count)\n \t\t\t\t\tbreak;\n \t\t\t}\n@@ -874,7 +874,7 @@ void iavf_add_vlans(struct iavf_adapter *adapter)\n \t\t\t\tvlan->tpid = f->vlan.tpid;\n \n \t\t\t\ti++;\n-\t\t\t\tf->state = IAVF_VLAN_IS_NEW;\n+\t\t\t\tf->state = IAVF_VLAN_ADDING;\n \t\t\t}\n \t\t}\n \n@@ -2910,7 +2910,7 @@ void iavf_virtchnl_completion(struct iavf_adapter *adapter,\n \n \t\tspin_lock_bh(&adapter->mac_vlan_list_lock);\n \t\tlist_for_each_entry(f, &adapter->vlan_filter_list, list) {\n-\t\t\tif (f->state == IAVF_VLAN_IS_NEW)\n+\t\t\tif (f->state == IAVF_VLAN_ADDING)\n \t\t\t\tf->state = IAVF_VLAN_ACTIVE;\n \t\t}\n \t\tspin_unlock_bh(&adapter->mac_vlan_list_lock);\n","prefixes":["iwl-net","v2","1/4"]}