{"id":2224399,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224399/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-27-magnuskulke@linux.microsoft.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417105618.3621-27-magnuskulke@linux.microsoft.com>","list_archive_url":null,"date":"2026-04-17T10:56:10","name":"[26/34] accel/mshv: introduce SaveVMHandler","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3e614aedfe03cae528fa08107f2cb917692cdff5","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/1.2/people/90753/?format=json","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-27-magnuskulke@linux.microsoft.com/mbox/","series":[{"id":500310,"url":"http://patchwork.ozlabs.org/api/1.2/series/500310/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500310","date":"2026-04-17T10:55:44","name":"Add migration support to the MSHV accelerator","version":1,"mbox":"http://patchwork.ozlabs.org/series/500310/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224399/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224399/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=ICTUaaaS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxsM93Qtcz1yD3\n\tfor ; Fri, 17 Apr 2026 20:59:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDgtu-0003v6-Vw; Fri, 17 Apr 2026 06:58:19 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDgtp-0003WM-4H\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:58:13 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wDgtn-0001rs-GS\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:58:12 -0400","from DESKTOP-TUU1E5L.fritz.box (p5086d620.dip0.t-ipconnect.de\n [80.134.214.32])\n by linux.microsoft.com (Postfix) with ESMTPSA id 8F9D120B7001;\n Fri, 17 Apr 2026 03:57:57 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 8F9D120B7001","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1776423480;\n bh=Xw/caTrzhER4UZh+Hl5RTibaD3S7XoFJ/++MpcgizJQ=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=ICTUaaaSyGCPk0ZEfXl99cReLGE4GDPBP1BeA9SKYA/f3ocStA5vqjEvLVVi+ZwqF\n Pss/ONFs/3Ge+KrNdBZu1fJj3QmRWpdJFeXqC2vesGGcaaHDpa3aljSY35PK/cLqKs\n 5GiNol8HCRn65C0xx2qoC1iIEMQhAepx/rhI+ly8=","From":"Magnus Kulke ","To":"qemu-devel@nongnu.org","Cc":"kvm@vger.kernel.org, Magnus Kulke ,\n Wei Liu , \"Michael S. Tsirkin\" ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Zhao Liu ,\n Richard Henderson ,\n Paolo Bonzini , Wei Liu ,\n Magnus Kulke ,\n Alex Williamson ,\n Marcel Apfelbaum , =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?q?aud=C3=A9?= ,\n Marcelo Tosatti ","Subject":"[PATCH 26/34] accel/mshv: introduce SaveVMHandler","Date":"Fri, 17 Apr 2026 12:56:10 +0200","Message-Id":"<20260417105618.3621-27-magnuskulke@linux.microsoft.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","References":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-42","X-Spam_score":"-4.3","X-Spam_bar":"----","X-Spam_report":"(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This mechanism is used to handle more imperative partition-wide steps\nthat have to be taken as part of a migration routine.\n\nCurrently it's a skeleton that will just pause/resume the partition as\npart of a migration. It will later be extended with more specific steps\nlike reference time and hypercall pages.\n\nSigned-off-by: Magnus Kulke \n---\n accel/mshv/mshv-all.c | 75 +++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 75 insertions(+)","diff":"diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\nindex 4c1a42d002..5f81881c05 100644\n--- a/accel/mshv/mshv-all.c\n+++ b/accel/mshv/mshv-all.c\n@@ -39,6 +39,8 @@\n #include \"system/mshv.h\"\n #include \"system/mshv_int.h\"\n #include \"system/reset.h\"\n+#include \"migration/qemu-file-types.h\"\n+#include \"migration/register.h\"\n #include \"trace.h\"\n #include \n #include \n@@ -47,6 +49,9 @@ bool mshv_allowed;\n \n MshvState *mshv_state;\n \n+static int pause_vm(int vm_fd);\n+static int resume_vm(int vm_fd);\n+\n static int init_mshv(int *mshv_fd)\n {\n int fd = open(\"/dev/mshv\", O_RDWR | O_CLOEXEC);\n@@ -80,6 +85,64 @@ static int set_time_freeze(int vm_fd, int freeze)\n return 0;\n }\n \n+static void mshv_save_state(QEMUFile *f, void *opaque)\n+{\n+ return;\n+}\n+\n+static int mshv_load_state(QEMUFile *f, void *opaque, int version_id)\n+{\n+ return 0;\n+}\n+\n+static int mshv_save_prepare(void *opaque, Error **errp)\n+{\n+ MshvState *s = opaque;\n+ int ret;\n+\n+ ret = pause_vm(s->vm);\n+ if (ret < 0) {\n+ error_setg(errp, \"Failed to pause VM for migration\");\n+ return -1;\n+ }\n+\n+ return 0;\n+}\n+\n+static void mshv_save_cleanup(void *opaque)\n+{\n+ MshvState *s = opaque;\n+ int ret;\n+\n+ ret = resume_vm(s->vm);\n+ if (ret < 0) {\n+ error_report(\"Failed to resme VM after migration\");\n+ }\n+}\n+\n+static int mshv_load_setup(QEMUFile *f, void *opaque, Error **errp)\n+{\n+ MshvState *s = opaque;\n+ int ret;\n+\n+ ret = pause_vm(s->vm);\n+ if (ret < 0) {\n+ error_setg(errp, \"Failed to pause VM for migration restore\");\n+ return -1;\n+ }\n+\n+ return 0;\n+}\n+\n+static int mshv_load_cleanup(void *opaque)\n+{\n+ MshvState *s = opaque;\n+\n+ resume_vm(s->vm);\n+\n+ return 0;\n+}\n+\n static int pause_vm(int vm_fd)\n {\n int ret;\n@@ -454,6 +517,15 @@ static int mshv_init_vcpu(CPUState *cpu)\n return 0;\n }\n \n+static SaveVMHandlers savevm_mshv = {\n+ .save_prepare = mshv_save_prepare,\n+ .save_state = mshv_save_state,\n+ .save_cleanup = mshv_save_cleanup,\n+ .load_setup = mshv_load_setup,\n+ .load_state = mshv_load_state,\n+ .load_cleanup = mshv_load_cleanup,\n+};\n+\n static int mshv_init(AccelState *as, MachineState *ms)\n {\n MshvState *s;\n@@ -509,6 +581,9 @@ static int mshv_init(AccelState *as, MachineState *ms)\n 0, \"mshv-memory\");\n memory_listener_register(&mshv_io_listener, &address_space_io);\n \n+ /* register custom handlers for migration events */\n+ register_savevm_live(\"mshv\", 0, 1, &savevm_mshv, s);\n+\n return 0;\n }\n \n","prefixes":["26/34"]}