{"id":2224378,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224378/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-12-magnuskulke@linux.microsoft.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417105618.3621-12-magnuskulke@linux.microsoft.com>","list_archive_url":null,"date":"2026-04-17T10:55:55","name":"[11/34] accel/mshv: use s->irq_routes in commit_routes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"715f07b1190b65ccc7e01abb18f964b0626f69a5","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/1.2/people/90753/?format=json","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417105618.3621-12-magnuskulke@linux.microsoft.com/mbox/","series":[{"id":500310,"url":"http://patchwork.ozlabs.org/api/1.2/series/500310/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500310","date":"2026-04-17T10:55:44","name":"Add migration support to the MSHV accelerator","version":1,"mbox":"http://patchwork.ozlabs.org/series/500310/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224378/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224378/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=YXOysCp9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxsKC3xNyz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 20:57:19 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wDgsm-0000cb-Up; Fri, 17 Apr 2026 06:57:09 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <magnuskulke@linux.microsoft.com>)\n id 1wDgsl-0000Vq-Go\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:57:07 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from <magnuskulke@linux.microsoft.com>) id 1wDgsj-0001ZL-SD\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 06:57:07 -0400","from DESKTOP-TUU1E5L.fritz.box (p5086d620.dip0.t-ipconnect.de\n [80.134.214.32])\n by linux.microsoft.com (Postfix) with ESMTPSA id 50B1120B7129;\n Fri, 17 Apr 2026 03:57:02 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 50B1120B7129","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1776423425;\n bh=+449kqpsT3rs/26cTO+xTXYI56NYmCzZVttigepvBaE=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=YXOysCp9b2cic8VB8v4Yk2Kt0mt2YtL+E/6nLHunSHSEYj3cA2B+xd7+PBnJWsjr4\n 8pn5T9CE2Ju4HSP9UOqxrnVeqrMMCx10cy6bMw+0wikb1tEyueQiN/kATzK3WEakLr\n 56S076zZmobUTKRnZgHFINObZhFLjI2BfpPW+1HE=","From":"Magnus Kulke <magnuskulke@linux.microsoft.com>","To":"qemu-devel@nongnu.org","Cc":"kvm@vger.kernel.org, Magnus Kulke <magnuskulke@microsoft.com>,\n Wei Liu <liuwe@microsoft.com>, \"Michael S. Tsirkin\" <mst@redhat.com>,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= <clg@redhat.com>,\n Zhao Liu <zhao1.liu@intel.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Wei Liu <wei.liu@kernel.org>,\n Magnus Kulke <magnuskulke@linux.microsoft.com>,\n Alex Williamson <alex@shazbot.org>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, =?utf-8?q?Philippe_Mathieu-D?=\n\t=?utf-8?q?aud=C3=A9?= <philmd@linaro.org>,\n Marcelo Tosatti <mtosatti@redhat.com>","Subject":"[PATCH 11/34] accel/mshv: use s->irq_routes in commit_routes","Date":"Fri, 17 Apr 2026 12:55:55 +0200","Message-Id":"<20260417105618.3621-12-magnuskulke@linux.microsoft.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","References":"<20260417105618.3621-1-magnuskulke@linux.microsoft.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-42","X-Spam_score":"-4.3","X-Spam_bar":"----","X-Spam_report":"(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In mshv_irqchip_commit_routes() the entries that have been accumulated\nin s->irq_routes are committed directly to MSHV's irqchip.\n\nThe old commit_msi_routing_table() fn will be removed in a subsquent commit.\n\nSigned-off-by: Magnus Kulke <magnuskulke@linux.microsoft.com>\n---\n accel/accel-irq.c       | 2 +-\n accel/mshv/irq.c        | 7 ++++---\n accel/stubs/mshv-stub.c | 2 +-\n include/system/mshv.h   | 2 +-\n 4 files changed, 7 insertions(+), 6 deletions(-)","diff":"diff --git a/accel/accel-irq.c b/accel/accel-irq.c\nindex 0cb3ef78d3..4303e10e40 100644\n--- a/accel/accel-irq.c\n+++ b/accel/accel-irq.c\n@@ -55,7 +55,7 @@ void accel_irqchip_commit_routes(void)\n {\n #ifdef CONFIG_MSHV_IS_POSSIBLE\n     if (mshv_msi_via_irqfd_enabled()) {\n-        mshv_irqchip_commit_routes();\n+        mshv_irqchip_commit_routes(mshv_state);\n     }\n #endif\n     if (kvm_enabled()) {\ndiff --git a/accel/mshv/irq.c b/accel/mshv/irq.c\nindex 990ce34620..9ba837f0e2 100644\n--- a/accel/mshv/irq.c\n+++ b/accel/mshv/irq.c\n@@ -394,16 +394,17 @@ int mshv_request_interrupt(MshvState *mshv_state, uint32_t interrupt_type, uint3\n     return 0;\n }\n \n-void mshv_irqchip_commit_routes(void)\n+void mshv_irqchip_commit_routes(MshvState *s)\n {\n     int ret;\n-    int vm_fd = mshv_state->vm;\n+    int vm_fd = s->vm;\n \n-    ret = commit_msi_routing_table(vm_fd);\n+    ret = ioctl(vm_fd, MSHV_SET_MSI_ROUTING, s->irq_routes);\n     if (ret < 0) {\n         error_report(\"Failed to commit msi routing table\");\n         abort();\n     }\n+    trace_mshv_commit_msi_routing_table(vm_fd, s->irq_routes->nr);\n }\n \n int mshv_irqchip_add_irqfd_notifier_gsi(const EventNotifier *event,\ndiff --git a/accel/stubs/mshv-stub.c b/accel/stubs/mshv-stub.c\nindex dadf05511a..8b69539a85 100644\n--- a/accel/stubs/mshv-stub.c\n+++ b/accel/stubs/mshv-stub.c\n@@ -28,7 +28,7 @@ int mshv_irqchip_update_msi_route(int virq, MSIMessage msg, PCIDevice *dev)\n     return -ENOSYS;\n }\n \n-void mshv_irqchip_commit_routes(void)\n+void mshv_irqchip_commit_routes(MshvState *s)\n {\n }\n \ndiff --git a/include/system/mshv.h b/include/system/mshv.h\nindex 2033beed70..0c9a4f927c 100644\n--- a/include/system/mshv.h\n+++ b/include/system/mshv.h\n@@ -62,8 +62,8 @@ int mshv_request_interrupt(MshvState *mshv_state, uint32_t interrupt_type, uint3\n \n int mshv_irqchip_add_msi_route(AccelRouteChange *c, int vector, PCIDevice *dev);\n int mshv_irqchip_update_msi_route(int virq, MSIMessage msg, PCIDevice *dev);\n-void mshv_irqchip_commit_routes(void);\n void mshv_irqchip_release_virq(MshvState *s, int virq);\n+void mshv_irqchip_commit_routes(MshvState *s);\n int mshv_irqchip_add_irqfd_notifier_gsi(const EventNotifier *n,\n                                         const EventNotifier *rn, int virq);\n int mshv_irqchip_remove_irqfd_notifier_gsi(const EventNotifier *n, int virq);\n","prefixes":["11/34"]}