{"id":2224327,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224327/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417094443.785462-1-alex.bennee@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417094443.785462-1-alex.bennee@linaro.org>","list_archive_url":null,"date":"2026-04-17T09:44:43","name":"[RFC] hw/display: don't accidentally autofree existing virgl resources","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"91ee99560ab9680fefcf2ce2fe73dd3ec002abc6","submitter":{"id":39532,"url":"http://patchwork.ozlabs.org/api/1.2/people/39532/?format=json","name":"Alex Bennée","email":"alex.bennee@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417094443.785462-1-alex.bennee@linaro.org/mbox/","series":[{"id":500294,"url":"http://patchwork.ozlabs.org/api/1.2/series/500294/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500294","date":"2026-04-17T09:44:43","name":"[RFC] hw/display: don't accidentally autofree existing virgl resources","version":1,"mbox":"http://patchwork.ozlabs.org/series/500294/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224327/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224327/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=L9nwcpDm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqkp57DZz1yHp\n\tfor ; Fri, 17 Apr 2026 19:45:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDfkx-0006FE-Ez; Fri, 17 Apr 2026 05:44:59 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfkv-0006Ev-Ok\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:44:57 -0400","from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDfkt-0006Rv-PN\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:44:57 -0400","by mail-wm1-x32f.google.com with SMTP id\n 5b1f17b1804b1-4838c15e3cbso4203785e9.3\n for ; Fri, 17 Apr 2026 02:44:55 -0700 (PDT)","from draig.lan ([185.124.0.195]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43fe4e3a166sm3383545f8f.19.2026.04.17.02.44.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 02:44:52 -0700 (PDT)","from draig.lan (localhost [IPv6:::1])\n by draig.lan (Postfix) with ESMTP id 233F65F94F;\n Fri, 17 Apr 2026 10:44:52 +0100 (BST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776419093; x=1777023893; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=95kL8o9wIOGj8/U74zkb4wUZKKITt6J6HXnMFnuJ9VU=;\n b=L9nwcpDmUEkHHcuNpMAtogYak/+h/p2lq7ApU/TXmVT5ktzzoKNq2ZVSFGCOV/B1Bw\n CrdQWxnzr/SXQwIfQfwy18i6O8404ufMoftXuFcTeEYsMl6gMCx6A4PZW//CK0gC93aM\n D8aKk/DIYvpqMfmMjZFk1veayGj2u8pSvqreBM0IUsiolJcFhc1phlRgBHzn6rgL7zdl\n AKLfTItwbNM6ICbYDUVfxkCqZEUziO0SH/OBoOeEcwUp/j7ybea2w5rK8+Qkga7MPLPx\n +40pdtLYyOtJC7t0/08xdLM4a8+iql9ER8QwGgjfs4Z0GS1295M8U1IytGaga2YRrCwd\n dkAg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776419093; x=1777023893;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=95kL8o9wIOGj8/U74zkb4wUZKKITt6J6HXnMFnuJ9VU=;\n b=BYI87Lc/yaGhsjHf/gP7Am1/Cg3evGKakjN7QYsSAPINqnJyqFbVJtgcqoMQ0X3D/E\n 5kse61GRPNAz0DvWZz5itfIyCphIUXhixfG/jO0YSpbWFD9fiC3Grm1ecYc6hQWQhhhR\n 27qG+vipo1G7gTwMxwP3cgeTRLrF9TgvZK/6zopKh7gbwD2EnZoR/5PYFvdfdpLAXe9/\n i1tp4Bl4v69l2u2SRIK8p5ttb4Y+Z3NBB8Q6wrRcuyHxioqpZtwiAyCFC0glQ7ZXNUNB\n IEF47KJpZAcymCKVyo94A/k8gyZaAcsgQLU/bSJO3UhK/vYxIeXLPYV0ezyWRvCjF0ft\n MdTA==","X-Gm-Message-State":"AOJu0YzwlPLPMJOTcqr0MAu3V/Zw7eFgsnspyEEVOlz+SPeULD+TBdnY\n At/l+2eOdtNTRqrmAFw9bSNWxjHI5mqr3lXNcTMqQyl6IUXmVj4uvB/fxcdMJyHA7aY=","X-Gm-Gg":"AeBDieu3qM0sz8mAc4qQgtKH9puPse6ddeCZmPyNMTOZbj5pB4IhoWv8/OzT0CrDJ3F\n xmqqi5oPgs7GSXEbAei2txHuX9HLnuHSroOHERskM4gmimFD0FEtkNGM9Dx/Ey4Xw7UIOK2UycB\n dTjrxMjRXAXhO9jKVOYMt2rMmgLK7qm3TA8Zb7DZU+RL28sTPkjyqDLDXWWH1hij0az6FG8wjxp\n C0jeVxGj0aqU43t0vx6aED2aPsin4PPTBrJtdQxsN8ww25xGz//dHabMoPpg/w8ZjeUpojpgxn6\n bsx148pnoVzEL5fp30ZYu8kNJrO1613FS/jNUD6AppBLxoZMk41/i9/HRittQsTgWHuI8VkJk8+\n T1xKaTypCEg4AALabfeugXQqfDo4pvNyDrW1GeggmA31FrJwVr/OEeszwcONeoIBUQEyEnlSZB1\n mqUy3kKJyBrTmxohjIf73sf7e/qhj9T0iRUg==","X-Received":"by 2002:a05:600c:a00c:b0:488:c51f:e04e with SMTP id\n 5b1f17b1804b1-488fb765e65mr26192995e9.13.1776419093461;\n Fri, 17 Apr 2026 02:44:53 -0700 (PDT)","From":"=?utf-8?q?Alex_Benn=C3=A9e?= ","To":"qemu-devel@nongnu.org","Cc":"manos.pitsidianakis@linaro.org,\n =?utf-8?q?Alex_Benn=C3=A9e?= ,\n qemu-stable@nongnu.org, \"Michael S. Tsirkin\" ,\n Akihiko Odaki ,\n Dmitry Osipenko ","Subject":"[RFC PATCH] hw/display: don't accidentally autofree existing virgl\n resources","Date":"Fri, 17 Apr 2026 10:44:43 +0100","Message-ID":"<20260417094443.785462-1-alex.bennee@linaro.org>","X-Mailer":"git-send-email 2.47.3","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32f;\n envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32f.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"While sanity checking a create blob operation the use of the auto\nfreed res variable could lead to inadvertently freeing an existing\nblob.\n\nAvoid this by in-lining the virtio_gpu_virgl_find_resource() check as\nthe value is not needed anyway.\n\nWhile at it add a comment to the end and use g_steal_pointer to make\nit clearer the object lifetime exceeds the function bounds if we pass\nall the checks.\n\nFixes: 7c092f17cce (virtio-gpu: Handle resource blob commands)\nSigned-off-by: Alex Bennée \nCc: qemu-stable@nongnu.org\n---\n hw/display/virtio-gpu-virgl.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/display/virtio-gpu-virgl.c b/hw/display/virtio-gpu-virgl.c\nindex b7a2d160ddd..add85bd4e61 100644\n--- a/hw/display/virtio-gpu-virgl.c\n+++ b/hw/display/virtio-gpu-virgl.c\n@@ -830,8 +830,7 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g,\n return;\n }\n \n- res = virtio_gpu_virgl_find_resource(g, cblob.resource_id);\n- if (res) {\n+ if (virtio_gpu_virgl_find_resource(g, cblob.resource_id)) {\n qemu_log_mask(LOG_GUEST_ERROR, \"%s: resource already exists %d\\n\",\n __func__, cblob.resource_id);\n cmd->error = VIRTIO_GPU_RESP_ERR_INVALID_RESOURCE_ID;\n@@ -884,8 +883,9 @@ static void virgl_cmd_resource_create_blob(VirtIOGPU *g,\n \n res->base.dmabuf_fd = info.fd;\n \n+ /* Now live, cleaned up in virtio_gpu_virgl_resource_unref */\n QTAILQ_INSERT_HEAD(&g->reslist, &res->base, next);\n- res = NULL;\n+ g_steal_pointer(&res);\n }\n \n static void virgl_cmd_resource_map_blob(VirtIOGPU *g,\n","prefixes":["RFC"]}