{"id":2224323,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224323/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417093805.1076954-1-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417093805.1076954-1-peter.maydell@linaro.org>","list_archive_url":null,"date":"2026-04-17T09:38:05","name":"hw/arm, hw/ppc: Remove unnecessary audio.h includes from board code","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c74b10fe730090a9362d7b736f033e6f80c5103f","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.2/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417093805.1076954-1-peter.maydell@linaro.org/mbox/","series":[{"id":500291,"url":"http://patchwork.ozlabs.org/api/1.2/series/500291/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500291","date":"2026-04-17T09:38:05","name":"hw/arm, hw/ppc: Remove unnecessary audio.h includes from board code","version":1,"mbox":"http://patchwork.ozlabs.org/series/500291/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224323/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224323/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KG0BQ8j1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxqZW2JtNz1yDF\n\tfor ; Fri, 17 Apr 2026 19:38:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDfeQ-0005De-9o; Fri, 17 Apr 2026 05:38:14 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wDfeM-0005CV-Hk\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:38:10 -0400","from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wDfeK-00052h-QZ\n for qemu-devel@nongnu.org; Fri, 17 Apr 2026 05:38:10 -0400","by mail-wm1-x32b.google.com with SMTP id\n 5b1f17b1804b1-488c2690057so4559235e9.0\n for ; Fri, 17 Apr 2026 02:38:07 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc18bccfsm28611615e9.8.2026.04.17.02.38.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 17 Apr 2026 02:38:05 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776418686; x=1777023486; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=A141vI3/UoGYhzPPu08TWpps2ytxzNsFg5NMoVqZZ9k=;\n b=KG0BQ8j1cwyGCHJ64ButfNJGuXYseEk5gWAaX7KVyJ4cKZaUNEt87DQJQIotzvpAEs\n cSWzC/HEw9TP6KMt7Ph0hdGFTcF0B+hB0rVNEV8WH4yH5IrZurMz2iwIjqE7GmwdIT6V\n UH+ks4gHBMvCu80w4Jg2bKkM40s/maVbWBRUqWoe/f757NtW1YowlezsCxRRz9XWoela\n tZdUVAAThU2n4AQGxCZ7klHjN9e09/cq+GUs2oudfEoma3+83rdMeM0cLVbfOlfp04fE\n 32Tbrb7DGxt1/yT9z6BYy9BSXjUBhmLsLZBLn3sC+/Jfpo6tZWrRoI8IC+eYUIW+qgPR\n htbg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776418686; x=1777023486;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=A141vI3/UoGYhzPPu08TWpps2ytxzNsFg5NMoVqZZ9k=;\n b=IOrvq+vDGhmos9S2ARLUPWPws8vpaLupG+C+HsnIG3PyBvcddmh6AQ2XQNDSpqujQU\n 68XYPg8j6ALRUYmP7Zru954TXv5L90O33t14LvwOq6IrVPZFQdZft1HxAj192S3JZwjf\n HvuY+14CvA84mfBsrLojuND2sqAnUvZsJeeLci+1fd3zWTeY28oPIZJV7Zy2gk35FQAB\n QhUBRnNVnhe0vYD7ga1FRAS149VZgraxRZXcauuZ/GWvpJtNr8kbLqo52VjigOyPwPg/\n WqHBCcDAbvTajzFAPi03tkrqvDo3PinZHXYbEaUVgb6JUQ7wqOPazx5u61D5gm1tmamB\n RQdA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ85VRZYmhW8ilYTtlTcMPiVPzLa0HMWSLtc8iFX//FegaSNTjNRsKaMcpPfc/taY7LfGzpnwxL+xJkV@nongnu.org","X-Gm-Message-State":"AOJu0Yz/DOV6bVTDfmjjCf2hJkKTaEfpyZGjraYxryfhaPgDb1OkyjR4\n oXU4p/JUv7gvTrn83gejF7qEmQI38lRe46qbJSc2C1z+4O1cmXwGjmmZW6V2LxI04gU=","X-Gm-Gg":"AeBDiev3oXj+c/c19RGBsLrbGvjM1l/etdwNKrHx2NvjeHzQsOoSkVEVbBo1c43aAqd\n Zize4oJ56IoZb14fLiKKNTBqcc6cjXpTSRPKo9SV/qgreSrk2hq+XBOv19UhI1gWGleFab7eHbQ\n jRzca2d0ckFFt0aifnmxhSnabjq+ZMVhMmt5u2BRqQbV0AMR1N0PBGKxmSmqQWpyg05u6GpG7y2\n UXmxKVeF4WwgUIaBqNbCPDxghxs+bHme8nXXDV9BB+wKB2dl2rkfZUN/riWwEj+YZZgKMmIjrSK\n 1xPg6t3crMpuHXfso6L0rso69vuPuGKQ5oEo3De+Zaoc+w1+j+BT2TTAUyEl29TEXKA3n/eVsOt\n Ne03SsvZLIlmgmeJlNpEvX/cIe2xL/gQJ9vNqr1pso4C4nhYbHQ6hGFbxl6B5ZFQIUaBWOc6DeD\n WrFUWs0pRjQjaCluPmUBYV9NROZFOCY4X/+Tp9Q1nepBzZTY6ElGNzGvwDFQCV5mIEDCMb2B2E3\n XDv6jcRZQ5Ufr7+yKF9eTHKEBQj7K4Hrnlr+nXVCQ==","X-Received":"by 2002:a05:600c:48a3:b0:488:caed:5ccf with SMTP id\n 5b1f17b1804b1-488fb8d1865mr14133525e9.16.1776418686529;\n Fri, 17 Apr 2026 02:38:06 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","Cc":"qemu-ppc@nongnu.org,\n =?utf-8?q?Herv=C3=A9_Poussineau?= ","Subject":"[PATCH] hw/arm,\n hw/ppc: Remove unnecessary audio.h includes from board code","Date":"Fri, 17 Apr 2026 10:38:05 +0100","Message-ID":"<20260417093805.1076954-1-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32b;\n envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32b.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Some boards (mostly arm, but also ppc/prep) include audio.h, but they\ndon't need anything from it. Drop the unnecessary include lines.\n\nThese seem to have been introduced with commits 2b16397264a8e,\nb8ab0303de, which added the machine-default audiodev handling, but as\nfar as I can tell they were unecessary right from the start, as the\nmachine_add_audiodev_property() function has always been in boards.h.\n\nSigned-off-by: Peter Maydell \n---\n hw/arm/integratorcp.c | 1 -\n hw/arm/musicpal.c | 1 -\n hw/arm/realview.c | 1 -\n hw/arm/versatilepb.c | 1 -\n hw/arm/vexpress.c | 1 -\n hw/arm/xlnx-zcu102.c | 1 -\n hw/ppc/prep.c | 1 -\n 7 files changed, 7 deletions(-)","diff":"diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c\nindex 0bf519b6bb..03633f3d4f 100644\n--- a/hw/arm/integratorcp.c\n+++ b/hw/arm/integratorcp.c\n@@ -27,7 +27,6 @@\n #include \"hw/core/irq.h\"\n #include \"hw/sd/sd.h\"\n #include \"qom/object.h\"\n-#include \"qemu/audio.h\"\n #include \"target/arm/cpu-qom.h\"\n \n #define TYPE_INTEGRATOR_CM \"integrator_core\"\ndiff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c\nindex 250fdb49b6..441a11100a 100644\n--- a/hw/arm/musicpal.c\n+++ b/hw/arm/musicpal.c\n@@ -37,7 +37,6 @@\n #include \"qemu/cutils.h\"\n #include \"qom/object.h\"\n #include \"hw/net/mv88w8618_eth.h\"\n-#include \"qemu/audio.h\"\n #include \"qemu/error-report.h\"\n #include \"target/arm/cpu-qom.h\"\n \ndiff --git a/hw/arm/realview.c b/hw/arm/realview.c\nindex c9558be4d4..e9c19e7e6e 100644\n--- a/hw/arm/realview.c\n+++ b/hw/arm/realview.c\n@@ -30,7 +30,6 @@\n #include \"hw/core/irq.h\"\n #include \"hw/i2c/arm_sbcon_i2c.h\"\n #include \"hw/sd/sd.h\"\n-#include \"qemu/audio.h\"\n #include \"target/arm/cpu-qom.h\"\n \n #define SMP_BOOT_ADDR 0xe0000000\ndiff --git a/hw/arm/versatilepb.c b/hw/arm/versatilepb.c\nindex 254b1610b3..c6991a52e6 100644\n--- a/hw/arm/versatilepb.c\n+++ b/hw/arm/versatilepb.c\n@@ -26,7 +26,6 @@\n #include \"hw/char/pl011.h\"\n #include \"hw/sd/sd.h\"\n #include \"qom/object.h\"\n-#include \"qemu/audio.h\"\n #include \"target/arm/cpu-qom.h\"\n #include \"qemu/log.h\"\n \ndiff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c\nindex cc6ae7d4c4..b178798085 100644\n--- a/hw/arm/vexpress.c\n+++ b/hw/arm/vexpress.c\n@@ -45,7 +45,6 @@\n #include \"hw/sd/sd.h\"\n #include \"qobject/qlist.h\"\n #include \"qom/object.h\"\n-#include \"qemu/audio.h\"\n #include \"target/arm/cpu-qom.h\"\n \n #define VEXPRESS_BOARD_ID 0x8e0\ndiff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c\nindex 3ba2736bab..4e48970274 100644\n--- a/hw/arm/xlnx-zcu102.c\n+++ b/hw/arm/xlnx-zcu102.c\n@@ -26,7 +26,6 @@\n #include \"system/device_tree.h\"\n #include \"qom/object.h\"\n #include \"net/can_emu.h\"\n-#include \"qemu/audio.h\"\n \n struct XlnxZCU102 {\n MachineState parent_obj;\ndiff --git a/hw/ppc/prep.c b/hw/ppc/prep.c\nindex e973b34099..2672eb9e7a 100644\n--- a/hw/ppc/prep.c\n+++ b/hw/ppc/prep.c\n@@ -46,7 +46,6 @@\n #include \"trace.h\"\n #include \"elf.h\"\n #include \"qemu/units.h\"\n-#include \"qemu/audio.h\"\n \n /* SMP is not enabled, for now */\n #define MAX_CPUS 1\n","prefixes":[]}