{"id":2224287,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224287/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260417084758.329107-1-pvorel@suse.cz/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.2/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417084758.329107-1-pvorel@suse.cz>","list_archive_url":null,"date":"2026-04-17T08:47:57","name":"[1/2] safe_stdio: More checks for invalid function return values","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"072e5dbe20f45e1d098ca866558f680a374220e9","submitter":{"id":70792,"url":"http://patchwork.ozlabs.org/api/1.2/people/70792/?format=json","name":"Petr Vorel","email":"pvorel@suse.cz"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260417084758.329107-1-pvorel@suse.cz/mbox/","series":[{"id":500278,"url":"http://patchwork.ozlabs.org/api/1.2/series/500278/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=500278","date":"2026-04-17T08:47:58","name":"[1/2] safe_stdio: More checks for invalid function return values","version":1,"mbox":"http://patchwork.ozlabs.org/series/500278/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224287/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2224287/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256\n header.s=susede2_rsa header.b=JR8RUzeJ;\n\tdkim=fail reason=\"signature verification failed\" header.d=suse.cz\n header.i=@suse.cz header.a=ed25519-sha256 header.s=susede2_ed25519\n header.b=3Oy36+if;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=suse.cz header.i=@suse.cz header.a=rsa-sha256 header.s=susede2_rsa\n header.b=uBd2u3YB;\n\tdkim=neutral header.d=suse.cz header.i=@suse.cz header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=wgyM7g4x;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=2001:1418:10:5::2; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)","smtp-out2.suse.de;\n\tnone"],"Received":["from picard.linux.it (picard.linux.it [IPv6:2001:1418:10:5::2])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxpSp71MQz1yD3\n\tfor ; Fri, 17 Apr 2026 18:48:42 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 3FB813E4AC7\n\tfor ; Fri, 17 Apr 2026 10:48:40 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id B6D4D3E2627\n for ; Fri, 17 Apr 2026 10:48:12 +0200 (CEST)","from smtp-out2.suse.de (smtp-out2.suse.de\n [IPv6:2a07:de40:b251:101:10:150:64:2])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 73C2B1400DBA\n for ; Fri, 17 Apr 2026 10:48:11 +0200 (CEST)","from imap1.dmz-prg2.suse.org (unknown [10.150.64.97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out2.suse.de (Postfix) with ESMTPS id E4B205BCD3;\n Fri, 17 Apr 2026 08:48:05 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CBDE0593AE;\n Fri, 17 Apr 2026 08:48:05 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id RpZqMMXz4WmUUAAAD6G6ig\n (envelope-from ); Fri, 17 Apr 2026 08:48:05 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776415690;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=CXuNUOiWgbIq3WSPfbYW6MmjGMl/42G2eZa53fGS5/4=;\n b=JR8RUzeJZ5BE0x2ePNZpg5iMyZfOjKsgWItaVmdYZwDVv6pYawCEvNkdz21eJ9qJYrxEf7\n QcJ3tYb4RouzkEQmpIvw53gDTgpuGrcuDtVj7BsFJqPmAi1T6PQFzgIw0jldi7dA9kHy76\n 5Pj0FlwjlCmM54GFWokEpVJ3ohJlnU0=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776415690;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=CXuNUOiWgbIq3WSPfbYW6MmjGMl/42G2eZa53fGS5/4=;\n b=3Oy36+ifJ8wUxBYnDH1q5aDV+ve9mHhsK2dJot9o41VcHk68AyFqRHW6IGogR3+T4m5oOA\n LPrZfirLrVuZWcCQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_rsa;\n t=1776415685;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=CXuNUOiWgbIq3WSPfbYW6MmjGMl/42G2eZa53fGS5/4=;\n b=uBd2u3YBYoWi98O4fVf1VodrRjCGnzkAMo/4NnVEbru48ABFku60RfQSxAGutLE6pHudln\n Ei82DALABNQtAoxe7YSMUZ/MZXeFHlPI5NmGor0GEiAhP+4wm8hab/YmoUzP+6HVdaCAl9\n udmD35VHPPAdZkLRbZXaHyktzuI+bn4=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;\n s=susede2_ed25519; t=1776415685;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=CXuNUOiWgbIq3WSPfbYW6MmjGMl/42G2eZa53fGS5/4=;\n b=wgyM7g4x8igjBI3owy40fyvmxvTztKoyYZNu/+b3rXcKksiC3Ww1YrWZ50sq1CBeTpBzp7\n DFhBubkYMPsba/DA=="],"From":"Petr Vorel ","To":"ltp@lists.linux.it","Date":"Fri, 17 Apr 2026 10:47:57 +0200","Message-ID":"<20260417084758.329107-1-pvorel@suse.cz>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Spam-Score":"-2.80","X-Spam-Level":"","X-Spamd-Result":"default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%];\n MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000];\n MIME_GOOD(-0.10)[text/plain];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+];\n RCPT_COUNT_TWO(0.00)[2];\n DKIM_SIGNED(0.00)[suse.cz:s=susede2_rsa,suse.cz:s=susede2_ed25519];\n TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[];\n RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_EQ_ENVFROM(0.00)[];\n RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS shortcircuit=no\n autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH 1/2] safe_stdio: More checks for invalid function\n return values","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"LTP library pedantically check invalid function return values, add\nmissing ones.\n\nFixes: 56221c5bb2 (\"lib: add safe macros for stream testing suite\")\nSigned-off-by: Petr Vorel \n---\n lib/safe_stdio.c | 30 +++++++++++++++++++++++-------\n 1 file changed, 23 insertions(+), 7 deletions(-)","diff":"diff --git a/lib/safe_stdio.c b/lib/safe_stdio.c\nindex feb8a4b5c8..ed5bca0072 100644\n--- a/lib/safe_stdio.c\n+++ b/lib/safe_stdio.c\n@@ -153,7 +153,11 @@ int safe_fseek(const char *file, const int lineno,\n \n \tif (ret == -1) {\n \t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL,\n-\t\t\t\"fseek(%p, %ld, %d)\", f, offset, whence);\n+\t\t\t\"fseek(%p, %ld, %d) failed\", f, offset, whence);\n+\t} else if (ret < 0) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL,\n+\t\t\t\"Invalid fseek(%p, %ld, %d) return value %d\",\n+\t\t\tf, offset, whence, ret);\n \t}\n \n \treturn ret;\n@@ -167,8 +171,12 @@ long safe_ftell(const char *file, const int lineno,\n \terrno = 0;\n \tret = ftell(f);\n \n-\tif (ret == -1)\n-\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL, \"ftell(%p)\", f);\n+\tif (ret == -1) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL, \"ftell(%p) failed\", f);\n+\t} else if (ret < 0) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL,\n+\t\t\t\t \"Invalid ftell(%p) return value %ld\", f, ret);\n+\t}\n \n \treturn ret;\n }\n@@ -181,8 +189,12 @@ int safe_fileno(const char *file, const int lineno,\n \terrno = 0;\n \tret = fileno(f);\n \n-\tif (ret == -1)\n-\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL, \"fileno(%p)\", f);\n+\tif (ret == -1) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL, \"fileno(%p) failed\", f);\n+\t} else if (ret < 0) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL,\n+\t\t\t\t \"Invalid fileno(%p) return value %d\", f, ret);\n+\t}\n \n \treturn ret;\n }\n@@ -195,8 +207,12 @@ int safe_fflush(const char *file, const int lineno,\n \terrno = 0;\n \tret = fflush(f);\n \n-\tif (ret == EOF)\n-\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL, \"fflush(%p)\", f);\n+\tif (ret == EOF) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL, \"fflush(%p) failed\", f);\n+\t} else if (!ret) {\n+\t\ttst_brkm_(file, lineno, TBROK | TERRNO, NULL,\n+\t\t\t\t \"Invalid fflush(%p) return value %d\", f, ret);\n+\t}\n \n \treturn ret;\n }\n","prefixes":["1/2"]}