{"id":2224273,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224273/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260417083050.499955-2-yan.wang@softathome.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417083050.499955-2-yan.wang@softathome.com>","list_archive_url":null,"date":"2026-04-17T08:30:48","name":"[v7,1/3] binman: Generate preload header and sign data only once","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"6ff4fb0d52e04fc31a295d55665ceb65db6ddb86","submitter":{"id":90652,"url":"http://patchwork.ozlabs.org/api/1.2/people/90652/?format=json","name":"Yan WANG","email":"yan.wang@softathome.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260417083050.499955-2-yan.wang@softathome.com/mbox/","series":[{"id":500273,"url":"http://patchwork.ozlabs.org/api/1.2/series/500273/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=500273","date":"2026-04-17T08:30:47","name":"binman: Fix preload signing with encrypted FIT","version":7,"mbox":"http://patchwork.ozlabs.org/series/500273/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224273/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224273/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.a=rsa-sha256 header.s=selector1-softathome1-onmicrosoft-com\n header.b=uCPuPenV;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=softathome1.onmicrosoft.com header.i=@softathome1.onmicrosoft.com\n header.b=\"uCPuPenV\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=none (p=none dis=none)\n header.from=softathome.com","phobos.denx.de;\n spf=pass smtp.mailfrom=yan.wang@softathome.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxp4y1byHz1yHp\n\tfor ; Fri, 17 Apr 2026 18:31:30 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 006BA8422D;\n\tFri, 17 Apr 2026 10:31:28 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 81BF18425F; Fri, 17 Apr 2026 10:31:21 +0200 (CEST)","from PR0P264CU014.outbound.protection.outlook.com\n (mail-francecentralazlp170120004.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c20a::4])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id D02938422D\n for ; Fri, 17 Apr 2026 10:31:17 +0200 (CEST)","from PR3P189CA0064.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:b4::9) by\n MR0P264MB5180.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:4c::19) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9818.25; Fri, 17 Apr 2026 08:31:15 +0000","from PA1PEPF000CC3FA.FRAP264.PROD.OUTLOOK.COM\n (2603:10a6:102:b4:cafe::5e) by PR3P189CA0064.outlook.office365.com\n (2603:10a6:102:b4::9) with Microsoft SMTP Server (version=TLS1_3,\n cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.52 via Frontend Transport; Fri,\n 17 Apr 2026 08:31:14 +0000","from proxy.softathome.com (149.6.166.170) by\n PA1PEPF000CC3FA.mail.protection.outlook.com (10.167.242.5) with Microsoft\n SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9769.17\n via Frontend Transport; Fri, 17 Apr 2026 08:31:14 +0000","from sah1lpt719.softathome.com (unknown [192.168.72.213])\n by proxy.softathome.com (Postfix) with ESMTPSA id B73C41FFF1;\n Fri, 17 Apr 2026 10:31:14 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=O8KBi7fzSVDGP1vWt9x7t1QqxHVqiat8OLV15b7QGcY49vBSnPB5pqGy8rxsEvqhO/LW30DUhMRHxhWFzjEg+nd0WOlnsXnPjm1ZZYMzWkBFk2ZpHznfWjseP5c/p0Og+tYR2YQlXN5lDvLHGJ42Q/6Yqf2WVoSbxfMNdcObnlYzY/KAfjSZgh6EOpMmfbcfSUpgdtmk08pzmKwFsLyAqMaLtDo/c5hGOxWw9fPNunLZ3ep9MHznA7WYlcbghGRp64kDDLEwgZb3mqAnApaY4CCOENUZnZR9OhCp6ofeb1BD652C3OCiW2Azc8uvKQJ+nttiOHFSqMId+epHrbZb6g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ewnfzE1vH2rbVZAgcn9LzvUxYs4oqoC/PjjS70o7wUA=;\n b=kabnpm1LsNOiQfGMweRng0f+xiODpVQYZxY2+hkfWNS+DgmXty2tveQL9Dq3LQnSUHKmSDXux5UIHf7S4A4k74cBmmem9tdHGPirgZ17EmC9YMp1j91CfKaKGTMmdwPWQyompIw7ervLrmND7zWry3Trw8aUpr38q2oEj3XS/JIFmYGgsbDUZQi6nLH76Ou3PTpP5BtFoJdyUk9J2JaHPkpL2AJvhZnmrEyfU6CqdcoVg4PcU83V003DthafshhY5J6xCamnbv+L+nTu7Zi/sN+ToP00FKdFgWarpGVBYkKm+5dGEiA6UxP9br6jnrhWhJOo4niTFriZfNA+UjxZnQ==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 149.6.166.170) smtp.rcpttodomain=chromium.org smtp.mailfrom=softathome.com;\n dmarc=bestguesspass action=none header.from=softathome.com; dkim=none\n (message not signed); arc=none (0)","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=softathome1.onmicrosoft.com; s=selector1-softathome1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=ewnfzE1vH2rbVZAgcn9LzvUxYs4oqoC/PjjS70o7wUA=;\n b=uCPuPenVcRVGyt9j0r6tT0hRsUMdi+eCPMO07l58XAfAk8MMskJW4SZZcEUlqyk+yvIfRxP5VNvXoMzRYZ+QDGubjr1FmyGrN1SYrOOu/DjYQmaeLC+EvvzEZ0glDlHwj0DCcMQTE54DrOg90Ium+i2kvl5Hw7bgJfHBv1c4i4Ihrj9CnBhY2NejQI9qU/wpcqoPtEeswsg7sZXlGMfV0MYDx2owoagspJt09uYJnIwxBxR+2TAIJQz/KSRynUj48E5e/2teWhn29goabTXfPeYgByYZhMyh76uIi/UpJFWXNQdQo6bGVe9BKZCJsSz22/WWbAeNTDlS31UChK9mxA==","X-MS-Exchange-Authentication-Results":"spf=pass (sender IP is 149.6.166.170)\n smtp.mailfrom=softathome.com; dkim=none (message not signed)\n header.d=none;dmarc=bestguesspass action=none header.from=softathome.com;","Received-SPF":"Pass (protection.outlook.com: domain of softathome.com\n designates 149.6.166.170 as permitted sender)\n receiver=protection.outlook.com; client-ip=149.6.166.170;\n helo=proxy.softathome.com; pr=C","From":"Yan WANG ","To":"trini@konsulko.com,\n\tsjg@chromium.org,\n\talpernebiyasak@gmail.com","Cc":"paul.henrys_ext@softathome.com,\n\tu-boot@lists.denx.de","Subject":"[PATCH v7 1/3] binman: Generate preload header and sign data only\n once","Date":"Fri, 17 Apr 2026 10:30:48 +0200","Message-Id":"<20260417083050.499955-2-yan.wang@softathome.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20260417083050.499955-1-yan.wang@softathome.com>","References":"<20260414131558.538656-3-yan.wang@softathome.com>\n <20260417083050.499955-1-yan.wang@softathome.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-EOPAttributedMessage":"0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"PA1PEPF000CC3FA:EE_|MR0P264MB5180:EE_","Content-Type":"text/plain","X-MS-Office365-Filtering-Correlation-Id":"1caee079-565c-400a-6124-08de9c5bb06b","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|36860700016|82310400026|1800799024|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n rEF4YW7iOpExCe1i4h/zZ3CY9hR/KbPaxgn12G2hfhgW6VOHkN4fMHbRMMNd2W+L6QukUbxXZNYd+A2ilQ383+Rxccn1EfPLounNRsG8aWWmDwF0Zpb+mE1g6UNiXSHTQDsX8fqYSpFn7SJ49k0J2xByj3cMRAH9i5gGki9x29Re+/moY65xM+IQUcyWeEkKKNx/BiFEDP2EbS4hlmLb62PX8s1mdwMykE/Qq2G5qHSpjo++PaRCn1hca+XU6P/F+DRWEtN25uhsz1fLHt36BN+y8W097qnhFGw2CHM6HJLg6pYB8VnD9LWsfvrXJlYinX8cZtr091FozR6L02aFyx0p16xTmkX0pIa5DrIPKn7d9nlxPjpASBJROSe2ujVqJBM14Hi+Z0mQT78+67SxBo4L5qfbxX1KYyQA8tHli5wBDPodcNg+jtv/e5HmgOIWU1ySroWO+FDbnXaw8sIidj2OXSOJqVmUW4HTY1ZnUtmWiflLncx5kmuwgC6jx/l0gj53eamK+CYEtryGxb6MAWBIU5+U2JNWexYmroWzi0o6/JjP/9QN24/+H4nSaCZpw0IEsZ6SzQXc5fXxlvNae42KigbjCmF3/7oqGrylY8+0gWDmHLfS7ktEzaOsayJDmy87PR92+RKD5QOQ8w3T1xMrM/m8bqrypl0pxsd8UcOqYIWBHVWpnzN5/UrrO6OEvSgiO5MVJp3dXCGaSdA1pMPGm46BkR4nqiklKrx7g37LZ1pRIS8i3C8hCcE/N3zEqDB2w1wPeeafBfrLOafsbw==","X-Forefront-Antispam-Report":"CIP:149.6.166.170; CTRY:FR; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:proxy.softathome.com; PTR:InfoDomainNonexistent;\n CAT:NONE;\n SFS:(13230040)(376014)(36860700016)(82310400026)(1800799024)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n V/7xZqjE3zxq+3vuPpu6TNuP7zeKQyChtw4da5X4Qs0j/0MucnjAnUeLu4wod+F66FawukKRpyQLpQIGm6X6jitMy4gOYiGnY9x71EAYyOIkzyFjWgHpPF/zJgdttvrP1iQb6KJU4iku4iWfLDfqqMaEY5Om/v2r48jhsveuh+VA5ZXctOZQf1S4JnncuZc8KmC0HolzCB30hd4nsS7vvZ62PKNx9mNZbNLEYXZd9Mf01ccpPpzcOCEytN5p+oGLi0I2VHo0Ty8HTK4Eur3Grk8mQrLGI72mScSzl3m+TUVCkBpwtd56PJYRFmwj3/pvCz322oeZVUM9whYGLUYtFXcGKHoyDHvAgUgPNH9Zo5et3jPPj7/FQVFjy28zAYmpOQc3ydP3OFR8IvX4/F2tx14JECgTUESrv3/WI//6bviEqlTfHLLsaW9qil4qDInz","X-OriginatorOrg":"softathome.com","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"17 Apr 2026 08:31:14.8507 (UTC)","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1caee079-565c-400a-6124-08de9c5bb06b","X-MS-Exchange-CrossTenant-Id":"aa10e044-e405-4c10-8353-36b4d0cce511","X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp":"\n TenantId=aa10e044-e405-4c10-8353-36b4d0cce511; Ip=[149.6.166.170];\n Helo=[proxy.softathome.com]","X-MS-Exchange-CrossTenant-AuthSource":"PA1PEPF000CC3FA.FRAP264.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Anonymous","X-MS-Exchange-CrossTenant-FromEntityHeader":"HybridOnPrem","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MR0P264MB5180","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Paul HENRYS \n\nTo optimize preload generation, generate the header and signatures only\nafter all data has been collected in ProcessContentsUpdate(). This\navoids signing the data multiple times.\n\nSince header_size is known upfront (from __init__), create a placeholder\nin `ObtainContents()` to avoid an extra packing pass when\nProcessContentsUpdate() detects a size change.\n\nThis reduces unnecessary repacking and signing operations.\n\nSigned-off-by: Paul HENRYS \n---\n\nChanges in v7:\n- No changes\n\n tools/binman/etype/pre_load.py | 9 +++------\n 1 file changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/tools/binman/etype/pre_load.py b/tools/binman/etype/pre_load.py\nindex 00f1a896767..0d953cb258e 100644\n--- a/tools/binman/etype/pre_load.py\n+++ b/tools/binman/etype/pre_load.py\n@@ -152,14 +152,11 @@ class Entry_pre_load(Entry_collection):\n return data + pad\n \n def ObtainContents(self):\n- \"\"\"Obtain a placeholder for the header contents\"\"\"\n- # wait that the image is available\n- self.image = self.GetContents(False)\n- if self.image is None:\n- return False\n- self.SetContents(self._CreateHeader())\n+ \"\"\"Create a placeholder for the header\"\"\"\n+ self.SetContents(tools.get_bytes(0, self.header_size))\n return True\n \n def ProcessContents(self):\n+ self.image = self.GetContents(True)\n data = self._CreateHeader()\n return self.ProcessContentsUpdate(data)\n","prefixes":["v7","1/3"]}