{"id":2224251,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224251/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260417073907.4985-1-pengpeng@iscas.ac.cn/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260417073907.4985-1-pengpeng@iscas.ac.cn>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260417073907.4985-1-pengpeng@iscas.ac.cn/","date":"2026-04-17T07:39:07","name":"powerpc/fadump: reject empty bootargs_append writes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94a857aba9ba81728da117f631b828f2f4f34161","submitter":{"id":93000,"url":"http://patchwork.ozlabs.org/api/1.2/people/93000/?format=json","name":"Pengpeng Hou","email":"pengpeng@iscas.ac.cn"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260417073907.4985-1-pengpeng@iscas.ac.cn/mbox/","series":[{"id":500254,"url":"http://patchwork.ozlabs.org/api/1.2/series/500254/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=500254","date":"2026-04-17T07:39:07","name":"powerpc/fadump: reject empty bootargs_append writes","version":1,"mbox":"http://patchwork.ozlabs.org/series/500254/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224251/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2224251/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19820-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=159.226.251.25","lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=iscas.ac.cn","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=iscas.ac.cn\n (client-ip=159.226.251.25; helo=cstnet.cn;\n envelope-from=pengpeng@iscas.ac.cn; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxmwt0DxLz1yDF\n\tfor ; Fri, 17 Apr 2026 17:39:24 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fxmwp4VNrz2yhP;\n\tFri, 17 Apr 2026 17:39:22 +1000 (AEST)","from cstnet.cn (smtp25.cstnet.cn [159.226.251.25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fxmwn3Q2bz2xpt\n\tfor ; Fri, 17 Apr 2026 17:39:19 +1000 (AEST)","from localhost.localdomain (unknown [111.196.245.116])\n\tby APP-05 (Coremail) with SMTP id zQCowADHVQmd4+Fptf7XDQ--.39774S2;\n\tFri, 17 Apr 2026 15:39:09 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776411562;\n\tcv=none;\n b=FcvXM895pcdyD+N60wL+/rhYBT60yhbwpYTnvcYZ+U42Al5B3wsB1SzHf8XlGddTE5zy1mcpPvUg2LhOYm5L6jxMZF1MFcDAVSGO+18EqSok3Dw8dhKCXgUeddZTk3IJwHjdJMYOe7ATd/66SrR7zt41IK0pbsOLRqhVEQG541oFQAYJOWf91Cl6Rf/P495nAj9EGdt1IaroUG68YYZQaVvABaoCOToBm+WqivhNDm5vQIy9Y6EZcf/iVc8hm6uVnlw6Z9e8EvskWqdzgVAOrLViiUwUYeGhxBvqw3kpI9RoyJAv++BWyq2L0U47ZzpoP7XOvNl4VY45L3dTgOB7QQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776411562; c=relaxed/relaxed;\n\tbh=j0/gV7yocmu0fgy6XiEhkYdc+nmzFc1Knwg28nisQ+U=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=eitwZIWQ0Z4l4MbJnjTMB1kumM+gOjXinZRNcKtvhXb7Te14QU4I/KQbUGAXZijpndjnywk2cV+pNyG5Oj5MkjkiMGITyHUE3SLMIgemDPoz/PWehBP2vE3i4qKesTmEGq5eizlZevDPefi0Ia/wjBA6ayG2PRM5tIgbKWEk8xmPfltVaQeOutx/TZAjeXs6HkuD11WKJ7a3jNBbm7DhhFcjjJJSaAc54Dqq1Tdkt0whL3kd4dB5mKdKRNXJXL8plaBM/WYdgIOt7W2TekDOxjJfyTXijaS3Fe2ljOFdC2jhCjoTnP/UXgqNCFpakCBzM6x+n9Sn3g67wUUV+R8H+A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=none (p=none dis=none) header.from=iscas.ac.cn;\n spf=pass (client-ip=159.226.251.25; helo=cstnet.cn;\n envelope-from=pengpeng@iscas.ac.cn;\n receiver=lists.ozlabs.org) smtp.mailfrom=iscas.ac.cn","From":"Pengpeng Hou ","To":"Madhavan Srinivasan ,\n\tMichael Ellerman ","Cc":"Nicholas Piggin ,\n\t\"Christophe Leroy (CS GROUP)\" ,\n\tSourabh Jain ,\n\tHari Bathini ,\n\tJiri Bohac ,\n\tShrikanth Hegde ,\n\tlinuxppc-dev@lists.ozlabs.org,\n\tlinux-kernel@vger.kernel.org,\n\tPengpeng Hou ,\n\tstable@vger.kernel.org","Subject":"[PATCH] powerpc/fadump: reject empty bootargs_append writes","Date":"Fri, 17 Apr 2026 15:39:07 +0800","Message-ID":"<20260417073907.4985-1-pengpeng@iscas.ac.cn>","X-Mailer":"git-send-email 2.50.1","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-CM-TRANSID":"zQCowADHVQmd4+Fptf7XDQ--.39774S2","X-Coremail-Antispam":"1UD129KBjvdXoW7Gry7GF4kCF15tFWrAFy7Wrg_yoWDuFX_Jw\n\tnrXFZ3Grs0qa12vFn0yFWYvr1xKanrWFy0kw12v3y3AF4DZa17Zw4fAFn5ArnrJFWkArZ8\n\tCFyIv3s7Z3W0gjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT\n\t9fnUUIcSsGvfJTRUUUba8FF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG\n\t6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w\n\tA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr1j\n\t6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x0267AKxVW0oV\n\tCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0\n\tI7IYx2IY67AKxVWUAVWUtwAv7VC2z280aVAFwI0_Gr0_Cr1lOx8S6xCaFVCjc4AY6r1j6r\n\t4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwACI402YVCY1x02628v\n\tn2kIc2xKxwCY1x0262kKe7AKxVWUtVW8ZwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7x\n\tkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E\n\t67AF67kF1VAFwI0_Jw0_GFylIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUCVW8Jw\n\tCI42IY6xIIjxv20xvEc7CjxVAFwI0_Cr0_Gr1UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWU\n\tCwCI42IY6I8E87Iv67AKxVW8JVWxJwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcS\n\tsGvfC2KfnxnUUI43ZEXa7VUbo5l5UUUUU==","X-Originating-IP":"[111.196.245.116]","X-CM-SenderInfo":"pshqw1xhqjqxpvfd2hldfou0/","X-Spam-Status":"No, score=-0.0 required=3.0 tests=RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_PASS,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"bootargs_append_store() indexes params[count - 1] when stripping a\ntrailing newline from the sysfs write buffer.\n\nkernfs passes zero-length writes through to the store callback, so an\nempty write makes that newline check read before the start of params.\n\nReject empty writes before looking at the last input byte.\n\nFixes: 683eab94da75 (\"powerpc/fadump: setup additional parameters for dump capture kernel\")\nCc: stable@vger.kernel.org\n\nSigned-off-by: Pengpeng Hou \n---\n arch/powerpc/kernel/fadump.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c\nindex 4ebc333dd786..03ab5565e420 100644\n--- a/arch/powerpc/kernel/fadump.c\n+++ b/arch/powerpc/kernel/fadump.c\n@@ -1479,6 +1479,9 @@ static ssize_t bootargs_append_store(struct kobject *kobj,\n \tif (!fw_dump.fadump_enabled || fw_dump.dump_active)\n \t\treturn -EPERM;\n \n+\tif (!count)\n+\t\treturn -EINVAL;\n+\n \tif (count >= COMMAND_LINE_SIZE)\n \t\treturn -EINVAL;\n \n","prefixes":[]}