{"id":2224218,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224218/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com>","list_archive_url":null,"date":"2026-04-17T04:16:25","name":"PCI: qcom: Set max OPP before DBI access during resume","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"29a99785e138e5c0cb98a02aec4d68f395a8b6b2","submitter":{"id":90999,"url":"http://patchwork.ozlabs.org/api/1.2/people/90999/?format=json","name":"Qiang Yu","email":"qiang.yu@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/mbox/","series":[{"id":500236,"url":"http://patchwork.ozlabs.org/api/1.2/series/500236/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=500236","date":"2026-04-17T04:16:25","name":"PCI: qcom: Set max OPP before DBI access during resume","version":1,"mbox":"http://patchwork.ozlabs.org/series/500236/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224218/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224218/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-pci+bounces-52682-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=NJzkkslN;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Mhp5ZKlP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52682-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=\"NJzkkslN\";\n\tdkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=\"Mhp5ZKlP\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=205.220.180.131","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxhWc5YRzz1yGt\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 14:20:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 2A2CE30D92EA\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 17 Apr 2026 04:16:33 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 9DD3130EF82;\n\tFri, 17 Apr 2026 04:16:31 +0000 (UTC)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ADAE1DF736\n\tfor <linux-pci@vger.kernel.org>; Fri, 17 Apr 2026 04:16:29 +0000 (UTC)","from pps.filterd (m0279868.ppops.net [127.0.0.1])\n\tby mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63H0fhmC1872640\n\tfor <linux-pci@vger.kernel.org>; Fri, 17 Apr 2026 04:16:29 GMT","from mail-dy1-f197.google.com (mail-dy1-f197.google.com\n [74.125.82.197])\n\tby mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dk2kna8qc-1\n\t(version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n\tfor <linux-pci@vger.kernel.org>; Fri, 17 Apr 2026 04:16:28 +0000 (GMT)","by mail-dy1-f197.google.com with SMTP id\n 5a478bee46e88-2dd6fb4c867so29385eec.0\n        for <linux-pci@vger.kernel.org>; Thu, 16 Apr 2026 21:16:28 -0700 (PDT)","from hu-qianyu-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20])\n        by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2e539fa5c38sm638451eec.5.2026.04.16.21.16.26\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Thu, 16 Apr 2026 21:16:26 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776399391; cv=none;\n b=Q+3VjKeRT+QZTjUCvcymEEiKyT9AhTg/TeJmVdbTtgfJb3ZDOePg8EgazPnbXSG+1sMgTGZpVkLdhpoVRl7OamUAoXIOvF5ZjdZFZUMVS08DBAkw2oEVbtfrfHX8/FhUQwy190RoIuNfQe6oOwMDA4crXPEhfZEUT4tdZdckgLE=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776399391; c=relaxed/simple;\n\tbh=wReg8hifVkzlEEdADzMhijrroaIK/MnJQ3ovMsYvmFo=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc;\n b=jr3MdWTQzN0g0K78Zh1OFovXT85eQ6qLyHXFe6rO0f8agyhvOuk1Wr2nx12rv1CBiHFZa+dwk3lOS+OBJ7yUfuedneh8vtfx99/Chib82bAj4jrL5yqAA4rOKbhHtO8ak5r1N9lgNVxegdV5wamIKBZ2/jT1jwamOhPyVB3e22s=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com;\n spf=pass smtp.mailfrom=oss.qualcomm.com;\n dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com\n header.b=NJzkkslN;\n dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.b=Mhp5ZKlP; arc=none smtp.client-ip=205.220.180.131","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n\tcc:content-transfer-encoding:content-type:date:from:message-id\n\t:mime-version:subject:to; s=qcppdkim1; bh=pPI4cCpBd7lg33U6go0Gl6\n\tviFTKES19pJQYgUxAXx5Y=; b=NJzkkslN2l0bWwmQGu7D/aGdTzidTHFhGQA69U\n\teBI1WqVLgBs5H7rGdCckHAAgyAYsngrlGw6f8q0H7Jw2kuFlLIEQuUBZfKU1pTkl\n\tYkyZqQVeumbs5ZceUTatK1OwtAxDqXB7MFuX7zBNwmC3wP8k3cFpI8h1k6BoFonF\n\tJYA7tMw2a0sjAuU3gEVYt8X0835LOwyscX4jE/SZj2+iVwbPzyOkpS0aMcOX9eM3\n\tt9Cp+bdguYNhxDCGjk5qofjWFEiQUGeIYH6JxHI9On3a6JI/o43ky4+M0oLVh4D7\n\tdf7Shlyyho1EJGfcjXg89L39y8p/+JW8gToufeIAXnIedNfg==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=oss.qualcomm.com; s=google; t=1776399388; x=1777004188;\n darn=vger.kernel.org;\n        h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n         :date:from:from:to:cc:subject:date:message-id:reply-to;\n        bh=pPI4cCpBd7lg33U6go0Gl6viFTKES19pJQYgUxAXx5Y=;\n        b=Mhp5ZKlPVlVqToHBr0fy6TUG3ZuKQv04INgY0LEottidgak31z2nobreF5wo9uapj+\n         KoalxziOfW+IHKEPOqXGJGZml09WT0iwQ1JX4cSxJUCAz5Q5KAE2YaBQqsrxMqOBtl1c\n         RL5q/NQXO5g+Xn6WmPU3VckfpbPcjUobkVqnrtU310YdNyuKM+9zEVk6rJIn0W48qasd\n         iSW+hHV7bhpewlF0UUtdBPk9iVBqGHHAR6Wc0XSWMeTdECd7vZCcu2TMTp3vWpdogX6Y\n         Quv34yDYveYHm8LARozdKA9ui8Zao5EKlgOkzBZzfCq0pNXlr7Dq/nTGx8zuTWoRLQk0\n         iUwg=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776399388; x=1777004188;\n        h=cc:to:message-id:content-transfer-encoding:mime-version:subject\n         :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=pPI4cCpBd7lg33U6go0Gl6viFTKES19pJQYgUxAXx5Y=;\n        b=Wk/uTshlQRoJ4G2leA7TxnWHIIzic9iC8K0G+rvm80pc5RY66INXJpLd7MLTuyrFBE\n         7TNDGg7lCYJmp1IdD4+f5hVGoaqBe9eODzan5wIQfUUDq3abBe6j/y+zTvi3rIkTvXJO\n         I7gO52IRsQrhcRRhxJEFiY/vMEvDyYu9046VFp/5LEHAr1DUNI16hkPuKf+2kxDJsMoM\n         716L+6FO6q+5DwKVBTTy0b+uGkxW5sx9TB24/IqjNLaYQy8aPUSMuKRbQv4pyrYEeR+x\n         ZzHFfw2xCOWGUtraBC/xPeqk3zSdvZU1IJEte2SltAsDpcwjPJbZfMvqkHX31z5+tIrU\n         PFgA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8NqmsNm1taup4BC6OQH4SgV7EA70YBotOSyHKauMdQ3d9J9sB9w8+RO7DPypmdyf6ki6mixlk+1+Y=@vger.kernel.org","X-Gm-Message-State":"AOJu0YyFw9DAFXTO7obUz8dwqN96LSyjKNVamhsv8Hg/miY+mKyC0+OQ\n\tWHTNSJ4myFXY0hQJfKKB2mtilLPRupp15fHEgIXZ0S2aXmdN9R/fdhUcPM6OA1bccxy4eLNAoZF\n\tQ1C6kEvoDV2MX7uAbKyno9R4B3D2crTeEQtb+6gHZcjdurmB9UYUGWn71mGM3pTg=","X-Gm-Gg":"AeBDietHt3l4h8CiwyAaEl/S/Fq1hj9v47n89ToSxUjDaB9jtUSK3k9U76VQwHxWkst\n\tuy31r865xNuz4BWCwKtUxtszp4ArL/GK/tWthssLlCGsAKp+aiIlkz4Zx+KMcV6TAOm5BlGmwAk\n\tFqr3FyfpwWIafXyVzyiRhYGVeVuqVWmcWdmGAB/yu0zN0R3qqzhqk0rard6kUTtHFIMj9m1X0Z/\n\tqTgKo9kCJwMNmeNxcWCYIakOZYbIZjVEp2BjnMgJijHDcYXYf+m/w3PYK+mvdzIrKgSnreWy3bb\n\tfbUqGOzQZrEsZwgZ0BVd4ItWsDuY6flsTT7zUlUWlX8Ud86X08C47JAKC+qNKS1Xth67+J19cs+\n\tCVQJrjTY2NJR641spNqMHo8P09DFWZl12VpUMnt9ZUc8710YYQatveNhJ82wVsyT+8+ARK8uR+S\n\tG1dzY=","X-Received":["by 2002:a05:7300:6c05:b0:2d4:2cc8:67e with SMTP id\n 5a478bee46e88-2e47a106ccfmr558556eec.23.1776399387845;\n        Thu, 16 Apr 2026 21:16:27 -0700 (PDT)","by 2002:a05:7300:6c05:b0:2d4:2cc8:67e with SMTP id\n 5a478bee46e88-2e47a106ccfmr558541eec.23.1776399387191;\n        Thu, 16 Apr 2026 21:16:27 -0700 (PDT)"],"From":"Qiang Yu <qiang.yu@oss.qualcomm.com>","Date":"Thu, 16 Apr 2026 21:16:25 -0700","Subject":"[PATCH] PCI: qcom: Set max OPP before DBI access during resume","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"<linux-pci.vger.kernel.org>","List-Subscribe":"<mailto:linux-pci+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-pci+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com>","X-B4-Tracking":"v=1; b=H4sIABi04WkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE\n vPSU3UzU4B8JSMDIzMDE0Mz3eLUktzEivyCAl3zRJM0E8u0JEuDJFMloPqCotS0zAqwWdGxtbU\n AQDZ/L1sAAAA=","X-Change-ID":"20260416-setmaxopp-7a4f49fb90b5","To":"Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?=\n\t=?utf-8?q?ski?= <kwilczynski@kernel.org>, Rob Herring <robh@kernel.org>,\n Bjorn Helgaas <bhelgaas@google.com>,\n Krishna chaitanya chundru <quic_krichai@quicinc.com>","Cc":"linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,\n        linux-kernel@vger.kernel.org, Qiang Yu <qiang.yu@oss.qualcomm.com>","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1776399386; l=3294;\n i=qiang.yu@oss.qualcomm.com; s=20250513; h=from:subject:message-id;\n bh=wReg8hifVkzlEEdADzMhijrroaIK/MnJQ3ovMsYvmFo=;\n b=/SvocC1tbAISboxZNBSseO3EC900RS6124mkUXh1rof+7sbSNZR3DgI4YolUmP8MVCo68k2vX\n QH/RORxPfmmA5nLQDcKQl/AG3247lgd/Sh6SuX2v/biC/eE1TLYeMs9","X-Developer-Key":"i=qiang.yu@oss.qualcomm.com; a=ed25519;\n pk=Rr94t+fykoieF1ngg/bXxEfr5KoQxeXPtYxM8fBQTAI=","X-Proofpoint-GUID":"Rcv9RNs-a3q5D_RD--3pXmvJsTXZcqP2","X-Authority-Analysis":"v=2.4 cv=XNoAjwhE c=1 sm=1 tr=0 ts=69e1b41d cx=c_pps\n a=Uww141gWH0fZj/3QKPojxA==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22\n a=EUspDBNiAAAA:8 a=_e_GtX_bwWpn_Ay3u5MA:9 a=QEXdDO2ut3YA:10\n a=PxkB5W3o20Ba91AHUih5:22","X-Proofpoint-ORIG-GUID":"Rcv9RNs-a3q5D_RD--3pXmvJsTXZcqP2","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDE3MDAzOSBTYWx0ZWRfX7p7I84NGcth3\n zRw1xKhUiH5rgd50X+D4rkcjM80VRZ45THljTo2vLjKxjmetlfpAZO3CtYp5JWE3S/CuCkZsAg0\n /eZErFipa1ySTVbISIAMTnUxj/ua0wh0dq9pMvyKnAei2QS9rDMxfBW5aKqy1qGNz+W2yIIQ6vG\n IEU0pjpRrkxsCG3USEHV9T+x/XotTnPTXDi9RhbwYd4B7vd7BtKtXS2aPzW950y2qJb6WigUtaa\n 5W1xVgY4v5bNfSre2JzfbU8rtiP9bimaZIAQwkBFjcz1pxW7LKIlJCAUBdLdyiLEkN8k5NZv1OL\n 3eba0dWzyQuiy1gijxdeXW9HLioVPIps4BsCqSTdnLe0fLZ0H958POmaNn908awHE6fPZalJAVg\n d1uZj/qnK64n808bOptYEbmfL/Vvb9eAJ5q/x/to6aE33SSswxoEB7iUL7lJZP6Ygr7Cv4scUyU\n EFo33Oo/eV+MXROR1ig==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-16_04,2026-04-16_03,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 impostorscore=0 priorityscore=1501 suspectscore=0 spamscore=0\n phishscore=0 clxscore=1011 lowpriorityscore=0 adultscore=0 bulkscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604170039"},"content":"During resume, qcom_pcie_icc_opp_update() may access DBI registers before\nthe OPP votes are restored, which can trigger NoC errors.\n\nSet the PCIe controller to the maximum OPP first in resume_noirq(), then\nproceed with link/DBI accesses. The OPP is later updated again based on\nthe actual link bandwidth requirements.\n\nAlso introduce a small helper to reuse the max-OPP setup path shared with\nprobe.\n\nFixes: 5b6272e0efd5 (\"PCI: qcom: Add OPP support to scale performance\")\nSigned-off-by: Qiang Yu <qiang.yu@oss.qualcomm.com>\n---\n drivers/pci/controller/dwc/pcie-qcom.c | 42 +++++++++++++++++++++-------------\n 1 file changed, 26 insertions(+), 16 deletions(-)\n\n\n---\nbase-commit: 33a76fc3c3e61386524479b99f35423bd3d9a895\nchange-id: 20260416-setmaxopp-7a4f49fb90b5\n\nBest regards,","diff":"diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c\nindex 9fdfc88ac15120b2b01cad746772ae612a2c9690..c9b201a1c033a9849e97db9ee4d07d26655d5a6c 100644\n--- a/drivers/pci/controller/dwc/pcie-qcom.c\n+++ b/drivers/pci/controller/dwc/pcie-qcom.c\n@@ -1613,6 +1613,22 @@ static void qcom_pcie_icc_opp_update(struct qcom_pcie *pcie)\n \t}\n }\n \n+static int qcom_pcie_set_max_opp(struct device *dev)\n+{\n+\tunsigned long max_freq = ULONG_MAX;\n+\tstruct dev_pm_opp *opp;\n+\tint ret;\n+\n+\topp = dev_pm_opp_find_freq_floor(dev, &max_freq);\n+\tif (IS_ERR(opp))\n+\t\treturn PTR_ERR(opp);\n+\n+\tret = dev_pm_opp_set_opp(dev, opp);\n+\tdev_pm_opp_put(opp);\n+\n+\treturn ret;\n+}\n+\n static int qcom_pcie_link_transition_count(struct seq_file *s, void *data)\n {\n \tstruct qcom_pcie *pcie = (struct qcom_pcie *)dev_get_drvdata(s->private);\n@@ -1845,9 +1861,7 @@ static int qcom_pcie_probe(struct platform_device *pdev)\n \tstruct qcom_pcie_perst *perst, *tmp_perst;\n \tstruct qcom_pcie_port *port, *tmp_port;\n \tconst struct qcom_pcie_cfg *pcie_cfg;\n-\tunsigned long max_freq = ULONG_MAX;\n \tstruct device *dev = &pdev->dev;\n-\tstruct dev_pm_opp *opp;\n \tstruct qcom_pcie *pcie;\n \tstruct dw_pcie_rp *pp;\n \tstruct resource *res;\n@@ -1951,21 +1965,9 @@ static int qcom_pcie_probe(struct platform_device *pdev)\n \t * probe(), OPP will be updated using qcom_pcie_icc_opp_update().\n \t */\n \tif (!ret) {\n-\t\topp = dev_pm_opp_find_freq_floor(dev, &max_freq);\n-\t\tif (IS_ERR(opp)) {\n-\t\t\tret = PTR_ERR(opp);\n-\t\t\tdev_err_probe(pci->dev, ret,\n-\t\t\t\t      \"Unable to find max freq OPP\\n\");\n-\t\t\tgoto err_pm_runtime_put;\n-\t\t} else {\n-\t\t\tret = dev_pm_opp_set_opp(dev, opp);\n-\t\t}\n-\n-\t\tdev_pm_opp_put(opp);\n+\t\tret = qcom_pcie_set_max_opp(dev);\n \t\tif (ret) {\n-\t\t\tdev_err_probe(pci->dev, ret,\n-\t\t\t\t      \"Failed to set OPP for freq %lu\\n\",\n-\t\t\t\t      max_freq);\n+\t\t\tdev_err_probe(dev, ret, \"Failed to set max OPP in probe\\n\");\n \t\t\tgoto err_pm_runtime_put;\n \t\t}\n \n@@ -2100,6 +2102,14 @@ static int qcom_pcie_resume_noirq(struct device *dev)\n \t\treturn 0;\n \n \tif (pm_suspend_target_state != PM_SUSPEND_MEM) {\n+\t\tif (pcie->use_pm_opp) {\n+\t\t\tret = qcom_pcie_set_max_opp(dev);\n+\t\t\tif (ret) {\n+\t\t\t\tdev_err(dev, \"Failed to set max OPP in resume: %d\\n\", ret);\n+\t\t\t\treturn ret;\n+\t\t\t}\n+\t\t}\n+\n \t\tret = icc_enable(pcie->icc_cpu);\n \t\tif (ret) {\n \t\t\tdev_err(dev, \"Failed to enable CPU-PCIe interconnect path: %d\\n\", ret);\n","prefixes":[]}