{"id":2224210,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224210/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417035734.32334-2-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417035734.32334-2-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-17T03:57:31","name":"[v5,1/4] target/mips: Pass MemOpIdx argument to Load/Store Multiple helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f10be251d275df1f9b805a8a38865dc5c2b539e8","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.2/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417035734.32334-2-philmd@linaro.org/mbox/","series":[{"id":500232,"url":"http://patchwork.ozlabs.org/api/1.2/series/500232/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500232","date":"2026-04-17T03:57:30","name":"target/mips: Replace cpu_ld/st_mmuidx_ra() calls in LD/ST Multiple","version":5,"mbox":"http://patchwork.ozlabs.org/series/500232/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224210/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224210/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=lm3/nY0L;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxh1k3q1yz1yDF\n\tfor ; Fri, 17 Apr 2026 13:58:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDaKy-0000AV-RF; Thu, 16 Apr 2026 23:57:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDaKx-0000AK-Pz\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:47 -0400","from mail-wm1-x334.google.com ([2a00:1450:4864:20::334])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDaKw-0001Dz-7J\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:47 -0400","by mail-wm1-x334.google.com with SMTP id\n 5b1f17b1804b1-4887f49ec5aso2956895e9.1\n for ; Thu, 16 Apr 2026 20:57:45 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fb7bd700sm6959855e9.31.2026.04.16.20.57.42\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 16 Apr 2026 20:57:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776398264; x=1777003064; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6FrY0N+MlqE1VqAmJP5+zOpwJgQamw0o/zYm1s6GqUI=;\n b=lm3/nY0LB0UU+NxWyqZI13gnId6IZIdVemkRF4xaa8Rgw7xtrQoafZptNK1CzSrWex\n lCkXx92De89BlirjYnsUtyuE1P9Lty1A3n+QvFDZJUE8LMqOQbxaYU4tA6hYmVItfhf1\n ZoD4q3CVUzESBxrA3zqT6K4w2pv71yYopW56A2yrq/VapxrLtWH5P8dlsWpfj8jTLxe5\n Ke4MvJzVwhbAgxnRqxTSV3jG3NOx4XLmxhSbgDajoeQl+SXey1nBKzbIGxhPSQK2m9Qp\n mtsi1ZFXqQ5jlexjnLbUwOH3/2IKa60X1wp7vDzueTD8V7VrrMLhfz27+vLnMiRToRVc\n XOKQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776398264; x=1777003064;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=6FrY0N+MlqE1VqAmJP5+zOpwJgQamw0o/zYm1s6GqUI=;\n b=AWjd4N2LkbwUn8Ite7B0A+BW2p1MGzywCtPzntHOqp8FcE5YFE7gZQ7IkO+xSiTCj/\n PvE8bTrkiXuItNTgrAbHwA0sGDc7PDmcH/O+MyPZMi46BXCenFQEK0JBpC88mgn6rkuW\n mh6Ex7OOhZv4m7zM8A5df9IrsGR0VyfKp1xshKO1mA91Rk9UpYP6JYkRGkGj1zsf8g/h\n 6516Kg8UortDQJzjKfTRgPN+v5MgtZyyKAoKfSJI2y5Tnl2LwfoHdjv8fv67eDETRVuv\n i8g5Z4Mwy+BBVWNW2soX8ZmAQKQIuodoFrR18YGXuxluhcOALasx8OE4034XaU3T0BZ2\n uQBg==","X-Gm-Message-State":"AOJu0YzjNcjyaM9k0/FYZS9GihGTqbz72+JYgEBlenSdueFohfKsyjWe\n oAB4ywFpvWdT/1rEuZ6AtFFPouhJPGTMGJcChaW9kl2I03/EWzYrQ4KJ1BF7hqxMmqoDkRQqo4X\n EYIn0lNk=","X-Gm-Gg":"AeBDies8hFO+fH/OgUPAoSMlTsvFPkSgIr4r+zEHNA5tPhnR0t2jCrNAshvQX2zXwAM\n yC9n/lxtnW5iJJonGSA5qlrkI6lD57Y4zpqP4KYwzY4yT6CqUtSZwqVcrZfoVc6A8JnSiw7y4Gr\n lk8Xx+dj8lHEKPrLAmgS701/JBrexTQ1lM6EdHJLgS5zyeyUNb9iLR/yWziI6bG0IMG61pbuSi7\n G+am6o4zvLyArazoImzsmK2iEklmYZ6K7K3y5tWn3sBh2Sb2/bkzRa4muhZ+0OIQUNJ4bw4eJ8Y\n qc/rPVsGQDa0BUynYEFEFKPfJOhGOrC1h/TzZPdyQZ97qnGLN/+EZt3cKAYbqw3Abx0TUmyAEQW\n 8+EwbMvyAjd2Bmvhx/g8NSuBh4YCCXRfFpIbc7ce2hJdsECBTKnLSPspJZxFYBifgZWF9pJ3dei\n 7IfJa63puYEtHv9bsiiRq4ng0AbEPVwfBvszNgAnMN0frcgrnbHxP1yuWosYaPfaCOdrgOGac2K\n Vsh9CpvwNE=","X-Received":"by 2002:a05:600d:13:b0:488:869c:edaf with SMTP id\n 5b1f17b1804b1-488fb7419c4mr10915175e9.8.1776398264331;\n Thu, 16 Apr 2026 20:57:44 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson , =?utf-8?q?Philippe_Mat?=\n\t=?utf-8?q?hieu-Daud=C3=A9?= ,\n Aleksandar Rikalo , Aurelien Jarno ,\n Jiaxun Yang ","Subject":"[PATCH v5 1/4] target/mips: Pass MemOpIdx argument to Load/Store\n Multiple helpers","Date":"Fri, 17 Apr 2026 05:57:31 +0200","Message-ID":"<20260417035734.32334-2-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260417035734.32334-1-philmd@linaro.org>","References":"<20260417035734.32334-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::334;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"In preparation of using the MemOp content in the next commit,\npass it as MemOpIdx. Include the access size.\n\nSigned-off-by: Philippe Mathieu-Daudé \nReviewed-by: Richard Henderson \n---\n target/mips/tcg/ldst_helper.c | 16 ++++++++++++----\n target/mips/tcg/micromips_translate.c.inc | 16 ++++++++++------\n 2 files changed, 22 insertions(+), 10 deletions(-)","diff":"diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c\nindex 4ebf72d610e..7be2cad89d6 100644\n--- a/target/mips/tcg/ldst_helper.c\n+++ b/target/mips/tcg/ldst_helper.c\n@@ -224,8 +224,10 @@ void helper_sdr(CPUMIPSState *env, target_ulong arg1, target_ulong arg2,\n static const int multiple_regs[] = { 16, 17, 18, 19, 20, 21, 22, 23, 30 };\n \n void helper_lwm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n- uint32_t mem_idx)\n+ uint32_t memop_idx)\n {\n+ MemOpIdx oi = memop_idx;\n+ unsigned mem_idx = get_mmuidx(oi);\n target_ulong base_reglist = reglist & 0xf;\n target_ulong do_r31 = reglist & 0x10;\n \n@@ -246,8 +248,10 @@ void helper_lwm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n }\n \n void helper_swm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n- uint32_t mem_idx)\n+ uint32_t memop_idx)\n {\n+ MemOpIdx oi = memop_idx;\n+ unsigned mem_idx = get_mmuidx(oi);\n target_ulong base_reglist = reglist & 0xf;\n target_ulong do_r31 = reglist & 0x10;\n \n@@ -268,8 +272,10 @@ void helper_swm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n \n #if defined(TARGET_MIPS64)\n void helper_ldm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n- uint32_t mem_idx)\n+ uint32_t memop_idx)\n {\n+ MemOpIdx oi = memop_idx;\n+ unsigned mem_idx = get_mmuidx(oi);\n target_ulong base_reglist = reglist & 0xf;\n target_ulong do_r31 = reglist & 0x10;\n \n@@ -290,8 +296,10 @@ void helper_ldm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n }\n \n void helper_sdm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n- uint32_t mem_idx)\n+ uint32_t memop_idx)\n {\n+ MemOpIdx oi = memop_idx;\n+ unsigned mem_idx = get_mmuidx(oi);\n target_ulong base_reglist = reglist & 0xf;\n target_ulong do_r31 = reglist & 0x10;\n \ndiff --git a/target/mips/tcg/micromips_translate.c.inc b/target/mips/tcg/micromips_translate.c.inc\nindex 8fda7c8a214..4dca11b84b4 100644\n--- a/target/mips/tcg/micromips_translate.c.inc\n+++ b/target/mips/tcg/micromips_translate.c.inc\n@@ -693,7 +693,8 @@ static void gen_ldst_multiple(DisasContext *ctx, uint32_t opc, int reglist,\n int base, int16_t offset)\n {\n TCGv t0, t1;\n- TCGv_i32 t2;\n+ MemOp mop = MO_UNALN;\n+ MemOpIdx oi;\n \n if (ctx->hflags & MIPS_HFLAG_BMASK) {\n gen_reserved_instruction(ctx);\n@@ -705,22 +706,25 @@ static void gen_ldst_multiple(DisasContext *ctx, uint32_t opc, int reglist,\n gen_base_offset_addr(ctx, t0, base, offset);\n \n t1 = tcg_constant_tl(reglist);\n- t2 = tcg_constant_i32(ctx->mem_idx);\n \n save_cpu_state(ctx, 1);\n switch (opc) {\n case LWM32:\n- gen_helper_lwm(tcg_env, t0, t1, t2);\n+ oi = make_memop_idx(mop | MO_UL, ctx->mem_idx);\n+ gen_helper_lwm(tcg_env, t0, t1, tcg_constant_i32(oi));\n break;\n case SWM32:\n- gen_helper_swm(tcg_env, t0, t1, t2);\n+ oi = make_memop_idx(mop | MO_UL, ctx->mem_idx);\n+ gen_helper_swm(tcg_env, t0, t1, tcg_constant_i32(oi));\n break;\n #ifdef TARGET_MIPS64\n case LDM:\n- gen_helper_ldm(tcg_env, t0, t1, t2);\n+ oi = make_memop_idx(mop | MO_UQ, ctx->mem_idx);\n+ gen_helper_ldm(tcg_env, t0, t1, tcg_constant_i32(oi));\n break;\n case SDM:\n- gen_helper_sdm(tcg_env, t0, t1, t2);\n+ oi = make_memop_idx(mop | MO_UQ, ctx->mem_idx);\n+ gen_helper_sdm(tcg_env, t0, t1, tcg_constant_i32(oi));\n break;\n #endif\n }\n","prefixes":["v5","1/4"]}