{"id":2224208,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2224208/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417035734.32334-3-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260417035734.32334-3-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-17T03:57:32","name":"[v5,2/4] target/mips: Remove unnecessary target_ulong uses in LD/ST Multiple","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"af6c44d3102bb95046be54f2a4feb05295b0b076","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.2/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260417035734.32334-3-philmd@linaro.org/mbox/","series":[{"id":500233,"url":"http://patchwork.ozlabs.org/api/1.2/series/500233/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=500233","date":"2026-04-17T03:57:32","name":null,"version":5,"mbox":"http://patchwork.ozlabs.org/series/500233/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2224208/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2224208/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=GnrrIL0e;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fxh1k3sYmz1yHp\n\tfor ; Fri, 17 Apr 2026 13:58:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wDaL6-0000C1-NE; Thu, 16 Apr 2026 23:57:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wDaL5-0000Bc-B3\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:55 -0400","from mail-wm1-x336.google.com ([2a00:1450:4864:20::336])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wDaL3-0001Eh-Mm\n for qemu-devel@nongnu.org; Thu, 16 Apr 2026 23:57:55 -0400","by mail-wm1-x336.google.com with SMTP id\n 5b1f17b1804b1-488b8bc6bc9so1136895e9.3\n for ; Thu, 16 Apr 2026 20:57:53 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488fc0f8193sm11083345e9.1.2026.04.16.20.57.50\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Thu, 16 Apr 2026 20:57:50 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776398272; x=1777003072; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=1wvsgcQ/M31Z4/UMXnX5x+3B1m7b5ZzzUe0LHeA1Em4=;\n b=GnrrIL0ea52TEIcIAIV8RP9exf7ysxiXaETXVxAuKEuroV6SgDVyiGJfzhu2AsTvXa\n sQqZVgYNcu1UArD3G/adzBarT15Iycst8Y3742C1AI/mL2DhB5Z0kIQ6igWPlhpzXLcx\n JUuYDM47TMtoQBY2RKjbhFJ804F8TSFIdxL0oD92TqFE28Bekd48Bd9+6nEGkZmiT3iz\n EsxMLZmN9SEd+jDMpo4j14U98nr25MJR4dAdIQ2oyNd0/+KNtnokc/55HBS/H5DPhJs3\n n19bG4D9QkeQALwNBjKcqgKj4BjYA3+/pRqvQ7F3fKDXgD7KqBx/UaeG7VNhNHJiOu1I\n jJJA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776398272; x=1777003072;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=1wvsgcQ/M31Z4/UMXnX5x+3B1m7b5ZzzUe0LHeA1Em4=;\n b=OX7qVwm2tO5YgNkqXRA59bTBgO3s83+DK7flsogZDDMtHxL3pNZ/cKYUiimqewXKbQ\n yaeoHIlyzX8XUUzpaYT7YXB95dBzZ3Sdt1nf9sx4G4ATNobmvpBHNFIxfQcfIYppf2kU\n z7gEwJ8n42pgqZHwgw5EVfABxoUcGbUtxgOqobdG+uR+1gdIQmTwwNFZfvjRaK9XvNcw\n ExJamjKBosgB0arDSMIFPPCu1dJZL7i9KESRMN7PT/wkLLzHXm9tCxFol/cREFTxT/E2\n qZucIPJZlHf+z+k+Xca+oA7nsZbxnz/JSkBmisnWDgUVWg5LKmjFOX6he0nKM2k0VeKX\n RfrQ==","X-Gm-Message-State":"AOJu0YzYDB1mUeKoLlTCVs44mibuoFNohdYpDHNo0Jd44VAsPOtvf0BG\n ktMwrEf8zRHfxkxJAgNZVAdRn0Isx/bq8s17+t254lx3rxZKfhisvo9gVQ78+LR06iaywzpjyCh\n WkeW8UBk=","X-Gm-Gg":"AeBDietr9haFtaHc6GgqYS8tn8f2MT49TrsbBkqMIcuqCQQMMyvmXp8w9PXToOmVW4o\n qNvtMT/6ZJ3f2/hKPnwNzHO+7AhVvvQwS/cxFM6oOxMO6RblUWZvv0JQWG0P3azUyZ4WyPtqJdt\n qY/Jt3ebr1+NXS7j5KTcoHGrH3h/xnd3ak0FTQE9ipOL4fiNVUwrHf7t8eAXNLVwSTn36DiZukz\n y0ZMPne74hMei2v6n1fnXzB2X4QgONdDznnEad2uPRPhQnVn1jaCn3vR/pw0GoSXSXllAF0QtW5\n 8v7h4TYuR5YJBgsn4ITFL7/xUH8pOJyfmlNQh7Nfk86AgcB+lOqsBIzWbHrVPrI7HJgmpS+zE+I\n sOW1eRzCNsj1mo2ndZfxQ/rrSL/VF4n6zad5rr9UNRRTb8fMOtGIKa0Vk+nI9cthU+2b6VNbmON\n 9vQC3VdtNv/bI5eoOLZWG2q5hxPi3K/ylHtKeS9xlw0/sClSU6JCTIjSs4X7sO50ASqNJ+ht+D+\n BfDfVFMz2E=","X-Received":"by 2002:a05:600c:8207:b0:485:3193:6ddb with SMTP id\n 5b1f17b1804b1-488fb73cf74mr15430345e9.3.1776398271918;\n Thu, 16 Apr 2026 20:57:51 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson , =?utf-8?q?Philippe_Mat?=\n\t=?utf-8?q?hieu-Daud=C3=A9?= ,\n Aleksandar Rikalo , Aurelien Jarno ,\n Jiaxun Yang ","Subject":"[PATCH v5 2/4] target/mips: Remove unnecessary target_ulong uses in\n LD/ST Multiple","Date":"Fri, 17 Apr 2026 05:57:32 +0200","Message-ID":"<20260417035734.32334-3-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260417035734.32334-1-philmd@linaro.org>","References":"<20260417035734.32334-1-philmd@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::336;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"@do_r31 is a boolean, @base_reglist an unsigned size\nand @i an unsigned index.\n\nSigned-off-by: Philippe Mathieu-Daudé \n---\n target/mips/tcg/ldst_helper.c | 32 ++++++++++++--------------------\n 1 file changed, 12 insertions(+), 20 deletions(-)","diff":"diff --git a/target/mips/tcg/ldst_helper.c b/target/mips/tcg/ldst_helper.c\nindex 7be2cad89d6..07a4aa99bae 100644\n--- a/target/mips/tcg/ldst_helper.c\n+++ b/target/mips/tcg/ldst_helper.c\n@@ -228,13 +228,11 @@ void helper_lwm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n {\n MemOpIdx oi = memop_idx;\n unsigned mem_idx = get_mmuidx(oi);\n- target_ulong base_reglist = reglist & 0xf;\n- target_ulong do_r31 = reglist & 0x10;\n+ unsigned base_reglist = reglist & 0xf;\n+ bool do_r31 = reglist & 0x10;\n \n if (base_reglist > 0 && base_reglist <= ARRAY_SIZE(multiple_regs)) {\n- target_ulong i;\n-\n- for (i = 0; i < base_reglist; i++) {\n+ for (unsigned i = 0; i < base_reglist; i++) {\n env->active_tc.gpr[multiple_regs[i]] =\n (target_long)cpu_ldl_mmuidx_ra(env, addr, mem_idx, GETPC());\n addr += 4;\n@@ -252,13 +250,11 @@ void helper_swm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n {\n MemOpIdx oi = memop_idx;\n unsigned mem_idx = get_mmuidx(oi);\n- target_ulong base_reglist = reglist & 0xf;\n- target_ulong do_r31 = reglist & 0x10;\n+ unsigned base_reglist = reglist & 0xf;\n+ bool do_r31 = reglist & 0x10;\n \n if (base_reglist > 0 && base_reglist <= ARRAY_SIZE(multiple_regs)) {\n- target_ulong i;\n-\n- for (i = 0; i < base_reglist; i++) {\n+ for (unsigned i = 0; i < base_reglist; i++) {\n cpu_stl_mmuidx_ra(env, addr, env->active_tc.gpr[multiple_regs[i]],\n mem_idx, GETPC());\n addr += 4;\n@@ -276,13 +272,11 @@ void helper_ldm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n {\n MemOpIdx oi = memop_idx;\n unsigned mem_idx = get_mmuidx(oi);\n- target_ulong base_reglist = reglist & 0xf;\n- target_ulong do_r31 = reglist & 0x10;\n+ unsigned base_reglist = reglist & 0xf;\n+ bool do_r31 = reglist & 0x10;\n \n if (base_reglist > 0 && base_reglist <= ARRAY_SIZE(multiple_regs)) {\n- target_ulong i;\n-\n- for (i = 0; i < base_reglist; i++) {\n+ for (unsigned i = 0; i < base_reglist; i++) {\n env->active_tc.gpr[multiple_regs[i]] =\n cpu_ldq_mmuidx_ra(env, addr, mem_idx, GETPC());\n addr += 8;\n@@ -300,13 +294,11 @@ void helper_sdm(CPUMIPSState *env, target_ulong addr, target_ulong reglist,\n {\n MemOpIdx oi = memop_idx;\n unsigned mem_idx = get_mmuidx(oi);\n- target_ulong base_reglist = reglist & 0xf;\n- target_ulong do_r31 = reglist & 0x10;\n+ unsigned base_reglist = reglist & 0xf;\n+ bool do_r31 = reglist & 0x10;\n \n if (base_reglist > 0 && base_reglist <= ARRAY_SIZE(multiple_regs)) {\n- target_ulong i;\n-\n- for (i = 0; i < base_reglist; i++) {\n+ for (unsigned i = 0; i < base_reglist; i++) {\n cpu_stq_mmuidx_ra(env, addr, env->active_tc.gpr[multiple_regs[i]],\n mem_idx, GETPC());\n addr += 8;\n","prefixes":["v5","2/4"]}