{"id":2223509,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2223509/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260415123716.1084463-2-xsimonar@redhat.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260415123716.1084463-2-xsimonar@redhat.com>","list_archive_url":null,"date":"2026-04-15T12:37:13","name":"[ovs-dev,v2,2/5] pinctrl: Fix garp_rarp waking up pinctrl thread too often.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"33267fc3e12bd2d2a1c1419cfa117e1ac16f7bda","submitter":{"id":82231,"url":"http://patchwork.ozlabs.org/api/1.2/people/82231/?format=json","name":"Xavier Simonart","email":"xsimonar@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260415123716.1084463-2-xsimonar@redhat.com/mbox/","series":[{"id":499984,"url":"http://patchwork.ozlabs.org/api/1.2/series/499984/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=499984","date":"2026-04-15T12:37:14","name":"[ovs-dev,v2,1/5] pinctrl: Add pinctrl_notify_handler_thread counter.","version":2,"mbox":"http://patchwork.ozlabs.org/series/499984/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223509/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2223509/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Sl2XRqzy;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::133; helo=smtp2.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp2.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Sl2XRqzy","smtp1.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp1.osuosl.org; dkim=pass (1024-bit key,\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Sl2XRqzy"],"Received":["from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwgdl3FMcz1yHd\n\tfor ; Wed, 15 Apr 2026 22:37:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp2.osuosl.org (Postfix) with ESMTP id 43E8342654;\n\tWed, 15 Apr 2026 12:37:26 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id rg9PaPP45jkh; Wed, 15 Apr 2026 12:37:25 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp2.osuosl.org (Postfix) with ESMTPS id 09BC540526;\n\tWed, 15 Apr 2026 12:37:25 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id E67EAC0902;\n\tWed, 15 Apr 2026 12:37:24 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 04A2DC054A\n for ; Wed, 15 Apr 2026 12:37:23 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id D8590853C5\n for ; Wed, 15 Apr 2026 12:37:22 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id pU1b5V078Hic for ;\n Wed, 15 Apr 2026 12:37:22 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id F1323853C4\n for ; Wed, 15 Apr 2026 12:37:21 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-cjJ6IdvoN9Orzi1Z2N1O1g-1; Wed,\n 15 Apr 2026 08:37:19 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 9E3431800348\n for ; Wed, 15 Apr 2026 12:37:18 +0000 (UTC)","from wsfd-netdev90.anl.eng.rdu2.dc.redhat.com\n (wsfd-netdev90.anl.eng.rdu2.dc.redhat.com [10.6.38.135])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 261ED180044F; Wed, 15 Apr 2026 12:37:18 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp2.osuosl.org 09BC540526","OpenDKIM Filter v2.11.0 smtp1.osuosl.org F1323853C4"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=xsimonar@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org F1323853C4","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776256640;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=pFpunRY7Vfm/5uqxp7ryIBbz0+KoNaAHmXQaodNo8C4=;\n b=Sl2XRqzykuyNP2vD/b75AGxRGUAPEXN9ufpzzTDRMZ80EuKVw6UDEmMsPXrlEumymggyO6\n dYEco/diWcr6hzmdVQHdqwOawH2eQRiiuffgjUDlwLZJdCd/FQI7ARpLT/U5c7bN9Cb4+j\n VHeTCyea3OScMtUgvplvfB51as2eow8=","X-MC-Unique":"cjJ6IdvoN9Orzi1Z2N1O1g-1","X-Mimecast-MFC-AGG-ID":"cjJ6IdvoN9Orzi1Z2N1O1g_1776256638","To":"xsimonar@redhat.com,\n\tdev@openvswitch.org","Date":"Wed, 15 Apr 2026 08:37:13 -0400","Message-ID":"<20260415123716.1084463-2-xsimonar@redhat.com>","In-Reply-To":"<20260415123716.1084463-1-xsimonar@redhat.com>","References":"<20260414152254.991243-5-xsimonar@redhat.com>\n <20260415123716.1084463-1-xsimonar@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"bSocxcqsIAba0BWXfNO-FUmFvA3EaA1gVFq8fyPi9KY_1776256638","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [PATCH ovn v2 2/5] pinctrl: Fix garp_rarp waking up\n pinctrl thread too often.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Xavier Simonart via dev ","Reply-To":"Xavier Simonart ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Avoid garp_rarp waking up pinctrl when no change.\nAs, with this patch, pinctrl is only waken up by garp_rarp when there are\ngarp_rarp changes, add a peridic wake up for pinctrl for syncing\ncoverage counters. Without this, pinctrl might sleep for a long time\nif no event such as packet_in, and recently updated counters might\nnot be sync'ed and hence not updated in appctl coverage/show.\n\nFixes: 05527bd6ccdb (\"controller: Extract garp_rarp to engine node.\")\nSigned-off-by: Xavier Simonart \n\n---\n-v2: Fix coverage counter issue reported by\n \"dns lookup : 1 HV, 2 LS, 2 LSPs/LS\" and by Ales.\n---\n controller/garp_rarp.c | 2 +-\n controller/pinctrl.c | 2 ++\n 2 files changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/controller/garp_rarp.c b/controller/garp_rarp.c\nindex 9d0c2c2e4..162fa0446 100644\n--- a/controller/garp_rarp.c\n+++ b/controller/garp_rarp.c\n@@ -565,7 +565,7 @@ garp_rarp_get_data(void)\n bool\n garp_rarp_data_changed(void) {\n bool ret = garp_rarp_data_has_changed;\n- garp_rarp_data_has_changed = true;\n+ garp_rarp_data_has_changed = false;\n return ret;\n }\n \ndiff --git a/controller/pinctrl.c b/controller/pinctrl.c\nindex f62022361..1ad058f2b 100644\n--- a/controller/pinctrl.c\n+++ b/controller/pinctrl.c\n@@ -4048,6 +4048,8 @@ pinctrl_handler(void *arg_)\n latch_wait(&pctrl->pinctrl_thread_exit);\n \n ovsrcu_quiesce_start();\n+ /* Wake-up periodicaly for coverage counters sync.*/\n+ poll_timer_wait(1000);\n poll_block();\n }\n \n","prefixes":["ovs-dev","v2","2/5"]}