{"id":2223508,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2223508/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260415123716.1084463-3-xsimonar@redhat.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260415123716.1084463-3-xsimonar@redhat.com>","list_archive_url":null,"date":"2026-04-15T12:37:14","name":"[ovs-dev,v2,3/5] pinctrl: Fix ip_mcast_sync waking up pinctrl thread too often.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"921d20a5fb036eb2ecef1854357cb52da95587ec","submitter":{"id":82231,"url":"http://patchwork.ozlabs.org/api/1.2/people/82231/?format=json","name":"Xavier Simonart","email":"xsimonar@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260415123716.1084463-3-xsimonar@redhat.com/mbox/","series":[{"id":499984,"url":"http://patchwork.ozlabs.org/api/1.2/series/499984/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=499984","date":"2026-04-15T12:37:14","name":"[ovs-dev,v2,1/5] pinctrl: Add pinctrl_notify_handler_thread counter.","version":2,"mbox":"http://patchwork.ozlabs.org/series/499984/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223508/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2223508/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=E7kRo0Cr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=E7kRo0Cr","smtp4.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwgdl1dnmz1yCv\n\tfor ; Wed, 15 Apr 2026 22:37:29 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 14FD346FD7;\n\tWed, 15 Apr 2026 12:37:27 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id UbFEbtBzKUTr; Wed, 15 Apr 2026 12:37:26 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 1BC9B470A7;\n\tWed, 15 Apr 2026 12:37:26 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id C70F5C0904;\n\tWed, 15 Apr 2026 12:37:25 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists.linuxfoundation.org (Postfix) with ESMTP id D6E3EC0549\n for ; Wed, 15 Apr 2026 12:37:23 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id BD68D45223\n for ; Wed, 15 Apr 2026 12:37:23 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id kCw4V8CZYKxl for ;\n Wed, 15 Apr 2026 12:37:22 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by smtp4.osuosl.org (Postfix) with ESMTPS id A294045BD3\n for ; Wed, 15 Apr 2026 12:37:22 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-400-u1iOJs7SOU2gv2L9ATBjvg-1; Wed,\n 15 Apr 2026 08:37:20 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 6B3921956088\n for ; Wed, 15 Apr 2026 12:37:19 +0000 (UTC)","from wsfd-netdev90.anl.eng.rdu2.dc.redhat.com\n (wsfd-netdev90.anl.eng.rdu2.dc.redhat.com [10.6.38.135])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id EBDB0180047F; Wed, 15 Apr 2026 12:37:18 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1BC9B470A7","OpenDKIM Filter v2.11.0 smtp4.osuosl.org A294045BD3"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.133.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=xsimonar@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org A294045BD3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776256641;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bdvjROGCFguCXNg3fWERJCWbwTg9VzLHbDAWZqMjOoo=;\n b=E7kRo0Cr2IjlbV4cO8UQ4DiECjyyEHcFyCD0gfxDpMeUr3FIIXLF1qRKkMtX8LJR7fA/fc\n iyqUL3DFoXCAW8yKcTB8PxZakhA38plPjofafkM4mi0bLfrguAW4go+ptjge0wV7IRcu84\n Z1506Id9lWSVK8KoaUU13nH/RA0aQng=","X-MC-Unique":"u1iOJs7SOU2gv2L9ATBjvg-1","X-Mimecast-MFC-AGG-ID":"u1iOJs7SOU2gv2L9ATBjvg_1776256639","To":"xsimonar@redhat.com,\n\tdev@openvswitch.org","Date":"Wed, 15 Apr 2026 08:37:14 -0400","Message-ID":"<20260415123716.1084463-3-xsimonar@redhat.com>","In-Reply-To":"<20260415123716.1084463-1-xsimonar@redhat.com>","References":"<20260414152254.991243-5-xsimonar@redhat.com>\n <20260415123716.1084463-1-xsimonar@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"SJmjtn7X6m4yxIpgrXJ61be_ylmr69wfVPT9wZD0px0_1776256639","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [PATCH ovn v2 3/5] pinctrl: Fix ip_mcast_sync waking up\n pinctrl thread too often.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Xavier Simonart via dev ","Reply-To":"Xavier Simonart ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Not local datapath related entries were added and removed in every loops,\ncausing constant pinctrl wakeup.\n\nFixes: 70ff8243040f (\"OVN: Add IGMP SB definitions and ovn-controller support\")\nSigned-off-by: Xavier Simonart \n\n---\n-v2: Fixes test issue reported by Ales.\n---\n controller/pinctrl.c | 3 +++\n tests/system-ovn.at | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/controller/pinctrl.c b/controller/pinctrl.c\nindex 1ad058f2b..94a4e9bce 100644\n--- a/controller/pinctrl.c\n+++ b/controller/pinctrl.c\n@@ -5751,6 +5751,9 @@ ip_mcast_sync(struct ovsdb_idl_txn *ovnsb_idl_txn,\n struct ip_mcast_snoop_cfg cfg;\n bool flush_groups = false;\n \n+ if (!get_local_datapath(local_datapaths, dp_key)) {\n+ continue;\n+ }\n ip_mcast_snoop_cfg_load(&cfg, ip_mcast);\n if (ip_mcast_snoop_state_update(dp_key, &cfg, &flush_groups)) {\n notify = true;\ndiff --git a/tests/system-ovn.at b/tests/system-ovn.at\nindex 8d1f21609..d22e75a76 100644\n--- a/tests/system-ovn.at\n+++ b/tests/system-ovn.at\n@@ -5027,6 +5027,9 @@ OVS_WAIT_UNTIL([\n test \"${n_reset}\" = \"1\"\n ])\n \n+ovn-appctl coverage/show > ovn_counters\n+AT_CHECK([test 50 -gt $(ovn-appctl -t ovn-controller coverage/read-counter pinctrl_notify_handler_thread)], [0])\n+\n # Check that we do not get too many immediate wake up.\n # Tolerate a few for any race conditions.\n AT_CHECK([test 5 -gt `cat ovn-controller.log | \\\n","prefixes":["ovs-dev","v2","3/5"]}