{"id":2223284,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2223284/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-27-arthur.cohen@embecosm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414231905.191063-27-arthur.cohen@embecosm.com>","list_archive_url":null,"date":"2026-04-14T23:18:48","name":"[COMMITTED,27/43] gccrs: Add a function for default outer attribute checks","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"fe187a620791fc2bd4a6186c08db92fa461ae9a1","submitter":{"id":83476,"url":"http://patchwork.ozlabs.org/api/1.2/people/83476/?format=json","name":"Arthur Cohen","email":"arthur.cohen@embecosm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-27-arthur.cohen@embecosm.com/mbox/","series":[{"id":499900,"url":"http://patchwork.ozlabs.org/api/1.2/series/499900/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499900","date":"2026-04-14T23:18:24","name":"[COMMITTED,01/43] gccrs: testsuite:Add a testcase for setup_associated_types","version":1,"mbox":"http://patchwork.ozlabs.org/series/499900/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223284/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223284/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=RXAfTWib;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=38.145.34.32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=RXAfTWib","sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com","sourceware.org; spf=pass smtp.mailfrom=embecosm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.54"],"Received":["from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwL0R1Hjdz1yHM\n\tfor ; Wed, 15 Apr 2026 09:22:31 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 343DC4BA23F1\n\tfor ; Tue, 14 Apr 2026 23:22:29 +0000 (GMT)","from mail-wm1-f54.google.com (mail-wm1-f54.google.com\n [209.85.128.54])\n by sourceware.org (Postfix) with ESMTPS id A7E374BA2E13\n for ; Tue, 14 Apr 2026 23:14:50 +0000 (GMT)","by mail-wm1-f54.google.com with SMTP id\n 5b1f17b1804b1-488a88aeec9so82231775e9.2\n for ; Tue, 14 Apr 2026 16:14:50 -0700 (PDT)","from platypus.localdomain (176-147-231-59.abo.bbox.fr.\n [176.147.231.59]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f1dd8806sm3325945e9.3.2026.04.14.16.14.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 16:14:47 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 343DC4BA23F1","OpenDKIM Filter v2.11.0 sourceware.org A7E374BA2E13"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org A7E374BA2E13","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org A7E374BA2E13","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776208490; cv=none;\n b=EA5QwcryFn9YnnrEQgoSToK3Y5Ziof6afKK2uDs5YGM3/ub3o6qlJGBGczW1UZ/80e6KomImN/DrMb26U5AMifufKOqEf0OfCUHJ847ypIpgKjmVkxeIZ2eytU4JyLOZpeC+NAEA9n8jTgzjUIp+4Jg/jPAdQzDqaCaPCc7Fx5w=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776208490; c=relaxed/simple;\n bh=7GJ1bstVN8pXH5I29oxH71oE66pfvZJXPa0FSg28b2I=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=DeECeyn6TctL+2U20bVoWC0N8LB803aT8TgNWZlAn9TX4618CPF3xDzFSNxyvTAraUtUagTweHyETGFdAciLhAVlvTwpKydQGHoC3bWGYbiz80lmfUf6WphD/uY5oSTLQhieR8dOlK90UO6/QKE+773sLzdKRtniFRlyfWDGhPA=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776208489; x=1776813289; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LS7FV9v+qJ5FVTbMaveQvcxIa9bFNQIrSMTdN0v63kM=;\n b=RXAfTWibqTRD+GIDfGsdXgRc+PayiIG77SHfO4XhjERHiCKv5825U9y3sYXocM+RsK\n 8tzmuYL9vxlJC7n8DaeH3DrN5g3wmko4C1jkk/Nl178QUIL6NMwXgiqDPaytyYoi1q9H\n u7J2LslnNJscHk4L7SCydRqQNKS3BADtVVA1aPJEOvzTzuXk8TvLsMPfjG52sck4h/3t\n qaPllyeplA/72KpJKeAM22Ht+mzMk7YYZtuUq5TG++pqJ3bgESQLsBbKBzI3u5sMPvku\n zeS0eXcu/HISa8/XXyDV+2CQiKJGE3vOVja0JBvmo0BwaYPvUDI6nuHowLmKuE7L9rL9\n EoEw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776208489; x=1776813289;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=LS7FV9v+qJ5FVTbMaveQvcxIa9bFNQIrSMTdN0v63kM=;\n b=kulzxFmHTiGs0/SG+cCjkxF4ANPxsGA6F4SMQyEKx7I4V7aN5RbmuFcVQyl/cL4xJm\n MzGUcmvRD0pYdFhyYz3alehCRvZPTauvsAXKEcWFlKryaZJZZ1B4vpgY39PVG0CGkmWb\n +XC4eCiK1GB9Ok9PwqxEUwb9SNSlKiYp4W7BJUFAun6Vw01T09TNmlDma7cD7P0AlW1e\n 1s3UcDSV5NUj5i1mbmSbz5hE2HXRJDbCGUE+Z2oLsSfRtn2ioDpX6ug5KCIY7eDbTbH8\n RhsW/O/5XhLFc/thVjDknUua+UbnqmTE/uKMYc8SsJbUb2eE4uuPv+TKZBQau2MZqJt5\n 7mLw==","X-Gm-Message-State":"AOJu0YxU4aU1XpGPtyEctIuoKy8KutZSOniU8WCt805xD7zUW9L36ctI\n c5M+PPHcj2GR44e9m9nwEJNfoO/5WfZKKsdZcvOXEzOsXF8Ck2EFkQ8MV/KiOSTu+9Gwb1d6H2C\n 3AxnP3A==","X-Gm-Gg":"AeBDiesPurLUQl0o156tKAubAtLYGK+WYbiS/r5VlqFc0G8XsslAOWOCk6+omEyKLUq\n vF7jsgzHjg0rKCuzK2Frs5qz0phTZqvopvbGYeU+p2gEL2T6vGNN1x4wirbGfTUjJPU8R0VuLQl\n S2rZHDrWGwimiMiCplKvGl+uifZ021ZFFjXmnPDvgOmHskCYftdIjQ/GwM6DHebiqCBnraxd07D\n 0qTf3SPGU3/Zv8QFXqjmUoKh8OP3t/EryqbyooYxChaZbCQfEkA07oLZ6ug0PMdmT7/SUzGhjem\n IRAOEiN/q6ULwyievr8TtCIh0MXhym53VQ+LIVwmZg3lZ3shCzJIf+nybnKMPEnXKQQr6LtG1/z\n SkI4eFy9Y9hWjJ/h3sqULKLHHzduFtSbZKA9W5FYjGrXmY7QYeF0UG4GfVuIlbHldmuIAyke+n1\n Mv6EL4d+lnApsUf+96vcoz5ir6wOh/Fv/RfuN8LAhth6KgGA2UMc9/6LSVqXIehgAE4grBfCBr7\n mqykQ==","X-Received":"by 2002:a05:600c:c171:b0:488:a894:b27a with SMTP id\n 5b1f17b1804b1-488d67f0105mr276223325e9.8.1776208489368;\n Tue, 14 Apr 2026 16:14:49 -0700 (PDT)","From":"arthur.cohen@embecosm.com","To":"gcc-patches@gcc.gnu.org","Cc":"gcc-rust@gcc.gnu.org,\n Pierre-Emmanuel Patry ","Subject":"[COMMITTED 27/43] gccrs: Add a function for default outer attribute\n checks","Date":"Wed, 15 Apr 2026 01:18:48 +0200","Message-ID":"<20260414231905.191063-27-arthur.cohen@embecosm.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","References":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Pierre-Emmanuel Patry \n\nAdd an helper function to keep most of the attribute checking short.\n\ngcc/rust/ChangeLog:\n\n\t* checks/errors/rust-builtin-attribute-checker.cc (BuiltinAttributeChecker::visit):\n\tDeduplicate lines using the new templated function within the visitor\n\tfunctions.\n\t* checks/errors/rust-builtin-attribute-checker.h (class BuiltinAttributeChecker):\n\tCreate a new templated function that achieves the default attribute\n\tchecking operations.\n\nSigned-off-by: Pierre-Emmanuel Patry \n---\n .../errors/rust-builtin-attribute-checker.cc | 67 ++++---------------\n .../errors/rust-builtin-attribute-checker.h | 7 ++\n 2 files changed, 21 insertions(+), 53 deletions(-)","diff":"diff --git a/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc b/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc\nindex 8cb251f7686..a2bf83f93cd 100644\n--- a/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc\n+++ b/gcc/rust/checks/errors/rust-builtin-attribute-checker.cc\n@@ -367,28 +367,19 @@ BuiltinAttributeChecker::visit (AST::Attribute &attribute)\n void\n BuiltinAttributeChecker::visit (AST::Module &module)\n {\n- for (auto &attr : module.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, module);\n-\n- AST::DefaultASTVisitor::visit (module);\n+ default_outer_attribute_check (module);\n }\n \n void\n-BuiltinAttributeChecker::visit (AST::ExternCrate &crate)\n+BuiltinAttributeChecker::visit (AST::ExternCrate &extern_crate)\n {\n- for (auto &attr : crate.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, crate);\n-\n- AST::DefaultASTVisitor::visit (crate);\n+ default_outer_attribute_check (extern_crate);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::UseDeclaration &declaration)\n {\n- for (auto &attr : declaration.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, declaration);\n-\n- AST::DefaultASTVisitor::visit (declaration);\n+ default_outer_attribute_check (declaration);\n }\n \n void\n@@ -492,55 +483,37 @@ BuiltinAttributeChecker::visit (AST::Function &function)\n void\n BuiltinAttributeChecker::visit (AST::TypeAlias &alias)\n {\n- for (auto &attr : alias.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, alias);\n-\n- AST::DefaultASTVisitor::visit (alias);\n+ default_outer_attribute_check (alias);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::StructStruct &struct_item)\n {\n- for (auto &attr : struct_item.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, struct_item);\n-\n- AST::DefaultASTVisitor::visit (struct_item);\n+ default_outer_attribute_check (struct_item);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::TupleStruct &tuple_struct)\n {\n- for (auto &attr : tuple_struct.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, tuple_struct);\n-\n- AST::DefaultASTVisitor::visit (tuple_struct);\n+ default_outer_attribute_check (tuple_struct);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::Enum &enumeration)\n {\n- for (auto &attr : enumeration.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, enumeration);\n-\n- AST::DefaultASTVisitor::visit (enumeration);\n+ default_outer_attribute_check (enumeration);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::Union &u)\n {\n- for (auto &attr : u.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, u);\n-\n- AST::DefaultASTVisitor::visit (u);\n+ default_outer_attribute_check (u);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::ConstantItem &item)\n {\n- for (auto &attr : item.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, item);\n-\n- AST::DefaultASTVisitor::visit (item);\n+ default_outer_attribute_check (item);\n }\n \n void\n@@ -565,37 +538,25 @@ BuiltinAttributeChecker::visit (AST::StaticItem &item)\n void\n BuiltinAttributeChecker::visit (AST::Trait &trait)\n {\n- for (auto &attr : trait.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, trait);\n-\n- AST::DefaultASTVisitor::visit (trait);\n+ default_outer_attribute_check (trait);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::InherentImpl &impl)\n {\n- for (auto &attr : impl.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, impl);\n-\n- AST::DefaultASTVisitor::visit (impl);\n+ default_outer_attribute_check (impl);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::TraitImpl &impl)\n {\n- for (auto &attr : impl.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, impl);\n-\n- AST::DefaultASTVisitor::visit (impl);\n+ default_outer_attribute_check (impl);\n }\n \n void\n BuiltinAttributeChecker::visit (AST::ExternBlock &block)\n {\n- for (auto &attr : block.get_outer_attrs ())\n- check_valid_attribute_for_item (attr, block);\n-\n- AST::DefaultASTVisitor::visit (block);\n+ default_outer_attribute_check (block);\n }\n \n } // namespace Analysis\ndiff --git a/gcc/rust/checks/errors/rust-builtin-attribute-checker.h b/gcc/rust/checks/errors/rust-builtin-attribute-checker.h\nindex 6717de8abf6..957243a1a21 100644\n--- a/gcc/rust/checks/errors/rust-builtin-attribute-checker.h\n+++ b/gcc/rust/checks/errors/rust-builtin-attribute-checker.h\n@@ -28,6 +28,13 @@ class BuiltinAttributeChecker : public AST::DefaultASTVisitor\n {\n using AST::DefaultASTVisitor::visit;\n \n+ template void default_outer_attribute_check (I item)\n+ {\n+ for (auto &attr : item.get_outer_attrs ())\n+ check_valid_attribute_for_item (attr, item);\n+ AST::DefaultASTVisitor::visit (item);\n+ }\n+\n public:\n BuiltinAttributeChecker ();\n void go (AST::Crate &crate);\n","prefixes":["COMMITTED","27/43"]}