{"id":2223282,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2223282/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-20-arthur.cohen@embecosm.com/","project":{"id":17,"url":"http://patchwork.ozlabs.org/api/1.2/projects/17/?format=json","name":"GNU Compiler Collection","link_name":"gcc","list_id":"gcc-patches.gcc.gnu.org","list_email":"gcc-patches@gcc.gnu.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414231905.191063-20-arthur.cohen@embecosm.com>","list_archive_url":null,"date":"2026-04-14T23:18:41","name":"[COMMITTED,20/43] gccrs: rust: Fix ICE in function_set_parameters","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"93493f4e6fbdef22ed190b26620e64daad1049c8","submitter":{"id":83476,"url":"http://patchwork.ozlabs.org/api/1.2/people/83476/?format=json","name":"Arthur Cohen","email":"arthur.cohen@embecosm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/gcc/patch/20260414231905.191063-20-arthur.cohen@embecosm.com/mbox/","series":[{"id":499900,"url":"http://patchwork.ozlabs.org/api/1.2/series/499900/?format=json","web_url":"http://patchwork.ozlabs.org/project/gcc/list/?series=499900","date":"2026-04-14T23:18:24","name":"[COMMITTED,01/43] gccrs: testsuite:Add a testcase for setup_associated_types","version":1,"mbox":"http://patchwork.ozlabs.org/series/499900/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223282/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2223282/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=GJGtPgrM;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=embecosm.com header.i=@embecosm.com header.a=rsa-sha256\n header.s=google header.b=GJGtPgrM","sourceware.org;\n dmarc=none (p=none dis=none) header.from=embecosm.com","sourceware.org; spf=pass smtp.mailfrom=embecosm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=209.85.128.67"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwKzX1ZDHz1yHM\n\tfor ; Wed, 15 Apr 2026 09:21:44 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 6C1704BA23D7\n\tfor ; Tue, 14 Apr 2026 23:21:42 +0000 (GMT)","from mail-wm1-f67.google.com (mail-wm1-f67.google.com\n [209.85.128.67])\n by sourceware.org (Postfix) with ESMTPS id 2B09D4BA23F9\n for ; Tue, 14 Apr 2026 23:14:39 +0000 (GMT)","by mail-wm1-f67.google.com with SMTP id\n 5b1f17b1804b1-488c2690057so61657175e9.0\n for ; Tue, 14 Apr 2026 16:14:39 -0700 (PDT)","from platypus.localdomain (176-147-231-59.abo.bbox.fr.\n [176.147.231.59]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488f1dd8806sm3325945e9.3.2026.04.14.16.14.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 14 Apr 2026 16:14:36 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 6C1704BA23D7","OpenDKIM Filter v2.11.0 sourceware.org 2B09D4BA23F9"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 2B09D4BA23F9","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 2B09D4BA23F9","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776208479; cv=none;\n b=oWgOtCAm4aErga3gu5cu9cKQo3fZxTp4p5UZmLzUlTFgVmmxP/qDOPmQxjtyc1VmTfSjMGGiPbOs0YZjNNdjhDZde1ZIpmbLU3ACVDlRSJ7A3TaOlhv6YOZkTld40QYO4dwQW0MDaZT/5SYhfI9njLdj2Ha9/LGQ1XEQhK/pYa4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776208479; c=relaxed/simple;\n bh=zkelL4lZbhDoLKx6jIpJJ/QcfuipEDEdnOg2iGKCSKw=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=EHtQI5WcOfRDC9o5amtNsT62M921jUjT/xWuyD05IHrHwNuTBUc2hrWGjkHVHfC5+AGU/eJYiRkYdW5KaKmOMRcqVecvjFR0ScDznjpt5EaWJhsL9lBhFNCcuEihVPdt3KoEOMKINLN0QThMx+m19/bMz6GW8yxK+5mZzcq7rpI=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=embecosm.com; s=google; t=1776208478; x=1776813278; darn=gcc.gnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=oCmliMJ/Ds1t6sBwHd3uVPS1i6pTpJNfQIgD4Fsljkc=;\n b=GJGtPgrMWknh13ZPjQWEe9auEnC06MXHImpqXkWvOQN1WfxI/Q1iN/Plm2ROAfgeMA\n hiGI3W3D+c/v6IsEhyej3N2fnLQ9v633oDZq591ehDF+8d4UDeFib9Md7nDG1i2mugCd\n d3tTfZorRVKd8mpFXZgB/ugGOwdIyA86cgg+4PCkgiTawNuGGbiYnbGlHIeVefwqT/ws\n j4wit9rmwEZdKiQsdKzE7R3hT//SSB8FBKe4WpWGGRwF6fuRMjmfL8/uHIfwyD0NAQBt\n CQJJghL/fx8wky4w9tURcRw11btDWt3PsbRrB2RNBC/yxS1cj6JvlPF83r6mRjPLGJpL\n cdqQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776208478; x=1776813278;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=oCmliMJ/Ds1t6sBwHd3uVPS1i6pTpJNfQIgD4Fsljkc=;\n b=q7rKkdW0g6BW9W37t60YaC6Vfilo+oRp7hymtPPufLX63C3hPAiD0zRH77O/9gGg2E\n nvybeBCkuqCAPhVvmBEPwerHZtKyIvzlOSgQM60ycg9CgwN1CV5gYlyTaBBocfHfWxpP\n jqw6hT1ReyX1JcGymedqu3loSoBA+PPL4fOtWLDMxouzI5tKJMrmxLikVkLZCW1fYJyI\n viY9X6dpU84mVR5fP708hW8EiffxPnyF99MDtyRtVwSLG7TfV6KK7F4Xk99jOs4eCBMP\n 3Go68og3d1M5+k4+1cI9E0QeGplrUv0XnvFeniJdX3Kh0rfG0hW2nQLu5aQjab83tKWW\n rCtg==","X-Gm-Message-State":"AOJu0YzaoZLuMUt/KJqxuxBEs2Ta7mvjelpmDsLta/winI7mRD8QVIh1\n AbeYzjCTpuz5E8O6bmZ0/sh1V4OIEgo887tpfG0cDL8dcNwCzABCxRDLfg1ofqee8Csgk7hoTO6\n 6Et/gm+Et","X-Gm-Gg":"AeBDiesZT8/qaHzb9FKH5RqZrCIJX3FtbdXmPcDMvaejxEg23RmhJLu2cJNINUd1VuE\n SeHC0BXKJ36VhsZx3pcCv5h7VHWEjCBPjJg++LWiRaBnMAmFjjtJTVnujNDsewbBPcMhOJprp8R\n FtVTRFZWYVfn+G9HHzrWnjMcT4Mp6OIfru5ba6DnchaC/1hTnkvcIFpz4Yn4erALAaBTEuKX7bG\n jhZXC2ceCWFxqPpsbsAWIwNkU2abRkVSe7r7btqVQ8YraRgrRmCo+bggzsEr/rbkiGvafllDdTB\n xr0pu37bHxNw5Wdz9bZf4k2M6N3THXphy4FTMOmrd8iK3OuoKRfJAwDX/fKbTPIUbQsXw0jzKzr\n IZQKihWV8i/O1sYYFiPXwXsv8fqCG3y8uwxY2GFlRHu00RJ2GWKbsfNx+dJt2M1StKwfhTvzzdj\n 7gOWkdDJRDZLjBKzhR9isyRrvYeL76KJ+iP8tIkpLzLKTgFSeYXX6WyX20O4vcKNdz+xg1iWvF7\n /wb4REV8OJXYNP7","X-Received":"by 2002:a05:600c:4e4d:b0:485:3193:6ddb with SMTP id\n 5b1f17b1804b1-488d6808507mr268667675e9.3.1776208477771;\n Tue, 14 Apr 2026 16:14:37 -0700 (PDT)","From":"arthur.cohen@embecosm.com","To":"gcc-patches@gcc.gnu.org","Cc":"gcc-rust@gcc.gnu.org,\n\tEgas Ribeiro ","Subject":"[COMMITTED 20/43] gccrs: rust: Fix ICE in function_set_parameters","Date":"Wed, 15 Apr 2026 01:18:41 +0200","Message-ID":"<20260414231905.191063-20-arthur.cohen@embecosm.com>","X-Mailer":"git-send-email 2.50.1","In-Reply-To":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","References":"<20260414231905.191063-1-arthur.cohen@embecosm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"},"content":"From: Egas Ribeiro \n\nWhen lowering a function to HIR with a refutable pattern in its\nparameter pattern, we were ICE'ing due to a lack of checks for invalid\nrefutable patterns. Fix this by erroring on invalid patterns while\nlowering a function.\n\n\tFixes Rust-GCC/gccrs#3919\n\ngcc/rust/ChangeLog:\n\n\t* hir/rust-ast-lower-item.cc (ASTLoweringItem::visit): added\n\trefutable pattern checks for function params.\n\ngcc/testsuite/ChangeLog:\n\n\t* rust/compile/issue-3919-ice-func-parms.rs: New test.\n\nSigned-off-by: Egas Ribeiro \n---\n gcc/rust/hir/rust-ast-lower-item.cc | 19 +++++++++++++++++++\n .../rust/compile/issue-3919-ice-func-parms.rs | 4 ++++\n 2 files changed, 23 insertions(+)\n create mode 100644 gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs","diff":"diff --git a/gcc/rust/hir/rust-ast-lower-item.cc b/gcc/rust/hir/rust-ast-lower-item.cc\nindex 2d3d021f837..96b6aefbc6a 100644\n--- a/gcc/rust/hir/rust-ast-lower-item.cc\n+++ b/gcc/rust/hir/rust-ast-lower-item.cc\n@@ -455,6 +455,25 @@ ASTLoweringItem::visit (AST::Function &function)\n \n auto translated_pattern = std::unique_ptr (\n \tASTLoweringPattern::translate (param.get_pattern ()));\n+\n+ switch (param.get_pattern ().get_pattern_kind ())\n+\t{\n+\tcase AST::Pattern::Kind::Identifier:\n+\tcase AST::Pattern::Kind::Wildcard:\n+\tcase AST::Pattern::Kind::Tuple:\n+\tcase AST::Pattern::Kind::Struct:\n+\tcase AST::Pattern::Kind::TupleStruct:\n+\tcase AST::Pattern::Kind::Reference:\n+\tcase AST::Pattern::Kind::Grouped:\n+\tcase AST::Pattern::Kind::Slice:\n+\tcase AST::Pattern::Kind::Rest:\n+\t break;\n+\tdefault:\n+\t rust_error_at (param.get_locus (),\n+\t\t\t \"refutable pattern in function argument\");\n+\t continue;\n+\t}\n+\n auto translated_type = std::unique_ptr (\n \tASTLoweringType::translate (param.get_type ()));\n \ndiff --git a/gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs b/gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs\nnew file mode 100644\nindex 00000000000..3305762bbb9\n--- /dev/null\n+++ b/gcc/testsuite/rust/compile/issue-3919-ice-func-parms.rs\n@@ -0,0 +1,4 @@\n+#![feature(no_core)]\n+#![no_core]\n+\n+fn func(1: i32) {} // { dg-error \"refutable pattern in function argument\" }\n","prefixes":["COMMITTED","20/43"]}