{"id":2223118,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2223118/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/patch/20260414134043.924997-2-dceara@redhat.com/","project":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/projects/68/?format=json","name":"Open Virtual Network development","link_name":"ovn","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260414134043.924997-2-dceara@redhat.com>","list_archive_url":null,"date":"2026-04-14T13:40:40","name":"[ovs-dev,1/4] northd: Fix other_config init in incremental LS processing.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a2a4f216c78bea0bec88bfbb819db21f2cb15570","submitter":{"id":76591,"url":"http://patchwork.ozlabs.org/api/1.2/people/76591/?format=json","name":"Dumitru Ceara","email":"dceara@redhat.com"},"delegate":{"id":132642,"url":"http://patchwork.ozlabs.org/api/1.2/users/132642/?format=json","username":"amusil","first_name":"Ales","last_name":"Musil","email":"amusil@redhat.com"},"mbox":"http://patchwork.ozlabs.org/project/ovn/patch/20260414134043.924997-2-dceara@redhat.com/mbox/","series":[{"id":499847,"url":"http://patchwork.ozlabs.org/api/1.2/series/499847/?format=json","web_url":"http://patchwork.ozlabs.org/project/ovn/list/?series=499847","date":"2026-04-14T13:40:39","name":"Fix conntrack handling for traffic to/from EVPN vteps.","version":1,"mbox":"http://patchwork.ozlabs.org/series/499847/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2223118/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2223118/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ovs-dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=O59TNA3U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp1.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key)\n header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=O59TNA3U","smtp3.osuosl.org; dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp3.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=O59TNA3U"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw55x0sZBz1xtJ\n\tfor ; Tue, 14 Apr 2026 23:41:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 0B72D84975;\n\tTue, 14 Apr 2026 13:41:23 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id S_MCvnp0M2g3; Tue, 14 Apr 2026 13:41:22 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp1.osuosl.org (Postfix) with ESMTPS id 096C6848D6;\n\tTue, 14 Apr 2026 13:41:22 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 01231C054A;\n\tTue, 14 Apr 2026 13:41:22 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 641D9C0549\n for ; Tue, 14 Apr 2026 13:41:21 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 5657761B82\n for ; Tue, 14 Apr 2026 13:41:21 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hWswHqbLxPmX for ;\n Tue, 14 Apr 2026 13:41:20 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 46F6661C14\n for ; Tue, 14 Apr 2026 13:41:20 +0000 (UTC)","from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-9-qhJ5tezlM92Ddew7Hcd5OA-1; Tue,\n 14 Apr 2026 09:41:17 -0400","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id E6E171955F2C\n for ; Tue, 14 Apr 2026 13:41:16 +0000 (UTC)","from cecil-rh.redhat.com (unknown [10.44.33.229])\n by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 3F87A19560AB; Tue, 14 Apr 2026 13:41:14 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 096C6848D6","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 46F6661C14"],"Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=dceara@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 46F6661C14","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776174079;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=bqZqYTeSlju//Ogg3bVd535FcvnnM4uT2AffKxf8Qc8=;\n b=O59TNA3UTapCtNII90zX8HJFOLnuIFPeJLX/T0rIW0xNpMdKlAt0BzZziwNSdoRm+uRpy8\n ZbggZp7aZ8eAatUQys92z8h63QRD90Xq3FdzLtmVvY0NGg4WLYsqW05cyy4EKDSer7BNFy\n PKpL05rkl+SE8WMQhwZOqln+PbOy+lE=","X-MC-Unique":"qhJ5tezlM92Ddew7Hcd5OA-1","X-Mimecast-MFC-AGG-ID":"qhJ5tezlM92Ddew7Hcd5OA_1776174077","To":"ovs-dev@openvswitch.org","Date":"Tue, 14 Apr 2026 15:40:40 +0200","Message-ID":"<20260414134043.924997-2-dceara@redhat.com>","In-Reply-To":"<20260414134043.924997-1-dceara@redhat.com>","References":"<20260414134043.924997-1-dceara@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"TFUlgkR1fbHiKkVliC0OiNNXXL6GDk2CTlv_cIkSMak_1776174077","X-Mimecast-Originator":"redhat.com","Subject":"[ovs-dev] [PATCH ovn 1/4] northd: Fix other_config init in\n incremental LS processing.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Dumitru Ceara via dev ","Reply-To":"Dumitru Ceara ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"northd_handle_ls_changes() failed to initialize lb_with_stateless_mode\nand has_evpn_vni when a new logical switch was created incrementally.\nThese fields are derived from NB other_config and were only initialized\nin the full recompute path (build_datapaths()).\n\nExtract init_ls_other_config() and call it from both paths so that\ncreating a logical switch with dynamic-routing-vni or\nenable-stateless-acl-with-lb set in the same transaction produces\ncorrect flows.\n\nFixes: 06e2c1bf0ce7 (\"northd: I-P for logical switch creation/deletion in en_northd.\")\nAssisted-by: Claude, with model: claude-opus-4-6\nSigned-off-by: Dumitru Ceara \n---\n northd/northd.c | 23 ++++++++++-------\n tests/ovn-northd.at | 60 +++++++++++++++++++++++++++++++++++++++++++++\n 2 files changed, 74 insertions(+), 9 deletions(-)","diff":"diff --git a/northd/northd.c b/northd/northd.c\nindex 0d133c62c2..6a8d0c311a 100644\n--- a/northd/northd.c\n+++ b/northd/northd.c\n@@ -923,6 +923,18 @@ ods_assign_array_index(struct ovn_datapaths *datapaths,\n od->datapaths = datapaths;\n }\n \n+static void\n+init_ls_other_config(struct ovn_datapath *od)\n+{\n+ od->lb_with_stateless_mode =\n+ smap_get_bool(&od->nbs->other_config,\n+ \"enable-stateless-acl-with-lb\", false);\n+\n+ int64_t vni = ovn_smap_get_llong(&od->nbs->other_config,\n+ \"dynamic-routing-vni\", -1);\n+ od->has_evpn_vni = ovn_is_valid_vni(vni);\n+}\n+\n /* Initializes 'ls_datapaths' to contain a \"struct ovn_datapath\" for every\n * logical switch, and initializes 'lr_datapaths' to contain a\n * \"struct ovn_datapath\" for every logical router.\n@@ -940,15 +952,7 @@ build_datapaths(const struct ovn_synced_logical_switch_map *ls_map,\n &ls->nb->header_.uuid,\n ls->nb, NULL, ls->sdp);\n init_ipam_info_for_datapath(od);\n- if (smap_get_bool(&od->nbs->other_config,\n- \"enable-stateless-acl-with-lb\",\n- false)) {\n- od->lb_with_stateless_mode = true;\n- }\n-\n- int64_t vni = ovn_smap_get_llong(&od->nbs->other_config,\n- \"dynamic-routing-vni\", -1);\n- od->has_evpn_vni = ovn_is_valid_vni(vni);\n+ init_ls_other_config(od);\n }\n \n struct ovn_synced_logical_router *lr;\n@@ -5133,6 +5137,7 @@ northd_handle_ls_changes(struct ovsdb_idl_txn *ovnsb_idl_txn,\n \n ods_assign_array_index(&nd->ls_datapaths, od);\n init_ipam_info_for_datapath(od);\n+ init_ls_other_config(od);\n init_mcast_info_for_datapath(od);\n \n /* Create SB:IP_Multicast for the logical switch. */\ndiff --git a/tests/ovn-northd.at b/tests/ovn-northd.at\nindex 7c2f53da69..624e08c1df 100644\n--- a/tests/ovn-northd.at\n+++ b/tests/ovn-northd.at\n@@ -18897,6 +18897,66 @@ OVN_CLEANUP_NORTHD\n AT_CLEANUP\n ])\n \n+OVN_FOR_EACH_NORTHD_NO_HV([\n+AT_SETUP([LS incremental processing - other_config fields])\n+AT_KEYWORDS([ovn, incremental])\n+ovn_start\n+\n+dnl Test that has_evpn_vni and lb_with_stateless_mode are properly\n+dnl initialized when a logical switch is created incrementally (i.e.,\n+dnl created with other_config set in the same transaction).\n+\n+AS_BOX([has_evpn_vni initialized during incremental LS creation])\n+dnl Create the switch with dynamic-routing-vni in the SAME transaction\n+dnl to exercise the incremental code path in northd_handle_ls_changes().\n+check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats\n+check ovn-nbctl --wait=sb \\\n+ -- ls-add ls-evpn \\\n+ -- set logical_switch ls-evpn other_config:dynamic-routing-vni=10 \\\n+ -- lsp-add ls-evpn lsp0 \\\n+ -- lsp-set-addresses lsp0 \"00:00:00:00:00:01 10.0.0.1\"\n+\n+dnl The northd engine node must not recompute; this proves the\n+dnl incremental code path (northd_handle_ls_changes) was used.\n+check_engine_stats northd norecompute compute\n+\n+ovn-sbctl dump-flows ls-evpn > lflows\n+\n+dnl When has_evpn_vni is true, the l2_lkup flow should include\n+dnl get_remote_fdb in addition to get_fdb.\n+AT_CHECK([grep 'ls_in_l2_lkup' lflows | grep \"get_fdb\" | ovn_strip_lflows], [0], [dnl\n+ table=??(ls_in_l2_lkup ), priority=0 , match=(1), action=(outport = get_fdb(eth.dst); remote_outport = get_remote_fdb(eth.dst); next;)\n+])\n+\n+AS_BOX([lb_with_stateless_mode initialized during incremental LS creation])\n+dnl Create the switch with enable-stateless-acl-with-lb in the SAME\n+dnl transaction to exercise the incremental code path.\n+check as northd ovn-appctl -t ovn-northd inc-engine/clear-stats\n+check ovn-nbctl --wait=sb \\\n+ -- ls-add ls-stateless \\\n+ -- set logical_switch ls-stateless other_config:enable-stateless-acl-with-lb=true \\\n+ -- lsp-add ls-stateless lsp1 \\\n+ -- lsp-set-addresses lsp1 \"00:00:00:00:00:02 10.0.0.2\"\n+\n+dnl The northd engine node must not recompute; this proves the\n+dnl incremental code path (northd_handle_ls_changes) was used.\n+check_engine_stats northd norecompute compute\n+\n+check ovn-nbctl lb-add lb1 10.0.0.100:80 10.0.0.2:80\n+check ovn-nbctl ls-lb-add ls-stateless lb1\n+check ovn-nbctl --wait=sb acl-add ls-stateless from-lport 100 \"ip\" allow-related\n+\n+ovn-sbctl dump-flows ls-stateless > lflows\n+\n+dnl With lb_with_stateless_mode, the priority 65532 drop rule in acl_eval\n+dnl should NOT contain ct.inv. It should match only\n+dnl (ct.est && ct.rpl && ct_mark.blocked == 1).\n+AT_CHECK([grep 'ls_in_acl_eval' lflows | grep 'priority=65532' | grep -q 'ct.inv'], [1])\n+\n+OVN_CLEANUP_NORTHD\n+AT_CLEANUP\n+])\n+\n OVN_FOR_EACH_NORTHD_NO_HV([\n AT_SETUP([Check network function])\n ovn_start\n","prefixes":["ovs-dev","1/4"]}