{"id":2222644,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222644/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20260413-linux-werror-v2-1-e29e45398c56@cherry.de/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/1.2/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413-linux-werror-v2-1-e29e45398c56@cherry.de>","list_archive_url":null,"date":"2026-04-13T09:08:27","name":"[v2] Revert \"linux: disable -Werror\"","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9a50dfea8a41f2470078afd6f3b6b55fc7a7896a","submitter":{"id":83602,"url":"http://patchwork.ozlabs.org/api/1.2/people/83602/?format=json","name":"Quentin Schulz","email":"foss+buildroot@0leil.net"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20260413-linux-werror-v2-1-e29e45398c56@cherry.de/mbox/","series":[{"id":499671,"url":"http://patchwork.ozlabs.org/api/1.2/series/499671/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=499671","date":"2026-04-13T09:08:27","name":"[v2] Revert \"linux: disable -Werror\"","version":2,"mbox":"http://patchwork.ozlabs.org/series/499671/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222644/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222644/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming-buildroot@patchwork.ozlabs.org","buildroot@buildroot.org"],"Delivered-To":["patchwork-incoming-buildroot@legolas.ozlabs.org","buildroot@buildroot.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=rYbeKq49;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvM5w0fVjz1yDG\n\tfor ;\n Mon, 13 Apr 2026 19:08:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 28FBD84494;\n\tMon, 13 Apr 2026 09:08:49 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id empbi85yCxvp; Mon, 13 Apr 2026 09:08:47 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id E750084060;\n\tMon, 13 Apr 2026 09:08:46 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 55018283\n for ; Mon, 13 Apr 2026 09:08:45 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 52206608DA\n for ; Mon, 13 Apr 2026 09:08:45 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 4k3oNjP6Y5nd for ;\n Mon, 13 Apr 2026 09:08:44 +0000 (UTC)","from smtp-8fa9.mail.infomaniak.ch (smtp-8fa9.mail.infomaniak.ch\n [83.166.143.169])\n by smtp3.osuosl.org (Postfix) with ESMTPS id D8170608D4\n for ; Mon, 13 Apr 2026 09:08:42 +0000 (UTC)","from smtp-4-0001.mail.infomaniak.ch (unknown\n [IPv6:2001:1600:7:10::a6c])\n by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fvM5g5bpKzqhd;\n Mon, 13 Apr 2026 11:08:39 +0200 (CEST)","from unknown by smtp-4-0001.mail.infomaniak.ch (Postfix) with ESMTPA\n id 4fvM5g1bPfz4V5; Mon, 13 Apr 2026 11:08:39 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org E750084060","OpenDKIM Filter v2.11.0 smtp3.osuosl.org D8170608D4"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1776071327;\n\tbh=+0Vls6bedi5Ky6A2Q7MDzuMTKosIl6qd/+3VJoKPsv0=;\n\th=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\t List-Help:List-Subscribe:From:Reply-To:Cc:From;\n\tb=rYbeKq49aTtQNxd1+Rf8q2iMw4MrR7ljahKKws6ou5fVlnSTqxvQQrY4yzaUTdMU8\n\t CjAObNjOw3usAhS9OvnhlrLnewGzzNKqZIEWu84RXyqaGn9V3fbBuEhNleXa/PQsoo\n\t b7Gmr2IV9LUafbi3i9OHtvgCtCTrdeghVFzoFshb43VnURTbxUIi1r6kXcEvGKcLyJ\n\t aL9LIqiszj1iQ4Gzv83ioC548FA9JwmtlVknOYbsL7uH4TTNt7GXgpzl+rSR49usek\n\t uAcEks8aN8QQSHBgLYyW+0A9p0c0R8Mwez9RXbRsMFbjJoxc714xiqm/eEHLN3wPOq\n\t Sp58FC2YFeGdw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=83.166.143.169;\n helo=smtp-8fa9.mail.infomaniak.ch; envelope-from=foss+buildroot@0leil.net;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org D8170608D4","Date":"Mon, 13 Apr 2026 11:08:27 +0200","MIME-Version":"1.0","Message-Id":"<20260413-linux-werror-v2-1-e29e45398c56@cherry.de>","X-B4-Tracking":"v=1; b=H4sIAAAAAAAC/3WNwQ6CMBBEf4Xs2RpYKxFP/ofhAO1W1hgwW6gQw\n r/b4tnjy8y8WcGTMHm4ZisIBfY89BHwkIHpmv5Bim1kwBzL/IRn9eJ+mtWHRAZRlStJN1brNnc\n QJ28hx/Ouu9c/9lP7JDMmR2p07MdBlv0vFKn3Rx0KVShsq4tz2KCx9ma6mCxHS1Bv2/YFoAUX7\n 7oAAAA=","X-Change-ID":"20260325-linux-werror-9f6e4ad44b0f","To":"buildroot@buildroot.org","X-Mailer":"b4 0.15-dev-47773","X-Infomaniak-Routing":"alpha","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=0leil.net; s=20231125; t=1776071319;\n bh=xxna9uscV0fSFyBQ5BBxxQ3LDR7RG+hyiUIjPA97rro=;\n h=From:Date:Subject:To:Cc:From;\n b=RbcRSjSDyMkpMMP0UzgXWySV2hGinWPoW2IB1+HrDtG5PzmsdVkK3WzUfLaZKEvLQ\n EJOzwFGDBHTqmFToWI7HSFP/2A9CCrlQC9Byl2q9tYjKduUWAb68hngVVG5ZfZcJA9\n Gn5CXxKgLfx7sehrkglVUHXd2Fa7l6Y1+VDoNUFIRudbIHn9mrV1glK9oXjT94sRk0\n l5zy/OGohx1rpG99wvLTkyl7s5xn20u4Bpz6/P7y/ITKXIgvfprHJFCI813OTrKr5F\n aT+uDme6kgUgFaT3ofZB46nbKWF0I1EfVm4BS8Ki16K3BP5D5UfOUuXuZTmFrR7CR8\n FPbOeTitaZE2w==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=reject dis=none)\n header.from=0leil.net","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=0leil.net header.i=@0leil.net header.a=rsa-sha256\n header.s=20231125 header.b=RbcRSjSD"],"Subject":"[Buildroot] [PATCH v2] Revert \"linux: disable -Werror\"","X-BeenThere":"buildroot@buildroot.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","From":"Quentin Schulz via buildroot ","Reply-To":"Quentin Schulz ","Cc":"Quentin Schulz ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@buildroot.org","Sender":"\"buildroot\" "},"content":"From: Quentin Schulz \n\nThis reverts commit 6b56e0b4f09b36140e2cb9e41072d5ac6074f375.\n\ncommit 6b56e0b4f09b (\"linux: disable -Werror\") said we needed to disable\nCONFIG_WERROR in the kernel because it failed to build the esp-hosted\nkernel module. This was very much the hammer approach because a) it'd be\nbetter to fix the warnings in the kernel module or b) disable the\nkernel's CONFIG_WERROR *only* if esp-hosted is to be built, via the\nESP_HOSTED_LINUX_CONFIG_FIXUPS variable in\npackage/esp-hosted/esp-hosted.mk.\n\nThis is a simple revert without making any change to any kernel module\n(including esp-hosted) because all upstream Buildroot defconfigs with a\nkernel module enabled build fine today (albeit with warnings). The two\ndefconfigs that were pointed at by the now-reverted commit all have been\n(updated for and) run on master without failing the build.\n\nSuggested-by: Arnout Vandecappelle \nSigned-off-by: Quentin Schulz \n---\nI've rebuilt the kernel of all 307 upstream Buildroot defconfigs which\nselects the Linux kernel with:\n\nfor defconfig in $(git grep -l LINUX_KERNEL configs/); do\n d=$(basename \"$defconfig\")\n make O=build/$d $d | tee -a log.txt\n make O=build/$d linux | tee -a log.txt || break\n rm -rf build/$d\ndone\n\nand the loop didn't exit early and log.txt didn't contain any error: (or\neven warning: or ^^^ lines, which is surprising...).\n\nI also built the kernel modules of the couple of upstream Buildroot\ndefconfigs that build some modules, identified with:\n\nfor module in $(git grep -l --full-name kernel-module package/ | xargs basename -a | grep '.mk' | xargs basename -a -s .mk | sed 's/-/_/g' | tr '[:lower:]' '[:upper:]' | sed 's/\\(.*\\)/BR2_PACKAGE_\\1/'); do\n git grep $module configs\ndone\n\nwhich returns:\nconfigs/orangepi_lite_defconfig:BR2_PACKAGE_RTL8189FS=y\nconfigs/orangepi_pc_plus_defconfig:BR2_PACKAGE_RTL8189FS=y\nconfigs/mangopi_mq1rdw2_defconfig:BR2_PACKAGE_RTL8723DS=y\nconfigs/sipeed_lichee_rv_dock_defconfig:BR2_PACKAGE_RTL8723DS=y\nconfigs/sipeed_lichee_rv_dock_defconfig:BR2_PACKAGE_RTL8723DS_BT=y\nconfigs/orangepi_zero_defconfig:BR2_PACKAGE_XR819_XRADIO=y\n\nand while there were warnings, they don't fail the build of the kernel\nmodule(s) for those defconfigs. No available updates for all kernel\nmodules I built, as far as I could tell.\n---\nChanges in v2:\n- changed implementation: simply revert commit 6b56e0b4f09b instead of\n adding yet another Kconfig knob,\n- Link to v1: https://patch.msgid.link/20260325-linux-werror-v1-1-2b98ff2a2cdd@cherry.de\n---\n linux/linux.mk | 1 -\n 1 file changed, 1 deletion(-)\n\n\n---\nbase-commit: c8dd9e9a011f1a5755df62baceb865efc09862fe\nchange-id: 20260325-linux-werror-9f6e4ad44b0f\n\nBest regards,\n-- \nQuentin Schulz ","diff":"diff --git a/linux/linux.mk b/linux/linux.mk\nindex c61089bfe0..79117275f7 100644\n--- a/linux/linux.mk\n+++ b/linux/linux.mk\n@@ -474,7 +474,6 @@ define LINUX_KCONFIG_FIXUP_CMDS\n \t\t$(call KCONFIG_ENABLE_OPT,CONFIG_LOGO)\n \t\t$(call KCONFIG_ENABLE_OPT,CONFIG_LOGO_LINUX_CLUT224))\n \t$(call KCONFIG_DISABLE_OPT,CONFIG_GCC_PLUGINS)\n-\t$(call KCONFIG_DISABLE_OPT,CONFIG_WERROR)\n \t$(PACKAGES_LINUX_CONFIG_FIXUPS)\n endef\n \n","prefixes":["v2"]}