{"id":2222643,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222643/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413090010.60339-1-anisinha@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413090010.60339-1-anisinha@redhat.com>","list_archive_url":null,"date":"2026-04-13T09:00:10","name":"[for-11.0] accel/kvm: return early from kvm_irqchip_create if kvm does not support irqchip","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a3e8bcf5c6edab4d9a11db372559c55f21a1225b","submitter":{"id":86030,"url":"http://patchwork.ozlabs.org/api/1.2/people/86030/?format=json","name":"Ani Sinha","email":"anisinha@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260413090010.60339-1-anisinha@redhat.com/mbox/","series":[{"id":499670,"url":"http://patchwork.ozlabs.org/api/1.2/series/499670/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499670","date":"2026-04-13T09:00:10","name":"[for-11.0] accel/kvm: return early from kvm_irqchip_create if kvm does not support irqchip","version":1,"mbox":"http://patchwork.ozlabs.org/series/499670/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222643/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222643/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=O6F+Ma0N;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=hQQjrb6a;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvLxd5CZPz1yDG\n\tfor ; Mon, 13 Apr 2026 19:01:40 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCDA4-00027o-KG; Mon, 13 Apr 2026 05:00:52 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCDA3-00027g-Ds\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:00:51 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCDA1-00044K-GO\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:00:51 -0400","from mail-pj1-f71.google.com (mail-pj1-f71.google.com\n [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-356-LcRD21PIOtmgB1s2Opz-eg-1; Mon, 13 Apr 2026 05:00:45 -0400","by mail-pj1-f71.google.com with SMTP id\n 98e67ed59e1d1-358e95e81aeso8756499a91.0\n for ; Mon, 13 Apr 2026 02:00:45 -0700 (PDT)","from localhost.localdomain ([122.163.114.34])\n by smtp.googlemail.com with ESMTPSA id\n 98e67ed59e1d1-35fb38eb48bsm3560588a91.2.2026.04.13.02.00.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 Apr 2026 02:00:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1776070846;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=tLnbVIMW0pl4KY5Dao3ueAu8GiBy46W1IL2uR3rJhjE=;\n b=O6F+Ma0NUUc8WVMleajvQVD+Vd/mZ/ZXYUBlssaZdT0ja/QUKZzhSpzQgc3dk4BOBORKgE\n czlSdy138qEcPmNzwl6p4HVJwBOzZGg4E8hemt2KT2ylKaRG+6VfQ/EquVqdHMUSL8owmh\n f4rLke3CvLjsI5BR6pb2vOLoq0/ohkw=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1776070844; x=1776675644; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=tLnbVIMW0pl4KY5Dao3ueAu8GiBy46W1IL2uR3rJhjE=;\n b=hQQjrb6a8mvhl3czjgHN1hBV2IbOseKK6Vy8G4Em9houEEQP6DliD1tieIXq8MsYvp\n Vy7xZIlqVZpKweJzpKGnl4d2JEdUwIFUBH7x2zB+E81LhLjWPjbg2IrmW0nm7bWSypd8\n YotWKUGiiQ7DO4VSgdSiIo3XO3nJ5sOLL3iaLRAp0L8Vpy809Juf+r7+9Ny/xiN6fQJQ\n 6LKBMQq3Ss9AWq7HKpqGmRJQzEhdBIwjjn2swPBkQcTAE3gyJf//B87nQQAZjExU389d\n PSyMvC01nMH10hRUfpDmc2HgsKXtmh62P5Al6zIUpx1+YaL99NOf77lUyEf8CO22OacS\n TUaA=="],"X-MC-Unique":"LcRD21PIOtmgB1s2Opz-eg-1","X-Mimecast-MFC-AGG-ID":"LcRD21PIOtmgB1s2Opz-eg_1776070844","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776070844; x=1776675644;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tLnbVIMW0pl4KY5Dao3ueAu8GiBy46W1IL2uR3rJhjE=;\n b=GRLmyrclj2WNa7TcYz4MX/0fcvGL+Bok6Lq5ogR8hudl1L3mwf0TLejlPREeywwRiY\n GEkrbYCvTjVPcWGzp1gLEtHltPlvXu44nK6frMjbj5QEQCp/wWDI/urbPGflCoHyaucI\n XKPypHTBe50wZSUtpEDndYoBWbNSB13mdEYMx+86FUW47Xbs88vDG1K9NCjwr6IEUEf/\n HnIg3uacxmeiIzAv2dMsJrVrwUk/Z+UaQSjnLiLpUkPsE4N39KAw1QDvhVNnV0Cm+MmX\n mtYGTu+5xHa6tvCOBssKeVru9vkVzzLimMwzGheK1UXXGxaU/8wwWI4KqT/SMP9Wwtqy\n YEgQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8lCa9gMQ1CQQmN6uC7O0YB6kF80RAU2ZBgSwOxj0znMy+GQHo6UJkomYRfvEBKNu6ShrjaqVMZu+bG@nongnu.org","X-Gm-Message-State":"AOJu0YzQ5VMRbL/wxHCt26OEOXp/LVtcO3YAIJe0gZyiM1ELOdbziNwS\n 57h6ayQTg3p1JbzHRdCPyhM4ytTeX5vWPY/470AvK2tht3CtY85otExvbHIBjNe+KwSKew51MTl\n /oiqODvqNflXjnyNpUxvMeEGzL2Qmb0NXoME34K7R/rGd3G1dRhtdZKFI","X-Gm-Gg":"AeBDietORy788CIG1g87DZoRKRuecEIKU3eCoWTsN3JrkyVHPn2zMtRf9yaG6I9iJ4H\n F88XBGmHVhnS2U448BeIpYpzb+2NfuRfFzNlP9BSP/7PtTg39/9rfpGiHMj2UCAM3dc01Lp0A8Y\n g+JurkWRo9dhOk6T+m/i8mhWYFi8KMKuoIn/Mfj4RA1JvMU1UjHOEpfJ5q8n2i7ceaNpiaGI0qo\n CApN53wcLkTHtmMi40s5dGaQoXYr/3505XCdmNilH5A+ineiyrwNZpQzsysOZ2/6af74KMQWeYc\n 7I3QZAe9q+AQ8SLCgUQ8HJhzDCGadN5OQ7VGGeP/e/oGQIr0qTgAasYpz+9vxISttug2DSE0f2e\n WMQHyj4BUiiZuzmsB9aq80O6dXoA9EKs76+oL5Xbiw6ALDOqKAfysBmY2veninte9wyWwib4uJK\n qTiZJi6Q==","X-Received":["by 2002:a17:90b:28cc:b0:35d:aeb2:25b2 with SMTP id\n 98e67ed59e1d1-35e428cda1bmr13170965a91.27.1776070844343;\n Mon, 13 Apr 2026 02:00:44 -0700 (PDT)","by 2002:a17:90b:28cc:b0:35d:aeb2:25b2 with SMTP id\n 98e67ed59e1d1-35e428cda1bmr13170663a91.27.1776070839003;\n Mon, 13 Apr 2026 02:00:39 -0700 (PDT)"],"From":"Ani Sinha ","To":"Paolo Bonzini ","Cc":"Ani Sinha , Misbah Anjum N ,\n Gautam Menghani , Fabiano Rosas ,\n Harsh Prateek Bora , kvm@vger.kernel.org,\n qemu-devel@nongnu.org","Subject":"[PATCH for-11.0] accel/kvm: return early from kvm_irqchip_create if\n kvm does not support irqchip","Date":"Mon, 13 Apr 2026 14:30:10 +0530","Message-ID":"<20260413090010.60339-1-anisinha@redhat.com>","X-Mailer":"git-send-email 2.49.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124;\n envelope-from=anisinha@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"During refactoring of kvm_irqchip_create(), the refactored code was returning\nearly from do_kvm_irqchip_create() function if the required capabilities were\nnot present in KVM. This was not translating to an early return from\nkvm_irqchip_create() as was the case before refactoring. This is because,\ndo_kvm_irqchip_create() did not have a means to notify the caller of the lack\nof kvm capabilities. Fix this by making do_notify_irqchip_create() return\nEOPNOTSUPP error when required capabilities are absent and then the caller\ncan check the return code and return early.\n\nFixes: 98884e0cc1 (\"accel/kvm: add changes required to support KVM VM file descriptor change\")\nReported-by: Misbah Anjum N \nReported-by: Gautam Menghani \nSuggested-by: Fabiano Rosas \nSuggested-by: Harsh Prateek Bora \nSigned-off-by: Ani Sinha \n---\n accel/kvm/kvm-all.c | 11 ++++++++---\n 1 file changed, 8 insertions(+), 3 deletions(-)","diff":"diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c\nindex 774499d34f..92af42503b 100644\n--- a/accel/kvm/kvm-all.c\n+++ b/accel/kvm/kvm-all.c\n@@ -2575,7 +2575,7 @@ void kvm_irqchip_set_qemuirq_gsi(KVMState *s, qemu_irq irq, int gsi)\n g_hash_table_insert(s->gsimap, irq, GINT_TO_POINTER(gsi));\n }\n \n-static void do_kvm_irqchip_create(KVMState *s)\n+static int do_kvm_irqchip_create(KVMState *s)\n {\n int ret;\n if (kvm_check_extension(s, KVM_CAP_IRQCHIP)) {\n@@ -2587,7 +2587,7 @@ static void do_kvm_irqchip_create(KVMState *s)\n exit(1);\n }\n } else {\n- return;\n+ return -EOPNOTSUPP;\n }\n \n if (kvm_check_extension(s, KVM_CAP_IRQFD) <= 0) {\n@@ -2610,13 +2610,17 @@ static void do_kvm_irqchip_create(KVMState *s)\n fprintf(stderr, \"Create kernel irqchip failed: %s\\n\", strerror(-ret));\n exit(1);\n }\n+\n+ return 0;\n }\n \n static void kvm_irqchip_create(KVMState *s)\n {\n assert(s->kernel_irqchip_split != ON_OFF_AUTO_AUTO);\n \n- do_kvm_irqchip_create(s);\n+ if (do_kvm_irqchip_create(s) < 0) {\n+ return;\n+ }\n kvm_kernel_irqchip = true;\n /* If we have an in-kernel IRQ chip then we must have asynchronous\n * interrupt delivery (though the reverse is not necessarily true)\n@@ -2835,6 +2839,7 @@ static int kvm_reset_vmfd(MachineState *ms)\n }\n \n if (s->kernel_irqchip_allowed) {\n+ /* ignore return from this function */\n do_kvm_irqchip_create(s);\n }\n \n","prefixes":["for-11.0"]}