{"id":2222640,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222640/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413084822.70754-1-phx0fer@gmail.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413084822.70754-1-phx0fer@gmail.com>","list_archive_url":null,"date":"2026-04-13T08:48:22","name":"netfilter: nfnetlink_cthelper: fix expect policy update copying only first class values to all classes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f29a611338ce9e578da8b5d72817bc62d55049db","submitter":{"id":93127,"url":"http://patchwork.ozlabs.org/api/1.2/people/93127/?format=json","name":"Dudu Lu","email":"phx0fer@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413084822.70754-1-phx0fer@gmail.com/mbox/","series":[{"id":499667,"url":"http://patchwork.ozlabs.org/api/1.2/series/499667/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499667","date":"2026-04-13T08:48:22","name":"netfilter: nfnetlink_cthelper: fix expect policy update copying only first class values to all classes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499667/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222640/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222640/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=GLHREnpX;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11841-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"GLHREnpX\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.194","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvLlN38pwz1yDG\n\tfor ; Mon, 13 Apr 2026 18:52:48 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id C0FC5301FD7C\n\tfor ; Mon, 13 Apr 2026 08:48:30 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id D473D3AD527;\n\tMon, 13 Apr 2026 08:48:29 +0000 (UTC)","from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n [209.85.214.194])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EF403ACA7B\n\tfor ; Mon, 13 Apr 2026 08:48:28 +0000 (UTC)","by mail-pl1-f194.google.com with SMTP id\n d9443c01a7336-2b4583f0a1aso5894875ad.3\n for ;\n Mon, 13 Apr 2026 01:48:28 -0700 (PDT)","from gmail.com (69-172-89-235.static.imsbiz.com. [69.172.89.235])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4daede9sm141700485ad.14.2026.04.13.01.48.25\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Mon, 13 Apr 2026 01:48:26 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776070109; cv=none;\n b=sSQyJHOj77nU19HwgAoeIIDUPlinoJqqFb37kqX+Yj3GVH9F8GaNC+yK/5wZmUkDtKNz9YpTZCO/MJ79EgVxj3rUxT7jlqs+MZlYKymMNqvzP2ctBWsO5l6fXpwpCZrS79lrnOLRJIb4XceRY786yjnnHAkLkePNy4+9kdVQppo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776070109; c=relaxed/simple;\n\tbh=8IMLk3ne7Zq7gCFJB45nqzF2wesVtWkMU7SvQqsWypM=;\n\th=From:To:Cc:Subject:Date:Message-Id:MIME-Version;\n b=RdJarcUaPaUwX1SnyS2qoQYjXAKp6du6BJ9eUIs7m16x1mOcNl79UjOBQQM8TSfsjW/p9mndADSx2EyiAeNmRgAJS6FkGZu2pfGHDE0PKEZa+NMZ1xws0qCPVDLnnecMtziSjRstGBb6quNwahoBJmTzDgBkCu3g/WLQR+VY0Io=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=GLHREnpX; arc=none smtp.client-ip=209.85.214.194","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776070107; x=1776674907;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=m2fS7SSQov1oj9aq4GgwHcUoeWbd2x4UWXUE2U4OB5I=;\n b=GLHREnpXg2a+q2L9xxD/+X2Vd/XDjE0foMM92JQByGylOAP+sejpV2/ZOZRxJjhFMl\n EGea/6F+kn8irW+VSs1VaP7ZbAmAnwlJyvZKRJdYZRdlpG7wV2EuWIDSE4lPY8oXLRx4\n exWUITP9JJc65I19kG9nPAQVNXEvOhEEWTibNdSDJ4bsDJFZ7dvV64VE00AE9XIb/1g0\n XP1Zy2FKTYSWCOeMhSKIgcfc0PfBuxH952PCDPT3XMM4tgvayLd0B0BLCgay0mLbQsQZ\n bZM53pZnJeCNURz18aMMEFnSFf8xT/o5AOfbQYpVVnPbP2o2OZj9mHDCFDxQPEPwvtNj\n oHUQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776070107; x=1776674907;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=m2fS7SSQov1oj9aq4GgwHcUoeWbd2x4UWXUE2U4OB5I=;\n b=Zti2eraxnr/UqVJFyMrAwPlNKPWicgWG/yGDoh0xm6/r4F3F6eX12FmZ/vqZJLb1fl\n nzKELq7vx5p4xKSYeZoCW/V8CSDyXqURi92u2DxRqXFGjBtEF6VMPaiCxS15vjhs4gk4\n 6Y4IR6ptoNlhpxU68iayFMPL7m2cHTPY6szm8l3uj85rcVND5FB1IaBspZVv1bTwO+eg\n 2QiExIkQ74c0xzavDKwsSNpHIywOD2WD6Fu7EHqKFQiSsDpiwrKtjD6nbcTSoxmqhEVu\n Kx0k206CYJWomvzSKDaa0GfJN+1RcjzV+s/Dr6Wtckgn1CPV9QEoRh6YgJKaTQRZq+XG\n +r3Q==","X-Gm-Message-State":"AOJu0YwnUM31+pjEIgAVEi3XJL/PT8D9RzSP/k89a0V0zlakvpVHOpY9\n\ttuxLSglRcI9ic8UFsN3rTI4FJnyx3IPdngMnWw/wTgoV6W1HwHoZyyVrFrRtsakS","X-Gm-Gg":"AeBDiesPNcowk5ys6AkWgl3gH3jnBlUpimj6v1xbfFke+C5A3a3ZdmLFKZfRn5yg+ZS\n\tHScxrnDJDV7DeuXv3C9Xaw2JwL2NWymBYyMg0HZ2I8TEeYrI2HRZwSo95dNKnpsY4qeMBfmpXJx\n\tb8yxltWfUZgl58H9zRS4F59aD8/8Lbze6y2sbL/Tbm3XeTI/80ESGiUNAwnRAZ5cGvhYXVq35zg\n\tMjE3RjZroQ9z/utY5FfFgTZw2vNq+37jKc8+tSGgrY/4v8LgSzWWTRjHe0N43iYy4ygMuQ2TGNY\n\tO5x59WFzVx2xcp9zbhyI+t0ObFTc8ccgfb+4aCwnrRXAsgYJKqrKLcHqiv/pZhVqfdjWlde6CaT\n\tVpTo0p2jIRL8q24mH+X3vLQmCXfHKAzlHUMjbIz/DnFK1m4Pp0XwXYL4hEahm4OqNEH759+YXLq\n\thTsZksxYWZcQkVLP7N89BkFQQc1LKn8OLk7A7+FfHQepW4miQHqA6ZkAFi3whtsAIu","X-Received":"by 2002:a17:902:d590:b0:2b2:b117:1e1b with SMTP id\n d9443c01a7336-2b2d599f553mr124015995ad.17.1776070107246;\n Mon, 13 Apr 2026 01:48:27 -0700 (PDT)","From":"Dudu Lu ","To":"netfilter-devel@vger.kernel.org","Cc":"pablo@netfilter.org,\n\tfw@strlen.de,\n\tDudu Lu ","Subject":"[PATCH] netfilter: nfnetlink_cthelper: fix expect policy update\n copying only first class values to all classes","Date":"Mon, 13 Apr 2026 16:48:22 +0800","Message-Id":"<20260413084822.70754-1-phx0fer@gmail.com>","X-Mailer":"git-send-email 2.39.3 (Apple Git-145)","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"In nfnl_cthelper_update_policy_all(), when updating the expect policies\nof a multi-class conntrack helper, the loop iterates over all expect\nclasses but always reads from new_policy[0] instead of new_policy[i]:\n\n for (i = 0; i < helper->expect_class_max + 1; i++) {\n policy = &helper->expect_policy[i];\n policy->max_expected = new_policy->max_expected; /* always [0] */\n policy->timeout = new_policy->timeout; /* always [0] */\n }\n\nThe new_policy array was correctly parsed per-class by\nnfnl_cthelper_update_policy_one() in the validation loop above (line\n336-342), with each new_policy[i] holding its respective class values.\nHowever, the copy loop dereferences new_policy as a pointer\n(new_policy->x) rather than indexing it as an array\n(new_policy[i].x), creating a security vulnerability.\n\nAs a result, all expect classes of a multi-class helper get overwritten\nwith the values of class 0, discarding the per-class differentiation.\n\nThis affects helpers like H.323 which use multiple expect classes\n(RTP, RTCP, T.120) with different max_expected and timeout values.\nAfter a policy update, all classes get identical limits, breaking the\nper-class expect enforcement.\n\nFix by indexing new_policy with the loop variable.\n\nFixes: 2c422257550f (\"netfilter: nfnl_cthelper: fix runtime expectation policy updates\")\nSigned-off-by: Dudu Lu \n---\n net/netfilter/nfnetlink_cthelper.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/net/netfilter/nfnetlink_cthelper.c b/net/netfilter/nfnetlink_cthelper.c\nindex d545fa459455..1e605d77796d 100644\n--- a/net/netfilter/nfnetlink_cthelper.c\n+++ b/net/netfilter/nfnetlink_cthelper.c\n@@ -346,8 +346,8 @@ static int nfnl_cthelper_update_policy_all(struct nlattr *tb[],\n \tfor (i = 0; i < helper->expect_class_max + 1; i++) {\n \t\tpolicy = (struct nf_conntrack_expect_policy *)\n \t\t\t\t&helper->expect_policy[i];\n-\t\tpolicy->max_expected = new_policy->max_expected;\n-\t\tpolicy->timeout\t= new_policy->timeout;\n+\t\tpolicy->max_expected = new_policy[i].max_expected;\n+\t\tpolicy->timeout\t= new_policy[i].timeout;\n \t}\n \n err:\n","prefixes":[]}