{"id":2222585,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222585/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413043304.3327873-1-keerthana.kalyanasundaram@broadcom.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413043304.3327873-1-keerthana.kalyanasundaram@broadcom.com>","list_archive_url":null,"date":"2026-04-13T04:33:04","name":"[v5.10] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"3dfc8451e538ab1b2092a11507cb35f9ee1e5103","submitter":{"id":92585,"url":"http://patchwork.ozlabs.org/api/1.2/people/92585/?format=json","name":"Keerthana K","email":"keerthana.kalyanasundaram@broadcom.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413043304.3327873-1-keerthana.kalyanasundaram@broadcom.com/mbox/","series":[{"id":499645,"url":"http://patchwork.ozlabs.org/api/1.2/series/499645/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499645","date":"2026-04-13T04:33:04","name":"[v5.10] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","version":1,"mbox":"http://patchwork.ozlabs.org/series/499645/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222585/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222585/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=google header.b=Bsl+aEeG;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11839-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"Bsl+aEeG\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.222.99","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvFDM0220z1xtJ\n\tfor ; Mon, 13 Apr 2026 14:44:02 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 88DE5303A855\n\tfor ; Mon, 13 Apr 2026 04:40:36 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 32F6D38552F;\n\tMon, 13 Apr 2026 04:40:34 +0000 (UTC)","from mail-ua1-f99.google.com (mail-ua1-f99.google.com\n [209.85.222.99])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 65BAF3815DF\n\tfor ; Mon, 13 Apr 2026 04:40:32 +0000 (UTC)","by mail-ua1-f99.google.com with SMTP id\n a1e0cc1a2514c-94ac2903796so70948241.2\n for ;\n Sun, 12 Apr 2026 21:40:32 -0700 (PDT)","from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com\n (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24])\n by smtp-relay.gmail.com with ESMTPS id\n a1e0cc1a2514c-9567ba161fasm172756241.5.2026.04.12.21.40.30\n for \n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Sun, 12 Apr 2026 21:40:31 -0700 (PDT)","by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2ca8a374558so41652eec.0\n for ;\n Sun, 12 Apr 2026 21:40:30 -0700 (PDT)","from keerthanak-ph5-dev.. ([192.19.161.250])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2d562db64c4sm14677061eec.27.2026.04.12.21.40.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 21:40:27 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776055233; cv=none;\n b=i4I17MFxiy9rsKk3knELLSkQB3LvbIPV0fDmJxsmZA6UBmZygj1jfxAVYZ/nIJR+ytFAHQDick7oxoLBzI3aVjE+/4hkhJh6e5kYpnGxVZUpy3P18xLcKO+FvEou7iurwXWd4rDJnvuXtg8bIWPZbSxnVsG2wkm5sC/rK//O7p4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776055233; c=relaxed/simple;\n\tbh=eUByrnPJ2nona1QXhiPKoFAJ4ou5D+Pn4Dg2jpFDt6M=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=LEle8RnXFyZvBgo/m8O+nHADK4mDJJ7TOauB4N7KkETiHgZGUbvPLvvLdaSTYghpKbSwVF7BmIA6P1GxG+K24q+B699ZHajGyExUA8bPL4obQ1FQjUs/hgxa+alPLIViD4NcahAe7u1XaofsKIW/VDqtOmvrkLjdW5eCBshybXI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=Bsl+aEeG; arc=none smtp.client-ip=209.85.222.99","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776055231; x=1776660031;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2l7i8vnpUJQTdJaWwY66SR5P0SKGOILNorZy9BBZKRQ=;\n b=AZUZ+an2SpFYb7uX3GqlzqYdKVpu13mxnyNuTblnknKZrG/G0KFtA13sF1lil9g7/U\n A+nnJg4bd8Kcz3JscdnQ0s2jptvHCZM9d94NP06SWaAin4eZeTsicS67X51c9d/L9Vz2\n 4TUVsK2RRcSdCc64cgrJGWiOfJZ5jW4GqiMNpenE48Swrdh/1Tfv3XSLWZQAK+WMepMH\n BEX+HsumPQ7N5OEd5qQrShl5ebpkbDoGpWaf4Hr41BDmxhlF0PJnQXnycpPGxQfRY+8+\n WDqu5o3H+3MYkVEPEIHKYyZGGlcy+NZEnBCKGpC+RQoiBMvgmaxn1m0zQL16V3g28JPI\n MsvQ==","X-Forwarded-Encrypted":["i=1;\n AFNElJ9q+HjGFGs9RjU96vYamDWb1QwfsUtKeGGHmUVZu32NGyikM9M+5zMjCJqkn5j0l2VspvuIS07VrwkkaPtOqYc=@vger.kernel.org","i=1;\n AFNElJ/cjiFn3Z7uQqUqZv2sQ2bec4zNLwruc2ChAHkoH13E8mizFyAuxdHZ5TBKdWWi+hYW6llXQbZPm3Vt0GIiFvw=@vger.kernel.org"],"X-Gm-Message-State":"AOJu0YwVcheL2zJr0WIjZjB1KuPuz2Bf5U149wVl8816m6usDa1A8p58\n\tBvCgvZjtCF7pJjiyIWjTMGiArTg7JixJQhmq8htenIimTm85JeDo/TYOv0re8Z5Z8W53oSRn7aq\n\t2orEAwpuQUUJ7KY8R6oqhtIfJ8/3X0KfTrtHkaN+n7YC6kSvHmJhXHaI3O7/WeN80Yb3Zbs05zD\n\tPKNLoW9Ceh7lkBzHILo9iqlO7ihdNT+NK0tqbz1iRUI8UzTsdeLdwFjnRPQQKwPmqqexE3dDGQt\n\tdwP343BTex5ZCUCuUmjdnSwTVOyur76fW1d7tFZ7XE=","X-Gm-Gg":"AeBDietrBESk1VQpap6pQ9M1V2gS2yWnYJc7hluAxBVwQ2DoP56p2S9FQH4msIQM5ek\n\tGyGBaygxY8yfDpwcEuD0UbnqYu7MohOMwWaDBdqhmGQZ952AFXjfJJwk67MsGRgvvOpRUHzQmcl\n\ttlIAQwOiCWEqFlb4BxWEqVEcuI3qUkDpO5ZG4KL7YW9jbboAerwYXD7OqOUt/fGggH/2FVMyoES\n\tZTHEq1TaRS1X15RP8lyCXfUW4wM1l4pYCLC9+8E98gK5sq3aY2jFO9nTNBvacO15abWNlLBIN57\n\t1McNSLiXs7vbyXNF5NVPedW8hYqPjrCtD8tvgck6CH+/YS/V7CwD/g2mqFhZ2zfvOfGFnHJfHp8\n\tgPTRKKsmw3P2/mx+8tbXOK40WbC60nzNnomLOgDGWBKUxMjGkliz+t9RLXxA49a5Y7B9kxyGNdR\n\t8hwDp+L+RdS1+eL1jKwYbNLIzIjTpd949W6aDlfGr325h24SlV4+Jow4rUc9XdwxsiJ3q/iY/qT\n\tg==","X-Received":["by 2002:a05:6102:2416:b0:5db:f553:4ca0 with SMTP id\n ada2fe7eead31-60a339f920emr1320540137.1.1776055231296;\n Sun, 12 Apr 2026 21:40:31 -0700 (PDT)","by 2002:a05:7301:1e84:b0:2cb:de38:c76f with SMTP id\n 5a478bee46e88-2d5c3f14ed2mr2494761eec.6.1776055228849;\n Sun, 12 Apr 2026 21:40:28 -0700 (PDT)","by 2002:a05:7301:1e84:b0:2cb:de38:c76f with SMTP id\n 5a478bee46e88-2d5c3f14ed2mr2494757eec.6.1776055228195;\n Sun, 12 Apr 2026 21:40:28 -0700 (PDT)"],"X-Relaying-Domain":"broadcom.com","X-CFilter-Loop":"Reflected","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1776055229; x=1776660029;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=2l7i8vnpUJQTdJaWwY66SR5P0SKGOILNorZy9BBZKRQ=;\n b=Bsl+aEeG4YLqFSpfbtV7Jd9pMFk2JSju6AQGoN4NqSduQqZnCgkIF8Ld5R94KaR51M\n sZC4bVByMRuFyGBgGuFzVzda/YmbojVV8OZcHIi1Rt4g0GOAK5gxZsC4S8UrTTrtYUOW\n nA/q1LToHVseQb6q9tXlIO6+Si3rQ2LsU54pA=","From":"Keerthana K ","To":"stable@vger.kernel.org,\n\tgregkh@linuxfoundation.org","Cc":"pablo@netfilter.org,\n\tkadlec@netfilter.org,\n\tfw@strlen.de,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tajay.kaher@broadcom.com,\n\talexey.makhalov@broadcom.com,\n\tvamsi-krishna.brahmajosyula@broadcom.com,\n\tyin.ding@broadcom.com,\n\ttapas.kundu@broadcom.com,\n\tStefano Brivio ,\n\tMukul Sikka ,\n\tBrennan Lamoreaux ,\n\tKeerthana K ","Subject":"[PATCH v5.10] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","Date":"Mon, 13 Apr 2026 04:33:04 +0000","Message-ID":"<20260413043304.3327873-1-keerthana.kalyanasundaram@broadcom.com>","X-Mailer":"git-send-email 2.43.7","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-DetectorID-Processed":"b00c1d49-9d2e-4205-b15f-d015386d3d5e"},"content":"From: Florian Westphal \n\ncommit 07ace0bbe03b3d8e85869af1dec5e4087b1d57b8 upstream\n\npipapo relies on kmalloc(0) returning ZERO_SIZE_PTR (i.e., not NULL\nbut pointer is invalid).\n\nRework this to not call slab allocator when we'd request a 0-byte\nallocation.\n\nReviewed-by: Stefano Brivio \nSigned-off-by: Florian Westphal \nSigned-off-by: Mukul Sikka \nSigned-off-by: Brennan Lamoreaux \n[Keerthana: In older stable branches (v6.6 and earlier), the allocation logic in\npipapo_clone() still relies on `src->rules` rather than `src->rules_alloc`\n(introduced in v6.9 via 9f439bd6ef4f). Consequently, the previously\nbackported INT_MAX clamping check uses `src->rules`. This patch correctly\nmoves that `src->rules > (INT_MAX / ...)` check inside the new\n`if (src->rules > 0)` block]\nSigned-off-by: Keerthana K \n---\n net/netfilter/nft_set_pipapo.c | 21 +++++++++++++++------\n 1 file changed, 15 insertions(+), 6 deletions(-)","diff":"diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c\nindex a4fdd1587bb3..83606dfde033 100644\n--- a/net/netfilter/nft_set_pipapo.c\n+++ b/net/netfilter/nft_set_pipapo.c\n@@ -524,6 +524,9 @@ static struct nft_pipapo_elem *pipapo_get(const struct net *net,\n \tstruct nft_pipapo_field *f;\n \tint i;\n \n+\tif (m->bsize_max == 0)\n+\t\treturn ret;\n+\n \tres_map = kmalloc_array(m->bsize_max, sizeof(*res_map), GFP_ATOMIC);\n \tif (!res_map) {\n \t\tret = ERR_PTR(-ENOMEM);\n@@ -1363,14 +1366,20 @@ static struct nft_pipapo_match *pipapo_clone(struct nft_pipapo_match *old)\n \t\t src->bsize * sizeof(*dst->lt) *\n \t\t src->groups * NFT_PIPAPO_BUCKETS(src->bb));\n \n-\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n-\t\t\tgoto out_mt;\n+\t\tif (src->rules > 0) {\n+\t\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n+\t\t\t\tgoto out_mt;\n \n-\t\tdst->mt = kvmalloc(src->rules * sizeof(*src->mt), GFP_KERNEL);\n-\t\tif (!dst->mt)\n-\t\t\tgoto out_mt;\n+\t\t\tdst->mt = kvmalloc_array(src->rules, sizeof(*src->mt),\n+\t\t\t\t\t\t GFP_KERNEL);\n+\t\t\tif (!dst->mt)\n+\t\t\t\tgoto out_mt;\n+\n+\t\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n+\t\t} else {\n+\t\t\tdst->mt = NULL;\n+\t\t}\n \n-\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n \t\tsrc++;\n \t\tdst++;\n \t}\n","prefixes":["v5.10"]}