{"id":2222583,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222583/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413043223.3327827-1-keerthana.kalyanasundaram@broadcom.com/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413043223.3327827-1-keerthana.kalyanasundaram@broadcom.com>","list_archive_url":null,"date":"2026-04-13T04:32:23","name":"[v6.6] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","commit_ref":null,"pull_url":null,"state":"not-applicable","archived":true,"hash":"4b35745a6b7ece8c1a2e8e32b2be7cda1feb72eb","submitter":{"id":92585,"url":"http://patchwork.ozlabs.org/api/1.2/people/92585/?format=json","name":"Keerthana K","email":"keerthana.kalyanasundaram@broadcom.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20260413043223.3327827-1-keerthana.kalyanasundaram@broadcom.com/mbox/","series":[{"id":499643,"url":"http://patchwork.ozlabs.org/api/1.2/series/499643/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/list/?series=499643","date":"2026-04-13T04:32:23","name":"[v6.6] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","version":1,"mbox":"http://patchwork.ozlabs.org/series/499643/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222583/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222583/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256\n header.s=google header.b=HpSI2RVO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.232.135.74; helo=sto.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11837-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=\"HpSI2RVO\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=74.125.82.98","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=broadcom.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org [172.232.135.74])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvF7g1pKYz1y2d\n\tfor ; Mon, 13 Apr 2026 14:39:59 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 314713004DEC\n\tfor ; Mon, 13 Apr 2026 04:39:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 10C99383C8D;\n\tMon, 13 Apr 2026 04:39:54 +0000 (UTC)","from mail-dl1-f98.google.com (mail-dl1-f98.google.com\n [74.125.82.98])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 61057344DB8\n\tfor ; Mon, 13 Apr 2026 04:39:52 +0000 (UTC)","by mail-dl1-f98.google.com with SMTP id\n a92af1059eb24-12c22b9bdabso215174c88.2\n for ;\n Sun, 12 Apr 2026 21:39:52 -0700 (PDT)","from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com\n (address-144-49-247-24.dlp.protect.broadcom.com. [144.49.247.24])\n by smtp-relay.gmail.com with ESMTPS id\n a92af1059eb24-12c3434ec0asm287754c88.0.2026.04.12.21.39.50\n for \n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Sun, 12 Apr 2026 21:39:51 -0700 (PDT)","by mail-qt1-f200.google.com with SMTP id\n d75a77b69052e-50d7128e038so9780861cf.2\n for ;\n Sun, 12 Apr 2026 21:39:50 -0700 (PDT)","from keerthanak-ph5-dev.. ([192.19.161.250])\n by smtp.gmail.com with ESMTPSA id\n 6a1803df08f44-8ac84cf55b7sm85742136d6.45.2026.04.12.21.39.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 21:39:48 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776055193; cv=none;\n b=k5ujNAFeW3Yqt+5RcD9Q07xVD13E5HpZO/JD9+88wKv/zQyxr2QupGzpSUrTANLcakB8U/35CzsVx8eKzvYi5erkImDrg35Ow18iO3HAv69wcojXHodhZBn1hATsapzxu8d+iLmEMxmq0cm+qDQ8XkZyVSyOgC9TzIdZUjzxoIc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776055193; c=relaxed/simple;\n\tbh=wtSSTcWRwe559pZ1gDdmuMpz8Bc8ySi6j0tYNMZuVwg=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=Ycf0BAHX7j5YP0eMehGZ0wRZ0TwJHKYAZKAS2ZJctCRhMLuYkU6l1es9FlwxwD7XR7ioP3/N1OoQ3B/3SFWyXklGoEs2krZUm4IlEWL3BhoNWZFpmfltiY6/5tGWPeui0dRCZUZGPAvyNxPYcNwttXPN3QA/LQrrF3gOn93dses=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=broadcom.com;\n spf=fail smtp.mailfrom=broadcom.com;\n dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com\n header.b=HpSI2RVO; arc=none smtp.client-ip=74.125.82.98","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776055191; x=1776659991;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:dkim-signature:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=9qLamvoygs8XdLleM+az9cX6DHqELe8TmHOQBddVvD8=;\n b=gtsFlvcxEAtI9BU/ySsK7YCDkU1FbmRafcpnkMfqW8fdal80gvVx66SakB5L5pm1U/\n BOQ9tG58+YafExo9iXa2VbByhaCzujMk4ieW2Ru/EczFMaG/zKS4NTu31JeBXs6ObORz\n ulw4ZOj6g0xTv1XqgG6Vm/Sa9x4xQ4QxYhFECCvLqgerUGdolL5lSQye9ofj6qGWu5Gk\n ywkS5AWQrVwWS4tCBZQSmG5KEQ/DDyIweJF9jDgxIcXhMbuxxmwqBhybUXgQOBS/v8Ru\n os3uqfmKV9q0aCUHfqFRv3/zLzGrPqWvZUXqdVVlee1Bct8HiG0ORPfCWcW5lvrMPdqV\n k8rA==","X-Forwarded-Encrypted":["i=1;\n AJvYcCVeogqmVzHsT3OZlSwo8tchjVD9i8gO6ezExcXJfSgKZt3R1RQ4MpC3X3wf6lkQM7N2RJPDRE7YU6CB7gZ1mCs=@vger.kernel.org","i=1;\n AFNElJ/dQ4pNrzAP8RK9JMIjC7nVCKb5woaq2D4RJzwV/kO11s9iPteFSfBQ2g4Yi+H7wrd8XsQFPvqHwsAyI3c2XCk=@vger.kernel.org"],"X-Gm-Message-State":"AOJu0Yy64LzTRu9sxpQwFCvUTafse9GHZ0VC9C+4QNOxtxpxrHAehU5g\n\tGzNX/9Ata1L+rfMmC2qX0s68Lc5wHliYDnmuJQpMLZ3kfmCdWb30v3l7ZYp1KbqmfQeMK8LrFse\n\tOM3niZDyt3RzgmnbToufZwLmBfFeB+2ebSZPd2bWdUxl12LqU5NQB8IVX+1R0ro7+++3pC+2sUs\n\tTRro6KMz8yJ9j79DKx3Z0W2GmN2aEauM569UqcGKXMvw72ppx9AONPlSg5fLsGTKWg+OkjNNbbw\n\tsQ/z87l7nG6hETSgPh8YQLUt5if+3M/JQamLrX9QVs=","X-Gm-Gg":"AeBDiesI+enSJAWJXjmkmUzF+teyFGWq47hbEpKtTC4HUfKaDiotyLkiyN/NcCEgNw9\n\tRxESxIXJmnLyOTQXwHgY8HVCChJI7jNDTpbBZmn5Yuf+SzDZsLBCj88lldzB0OE4ubEmoFBGQXU\n\tbfiYxm0zhkdWuOTRPHYR6OEe7fOvWfo/kAGcqWJWgMEphhbNMT/hFC3SFF+1Ljj3GTgQnWed42M\n\t4Zz3DERbBzD3gcgI5XG/rT+7TL0zpzuEoxxoJWMfXukHWg7HAXDBJMkgSDeyEgLfqxa6HoDS17K\n\txR0z/Og7K9wkkCuSyb97G0LwkdsSNfwbxmEjHSpl//+IbxOGAHdDWXhw46d/+JhdbxeP7QpdoEB\n\tI6LfWKYeXStWfHxthqsp+ouxvvq6mU5KZrZAnoLP68GR0eNHfrNLqeGW4TgwLj0Re7Lzbxuvnqb\n\tiWK4A+A1Y1pJ9LJwOZFATlk7dv+2TUpXRtTLSh8IGD7sePmcJ/w0FdmgmlgrJXbXGbzKeiVQtSH\n\tA==","X-Received":["by 2002:a05:7022:672b:b0:119:e56b:46b6 with SMTP id\n a92af1059eb24-12c34dbed15mr2575681c88.0.1776055191120;\n Sun, 12 Apr 2026 21:39:51 -0700 (PDT)","by 2002:a05:6214:258a:b0:8ac:b300:c558 with SMTP id\n 6a1803df08f44-8acb300c627mr10722556d6.2.1776055189864;\n Sun, 12 Apr 2026 21:39:49 -0700 (PDT)","by 2002:a05:6214:258a:b0:8ac:b300:c558 with SMTP id\n 6a1803df08f44-8acb300c627mr10722376d6.2.1776055189373;\n Sun, 12 Apr 2026 21:39:49 -0700 (PDT)"],"X-Relaying-Domain":"broadcom.com","X-CFilter-Loop":"Reflected","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1776055190; x=1776659990;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=9qLamvoygs8XdLleM+az9cX6DHqELe8TmHOQBddVvD8=;\n b=HpSI2RVOGwNnCY0VhVy7LD9oFYUJyBdHxuVeVw3djJOilW/R2fsFD2cFr+pqsg+/uX\n zNkFFt3Lis3oRUqevrv02ssMtrQLNl2Gpd07xwMMD+OfKUB5Lp8KXMmknDbRPseZgSab\n 6BOFACv3iZ98WfiG9WgIP+7KsPngAYBVk2jcI=","From":"Keerthana K ","To":"stable@vger.kernel.org,\n\tgregkh@linuxfoundation.org","Cc":"pablo@netfilter.org,\n\tkadlec@netfilter.org,\n\tfw@strlen.de,\n\tdavem@davemloft.net,\n\tedumazet@google.com,\n\tkuba@kernel.org,\n\tpabeni@redhat.com,\n\tnetfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org,\n\tnetdev@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tajay.kaher@broadcom.com,\n\talexey.makhalov@broadcom.com,\n\tvamsi-krishna.brahmajosyula@broadcom.com,\n\tyin.ding@broadcom.com,\n\ttapas.kundu@broadcom.com,\n\tStefano Brivio ,\n\tMukul Sikka ,\n\tBrennan Lamoreaux ,\n\tKeerthana K ","Subject":"[PATCH v6.6] netfilter: nft_set_pipapo: do not rely on ZERO_SIZE_PTR","Date":"Mon, 13 Apr 2026 04:32:23 +0000","Message-ID":"<20260413043223.3327827-1-keerthana.kalyanasundaram@broadcom.com>","X-Mailer":"git-send-email 2.43.7","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-DetectorID-Processed":"b00c1d49-9d2e-4205-b15f-d015386d3d5e"},"content":"From: Florian Westphal \n\ncommit 07ace0bbe03b3d8e85869af1dec5e4087b1d57b8 upstream\n\npipapo relies on kmalloc(0) returning ZERO_SIZE_PTR (i.e., not NULL\nbut pointer is invalid).\n\nRework this to not call slab allocator when we'd request a 0-byte\nallocation.\n\nReviewed-by: Stefano Brivio \nSigned-off-by: Florian Westphal \nSigned-off-by: Mukul Sikka \nSigned-off-by: Brennan Lamoreaux \n[Keerthana: In older stable branches (v6.6 and earlier), the allocation logic in\npipapo_clone() still relies on `src->rules` rather than `src->rules_alloc`\n(introduced in v6.9 via 9f439bd6ef4f). Consequently, the previously\nbackported INT_MAX clamping check uses `src->rules`. This patch correctly\nmoves that `src->rules > (INT_MAX / ...)` check inside the new\n`if (src->rules > 0)` block]\nSigned-off-by: Keerthana K \n---\n net/netfilter/nft_set_pipapo.c | 20 ++++++++++++++------\n 1 file changed, 14 insertions(+), 6 deletions(-)","diff":"diff --git a/net/netfilter/nft_set_pipapo.c b/net/netfilter/nft_set_pipapo.c\nindex c3ada6798d4a..98cdeb9fa210 100644\n--- a/net/netfilter/nft_set_pipapo.c\n+++ b/net/netfilter/nft_set_pipapo.c\n@@ -525,6 +525,8 @@ static struct nft_pipapo_elem *pipapo_get(const struct net *net,\n \tint i;\n \n \tm = priv->clone;\n+\tif (m->bsize_max == 0)\n+\t\treturn ret;\n \n \tres_map = kmalloc_array(m->bsize_max, sizeof(*res_map), GFP_ATOMIC);\n \tif (!res_map) {\n@@ -1394,14 +1396,20 @@ static struct nft_pipapo_match *pipapo_clone(struct nft_pipapo_match *old)\n \t\t src->bsize * sizeof(*dst->lt) *\n \t\t src->groups * NFT_PIPAPO_BUCKETS(src->bb));\n \n-\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n-\t\t\tgoto out_mt;\n+\t\tif (src->rules > 0) {\n+\t\t\tif (src->rules > (INT_MAX / sizeof(*src->mt)))\n+\t\t\t\tgoto out_mt;\n \n-\t\tdst->mt = kvmalloc(src->rules * sizeof(*src->mt), GFP_KERNEL_ACCOUNT);\n-\t\tif (!dst->mt)\n-\t\t\tgoto out_mt;\n+\t\t\tdst->mt = kvmalloc_array(src->rules, sizeof(*src->mt),\n+\t\t\t\t\t\t GFP_KERNEL);\n+\t\t\tif (!dst->mt)\n+\t\t\t\tgoto out_mt;\n+\n+\t\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n+\t\t} else {\n+\t\t\tdst->mt = NULL;\n+\t\t}\n \n-\t\tmemcpy(dst->mt, src->mt, src->rules * sizeof(*src->mt));\n \t\tsrc++;\n \t\tdst++;\n \t}\n","prefixes":["v6.6"]}