{"id":2222577,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222577/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/patch/20260413000423.9275-1-fl@n621.de/","project":{"id":27,"url":"http://patchwork.ozlabs.org/api/1.2/projects/27/?format=json","name":"Buildroot development","link_name":"buildroot","list_id":"buildroot.buildroot.org","list_email":"buildroot@buildroot.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413000423.9275-1-fl@n621.de>","list_archive_url":null,"date":"2026-04-13T00:04:22","name":"[1/1] package/flashrom: fix build on big-endian targets","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a67736ae996ca53a4581208abc4f1b56452be887","submitter":{"id":69614,"url":"http://patchwork.ozlabs.org/api/1.2/people/69614/?format=json","name":"Florian Larysch","email":"fl@n621.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/buildroot/patch/20260413000423.9275-1-fl@n621.de/mbox/","series":[{"id":499637,"url":"http://patchwork.ozlabs.org/api/1.2/series/499637/?format=json","web_url":"http://patchwork.ozlabs.org/project/buildroot/list/?series=499637","date":"2026-04-13T00:04:22","name":"[1/1] package/flashrom: fix build on big-endian targets","version":1,"mbox":"http://patchwork.ozlabs.org/series/499637/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222577/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222577/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming-buildroot@patchwork.ozlabs.org","buildroot@buildroot.org"],"Delivered-To":["patchwork-incoming-buildroot@legolas.ozlabs.org","buildroot@buildroot.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=buildroot.org header.i=@buildroot.org\n header.a=rsa-sha256 header.s=default header.b=k8AVVYAO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=buildroot.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=buildroot-bounces@buildroot.org; receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv7CH4swZz1yDF\n\tfor ;\n Mon, 13 Apr 2026 10:12:43 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id BF71B42454;\n\tMon, 13 Apr 2026 00:12:40 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id hXx6SZ21u_PQ; Mon, 13 Apr 2026 00:12:39 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 7F4EB4245E;\n\tMon, 13 Apr 2026 00:12:39 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id BFBB8283\n for ; Mon, 13 Apr 2026 00:12:37 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id A967B8444E\n for ; Mon, 13 Apr 2026 00:12:37 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id zBwVwseZidNn for ;\n Mon, 13 Apr 2026 00:12:36 +0000 (UTC)","from nyx.n621.de (v4gw.hekate.n621.de [136.243.2.102])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 7EB3284339\n for ; Mon, 13 Apr 2026 00:12:36 +0000 (UTC)","from eos.home.n621.de (localhost [127.0.0.1])\n by nyx.n621.de (Postfix) with ESMTP id 83D8BE006E3;\n Mon, 13 Apr 2026 02:04:40 +0200 (CEST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=buildroot-bounces@buildroot.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7F4EB4245E","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 7EB3284339"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=buildroot.org;\n\ts=default; t=1776039159;\n\tbh=LlYmxQdr87BpzjHM3Euzg9pragU8du/clHEuM3uWRl0=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=k8AVVYAOzrm/2XZ6TnJcT38PYwVQIyvuTtzDxe2xBMQAZ9eVjpU0/gHoSW/wDtmVa\n\t rQvPQErqJui+JN7fGTVwTDY8tJiWzWq5FhuGNUas309o4MbVcXv8aUsVs1XbLDfZRg\n\t qD02/4Rdb9STwjUWsnB1FmcqXoWFobZySx9hdYrhjif4d673bUMdrkoXgmQsSspXNE\n\t sQL4aGPfSQ9nlMnQs5mQmFkdZoGlbyCoqp5BDq4LIO/zc6m/szzgHq5NwYki3YaV9d\n\t wdnFsXv7ayI3vFSFbXildl6nsfcI5T9B31hfbcZumnHwKvJhonvKi41fW2+4yrFn5N\n\t NQ1szaJptKbTg==","X-Greylist":"delayed 472 seconds by postgrey-1.37 at util1.osuosl.org;\n Mon, 13 Apr 2026 00:12:36 UTC","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 7EB3284339","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=136.243.2.102;\n helo=nyx.n621.de; envelope-from=fl@n621.de; receiver=","From":"Florian Larysch ","To":"buildroot@buildroot.org","Cc":"Thomas Petazzoni ,\n Florian Larysch ","Date":"Mon, 13 Apr 2026 02:04:22 +0200","Message-ID":"<20260413000423.9275-1-fl@n621.de>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=n621.de; s=dkim; t=1776038680;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:\n content-transfer-encoding:content-transfer-encoding;\n bh=WMoWJ7u6PcAjQONZ4HuuQZ11/FPm6C6tt0IXvEkcgO0=;\n b=Ya0HKuMv33R/Ju490Z9dact+l0OQ79+m0xKhgVbDjLj5YUencLOjoKVdcBj1jxqNor96nf\n wiXsRO4Mdip7FEdjYWpOaUwFPFbJfid8awXsR0NlTIa/FHKCwZk+z2X3UMuHooc7w8dlfq\n jGr6dkx3U8913HPcrWDWqebJO1hVYUk=","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=n621.de","smtp1.osuosl.org;\n dkim=pass (1024-bit key,\n unprotected) header.d=n621.de header.i=@n621.de header.a=rsa-sha256\n header.s=dkim header.b=Ya0HKuMv"],"Subject":"[Buildroot] [PATCH 1/1] package/flashrom: fix build on big-endian\n targets","X-BeenThere":"buildroot@buildroot.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Discussion and development of buildroot ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"buildroot-bounces@buildroot.org","Sender":"\"buildroot\" "},"content":"flashrom 1.7.0 fails to build on big-endian targets because of an errant\ncompile guard. Import the pending upstream patch that fixes it.\n\nFixes: https://autobuild.buildroot.org/results/d75/d75f5a555b7ad1a99ffe46298bf6f527f3bafbc9\n\nSigned-off-by: Florian Larysch \n---\n ...hrom-fix-build-on-big-endian-targets.patch | 54 +++++++++++++++++++\n 1 file changed, 54 insertions(+)\n create mode 100644 package/flashrom/0001-libflashrom-fix-build-on-big-endian-targets.patch","diff":"diff --git a/package/flashrom/0001-libflashrom-fix-build-on-big-endian-targets.patch b/package/flashrom/0001-libflashrom-fix-build-on-big-endian-targets.patch\nnew file mode 100644\nindex 0000000000..f09a39d137\n--- /dev/null\n+++ b/package/flashrom/0001-libflashrom-fix-build-on-big-endian-targets.patch\n@@ -0,0 +1,54 @@\n+From 13c19fccd7946c692e587e308c916a1090d3592d Mon Sep 17 00:00:00 2001\n+From: Florian Larysch \n+Date: Mon, 13 Apr 2026 01:40:52 +0200\n+Subject: [PATCH] libflashrom: fix build on big-endian targets\n+\n+Commit f74f02e2 (\"Add guard for compare_region_with_dump()\") added\n+little-endian-only compile guards to that function because it was only\n+used on little-endian systems and caused -Wunused-function to trip on\n+other targets.\n+\n+When b0b975d0 (\"libflashrom: Add new layout_compare() function with\n+test\") introduced flashrom_layout_compare(), it included the new\n+function within those guards too, but this isn't necessary:\n+compare_region_with_dump() is not sensitive to endianess and adding that\n+new dependent actually made the original reason for adding the guard\n+obsolete.\n+\n+However, now building on big-endian architectures fails because\n+cli_classic.c unconditionally refers to flashrom_layout_compare().\n+\n+Resolve this by simply removing the guard.\n+\n+Fixes: https://ticket.coreboot.org/issues/635\n+\n+Change-Id: If3e6828e6445e0708e1174728f91053e48a097ba\n+Signed-off-by: Florian Larysch \n+Upstream: https://review.coreboot.org/c/flashrom/+/92156\n+---\n+ libflashrom.c | 2 --\n+ 1 file changed, 2 deletions(-)\n+\n+diff --git a/libflashrom.c b/libflashrom.c\n+index 159e3924..503386fa 100644\n+--- a/libflashrom.c\n++++ b/libflashrom.c\n+@@ -462,7 +462,6 @@ bool flashrom_flag_get(const struct flashrom_flashctx *const flashctx, const enu\n+ \t}\n+ }\n+ \n+-#ifdef __FLASHROM_LITTLE_ENDIAN__\n+ static int compare_region_with_dump(const struct romentry *const a, const struct romentry *const b)\n+ {\n+ \tif (a->region.start != b->region.start\n+@@ -508,7 +507,6 @@ int flashrom_layout_compare(const struct flashrom_layout *layout1,\n+ \n+ \treturn 0;\n+ }\n+-#endif /* __FLASHROM_LITTLE_ENDIAN__ */\n+ \n+ int flashrom_layout_read_from_ifd(struct flashrom_layout **const layout, struct flashctx *const flashctx,\n+ \t\t\t\t const void *const dump, const size_t len)\n+-- \n+2.53.0\n+\n","prefixes":["1/1"]}