{"id":2222576,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222576/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260413000325.33379-1-tactii@gmail.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260413000325.33379-1-tactii@gmail.com>","list_archive_url":null,"date":"2026-04-13T00:03:25","name":"[iwl-net,v2] e1000e: Unroll PTP in probe error handling","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"43fe144f52a249eb8463cdf7d708bbb09e8af1e5","submitter":{"id":92679,"url":"http://patchwork.ozlabs.org/api/1.2/people/92679/?format=json","name":"Matt Vollrath","email":"tactii@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260413000325.33379-1-tactii@gmail.com/mbox/","series":[{"id":499636,"url":"http://patchwork.ozlabs.org/api/1.2/series/499636/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499636","date":"2026-04-13T00:03:25","name":"[iwl-net,v2] e1000e: Unroll PTP in probe error handling","version":2,"mbox":"http://patchwork.ozlabs.org/series/499636/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222576/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222576/checks/","tags":{},"related":[],"headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=q0eElVWn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv71N1bhlz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 10:04:05 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C4AF542469;\n\tMon, 13 Apr 2026 00:04:02 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id VTd3TsHhU05x; Mon, 13 Apr 2026 00:04:00 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id A701142468;\n\tMon, 13 Apr 2026 00:04:00 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133])\n by lists1.osuosl.org (Postfix) with ESMTP id D558F237\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 00:03:58 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id C6F90407A8\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 00:03:58 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FfbeK-UdGky9 for <intel-wired-lan@lists.osuosl.org>;\n Mon, 13 Apr 2026 00:03:58 +0000 (UTC)","from mail-dy1-x1334.google.com (mail-dy1-x1334.google.com\n [IPv6:2607:f8b0:4864:20::1334])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 28CD0407A1\n for <intel-wired-lan@osuosl.org>; Mon, 13 Apr 2026 00:03:57 +0000 (UTC)","by mail-dy1-x1334.google.com with SMTP id\n 5a478bee46e88-2d868d014a5so536211eec.1\n for <intel-wired-lan@osuosl.org>; Sun, 12 Apr 2026 17:03:57 -0700 (PDT)","from devobuntu.lan ([2600:6c5c:6b00:ba4::23])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2d561cd2a4esm18067085eec.16.2026.04.12.17.03.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 17:03:56 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org A701142468","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 28CD0407A1"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776038640;\n\tbh=bLZ2hGvxy/AXXUxBlYW4a7XQvCB2LmyGHSGavvwLlRA=;\n\th=From:To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive:\n\t List-Post:List-Help:List-Subscribe:From;\n\tb=q0eElVWnGM4J3GnRY4qeDgU//QFQjqVR7KiXGTxKeWTmBuU/qtRaH6JvF2zmx5xx0\n\t BtYgXLanlzn25F/i74yGkcnpH8/AdqLr1vwLysh4iWYcuI+46hNQbjp9B6W7GMQ1sg\n\t C4F6cP6zfpTI5p84UH1ohtEUi2NSf4foSJHHf8QWlgBnNSoNaxQmpMrdYQKRmIvi0Z\n\t MR+ds8G0cpIVhqkGYue1k26582qpV8tuz1CVFwMRBK0AN//1eBnGSH1nFhhaomZzIz\n\t FySVeY0yii6QeV/nBESL7AHrvhwPyKNmc00MgF6pfN50Zqhcq9G9EkQb7AqBBznPLr\n\t CoCJFZMgERNqg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::1334; helo=mail-dy1-x1334.google.com;\n envelope-from=tactii@gmail.com; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 28CD0407A1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776038637; x=1776643437;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bLZ2hGvxy/AXXUxBlYW4a7XQvCB2LmyGHSGavvwLlRA=;\n b=OFdimfm4O/W9vJrZqOMjnuJWFeVTp5958IJOZ3o8sCLumGnV6+7p0aRdqkEKJDTTuD\n BxENPUStqpYMPDDtJZl2vAH6EEj3FtCloNDSh41KE4a9TAo6sySSwubg/xqf7ekh5j4B\n 2Ck229j9lnUnnU6r64iQ84EkVMy+UqZTKNmt48rVfccj0w3Q8r6skk2DquwZjY3pUsTI\n k6IhrFLPVpsEkLnxAP+tLJ1by5lTX5ybBBVSaKufI88n7umxC1kHT52gyI1hV2+73E1g\n 3C2OJtugn/3znwviqeHNadC/Q888npWId2bzjgQwza5CkKIf+KTRoe5vVaPQQbqk+3O2\n Dxjg==","X-Gm-Message-State":"AOJu0YzYc97whEREKRlhuL7hUoNZ18NvO8PlpRd/JipIpC10k4eTTnSm\n fWl5muUEqkCIaj5SeBaOG259UX5Ve2Tonwea5XSudJCrUE4P/aBHBiA01mbjWZLyYPg=","X-Gm-Gg":"AeBDietp2jjH20qwUCV7z5ZTSoseghHba0s1mTUgpprvsalZeWNslQw6prArWiXhDnr\n pA/zeTlc6iBq+Wzsshvj97XcsQ8/g/6C4um7+sSM8zUI5s2FkcPPzPld3ulRYqIuuVPev1dGUFB\n NuX0RFSxK5N8K27XG1s/T3F+E76voaiOhv9861Hqzw9Uq6ZQUKvq+Sdsl2QXv7ZMG8C97VOsWZR\n NK1D63pMzBPKJ2HJevb9IyYFN1byteTCQ9s41SbYzG2xe1mt2UKK5xWehNUnZxA6PZeomO2WPOP\n 3FK0TFUOsksou3Xc6yn008aPH/6rnEpHuHY9w9I/mQkKd2d55E6JhsJI/nWToCml4Pn3SkNUux+\n 4bjjob/b6Zf5Y3njdon/d8v68zT12EXGSOACOY7XzC4qAg//WtVgvo4KFaR7aeo5JvKZaCA23F1\n GJEWo=","X-Received":"by 2002:a05:7300:dc8b:b0:2d9:f0b3:1d98 with SMTP id\n 5a478bee46e88-2d9f0b33952mr27219eec.7.1776038636511;\n Sun, 12 Apr 2026 17:03:56 -0700 (PDT)","From":"Matt Vollrath <tactii@gmail.com>","To":"intel-wired-lan@osuosl.org","Cc":"Matt Vollrath <tactii@gmail.com>, stable@vger.kernel.org,\n Avigail Dahan <avigailx.dahan@intel.com>","Date":"Sun, 12 Apr 2026 20:03:25 -0400","Message-ID":"<20260413000325.33379-1-tactii@gmail.com>","X-Mailer":"git-send-email 2.43.0","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776038637; x=1776643437; darn=osuosl.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=bLZ2hGvxy/AXXUxBlYW4a7XQvCB2LmyGHSGavvwLlRA=;\n b=W/Pq9fcLEwQR5nVig2Ym0dv8nHZNt4reHMdi8YExfmiZiO4nQBeRSLwdllHwhas1e1\n JhsqB11+psJouU0s9BHBpE00FqRr6WGLsxai7k/7x+f4ZTiqz7r4r1KiNFkooR1qLTeD\n mVmScWw38ez8wZIGDBVkzLG5bnZmZqtPCQEHS6l5751shRb/XCN7nbGKRddBJ6xGb20t\n tkaoNYjZpl2f9qz4la4BDo+fHzOr7BwZ9EP1NyIcml/d1PpQzX5/15dkqqriPJ7DiuuO\n OT6hyI3vrHB67CQApK4o+XREf4SjJf7FIFzVxDCQEA/R7v+mTeb30PgNDwo31oSbQVaa\n h5jA==","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=gmail.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=W/Pq9fcL"],"Subject":"[Intel-wired-lan] [PATCH iwl-net v2] e1000e: Unroll PTP in probe\n error handling","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"},"content":"If probe fails after registering the PTP clock and its delayed work,\nthese resources must be released.\n\nThis was not an issue until a 2016 fix moved the e1000e_ptp_init() call\nbefore the jump to err_register.\n\nFixes: aa524b66c5ef (\"e1000e: don't modify SYSTIM registers during SIOCSHWTSTAMP ioctl\")\nSigned-off-by: Matt Vollrath <tactii@gmail.com>\nTested-by: Avigail Dahan <avigailx.dahan@intel.com>\n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 9befdacd6730..7ce0cc8ab8f4 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -7706,6 +7706,7 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)\n err_register:\n \tif (!(adapter->flags & FLAG_HAS_AMT))\n \t\te1000e_release_hw_control(adapter);\n+\te1000e_ptp_remove(adapter);\n err_eeprom:\n \tif (hw->phy.ops.check_reset_block && !hw->phy.ops.check_reset_block(hw))\n \t\te1000_phy_hw_reset(&adapter->hw);\n","prefixes":["iwl-net","v2"]}