{"id":2222569,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222569/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412212547.29645-1-philmd@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412212547.29645-1-philmd@linaro.org>","list_archive_url":null,"date":"2026-04-12T21:25:47","name":"cpus: Remove CPUClass::init_accel_cpu() left-over hook","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"4564f8114cb3c6e83a8ffa4f6dcde1c6e3046fad","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/1.2/people/85046/?format=json","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260412212547.29645-1-philmd@linaro.org/mbox/","series":[{"id":499632,"url":"http://patchwork.ozlabs.org/api/1.2/series/499632/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499632","date":"2026-04-12T21:25:47","name":"cpus: Remove CPUClass::init_accel_cpu() left-over hook","version":1,"mbox":"http://patchwork.ozlabs.org/series/499632/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222569/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222569/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=wwzQEL5I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv3Wc43XHz1yGC\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 07:26:35 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wC2Jd-0007qY-Bj; Sun, 12 Apr 2026 17:26:01 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wC2JX-0007qF-Qc\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 17:25:57 -0400","from mail-wm1-x333.google.com ([2a00:1450:4864:20::333])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from <philmd@linaro.org>) id 1wC2JV-00076R-PS\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 17:25:55 -0400","by mail-wm1-x333.google.com with SMTP id\n 5b1f17b1804b1-482f454be5bso40157345e9.0\n for <qemu-devel@nongnu.org>; Sun, 12 Apr 2026 14:25:52 -0700 (PDT)","from localhost.localdomain (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d6864121sm78508835e9.28.2026.04.12.14.25.48\n (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256);\n Sun, 12 Apr 2026 14:25:49 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776029150; x=1776633950; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=Z8VZn4FxpRf32y6yQiXLMXIl12GmZ01c/kHgJ1+ertw=;\n b=wwzQEL5It95IHu11Sufj603V6bpjQHqEwm7FmK36PT+QjWsFUDEtDsp7vMqn2K3KMt\n t4vl41Lm6N2lUER3wG9EZfaS0JT4PYNMAMl9RoXnLyKeRFXkm2SCT9UEexZMh/izBNoC\n DWOvtEKHZgj3FAltG/lg6IxqI9ZLBscGsZX9WpjH4P5jo7aEwpqqHo3ba+J5td9/obXf\n MgY6UBXdZ7Ca83p4bmUSCllo3YWNXQMKltJXiIEmp4U0bwyjMeUYhTsj/GsUF3qAbsC2\n zyj2SO7h5YI5m8J1D5sw1gyefAqutoWeaUqtn5iL0KxV+s3UTUq5um85W74yLux7r9v6\n mN7w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776029150; x=1776633950;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Z8VZn4FxpRf32y6yQiXLMXIl12GmZ01c/kHgJ1+ertw=;\n b=IiWPKgOq7MJ7Q6lHY7AgH85Z62DCeGosd5/vqmTlk5xx4euUevZGnTbK5GOYvENx+M\n Lby8IfVd0HxjKISno3JL2SO9gjnhuDmzMbojmZCnhlOp+58Z1Nzog6/z93b+xg3RYbjX\n lvRm+ZMxPPF+xUMs61jTWUdGR9dS7he4oMfU9bfwAwCR1nfqb5wMytgA4OUloLYY9zzI\n pcSSR38ZHlAhV237Qof8Hr8g366Rv2unWh2a4WgdZRkjL2WCYTbhKIh7rd/ATxZgWily\n CkVZTC6+GhCX3BPV1lkHnd/FgRsd6fsuJBjuFIMykGEMYndNh6b4O+G8LNeysGc9iCqX\n h/Xg==","X-Gm-Message-State":"AOJu0YwsaAfCm0XJUGRq5adThn+juzOhh44S+Za0BNhfgpeNuCreGAOZ\n cEG9nhvt8VS0zfFO4aYp9uOKQ4qPUSnF176Eu8ZrbjQNzn9jxxA5is19bxweexbsmdlKdwFj4jW\n Jp7KqMVg=","X-Gm-Gg":"AeBDiesPace+1G8bS6EXM6Lyd71qqwydTiAt47f83B9hLuCnpBbYJRcHzdSiPy3VvRP\n 5leBFFZZaXDZvVY39jbtaw82qHrf8BM8B4FXTIqRR7GheMh2LX3anOcrDDLAfpfevju7K/en5au\n 7TmYgpC9LtlV3SGHeYznBdP/QNdA+Y5WKkFksed7Bk01JMe5QyuZ5hqa1MeRU2TjMBkMAQjtAtT\n yL0+KnE2eLQ0U3bWBt+gQsxbNp5YodwbOR4LrTo0Ju5XcU8UXamjucCyZBMablhPumMKC6asWOq\n g+6fCpMHUb98XrWh2UhmGRzge8ECXIONz4sUte6QDVbHSvw1XEwLzJ454a05My87TzszEdA4pMJ\n MZ9+8OwOk9a8fJCAgZ2pbuS2f1CVFdW2CwgNBhKdEQ9oloEnS2+gVbY+alEnpKnBmF4IodQYLRH\n aA1TFyghRGIc3Oj7PVW6WME/3u1SVth8WnSPD5SYdIXtk35coBFGHTHy9YHx4126Y7VaCqXSpk","X-Received":"by 2002:a05:600c:c10c:b0:486:faa8:9e4 with SMTP id\n 5b1f17b1804b1-488d68cb8demr85362455e9.12.1776029150445;\n Sun, 12 Apr 2026 14:25:50 -0700 (PDT)","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>","To":"qemu-devel@nongnu.org","Cc":"Yanan Wang <wangyanan55@huawei.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Paolo Bonzini <pbonzini@redhat.com>, Zhao Liu <zhao1.liu@intel.com>,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Marcel Apfelbaum <marcel.apfelbaum@gmail.com>","Subject":"[PATCH] cpus: Remove CPUClass::init_accel_cpu() left-over hook","Date":"Sun, 12 Apr 2026 23:25:47 +0200","Message-ID":"<20260412212547.29645-1-philmd@linaro.org>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::333;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Commits f50d0f335a6 and a522b04bb9c (\"target/riscv,i386: Remove\nAccelCPUClass::cpu_class_init need\") removed the last uses of\nthe CPUClass::init_accel_cpu hook. Remove it as unused.\n\nSigned-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>\n---\n include/hw/core/cpu.h |  6 ------\n accel/accel-common.c  | 13 -------------\n 2 files changed, 19 deletions(-)","diff":"diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h\nindex 04e1f970caf..cd03187e116 100644\n--- a/include/hw/core/cpu.h\n+++ b/include/hw/core/cpu.h\n@@ -186,12 +186,6 @@ struct CPUClass {\n     /* when TCG is not available, this pointer is NULL */\n     const TCGCPUOps *tcg_ops;\n \n-    /*\n-     * if not NULL, this is called in order for the CPUClass to initialize\n-     * class data that depends on the accelerator, see accel/accel-common.c.\n-     */\n-    void (*init_accel_cpu)(struct AccelCPUClass *accel_cpu, CPUClass *cc);\n-\n     /*\n      * Keep non-pointer data at the end to minimize holes.\n      */\ndiff --git a/accel/accel-common.c b/accel/accel-common.c\nindex eecb2a292af..9c5b4111c8d 100644\n--- a/accel/accel-common.c\n+++ b/accel/accel-common.c\n@@ -37,23 +37,10 @@ static void accel_init_cpu_int_aux(ObjectClass *klass, void *opaque)\n     CPUClass *cc = CPU_CLASS(klass);\n     AccelCPUClass *accel_cpu = opaque;\n \n-    /*\n-     * The first callback allows accel-cpu to run initializations\n-     * for the CPU, customizing CPU behavior according to the accelerator.\n-     *\n-     * The second one allows the CPU to customize the accel-cpu\n-     * behavior according to the CPU.\n-     *\n-     * The second is currently only used by TCG, to specialize the\n-     * TCGCPUOps depending on the CPU type.\n-     */\n     cc->accel_cpu = accel_cpu;\n     if (accel_cpu->cpu_class_init) {\n         accel_cpu->cpu_class_init(cc);\n     }\n-    if (cc->init_accel_cpu) {\n-        cc->init_accel_cpu(accel_cpu, cc);\n-    }\n }\n \n /* initialize the arch-specific accel CpuClass interfaces */\n","prefixes":[]}