{"id":2222568,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222568/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260412205117.387125-2-hossu.alexandru@gmail.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/1.2/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412205117.387125-2-hossu.alexandru@gmail.com>","list_archive_url":null,"date":"2026-04-12T20:51:17","name":"[4/5] staging: nvec: fix pm_power_off teardown in tegra_nvec_remove()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"bd379b72e4e9e7bdd55956677fb99901e6cb0e09","submitter":{"id":92777,"url":"http://patchwork.ozlabs.org/api/1.2/people/92777/?format=json","name":"Alexandru Hossu","email":"hossu.alexandru@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260412205117.387125-2-hossu.alexandru@gmail.com/mbox/","series":[{"id":499631,"url":"http://patchwork.ozlabs.org/api/1.2/series/499631/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=499631","date":"2026-04-12T20:51:16","name":"[1/5] staging: media: tegra-video: add NULL checks for of_device_get_match_data()","version":1,"mbox":"http://patchwork.ozlabs.org/series/499631/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222568/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222568/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hgPxzRch;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13723-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"hgPxzRch\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.218.54","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv2qQ3Z3Qz1yGC\n\tfor ; Mon, 13 Apr 2026 06:55:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D3C85302BEA5\n\tfor ; Sun, 12 Apr 2026 20:52:52 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BA58D37F8A2;\n\tSun, 12 Apr 2026 20:52:52 +0000 (UTC)","from mail-ej1-f54.google.com (mail-ej1-f54.google.com\n [209.85.218.54])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 78AE337FF48\n\tfor ; Sun, 12 Apr 2026 20:52:50 +0000 (UTC)","by mail-ej1-f54.google.com with SMTP id\n a640c23a62f3a-b9825ba7e8dso532079466b.3\n for ;\n Sun, 12 Apr 2026 13:52:50 -0700 (PDT)","from ahossu.residents.sin.openfiber.nl ([88.202.160.248])\n by smtp.gmail.com with ESMTPSA id\n a640c23a62f3a-b9d6dfd78f6sm263126266b.26.2026.04.12.13.52.45\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 13:52:47 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776027172; cv=none;\n b=kODELcQuTk+Tj5l5L3uC8v6sQCmoFF6SduI0empg03XCw6HWZ5Bg/Dbl+Mngmql2Rn84ny+h0NkP2WpdicyvfifOisazRKG8iUAyCJDkbIM+ZBPKp+aizgTWZZGLwYnboSL0mPYOJA2w4c22gg65G3cUO63uM2UarSwzuEYgYKg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776027172; c=relaxed/simple;\n\tbh=V3bsKhIGaACHg6eM2xcGs/HQit58c7w+q2E2j1CAkeY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=OliD1Iwa58KBHaJHiKb0AIGSVcS0my0L2dlRnPvx1aJPNbJnyzBTmR1nVYA1O25FQAjFtbvmtT0zlwEcOjYMaJWUJUhrIArlXw6+hNbUlvbubfhLFpAXC7R+UY19iltaLyj0VtoWK/CswKV4HyIoGzRlac0J7e4DFJjI8jKGiKE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=hgPxzRch; arc=none smtp.client-ip=209.85.218.54","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776027169; x=1776631969;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=ZsyBN8eqgGgLu6vT6sEQv8tzWdzbqq6eDTPaal4nWic=;\n b=hgPxzRchTAuPXQGf+g7xsJUR487jBlBPP+t988slnWuQPcc/3AexiH5o7vut8s2wJA\n HO7RAukpTJapG4GeoTOYyP0TS6t7B/wZ7Z/fXbx6klaIazKM3CxV/6GUkfqD30f0Nqob\n HmIvJLMbpUDYK5oEkH7D/bQ5qhHkGvfJ6I/VFk3IBXCsJithZcO/YmYRNx9lhxTR/G7D\n WWshUNwzuK6KomO1qBGSM6Kt5zu/++lQsY+s63J8/fWwADaYPPXdQgwpDgNgJKk8ql2l\n c/OOqdR08MB6rObv6PDMvpVBjZIt1DeiS8uKx7SWJRFCJJokZNWOt2WIxKGXUTqYdn83\n 9LkA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776027169; x=1776631969;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=ZsyBN8eqgGgLu6vT6sEQv8tzWdzbqq6eDTPaal4nWic=;\n b=JEgGnGuvn/gfmNkz+ejEmiHNkDErHnNsbEmjiygmZEH5IT4V2aHDW9nCKhv+DviC/y\n 6vaKypconJG6HAwETmz8LPOGaDd+L4Wjqe+zNLmDg1l+1BlNAAVxS0eqTkBLd07yFBcc\n iEz61TZs3PfEto/zN03MDVDEKgIcuM3LQlNaRlzkAOZJXOsCejrK68iCtapXY4UyRIFi\n nvM40OqNq5E7eOM/VYTDxZv1twR6kfXiPtS52IcNZIUeSIRhdE25bxUDxgH2wod1T/63\n Ss7hQ28+1hTSo/6tc9PQ/m+Gl9vkvwUPYkFZRIf4QKMK95SG0q+0/KvJBh7Ljgvnz0lo\n bw+Q==","X-Gm-Message-State":"AOJu0Yw3p7iutsKRyfKNJgxeiShmnE68hgXBT1h6V498jqKxmqd+K//K\n\tXBr/qb/xKacL1iA+G0FRbHmu9EC96O728r0TB0dE/F0aY/wN6Dafoj/t9rnWv1wAnwg=","X-Gm-Gg":"AeBDietMhUT58oekWYLynh5LnP1hm9rf/L4I1S8CXwEysfNis9DG1TAIAkUFRDilqdM\n\tIvrt/F8Kd5g54zOCNp5Cbg5t9fdnzoFcx+KDH0hNo0XeU3eum2aUDPxPW1o7aCV3ADkQ83QGvD6\n\tDtiRqf/4MuZQLmzYpHvGXIcmO3tum/KwZWwayTGbORHUpIrAtWw2Oh2qva5GxS/gwMgVDzkzGRB\n\t94XP2emOkwdF+TpRKwBdBP1XCBEDDrDL0uUIj03styS3XoTGqImUKEZ/fiLvnOwqcCXcmSVV0CN\n\tEDOAwQBPwdh4OQcDLPM46gtFFUhmJ3f+531kLh76EOyyZ3onWhgs1HTVrmnj/Lla1a+3VMdt3Oa\n\tzFkSxR1cmPRPBgMQ2CBvtVnWaf6cS7JPdFU1exsAQpxilOlLBPJj0oe/gmzB0phMDNdBsM7l1s9\n\t34KdtSm+S5GFR9ig5uLGZDyEyd1xfX5UT1VIkKWp39u/XqIx2hY3jMq1eblPb6hF7BY/WGCNA1Y\n\tqEjOU8lBgXkg1mco7aL6MyPTtRQkhyjb5Wc0OnLM7WDfmkx2SYAQY7g7fRHM8ayHDvNZej4cvDt\n\tvi47KA==","X-Received":"by 2002:a17:907:a603:b0:b97:c5e2:d7c9 with SMTP id\n a640c23a62f3a-b9d729bd51dmr596748166b.44.1776027168505;\n Sun, 12 Apr 2026 13:52:48 -0700 (PDT)","From":"Alexandru Hossu ","To":"linux-tegra@vger.kernel.org","Cc":"marvin24@gmx.de,\n\tgregkh@linuxfoundation.org,\n\tlinux-staging@lists.linux.dev,\n\tlinux-kernel@vger.kernel.org,\n\tAlexandru Hossu ","Subject":"[PATCH 4/5] staging: nvec: fix pm_power_off teardown in\n tegra_nvec_remove()","Date":"Sun, 12 Apr 2026 22:51:17 +0200","Message-ID":"<20260412205117.387125-2-hossu.alexandru@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260412205117.387125-1-hossu.alexandru@gmail.com>","References":"<20260412205117.387125-1-hossu.alexandru@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"The remove() function unconditionally sets pm_power_off to NULL regardless\nof whether this driver instance was the one that set it. There is even a\nFIXME comment acknowledging this. Additionally, nvec_power_handle is never\ncleared on removal, leaving a dangling pointer to freed device data.\n\nFix both issues: check that pm_power_off still points to nvec_power_off\nbefore clearing it, and also clear nvec_power_handle at the same time.\n\nSigned-off-by: Alexandru Hossu \n---\n drivers/staging/nvec/nvec.c | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/staging/nvec/nvec.c b/drivers/staging/nvec/nvec.c\nindex 75877038847f..9fe9b7a3491d 100644\n--- a/drivers/staging/nvec/nvec.c\n+++ b/drivers/staging/nvec/nvec.c\n@@ -907,8 +907,10 @@ static void tegra_nvec_remove(struct platform_device *pdev)\n \tnvec_unregister_notifier(nvec, &nvec->nvec_status_notifier);\n \tcancel_work_sync(&nvec->rx_work);\n \tcancel_work_sync(&nvec->tx_work);\n-\t/* FIXME: needs check whether nvec is responsible for power off */\n-\tpm_power_off = NULL;\n+\tif (pm_power_off == nvec_power_off) {\n+\t\tpm_power_off = NULL;\n+\t\tnvec_power_handle = NULL;\n+\t}\n }\n \n #ifdef CONFIG_PM_SLEEP\n","prefixes":["4/5"]}