{"id":2222564,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222564/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260412195947.1982729-9-ravi@prevas.dk/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412195947.1982729-9-ravi@prevas.dk>","list_archive_url":null,"date":"2026-04-12T19:59:47","name":"[8/8] drivers/core: use memdup() instead of malloc()+memcpy()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"f6206d3abb5a44f943ce7f16e8fbffb91915b808","submitter":{"id":89443,"url":"http://patchwork.ozlabs.org/api/1.2/people/89443/?format=json","name":"Rasmus Villemoes","email":"ravi@prevas.dk"},"delegate":{"id":3651,"url":"http://patchwork.ozlabs.org/api/1.2/users/3651/?format=json","username":"trini","first_name":"Tom","last_name":"Rini","email":"trini@ti.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260412195947.1982729-9-ravi@prevas.dk/mbox/","series":[{"id":499629,"url":"http://patchwork.ozlabs.org/api/1.2/series/499629/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=499629","date":"2026-04-12T19:59:41","name":"add memdup_nul(), use it and memdup() in a few places","version":1,"mbox":"http://patchwork.ozlabs.org/series/499629/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222564/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222564/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.a=rsa-sha256\n header.s=selector1 header.b=h2reCL1m;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=prevas.dk header.i=@prevas.dk header.b=\"h2reCL1m\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=prevas.dk","phobos.denx.de;\n spf=pass smtp.mailfrom=rasmus.villemoes@prevas.dk","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=prevas.dk;"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv1dM3NDXz1yGg\n\tfor ; Mon, 13 Apr 2026 06:01:27 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AAE0984214;\n\tSun, 12 Apr 2026 22:00:10 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 9FF1C841A2; Sun, 12 Apr 2026 22:00:08 +0200 (CEST)","from DB3PR0202CU003.outbound.protection.outlook.com\n (mail-northeuropeazlp170100001.outbound.protection.outlook.com\n [IPv6:2a01:111:f403:c200::1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 0280E839D5\n for ; Sun, 12 Apr 2026 22:00:04 +0200 (CEST)","from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:681::18)\n by GV2PR10MB9930.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:150:341::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Sun, 12 Apr\n 2026 20:00:03 +0000","from AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8]) by AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n ([fe80::ebc6:4e0d:5d6b:95d8%5]) with mapi id 15.20.9769.046; Sun, 12 Apr 2026\n 20:00:03 +0000"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=AAwjVDFy9PDBxmXpe0OjR2Ng2vQbLz2zwmPu4PRv9qeSBpvf1ssI+3LTwJCkjrdDaA75K296T/AlnzxgjwpJhvTBbxnD5oidp0Y7DwXz7gHysPWN9/0yEnyBvU/PYocRfkYRZixXF/eNu8QjgXhz3P/5QIMwR6jqLrBeMBfjHZsEhoukBTQvPvqk+tQ5SvQMaQdRj7YoRW9ZFVsAbLmS6IK0sxdi+E706KFWdJw1ObF3dvcK6D/Ut6joigk+wO+xAaMzNMgVUeS2e76ifWP4/1/fN5j5i5dZ0YyZr/Ht/vy7Mj591a5wPhUeg82rabWTfbPA93ZjpL+Y2gmz0eFLrQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=jULvsvXDnO6LZuUUTO4Kv2szZFU7msyKQpbEMlXdqFM=;\n b=Qp/79Lkx5H+LM2gxkVejHzdIPpsNGdTXOcni/cfvG46ZGk46RIw+YvR+venRmkaoaECrE+ioXS+ZTkAnBYYqSt/+yi/l7d7OL87aLHMH5BDdFHBMFKLJi7hGFEkP4U4XA1Cul8VeNTZ8Dr0hHMnumHdtRNe5mSO1VE/tka5pQLmfIxz+CbmiEyWjDW37v1NjBY+rytFQih/wJ+htb/XBGISIekUkK8WYTf3J7tDFhHXkY/45RHf4IlADW+D3dHL07WSWSnSSNeODIHikDGlbsdzAoROOkqzMIyIou5o0CXK6eJ9EBdl71c7gzIKsOMZYWFwaVwNQUNxBhy2cMTui4A==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=prevas.dk; dmarc=pass action=none header.from=prevas.dk;\n dkim=pass header.d=prevas.dk; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=prevas.dk;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jULvsvXDnO6LZuUUTO4Kv2szZFU7msyKQpbEMlXdqFM=;\n b=h2reCL1miSCnXn32x1lp/j68EgkTrTBdk+aEIvYlNfyxJ5bnJ9VnRaaJnDJYdVAbAXy8qucrRlIyewzlQFjvbWO9E5WoR8qpwbyBJzjIrMRkfYIfAkyYJj9HcI4WzgA9vZtvN87w+7x0Y/w/eDZQRQp6Xjq5huqjR20BMpnn0e4=","From":"Rasmus Villemoes ","To":"u-boot@lists.denx.de","Cc":"Tom Rini , Simon Glass ,\n Rasmus Villemoes ","Subject":"[PATCH 8/8] drivers/core: use memdup() instead of malloc()+memcpy()","Date":"Sun, 12 Apr 2026 21:59:47 +0200","Message-ID":"<20260412195947.1982729-9-ravi@prevas.dk>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260412195947.1982729-1-ravi@prevas.dk>","References":"<20260412195947.1982729-1-ravi@prevas.dk>","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain","X-ClientProxiedBy":"CPCP307CA0003.DNKP307.PROD.OUTLOOK.COM (2603:10a6:380::12)\n To AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM\n (2603:10a6:20b:681::18)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"AS5PR10MB8243:EE_|GV2PR10MB9930:EE_","X-MS-Office365-Filtering-Correlation-Id":"21893862-bd71-4d28-3b4e-08de98ce1630","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|52116014|376014|1800799024|366016|38350700014|18002099003|56012099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n EbMfs2PzDfiX+jGOrzzLoKvvqjaVpawQCwXOWEF9DJWYAaQCiiT+3KyK4FnysHRBjmSSDbDD1K9PLtwO9QILo6y7cOBabdC+apkn3a2GsgIZsDaasKone3UEO4peFWOxjx5tdFeu3pxWhOeWsXnKG6at0PDyodJ2gk7JHgTE+pKzAGvle3Nn/GO23Na8lB0dBmMjkalnFY6lDJq30PQiElLeQwi6HA4YRk+dE3lz4mFWIcFQMU8iY1ksoe+WJuNcPh4RQ+MsGnBer+7HzfLDSaY3A2azhHn9KUex5jy41fS2aqBd3LS8VfW3Hn/ZlFncK7/wCyGNQmS5QyhpWxk9iggk+IXBUnTv51/A7UUa6lN2+WRJXsuWB3ohFya/rS5stKk8JQ6i0ylmR/L/wp44Z44c3+dxbm6LBI9izdzcha7q+1Ur3kv7FO9c4iTCihgEIR+257uvmpuvBhBbfZX82t+XFZQUQDfQGzWomTqTlcue2CJ4KhV8XDJCGywFyIiCOsuR7WDZt3UJ6sXco+ZknJ79M+ikosYUyYhBiNqdjCDlv6pY4Hefq7g7BgjX40y93iL41/Ms+IE4wfuLMtXlfJmYYB6KfbIsrrlKI8rRpp08pZ4Z6cUnQ27J0Q6PVXu4YwcnkkSAxjovI1dTSZZoqY+M1Lk18tIQTzYDCqCekFr5NeODsyRf3a+N3HNSiAxzN1PHnhslDI8IA5TbhNa0PnnOtEDoqQ9cVj5/v7R2iFsTTixrQ/ktNJTlV82W78vP4AI7uvSQh46H2vwKpyJ0QyshCrqnoRpQPK0oGOSMslA=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM; PTR:; CAT:NONE;\n SFS:(13230040)(52116014)(376014)(1800799024)(366016)(38350700014)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"\n fRfhhitgM+oRoXKwKWmua5COolUCfocIUfHdAuXw7CA498d+6wGNPbG9KDDL+mgbFyJfkQMHtsZ/F/1oiqWjSLze5U6kaeVsnJJVz1EHnvxxj/9Hypm2npjK/BnwBa/Bbc9u8xS9Xub/nSXL+DIf6+p406MGSEZPSWY1nMCNoA0Fvcj547qpsk4FrCGSIJbVghK0i5z2SKIoX0QtB4RP0O1zERbH4nXiumsvWM7CzsZTpfLmrcu46FN3JqVxOtxDlomkO+Fux3t25rtb5TiykGHS5grk2zOrmgpr0+AaJNoHTM4tnOUuipwyC06BS+kV0ho4wL2VDPOOSyTPGezxGsV3VLY9XbZP7gyC57YZq+F0XgvMIFaDfXGTgekYaaS+Ib+HihOokp8RK2fMXhKie9lt8NVqrqqvnzMa4h+uQE8JQgjww4obl/SV8ie28ZGyZrqQloG9OWYluLt8MWyEVkdgiiPrmT6TjGyQ1hnWrlXQFjDADpYGpBzegxmhNVQieTAqb9Wcg1y5I/QZA16bhitBDJSKOq7AEJ0JeI78zn3CIR6wZRkv+smRji1SAFbc6wUbB6XwkmWKvY6ToWpFP9CaERd5AvlkKNz5xQWz9d1AvOYXGwlJMEjd56bz3ZYHsjpg7KM0/F7yHGvn8UvaBvET0iXYdU7fXf+OPtW3OOjpGr8pl+WuFrPVVR98z82genaYO89yCyrQ4WGz4yJC68p4NkKdHLElGqojUEnnFIZHWZggkXBr7XWz1giYqxKknjJSWe2BN5g9uXZFmd2bH4wPmzuZLhPIwoOlDedp5Wpuz0+/d+bde2t7LiLW4mCoP881kxO6zmLcqtjMfPCsyxRdkIpcDQ2yo98RT7KilqB02eUi5sJgyPNcwEUzPCKyobZFOXKpUxJRkC/KlZW5Mk1nELccrtWybW2nTxCOghroKKKPhrFN7006+RQCFbRx/U+92B7FDDl4VVq4G6quB4nxjn3QdsWtMNEFXShEe3ztmhoz0ZSCK3drrNp2aEQtPID8tAkdaZxBFlXTYM6Og5FvCQ8Nf6AR+lk8T5VSZxkWtYw19t5PlJQiJX6l+/6w/ZDkLAUROyk1xp1cO+DupLascws++shlwutnA5VS43ISti13LqzwW5KufqHUFmmY4a99nzbTgJJy/SKHB4wWzY3+ZqhWRxMQ4YeS5q3nvKYw9lTOH0ZUuN49t99bAqiBVhsONzMbi6xg1IJoD/seuKoMAS9gXWrsRDz8OqpK0SxXSobOSM8GdanBh/di5WIs7AzpsxC3kF7oO7SPfhTdGrOtK5/DKJIIbtYzrwo8qYJ89lh7IkVjTdIODD9brmsA/LERbbLeRgt3SwitffDbYupDLQnu0ZMV7XowctqYi9mj03SRCOVvkRhcGLzI9+UAaEp27r7WVn/ourvPi6nGFkfJ6uJ9uMRnjTh0xC7lBz8s7dr0sYgyF9mN6anHfHyOrbQ72rAArmzxNVwPrhLibPGEGtxBBnNn6ln98AkQEedsHgoXOU0C86xjHttzO8Q3XteutHEzL1d7dUTaMCHnUbxHuj86s9HN/eGeoIkJFnfwd1XtQ7fxofp3TLEiICteFexm5uImjGWklNk0ZnR1ucgl/TVS+TfDBSPtDIT2Mr9wdn4MJMKwjkUtpRbXqEn38BGNkSVN+wUTgR9CuqXBJAsMXlnKQLlc6TprMf883Vew1LUhhW0T8V7C9oORDrbhbg0iFH4erbVex6HNp8yNpovvMQw9SA3P67la3Sqnr9A=","X-OriginatorOrg":"prevas.dk","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 21893862-bd71-4d28-3b4e-08de98ce1630","X-MS-Exchange-CrossTenant-AuthSource":"AS5PR10MB8243.EURPRD10.PROD.OUTLOOK.COM","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"12 Apr 2026 20:00:03.6825 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"d350cf71-778d-4780-88f5-071a4cb1ed61","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n +60P9rfvwSKOBrthuQazDmt/BrDwWYLLaIrntXkxFBF3uLrVckl6uan48gjyl5zV7dbvvgaQixpUn0b3tre84drDsRuD7JyjKs/TGd81uoA=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"GV2PR10MB9930","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"Use memdup() instead of open-coding it.\n\nIn the dm_setup_inst() case, there was never any reason to use\ncalloc(), as the whole allocation is definitely initialized via the\nimmediately following memcpy().\n\nSigned-off-by: Rasmus Villemoes \n---\n drivers/core/acpi.c | 3 +--\n drivers/core/ofnode.c | 3 +--\n drivers/core/root.c | 3 +--\n 3 files changed, 3 insertions(+), 6 deletions(-)","diff":"diff --git a/drivers/core/acpi.c b/drivers/core/acpi.c\nindex 4763963914b..6a431171c8d 100644\n--- a/drivers/core/acpi.c\n+++ b/drivers/core/acpi.c\n@@ -154,10 +154,9 @@ static int add_item(struct acpi_ctx *ctx, struct udevice *dev,\n \tif (!item->size)\n \t\treturn 0;\n \tif (type != TYPE_OTHER) {\n-\t\titem->buf = malloc(item->size);\n+\t\titem->buf = memdup(start, item->size);\n \t\tif (!item->buf)\n \t\t\treturn log_msg_ret(\"mem\", -ENOMEM);\n-\t\tmemcpy(item->buf, start, item->size);\n \t}\n \titem_count++;\n \tlog_debug(\"* %s: Added type %d, %p, size %x\\n\",\ndiff --git a/drivers/core/ofnode.c b/drivers/core/ofnode.c\nindex 3a36b6fdd03..12511f10aa9 100644\n--- a/drivers/core/ofnode.c\n+++ b/drivers/core/ofnode.c\n@@ -1750,10 +1750,9 @@ int ofnode_write_prop(ofnode node, const char *propname, const void *value,\n \t\tvoid *newval;\n \n \t\tif (copy) {\n-\t\t\tnewval = malloc(len);\n+\t\t\tnewval = memdup(value, len);\n \t\t\tif (!newval)\n \t\t\t\treturn log_ret(-ENOMEM);\n-\t\t\tmemcpy(newval, value, len);\n \t\t\tvalue = newval;\n \t\t}\n \t\tret = of_write_prop(ofnode_to_np(node), propname, len, value);\ndiff --git a/drivers/core/root.c b/drivers/core/root.c\nindex d43645f34dd..1f32f33b295 100644\n--- a/drivers/core/root.c\n+++ b/drivers/core/root.c\n@@ -81,10 +81,9 @@ static int dm_setup_inst(void)\n \t\t/* Now allocate space for the priv/plat data, and copy it in */\n \t\tsize = __priv_data_end - __priv_data_start;\n \n-\t\tbase = calloc(1, size);\n+\t\tbase = memdup(__priv_data_start, size);\n \t\tif (!base)\n \t\t\treturn log_msg_ret(\"priv\", -ENOMEM);\n-\t\tmemcpy(base, __priv_data_start, size);\n \t\tgd_set_dm_priv_base(base);\n \t}\n \n","prefixes":["8/8"]}