{"id":2222513,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222513/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260412141039.1075095-1-samir@linux.ibm.com/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.2/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412141039.1075095-1-samir@linux.ibm.com>","list_archive_url":null,"date":"2026-04-12T14:10:39","name":"[v2] mem/hugetlb: use SAFE_SHMGET() in hugeshmget setup function.","commit_ref":null,"pull_url":null,"state":"needs-review-ack","archived":false,"hash":"8e0b828cafeccabb4d851e45d3ea90f8066f2449","submitter":{"id":91376,"url":"http://patchwork.ozlabs.org/api/1.2/people/91376/?format=json","name":"Samir M","email":"samir@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260412141039.1075095-1-samir@linux.ibm.com/mbox/","series":[{"id":499609,"url":"http://patchwork.ozlabs.org/api/1.2/series/499609/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=499609","date":"2026-04-12T14:10:39","name":"[v2] mem/hugetlb: use SAFE_SHMGET() in hugeshmget setup function.","version":2,"mbox":"http://patchwork.ozlabs.org/series/499609/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222513/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2222513/checks/","tags":{},"related":[],"headers":{"Return-Path":"<ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=hEj+SPS+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftsvC453hz1yCx\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 00:12:55 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id 248513E2958\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 16:12:53 +0200 (CEST)","from in-7.smtp.seeweb.it (in-7.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::7])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id ECF7B3D024C\n for <ltp@lists.linux.it>; Sun, 12 Apr 2026 16:12:49 +0200 (CEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-7.smtp.seeweb.it (Postfix) with ESMTPS id 4A23A200348\n for <ltp@lists.linux.it>; Sun, 12 Apr 2026 16:12:46 +0200 (CEST)","from pps.filterd (m0356517.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63C2OWkk987509; Sun, 12 Apr 2026 14:12:45 GMT","from ppma13.dal12v.mail.ibm.com\n (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfe17m41m-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sun, 12 Apr 2026 14:12:44 +0000 (GMT)","from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1])\n by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63C9aDek025621;\n Sun, 12 Apr 2026 14:12:44 GMT","from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224])\n by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dg2uj9fvx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sun, 12 Apr 2026 14:12:43 +0000","from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com\n [10.20.54.103])\n by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63CECgrR48496898\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 12 Apr 2026 14:12:42 GMT","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 503342004B;\n Sun, 12 Apr 2026 14:12:42 +0000 (GMT)","from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 59A8320043;\n Sun, 12 Apr 2026 14:12:41 +0000 (GMT)","from ltcden9-lp1.ltc.tadn.ibm.com (unknown [9.5.7.39])\n by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Sun, 12 Apr 2026 14:12:41 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=pp1; bh=zzeLs63ZRH+SUKL0pnPJZGOl3t+5uEAVQv21zhcvc\n Jo=; b=hEj+SPS+VKAdyby0IYSvdnhZ3/Ty88/CaZ0/eZBksoN061SCuZBnXyoi0\n fxrDC8t2DFv9rEoJ92LrnruM/eoj8AfS0m5Kmm/6C7qCdqAX+AiPUeMu04SuHGLd\n Xa0IprXrCNoHLYV1mQUQrZW+xBRBNkxX5v3S53HYXjlMbVdrfU6BFiGSIggj98IO\n pglkeGoR5shB1ojmOewO5w/+4m2Tv5sJSdAzD14afXACdela/aM5XAMCoBMrC8s1\n FXo+oNHRglE2R4p+lKX3pAbEUrs5rbwxwQ6zVTVjtD1KW9YxmpIceV1OzkHoYOfw\n qwKmV0K4ob/JYUugtFI+2VxF2AHLg==","From":"Samir <samir@linux.ibm.com>","To":"ltp@lists.linux.it","Date":"Sun, 12 Apr 2026 16:10:39 +0200","Message-ID":"<20260412141039.1075095-1-samir@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-TM-AS-GCONF":"00","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEyMDEzNSBTYWx0ZWRfX0ZNIuxZSVelc\n 26JEjopSnJCVivd/nF6ZxewWS4e0LfvHV4Qqs2uatAcieX09GYSO1Xhk4C11JIL1sZDe43A3flj\n dKxVRrkw+tPYoRvsPqXAD1y1Z4VRCm+qEwcyQa2dGxDh3YYWvhgL1IK8jh5eCLqsrHVwTHKxYfv\n KdaCtP6IcpBuYJmoJo97M4XGVmGAmgR51GIOVXfXv84TWC142RmZfLK/aYcQcul7Fa2jXZNQNbX\n ZGSuuFPjlaa4MTDVOSgkTZCIRWWMS2Fj646AU9gnH08nJx0/QYjxHvy8c9YZ6eFm2X+norK0iH1\n NMvOZ1vmR2lgC+hWaFRAdrfjqLyXrf9iKJ6EngRbC+Gj1s1CGzKpcqLUO31/L0evyUYvCqivQD6\n PBeIkgBRURUFDfLFJpNifIWTtxIwqLAMuIWkmoQN0NgZAANmM4J4P2PXNrBypNYTJ9zmMWXAFMK\n MnuvHuWFbph+/xEkecA==","X-Proofpoint-ORIG-GUID":"4oYEP5MRX_UduRlrOP4OSnFFesvypL3o","X-Proofpoint-GUID":"4oYEP5MRX_UduRlrOP4OSnFFesvypL3o","X-Authority-Analysis":"v=2.4 cv=SrOgLvO0 c=1 sm=1 tr=0 ts=69dba85c cx=c_pps\n a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8\n a=yhrbMPq3iphc3UI8JUQA:9","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-12_03,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n adultscore=0 priorityscore=1501 lowpriorityscore=0 clxscore=1011 bulkscore=0\n phishscore=0 suspectscore=0 malwarescore=0 spamscore=0 impostorscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604120135","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-7.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-7.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v2] mem/hugetlb: use SAFE_SHMGET() in hugeshmget setup\n function.","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project <ltp.lists.linux.it>","List-Unsubscribe":"<https://lists.linux.it/options/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=unsubscribe>","List-Archive":"<http://lists.linux.it/pipermail/ltp/>","List-Post":"<mailto:ltp@lists.linux.it>","List-Help":"<mailto:ltp-request@lists.linux.it?subject=help>","List-Subscribe":"<https://lists.linux.it/listinfo/ltp>,\n <mailto:ltp-request@lists.linux.it?subject=subscribe>","Cc":"Samir <samir@linux.ibm.com>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" <ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it>"},"content":"I updated hugeshmget02.c and hugeshmget05.c to use SAFE_SHMGET() and configured the setup paths\nso that shared memory allocation succeeds as expected.\n\nIn hugeshmget03.c, I also simplified the tst_brk() message by removing the unnecessary\n__func__ usage and keeping a straightforward shmget() error message.\n\nPatch v1: https://lore.kernel.org/ltp/20260407054943.125260-1-samir@linux.ibm.com/\n\nSigned-off-by: Samir <samir@linux.ibm.com>\n---\n testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c | 7 +++----\n testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c | 2 +-\n testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c | 7 +++----\n 3 files changed, 7 insertions(+), 9 deletions(-)","diff":"diff --git a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c\nindex bbd968c06..f808ac193 100644\n--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c\n+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget02.c\n@@ -12,6 +12,7 @@\n  *\t04/2004 - Updated by Robbie Williamson\n  */\n #include <limits.h>\n+#include \"tst_safe_sysv_ipc.h\"\n #include \"hugetlb.h\"\n \n static size_t shm_size;\n@@ -77,10 +78,8 @@ void setup(void)\n \n \tshmkey = getipckey();\n \tshmkey2 = shmkey + 1;\n-\tshm_id_1 = shmget(shmkey, shm_size,\n-\t\t\t  SHM_HUGETLB | IPC_CREAT | IPC_EXCL | SHM_RW);\n-\tif (shm_id_1 == -1)\n-\t\ttst_brk(TBROK | TERRNO, \"shmget #setup\");\n+\tshm_id_1 = SAFE_SHMGET(shmkey, shm_size,\n+\t\t\t      SHM_HUGETLB | IPC_CREAT | IPC_EXCL | SHM_RW);\n }\n \n void cleanup(void)\ndiff --git a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c\nindex 625761f6e..0e8ad16fc 100644\n--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c\n+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget03.c\n@@ -73,7 +73,7 @@ static void setup(void)\n \t\t\t\t  SHM_HUGETLB | IPC_CREAT | IPC_EXCL | SHM_RW);\n \t}\n \tif (errno != ENOSPC)\n-\t\ttst_brk(TBROK | TERRNO, \"shmget #setup\");\n+\t\ttst_brk(TBROK | TERRNO, \"shmget()\");\n }\n \n static void cleanup(void)\ndiff --git a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c\nindex 336319603..b34c93a08 100644\n--- a/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c\n+++ b/testcases/kernel/mem/hugetlb/hugeshmget/hugeshmget05.c\n@@ -14,6 +14,7 @@\n #include <sys/types.h>\n #include <sys/wait.h>\n #include <limits.h>\n+#include \"tst_safe_sysv_ipc.h\"\n #include \"hugetlb.h\"\n \n static size_t shm_size;\n@@ -69,10 +70,8 @@ void setup(void)\n \tshm_size = hpage_size * tst_hugepages / 2;\n \tupdate_shm_size(&shm_size);\n \tshmkey = getipckey();\n-\tshm_id_1 = shmget(shmkey, shm_size,\n-\t\t\t  SHM_HUGETLB | SHM_RW | IPC_CREAT | IPC_EXCL);\n-\tif (shm_id_1 == -1)\n-\t\ttst_brk(TBROK | TERRNO, \"shmget #setup\");\n+\tshm_id_1 = SAFE_SHMGET(shmkey, shm_size,\n+\t\t\t      SHM_HUGETLB | SHM_RW | IPC_CREAT | IPC_EXCL);\n \n \t/* get the userid for a non-root user */\n \tltp_uid = getuserid(ltp_user);\n","prefixes":["v2"]}