{"id":2222511,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222511/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260412133356.2536585-1-lgs201920130244@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412133356.2536585-1-lgs201920130244@gmail.com>","list_archive_url":null,"date":"2026-04-12T13:33:55","name":"misc: microchip: pci1xxxx: fix IRQ vector leak in gp_aux_bus_probe()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"9bcc86331554838db780d2ba82328ab9bd59c265","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/1.2/people/91722/?format=json","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260412133356.2536585-1-lgs201920130244@gmail.com/mbox/","series":[{"id":499607,"url":"http://patchwork.ozlabs.org/api/1.2/series/499607/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=499607","date":"2026-04-12T13:33:55","name":"misc: microchip: pci1xxxx: fix IRQ vector leak in gp_aux_bus_probe()","version":1,"mbox":"http://patchwork.ozlabs.org/series/499607/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222511/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222511/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-gpio+bounces-35063-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=lF/2lcur;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-gpio+bounces-35063-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"lF/2lcur\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.214.171","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fts2g6mMmz1y2d\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 23:34:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 9C23A3002921\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 13:34:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id BABF737C927;\n\tSun, 12 Apr 2026 13:34:09 +0000 (UTC)","from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE1F37C90E\n\tfor <linux-gpio@vger.kernel.org>; Sun, 12 Apr 2026 13:34:08 +0000 (UTC)","by mail-pl1-f171.google.com with SMTP id\n d9443c01a7336-2ad21f437eeso19996635ad.0\n        for <linux-gpio@vger.kernel.org>;\n Sun, 12 Apr 2026 06:34:08 -0700 (PDT)","from lgs.. ([199.182.234.55])\n        by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d4f27048sm82475495ad.62.2026.04.12.06.34.04\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Sun, 12 Apr 2026 06:34:07 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1776000849; cv=none;\n b=Rs43kcx87szp3uV0KKp0N5x3tALZYV3Mb3pcN5qvYOuZOSoyjLp+zrJK/nQ332eOp8NJPB4/hhIRRCqrh9hpXj35TpHd50MP/Mmsfu+LQPIlDW1LtLZoMqjgyjjZxdfi2PO9Gt24XGWIJr4msG1wW2f3vtvPNpsVDAOgY5n2inQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1776000849; c=relaxed/simple;\n\tbh=xbRuVz0HFLpaBJ4CfsXpXS0+01wpREeXceTWJkuRtHw=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=dnhsjdizjSAuBSevupscCRfvTFZrNs3/Yf2wI+RBiKs9Jq77KPau1SfJ9iPg6zAQi7M8ZjvXjuZhx9f6BudAARxzuEnw6uH34ZsLbU5UQyMu5dk+aCWW2djpgEwbaNnzXeKqsObkBfORwJFDbsRoZ2sNL7ifvySc7/ewt4la9EI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=lF/2lcur; arc=none smtp.client-ip=209.85.214.171","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1776000848; x=1776605648;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:from:to:cc:subject:date:message-id:reply-to;\n        bh=WMBdYVQUfN8Fv6N90jj5d+G39EYg75+iy6wVTIf08KY=;\n        b=lF/2lcurA2UY54pcoIwEJxmp74JWzZAWmAmYJMlabcAGYvrsV+o41ea24aNL+Q1T2q\n         0O1YASTqTIEFRyRcv92QjpS4BcbB0zuuk+CbV6ZjRsJP40hGVm60Uczt1u3ithuikKSR\n         n3Dr9HkClbcjyCb8ic9cnHKK6FG2ShTqwCIgi2dFaf5Z8BdrfOB1lf9Ena9IhvjdD1M4\n         RtRGp8nxTRst8UfYOulkE50tB2vgaIG81ctBB+eUCUOrWDCF6S3cBO/+lcGN1gFNR/6/\n         buuP/iOZIgAwOGmmcK4h9tlXE5TQSeejZy0AE51zT5dP0jR8pSu5GMiw9nndYKQTOBOx\n         IiGA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1776000848; x=1776605648;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=WMBdYVQUfN8Fv6N90jj5d+G39EYg75+iy6wVTIf08KY=;\n        b=FMnCUD/fpvLK/qUDrGcyXXcphl5BOsAuf+SD+q0q6IE65m15dglzM9EiSsbEiX7g2/\n         raEDviDHI0GHPQn6RR44FL/GKSV7+LUiUCXD82+wUNKkRVuzXF24cxij+jLkO7EpC2vl\n         MCiF0r18QfIQbd+4FEKBkAk+6avFiHUrVlv0dLOwf3fjSLyRxWcw1A6z2QHjubdCuBTe\n         +MF5qiHeA9etcrD4kXHpT8UDHDmc5pSl+e2NAGTtxj5QrcxbdHHdrW2IPFJFpu5PqqDg\n         0aaq4onJyvfGlEGEklqcWSP60Ny18QnVDu19EEHpeoqKZJN7g8jiVmz1wQPvtGOmxRZC\n         UkWQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+xOmo6gRkrhB7f0sL4NAOph7oMP884ggkhkcVhpMiQv0wGE8g2J6IApQqLeg60ACCrwEGZ9vtFaSZN@vger.kernel.org","X-Gm-Message-State":"AOJu0Yz0gL+JHiBpYZfzvIjEvVO6b0Dry5avqXH06BmzlNp6d6A+fzMQ\n\t7SNiipQH//GT4F4WdM362sX7OetGW8naZuxUYyWOFTp0VmQGERtFJx2s","X-Gm-Gg":"AeBDieuEvNB37Ky/OrHNnR9b4kchcKDDGGe/5MtNBgrBiMTJhcB1Vv89ZNfK22Ut8IV\n\tGUemVmjsVNtuZubQXmE+SG4KbH9UQmwdbQw9WuW7cySJkh00XVnPu4kZL6u4qf3P0VDNckr+pIR\n\t0FO8PTpkLZ1qHPcG4jMkUyFO++q9RYUAOefK3dlOxFqX0csptitIaWc0GYdYbhJjDwe3gX5+qzU\n\taUPUJeIjmez8w9ZILhKjEQAoVThcHUB8jgcWIF4jlDRkLYrL3wE7EtvkIliXSVmoOtigCJ7GtKB\n\tVk30KG2tR21TrehmmbqDJdLUbtXfORqAtkYsXdKqfRgqwu2/LdZqWsRRnv0+WlG+Ou166ddtPav\n\tPwGPye+C325y5wFvdwADXaWmd2b7wj6IGDnZuluHHE2FklI5yXXfldPgQHxDsPEtmvX2I2aWFaN\n\t8S4I5GUadq8imIG2g=","X-Received":"by 2002:a17:903:22c6:b0:2b0:4fb3:c771 with SMTP id\n d9443c01a7336-2b2c722effamr137776865ad.6.1776000847708;\n        Sun, 12 Apr 2026 06:34:07 -0700 (PDT)","From":"Guangshuo Li <lgs201920130244@gmail.com>","To":"\"Vaibhaav Ram T.L\" <vaibhaavram.tl@microchip.com>,\n\tKumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,\n\tArnd Bergmann <arnd@arndb.de>,\n\tGreg Kroah-Hartman <gregkh@linuxfoundation.org>,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"Guangshuo Li <lgs201920130244@gmail.com>,\n\tstable@vger.kernel.org","Subject":"[PATCH] misc: microchip: pci1xxxx: fix IRQ vector leak in\n gp_aux_bus_probe()","Date":"Sun, 12 Apr 2026 21:33:55 +0800","Message-ID":"<20260412133356.2536585-1-lgs201920130244@gmail.com>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"<linux-gpio.vger.kernel.org>","List-Subscribe":"<mailto:linux-gpio+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-gpio+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"gp_aux_bus_probe() allocates IRQ vectors with pci_alloc_irq_vectors()\nbefore initializing and adding the second auxiliary device.\n\nWhen pci_irq_vector(), auxiliary_device_init() or auxiliary_device_add()\nfor the second auxiliary device fails, the function unwinds the auxiliary\ndevices and ida allocations, but leaves the allocated IRQ vectors behind.\n\nAdd a dedicated error path to call pci_free_irq_vectors() after IRQ\nvectors have been allocated successfully.\n\nFixes: 393fc2f5948f (\"misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.\")\nCc: stable@vger.kernel.org\nSigned-off-by: Guangshuo Li <lgs201920130244@gmail.com>\n---\n drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\nindex 34c9be437432..5e1f99a35100 100644\n--- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n+++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c\n@@ -93,14 +93,14 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id\n \n \tretval = pci_irq_vector(pdev, 0);\n \tif (retval < 0)\n-\t\tgoto err_aux_dev_init_1;\n+\t\tgoto err_irq_vectors;\n \n \tpdev->irq = retval;\n \taux_bus->aux_device_wrapper[1]->gp_aux_data.irq_num = pdev->irq;\n \n \tretval = auxiliary_device_init(&aux_bus->aux_device_wrapper[1]->aux_dev);\n \tif (retval < 0)\n-\t\tgoto err_aux_dev_init_1;\n+\t\tgoto err_irq_vectors;\n \n \tretval = auxiliary_device_add(&aux_bus->aux_device_wrapper[1]->aux_dev);\n \tif (retval)\n@@ -113,6 +113,9 @@ static int gp_aux_bus_probe(struct pci_dev *pdev, const struct pci_device_id *id\n \n err_aux_dev_add_1:\n \tauxiliary_device_uninit(&aux_bus->aux_device_wrapper[1]->aux_dev);\n+\n+err_irq_vectors:\n+\tpci_free_irq_vectors(pdev);\n \tgoto err_aux_dev_add_0;\n \n err_aux_dev_init_1:\n","prefixes":[]}