{"id":2222507,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222507/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/patch/20260412122842.1074017-1-samir@linux.ibm.com/","project":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.2/projects/59/?format=json","name":"Linux Test Project development","link_name":"ltp","list_id":"ltp.lists.linux.it","list_email":"ltp@lists.linux.it","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412122842.1074017-1-samir@linux.ibm.com>","list_archive_url":null,"date":"2026-04-12T12:28:42","name":"[v2] cfs-scheduler: Fixed \"make check\" errors and warnings.","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ba2d0790e117cdf4115a8bde250f35da5fa43114","submitter":{"id":91376,"url":"http://patchwork.ozlabs.org/api/1.2/people/91376/?format=json","name":"Samir M","email":"samir@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/ltp/patch/20260412122842.1074017-1-samir@linux.ibm.com/mbox/","series":[{"id":499603,"url":"http://patchwork.ozlabs.org/api/1.2/series/499603/?format=json","web_url":"http://patchwork.ozlabs.org/project/ltp/list/?series=499603","date":"2026-04-12T12:28:42","name":"[v2] cfs-scheduler: Fixed \"make check\" errors and warnings.","version":2,"mbox":"http://patchwork.ozlabs.org/series/499603/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222507/comments/","check":"warning","checks":"http://patchwork.ozlabs.org/api/patches/2222507/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","ltp@lists.linux.it"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ltp@picard.linux.it"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=DIaVpb0Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.linux.it\n (client-ip=213.254.12.146; helo=picard.linux.it;\n envelope-from=ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it;\n receiver=patchwork.ozlabs.org)"],"Received":["from picard.linux.it (picard.linux.it [213.254.12.146])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftqdx2Mbwz1y2d\n\tfor ; Sun, 12 Apr 2026 22:31:15 +1000 (AEST)","from picard.linux.it (localhost [IPv6:::1])\n\tby picard.linux.it (Postfix) with ESMTP id AC76E3E215B\n\tfor ; Sun, 12 Apr 2026 14:31:06 +0200 (CEST)","from in-6.smtp.seeweb.it (in-6.smtp.seeweb.it\n [IPv6:2001:4b78:1:20::6])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature ECDSA (secp384r1))\n (No client certificate requested)\n by picard.linux.it (Postfix) with ESMTPS id 6888E3CF0FF\n for ; Sun, 12 Apr 2026 14:31:01 +0200 (CEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by in-6.smtp.seeweb.it (Postfix) with ESMTPS id 9166A1400353\n for ; Sun, 12 Apr 2026 14:30:59 +0200 (CEST)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63C8rItL2007384; Sun, 12 Apr 2026 12:30:57 GMT","from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdt3kxwn-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sun, 12 Apr 2026 12:30:57 +0000 (GMT)","from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63C8Auax003557;\n Sun, 12 Apr 2026 12:30:56 GMT","from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dg1mn1ddd-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sun, 12 Apr 2026 12:30:56 +0000","from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com\n [10.20.54.102])\n by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63CCUsxW51249634\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sun, 12 Apr 2026 12:30:54 GMT","from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 4DDE92004B;\n Sun, 12 Apr 2026 12:30:54 +0000 (GMT)","from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 5A45E20040;\n Sun, 12 Apr 2026 12:30:53 +0000 (GMT)","from ltcden9-lp1.ltc.tadn.ibm.com (unknown [9.5.7.39])\n by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP;\n Sun, 12 Apr 2026 12:30:53 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:message-id:mime-version\n :subject:to; s=pp1; bh=+Vo35pBYiV28DhUCOp0Foqajb6RElCaVLseJxqfsC\n mw=; b=DIaVpb0Z3lSRPVGxW7/MRqDBefwo8hH7ui0HBCnhryvWDbsMnFyY3fGDe\n UaDILMDDKSKNe1EkX8sitKxozlcvpIeZxnGknbRTTIxP1G2tBJCXKFCxk8JKr6FW\n zQrrClh17AISM3H2+wJCwpU5qEtltbyN4C0GW27hiecoGhRPrpaIFfy1Qj7mVMMp\n qyqfMjZ1c9IJH6k5XDtuZLsZRPKiuPntly1xe1JM3c/cJUnEjzoaEMaT8c103r1T\n osSELgIs8xVBSMKcqR8jANrNR7n3UWxgl88eADwG0DAHC69Lf2JcxvUhwc46Qz7i\n u7DV6A+zvB2+2LutOUQBZ8rmuzp5A==","From":"Samir ","To":"ltp@lists.linux.it","Date":"Sun, 12 Apr 2026 14:28:42 +0200","Message-ID":"<20260412122842.1074017-1-samir@linux.ibm.com>","X-Mailer":"git-send-email 2.53.0","MIME-Version":"1.0","X-TM-AS-GCONF":"00","X-Proofpoint-ORIG-GUID":"7q_W-GbbGVeU44uJFVMrb7eDUIwZz337","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEyMDExOSBTYWx0ZWRfX9BWgmZqNgGGR\n LrYkf+dlb7ofgeesEfuRNPSF7yQMFT0NrOxbIt7Kb0jLlln+Wu0qzNstSxmDceUE4q9Yd2LzJXf\n JXKoGEGHT6b9ktHUxm141tgD035VCfd16YMLn8BKcmMZFBnGgZ/UreQPfOzz4uajWB0+1AM63ro\n p2CmUs6dl0rOMiV4TLlqkSYzYEoRAKlHOHk9rZPlBXerIfJlJtxWkKZ2FjLCe1/kgJld2i1IRXM\n Ydt3AAMPR9BrAcJIZstXFcFgoNBGGhaMyB/COjryKJD8qf57rMwuzzr4xig0c+MB0VjSEJxY+ch\n 8CYEz46uA4gXK0fZ9duRD0zavoM+uXjeY7V3RFHSaXHF8L9HPdBnAGwtBLWw1WK26nb8fqh27aL\n uUWJDIDG6fD5eJFqoSXt89FbyyeSlrGY+oTqqRYKeREFpdZWDVsGQwoN1GyG0RAbn5zeLqtMToN\n NqjSM9q5PIwmEmMOZ/w==","X-Proofpoint-GUID":"7q_W-GbbGVeU44uJFVMrb7eDUIwZz337","X-Authority-Analysis":"v=2.4 cv=WpEb99fv c=1 sm=1 tr=0 ts=69db9081 cx=c_pps\n a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Tty9oNO6AAAA:8\n a=R93Jy7f2AAAA:8 a=JfrnYn6hAAAA:8 a=QyXUC8HyAAAA:8 a=ybZZDoGAAAAA:8\n a=M_LgezkW9z8i3c8hpWEA:9 a=Bts-Es6F1CBXvF7u4C_G:22 a=_4ULuFcjZWfTdIrHNsp6:22\n a=1CNFftbPRP8L7MoqJWF3:22 a=0RhZnL1DYvcuLYC8JZ5M:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-12_02,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0\n malwarescore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604120119","X-Spam-Status":"No, score=0.1 required=7.0 tests=DKIM_SIGNED,DKIM_VALID,\n SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on in-6.smtp.seeweb.it","X-Virus-Scanned":"clamav-milter 1.0.9 at in-6.smtp.seeweb.it","X-Virus-Status":"Clean","Subject":"[LTP] [PATCH v2] cfs-scheduler: Fixed \"make check\" errors and\n warnings.","X-BeenThere":"ltp@lists.linux.it","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"Linux Test Project ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"Samir ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ltp-bounces+incoming=patchwork.ozlabs.org@lists.linux.it","Sender":"\"ltp\" "},"content":"Fixed all make check errors and warnings in cfs_bandwidth01.c and\nhackbench.c to comply with LTP coding style.\n\ncfs_bandwidth01.c:\n- Remove initialization of static variable to 0\n\nPatch v1: https://lore.kernel.org/ltp/20260407062336.127454-1-samir@linux.ibm.com/\n\nAddressed review comments from patch v1 -> patch v2\nhackbench.c:\n- Drop SPDX-License-Identifier header addition.\n- Remove obsolete header metadata.\n- Keep short description and add trailing period.\n- Remove initialization of static variables to 0.\n- Convert zero-length array to C99 flexible array.\n- Drop variadic barf() change.\n- Drop __func__-based error messages.\n- Separate assignments from if conditions.\n- Fix pointer declaration spacing.\n- Add blank line after declarations.\n- Fix spacing in macro and struct initialization.\n- Remove unnecessary braces for single statement.\n- Use Authors block for contributor attribution.\n\nSigned-off-by: Samir \n---\n .../sched/cfs-scheduler/cfs_bandwidth01.c | 2 +-\n .../kernel/sched/cfs-scheduler/hackbench.c | 71 ++++++-------------\n 2 files changed, 24 insertions(+), 49 deletions(-)","diff":"diff --git a/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c b/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c\nindex e52858f8e..8c511f060 100644\n--- a/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c\n+++ b/testcases/kernel/sched/cfs-scheduler/cfs_bandwidth01.c\n@@ -35,7 +35,7 @@\n \n static struct tst_cg_group *cg_level2, *cg_level3a, *cg_level3b;\n static struct tst_cg_group *cg_workers[3];\n-static int may_have_waiters = 0;\n+static int may_have_waiters;\n \n static void set_cpu_quota(const struct tst_cg_group *const cg,\n \t\t\t const float quota_percent)\ndiff --git a/testcases/kernel/sched/cfs-scheduler/hackbench.c b/testcases/kernel/sched/cfs-scheduler/hackbench.c\nindex 6f37060aa..846985e3b 100644\n--- a/testcases/kernel/sched/cfs-scheduler/hackbench.c\n+++ b/testcases/kernel/sched/cfs-scheduler/hackbench.c\n@@ -1,49 +1,20 @@\n /******************************************************************************/\n-/* Copyright Rusty Russell, */\n-/* Copyright Pierre Peiffer */\n-/* Copyright Zhang, Yanmin, */\n-/* Copyright Ingo Molnar, */\n-/* Copyright Arjan van de Ven, */\n /* Copyright (c) International Business Machines Corp., 2008 */\n /* */\n-/* This program is free software; you can redistribute it and/or modify */\n-/* it under the terms of the GNU General Public License as published by */\n-/* the Free Software Foundation; either version 2 of the License, or */\n-/* (at your option) any later version. */\n-/* */\n-/* This program is distributed in the hope that it will be useful, */\n-/* but WITHOUT ANY WARRANTY; without even the implied warranty of */\n-/* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See */\n-/* the GNU General Public License for more details. */\n-/* */\n-/* You should have received a copy of the GNU General Public License */\n-/* along with this program; if not, write to the Free Software */\n-/* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */\n+/* Authors: Rusty Russell */\n+/* Pierre Peiffer */\n+/* Ingo Molnar */\n+/* Arjan van de Ven */\n+/* \"Zhang, Yanmin\" */\n+/* Nathan Lynch */\n+/* Subrata Modak */\n /* */\n /******************************************************************************/\n \n /******************************************************************************/\n /* */\n-/* File: hackbench.c */\n-/* */\n /* Description: hackbench tests the Linux scheduler. Test groups of 20 */\n-/* processes spraying to 20 receivers */\n-/* */\n-/* Total Tests: 1 */\n-/* */\n-/* Test Name: hackbench01 and hackbench02 */\n-/* */\n-/* Test Assertion: */\n-/* */\n-/* Author(s): Rusty Russell , */\n-/* Pierre Peiffer , */\n-/* Ingo Molnar , */\n-/* Arjan van de Ven , */\n-/* \"Zhang, Yanmin\" , */\n-/* Nathan Lynch */\n-/* */\n-/* History: Included into LTP */\n-/* - June 26 2008 - Subrata Modak*/\n+/* processes spraying to 20 receivers. */\n /* */\n /******************************************************************************/\n #include \n@@ -59,24 +30,24 @@\n #include \n #include \n \n-#define SAFE_FREE(p) { if (p) { free(p); (p)=NULL; } }\n+#define SAFE_FREE(p) { if (p) { free(p); (p) = NULL; } }\n #define DATASIZE 100\n static struct sender_context **snd_ctx_tab;\t/*Table for sender context pointers. */\n static struct receiver_context **rev_ctx_tab;\t/*Table for receiver context pointers. */\n-static int gr_num = 0;\t\t/*For group calculation */\n+static int gr_num;\t\t/*For group calculation */\n static unsigned int loops = 100;\n /*\n * 0 means thread mode and others mean process (default)\n */\n static unsigned int process_mode = 1;\n \n-static int use_pipes = 0;\n+static int use_pipes;\n \n struct sender_context {\n \tunsigned int num_fds;\n \tint ready_out;\n \tint wakefd;\n-\tint out_fds[0];\n+\tint out_fds[];\n };\n \n struct receiver_context {\n@@ -115,7 +86,7 @@ static void fdpair(int fds[2])\n static void ready(int ready_out, int wakefd)\n {\n \tchar dummy;\n-\tstruct pollfd pollfd = {.fd = wakefd,.events = POLLIN };\n+\tstruct pollfd pollfd = {.fd = wakefd, .events = POLLIN };\n \n \t/* Tell them we're ready. */\n \tif (write(ready_out, &dummy, 1) != 1)\n@@ -210,7 +181,8 @@ pthread_t create_worker(void *ctx, void *(*func) (void *))\n \t\tbarf(\"pthread_attr_setstacksize\");\n #endif\n \n-\tif ((err = pthread_create(&childid, &attr, func, ctx)) != 0) {\n+\terr = pthread_create(&childid, &attr, func, ctx);\n+\tif (err != 0) {\n \t\tfprintf(stderr, \"pthread_create failed: %s (%d)\\n\",\n \t\t\tstrerror(err), err);\n \t\texit(-1);\n@@ -235,11 +207,12 @@ void reap_worker(pthread_t id)\n }\n \n /* One group of senders and receivers */\n-static unsigned int group(pthread_t * pth,\n+static unsigned int group(pthread_t *pth,\n \t\t\t unsigned int num_fds, int ready_out, int wakefd)\n {\n \tunsigned int i;\n \tstruct sender_context *snd_ctx = malloc(sizeof(struct sender_context) + num_fds * sizeof(int));\n+\n \tif (!snd_ctx)\n \t\tbarf(\"malloc()\");\n \telse\n@@ -305,8 +278,11 @@ int main(int argc, char *argv[])\n \t\targv++;\n \t}\n \n-\tif (argc >= 2 && (num_groups = atoi(argv[1])) == 0)\n-\t\tprint_usage_exit();\n+\tif (argc >= 2) {\n+\t\tnum_groups = atoi(argv[1]);\n+\t\tif (num_groups == 0)\n+\t\t\tprint_usage_exit();\n+\t}\n \n \tprintf(\"Running with %d*40 (== %d) tasks.\\n\",\n \t num_groups, num_groups * 40);\n@@ -363,9 +339,8 @@ int main(int argc, char *argv[])\n \n \t/* free the memory */\n \tfor (i = 0; i < num_groups; i++) {\n-\t\tfor (j = 0; j < num_fds; j++) {\n+\t\tfor (j = 0; j < num_fds; j++)\n \t\t\tSAFE_FREE(rev_ctx_tab[i * num_fds + j])\n-\t\t}\n \t\tSAFE_FREE(snd_ctx_tab[i]);\n \t}\n \tSAFE_FREE(pth_tab);\n","prefixes":["v2"]}