{"id":2222502,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222502/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260412120644.2449624-1-lgs201920130244@gmail.com/","project":{"id":21,"url":"http://patchwork.ozlabs.org/api/1.2/projects/21/?format=json","name":"Linux Tegra Development","link_name":"linux-tegra","list_id":"linux-tegra.vger.kernel.org","list_email":"linux-tegra@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260412120644.2449624-1-lgs201920130244@gmail.com>","list_archive_url":null,"date":"2026-04-12T12:06:43","name":"gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"3fff0e6c0e95c542f3f11ce6d802d2fc9b5eeead","submitter":{"id":91722,"url":"http://patchwork.ozlabs.org/api/1.2/people/91722/?format=json","name":"Guangshuo Li","email":"lgs201920130244@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-tegra/patch/20260412120644.2449624-1-lgs201920130244@gmail.com/mbox/","series":[{"id":499598,"url":"http://patchwork.ozlabs.org/api/1.2/series/499598/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-tegra/list/?series=499598","date":"2026-04-12T12:06:43","name":"gpu: host1x: Fix device reference leak in host1x_device_parse_dt() error path","version":1,"mbox":"http://patchwork.ozlabs.org/series/499598/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222502/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222502/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linux-tegra+bounces-13715-incoming=patchwork.ozlabs.org@vger.kernel.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ZX77l/4z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13715-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"ZX77l/4z\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.216.46","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftq655x8Fz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 22:07:09 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 6D600300460E\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 12:07:01 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E9432377EB9;\n\tSun, 12 Apr 2026 12:06:59 +0000 (UTC)","from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id A654830276A\n\tfor <linux-tegra@vger.kernel.org>; Sun, 12 Apr 2026 12:06:58 +0000 (UTC)","by mail-pj1-f46.google.com with SMTP id\n 98e67ed59e1d1-35f9ab079bdso185301a91.2\n        for <linux-tegra@vger.kernel.org>;\n Sun, 12 Apr 2026 05:06:58 -0700 (PDT)","from lgs.. ([199.182.234.55])\n        by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35fb617725esm144261a91.1.2026.04.12.05.06.55\n        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n        Sun, 12 Apr 2026 05:06:57 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775995619; cv=none;\n b=q5TnTjyGsZCkJ6SF+xqcupaH0twtAehqtmkXlWrlg/PlBePJ6rRjAtixv+BmLlO5uPC9q1hu4o/DVf1Oed3AH1YN0ZYfQmzee7FKWHZpW14aqEmYoF3NUDWMtgxG30sTIxaHKPTpFFDoIqzxGNNDgZRX2+UqCFg29trySrYhW7s=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775995619; c=relaxed/simple;\n\tbh=oHSFf7/X2Ol8/Td4EihiLGhPeRmAfpxGq7jBu/AYfoA=;\n\th=From:To:Cc:Subject:Date:Message-ID:MIME-Version;\n b=BwCrQUvRFvTs9rBYxDweaRk52SfIOgW+3BCmkrugdQV582W5TKygpavWB33piuWkFGbQraRIGpu6tzIZ+H8jSfI1Ow25RtH/qJSjN+NGMoOTjzfThpBffsLHDpL2GrLCH8fHj0bNQQ0oQfVMtN3jjqwT26FeqXV1LRJ3N/eykT0=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=ZX77l/4z; arc=none smtp.client-ip=209.85.216.46","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=gmail.com; s=20251104; t=1775995618; x=1776600418;\n darn=vger.kernel.org;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:from:to:cc:subject:date:message-id:reply-to;\n        bh=96a3K+dWsyVQ0u2hcswt9wA9QXsiax09F0/1rMk4SCI=;\n        b=ZX77l/4zvP3c3+vlwmo1IT3/BF21r8ab31mOtD/4q54D3KC/NDCPjGTT/108Hg4HIN\n         M3OQM4Wk/wYp3AXLgdbzOgLTEer70HiN9Wa3VpoZ8u3vVl3UvUrmGtQmVysHPs7Eovil\n         NcMbcBQvP/eu0FuUgEFonjVWcdhx3T5/ZUgir2g5MYesjcxtS3iaHsDnuegzEeNQLf9B\n         P+1iIDuHRIn8fknTr0/TBGb/bkXLv9mwotLGbJGvKf+YPbHecIavYiFyV9e8HQQyljy6\n         eI9oJ8vMDUu0eOIU2m1WG9qTlmdJGYyVMhxiHTrt2dkoSEckkd5OzG/lhtjqqf68MpFZ\n         rQPg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n        d=1e100.net; s=20251104; t=1775995618; x=1776600418;\n        h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n         :message-id:reply-to;\n        bh=96a3K+dWsyVQ0u2hcswt9wA9QXsiax09F0/1rMk4SCI=;\n        b=TVF/d6dPIxflbCdcz4P2LfWAYPRccDH9+h5ymo5BVx/56l6ERFWu2bcnhIUkfMK6X4\n         457SE5PGac7aYuMb62jErWUlMtym930/gOeKCIsangXGBYh0pqVwosPJW8KFNSiObz9U\n         qfGnJVYhp2zDjL+scHvh6OtMMQ41CPk3h/g+ACZjafTxMeEy3WLGDQxJ4f6jl6B3CC3C\n         t8gb+YTbMJ3FmZouuS/HbDtrmU7bG31tdce148re6mpswS8gEhOi8owegCZdEVZqqodu\n         Y5+rHbGlvOC2H0BktFJ4q9kbhChVnptUCn4xoB30XCnVoPJ6ItMVaVuXf6n9pJAVrnq7\n         J66A==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/ACqOhSOqPIZsjq7ONgMQzl/JMmG23GSjtbk0zHlGSRSdTqSV/7qXgF+fXaiDBb+5DlNg9g/zz7twNpg==@vger.kernel.org","X-Gm-Message-State":"AOJu0YwzDtRBBn9T+7TXnWnDFWhqGiEJ2bF0h9O9LCuYAHy4qZ/DNElu\n\tayuxZbAV1+HLFToIO4KnFEssF1sVjgoj0KDsuaqUS0gsUkbb8/0z7F12wOZL5cc1Xr0=","X-Gm-Gg":"AeBDievPSQM/t0Nw3QCHBisOzKYZk6yHSK0SB6Rqituyai1eOL+9fjr4x7n5Gp6MZwL\n\thzuKWvDOBMs+rkrMoM++26wfBUvm3ACJiCBCf5SoZDhBTYCkg2xVG/7k4Zm2/P3BUnH6nGCsbfK\n\tbiFJCtVNmzdv98hiWjF4lct/gw/d8AYkwAveBbeDD4tfYIhCDhw1PanGP7ItdCe7MYR/stLBjWh\n\te1Q0Sm5WloVkY36IAYhXdJ6k5B5DUUL7TJMv+0uCTVY7dBqAURXnkuLb4+WNgNJnO4POiO2/Vg0\n\tadMEkxIJQKcD6c53kVWBq6XxfTd49hAYcPGn9mZWDJSkoFdZFLWq8ZUNPSG9PlFL+HWxnXeULMJ\n\tTOOrLUJSIptJlnTq5K/hoXwnfzbXWyRUkuLVE3k0mN0kuAndgS3hWddwwq2JUsyeaGkWAiovEAF\n\tghKcLUx+SCJnxt0h8=","X-Received":"by 2002:a17:90a:ec85:b0:35d:a542:2dc5 with SMTP id\n 98e67ed59e1d1-35e4254116emr9347519a91.2.1775995618057;\n        Sun, 12 Apr 2026 05:06:58 -0700 (PDT)","From":"Guangshuo Li <lgs201920130244@gmail.com>","To":"Thierry Reding <thierry.reding@gmail.com>,\n\tMikko Perttunen <mperttunen@nvidia.com>,\n\tDavid Airlie <airlied@gmail.com>,\n\tSimona Vetter <simona@ffwll.ch>,\n\tMark Zhang <markz@nvidia.com>,\n\tSean Paul <seanpaul@chromium.org>,\n\tdri-devel@lists.freedesktop.org,\n\tlinux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"Guangshuo Li <lgs201920130244@gmail.com>","Subject":"[PATCH] gpu: host1x: Fix device reference leak in\n host1x_device_parse_dt() error path","Date":"Sun, 12 Apr 2026 20:06:43 +0800","Message-ID":"<20260412120644.2449624-1-lgs201920130244@gmail.com>","X-Mailer":"git-send-email 2.43.0","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"<linux-tegra.vger.kernel.org>","List-Subscribe":"<mailto:linux-tegra+subscribe@vger.kernel.org>","List-Unsubscribe":"<mailto:linux-tegra+unsubscribe@vger.kernel.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"After device_initialize(), the embedded struct device in struct\nhost1x_device should be released through the device core with\nput_device().\n\nIn host1x_device_add(), if host1x_device_parse_dt() fails, the current\nerror path frees the object directly with kfree(device). That bypasses\nthe normal device lifetime handling and leaks the reference held on the\nembedded struct device.\n\nFix this by using put_device() in the host1x_device_parse_dt() failure\npath.\n\nFixes: f4c5cf88fbd50 (\"gpu: host1x: Provide a proper struct bus_type\")\nSigned-off-by: Guangshuo Li <lgs201920130244@gmail.com>\n---\n drivers/gpu/host1x/bus.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c\nindex 723a80895cd4..f97567e6ae87 100644\n--- a/drivers/gpu/host1x/bus.c\n+++ b/drivers/gpu/host1x/bus.c\n@@ -452,7 +452,7 @@ static int host1x_device_add(struct host1x *host1x,\n \n \terr = host1x_device_parse_dt(device, driver);\n \tif (err < 0) {\n-\t\tkfree(device);\n+\t\tput_device(&device->dev);\n \t\treturn err;\n \t}\n \n","prefixes":[]}