{"id":2222371,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222371/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260411085643.3221565-3-dhowells@redhat.com/","project":{"id":12,"url":"http://patchwork.ozlabs.org/api/1.2/projects/12/?format=json","name":"Linux CIFS Client","link_name":"linux-cifs-client","list_id":"linux-cifs.vger.kernel.org","list_email":"linux-cifs@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260411085643.3221565-3-dhowells@redhat.com>","list_archive_url":null,"date":"2026-04-11T08:56:40","name":"[2/4] netfs: fix error handling in netfs_extract_user_iter()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"25e23439a1dfe08509dd584c628ece8e8f0cf738","submitter":{"id":59,"url":"http://patchwork.ozlabs.org/api/1.2/people/59/?format=json","name":"David Howells","email":"dhowells@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-cifs-client/patch/20260411085643.3221565-3-dhowells@redhat.com/mbox/","series":[{"id":499541,"url":"http://patchwork.ozlabs.org/api/1.2/series/499541/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-cifs-client/list/?series=499541","date":"2026-04-11T08:56:38","name":"netfs: Miscellaneous fixes","version":1,"mbox":"http://patchwork.ozlabs.org/series/499541/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222371/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222371/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-cifs@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=KRsfDmVP;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-cifs+bounces-10761-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=\"KRsfDmVP\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=170.10.129.124","smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=redhat.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft6z56wmtz1y2d\n\tfor ; Sat, 11 Apr 2026 18:58:41 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 83FE930276A8\n\tfor ; Sat, 11 Apr 2026 08:57:10 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 0E7AD2D321B;\n\tSat, 11 Apr 2026 08:57:10 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 51AA52DF132\n\tfor ; Sat, 11 Apr 2026 08:57:08 +0000 (UTC)","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-335-dmUAf5kmOlS93i-o0tjmrA-1; Sat,\n 11 Apr 2026 04:57:04 -0400","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id 92B2F18002CA;\n\tSat, 11 Apr 2026 08:57:02 +0000 (UTC)","from warthog.procyon.org.com (unknown [10.44.48.47])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP\n id 89B153000C1F;\n\tSat, 11 Apr 2026 08:56:58 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775897829; cv=none;\n b=NsKgBJ1qpFedY8iveGRq6ezbgOuN/5zuWA3i5YccYwpoOIfD/LVWTguVjlZsVkOCU9XueMlMSYwlKqf6NOVvdmVGU3KmzBV2GxQf5z/hmRelyy1V3roIPwxS6QRIwNuqiVCCEJDWo0AO4Ygv8gEwjCR2da8m4Vfi2smauCOvj0o=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775897829; c=relaxed/simple;\n\tbh=S62t+upgojIYhz1p6dALu+kyrentByS35lQhzLSLXbY=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=Btm5GlO/jPhcNpz/YNxDApw+ChihzgE/fk76xSUtgyDF4dOHb+eCv5wxjVuWCOfEikYBUVzmfpTbVbP93m4cZnJ/uy0IPvoV2yUE/11f3MdQ8ZXAsmfn71LnsYWqHrhEf3hY4Zd11V9S7l4FODOLWonLTSdgHjlqDBxfLrVwlrA=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=quarantine dis=none) header.from=redhat.com;\n spf=pass smtp.mailfrom=redhat.com;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.b=KRsfDmVP; arc=none smtp.client-ip=170.10.129.124","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1775897827;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\t to:to:cc:cc:mime-version:mime-version:\n\t content-transfer-encoding:content-transfer-encoding:\n\t in-reply-to:in-reply-to:references:references;\n\tbh=0M8NeyGOtxqcK9n3lFvZBV03uT/fzw4I/4MxBJJ99Zo=;\n\tb=KRsfDmVPWBonH1ozX0MndaoOKBoVtN3sCTb4IjXm5nhc21V+tpdCR3JV9aliiZHURn9Ja4\n\td9Adz86aOCwdJuUyvkKOIVxonQWI7RK4eCVYePYMz7MdCPAcO8lnaJs4673TCSffrU1A4I\n\tUdda8O5LhtprUveVNEl6Y3qwZJFjIac=","X-MC-Unique":"dmUAf5kmOlS93i-o0tjmrA-1","X-Mimecast-MFC-AGG-ID":"dmUAf5kmOlS93i-o0tjmrA_1775897822","From":"David Howells ","To":"Christian Brauner ","Cc":"David Howells ,\n\tPaulo Alcantara ,\n\tnetfs@lists.linux.dev,\n\tlinux-afs@lists.infradead.org,\n\tlinux-cifs@vger.kernel.org,\n\tceph-devel@vger.kernel.org,\n\tlinux-fsdevel@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tPaulo Alcantara ,\n\tXiaoli Feng ,\n\tstable@vger.kernel.org","Subject":"[PATCH 2/4] netfs: fix error handling in netfs_extract_user_iter()","Date":"Sat, 11 Apr 2026 09:56:40 +0100","Message-ID":"<20260411085643.3221565-3-dhowells@redhat.com>","In-Reply-To":"<20260411085643.3221565-1-dhowells@redhat.com>","References":"<20260411085643.3221565-1-dhowells@redhat.com>","Precedence":"bulk","X-Mailing-List":"linux-cifs@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4"},"content":"From: Paulo Alcantara \n\nIn netfs_extract_user_iter(), if iov_iter_extract_pages() failed to\nextract user pages, bail out on -ENOMEM, otherwise return the error\ncode only if @npages == 0, allowing short DIO reads and writes to be\nissued.\n\nThis fixes mmapstress02 from LTP tests against CIFS.\n\nFixes: 85dd2c8ff368 (\"netfs: Add a function to extract a UBUF or IOVEC into a BVEC iterator\")\nReported-by: Xiaoli Feng \nSigned-off-by: Paulo Alcantara (Red Hat) \nSigned-off-by: David Howells \nCc: netfs@lists.linux.dev\nCc: stable@vger.kernel.org\nCc: linux-cifs@vger.kernel.org\nCc: linux-fsdevel@vger.kernel.org\n---\n fs/netfs/iterator.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)","diff":"diff --git a/fs/netfs/iterator.c b/fs/netfs/iterator.c\nindex 154a14bb2d7f..adca78747f23 100644\n--- a/fs/netfs/iterator.c\n+++ b/fs/netfs/iterator.c\n@@ -22,7 +22,7 @@\n *\n * Extract the page fragments from the given amount of the source iterator and\n * build up a second iterator that refers to all of those bits. This allows\n- * the original iterator to disposed of.\n+ * the original iterator to be disposed of.\n *\n * @extraction_flags can have ITER_ALLOW_P2PDMA set to request peer-to-peer DMA be\n * allowed on the pages extracted.\n@@ -67,8 +67,8 @@ ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,\n \t\tret = iov_iter_extract_pages(orig, &pages, count,\n \t\t\t\t\t max_pages - npages, extraction_flags,\n \t\t\t\t\t &offset);\n-\t\tif (ret < 0) {\n-\t\t\tpr_err(\"Couldn't get user pages (rc=%zd)\\n\", ret);\n+\t\tif (unlikely(ret <= 0)) {\n+\t\t\tret = ret ?: -EIO;\n \t\t\tbreak;\n \t\t}\n \n@@ -97,6 +97,13 @@ ssize_t netfs_extract_user_iter(struct iov_iter *orig, size_t orig_len,\n \t\tnpages += cur_npages;\n \t}\n \n+\tif (ret < 0 && (ret == -ENOMEM || npages == 0)) {\n+\t\tfor (i = 0; i < npages; i++)\n+\t\t\tunpin_user_page(bv[i].bv_page);\n+\t\tkvfree(bv);\n+\t\treturn ret;\n+\t}\n+\n \tiov_iter_bvec(new, orig->data_source, bv, npages, orig_len - count);\n \treturn npages;\n }\n","prefixes":["2/4"]}