{"id":2222354,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222354/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260411080148.471335-13-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260411080148.471335-13-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260411080148.471335-13-kwilczynski@kernel.org/","date":"2026-04-11T08:01:36","name":"[v4,12/24] alpha/PCI: Use BAR index in sysfs attr->private instead of resource pointer","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a717314bbb1a1bba10fc022c71f5910d4caf6cda","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260411080148.471335-13-kwilczynski@kernel.org/mbox/","series":[{"id":499538,"url":"http://patchwork.ozlabs.org/api/1.2/series/499538/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=499538","date":"2026-04-11T08:01:24","name":"PCI: Convert all dynamic sysfs attributes to static","version":4,"mbox":"http://patchwork.ozlabs.org/series/499538/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222354/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222354/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=W6ti0xpR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19632-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=W6ti0xpR;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ft5lS5mV1z1yCx\n\tfor ; Sat, 11 Apr 2026 18:03:32 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4ft5kQ45Fpz2ypw;\n\tSat, 11 Apr 2026 18:02:38 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4ft5kP4MBpz2ypV\n\tfor ; Sat, 11 Apr 2026 18:02:37 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 9053E600AE;\n\tSat, 11 Apr 2026 08:02:35 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 38CA6C2BC9E;\n\tSat, 11 Apr 2026 08:02:32 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775894558;\n\tcv=none;\n b=ktBeN8oKmVuZEph7Ccfm50e+q+P32aSIUfMnh7/stQ3hMxgMldLwWwTFYg6eaVTOEwUKzYjQfWFWsumF/QQ7ZKF3f1cQRwHCq88jUHmQkKkuWUA6O3kHcym85GnKs8ncAwCTxxKJVCFZ8s97N58m0GA0IycHOyuH03GcDpnU8pOJntPgX8le4IEIcpuO8/iRL53UGk59kjcwAdX7yV6WDf/i2d3MzLRY4jsunzsnXcUUaTsbuwNXGGvKd1D0FIxpJL/x9cdwZEKyjJVgh/vqi0+V9aOot+lWvRrli39fErOBu6RJIDcX2fHARUDk93Wzzsxw3Btu7k6LZuycEjKI/Q==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775894558; c=relaxed/relaxed;\n\tbh=w6Pg1tzYCcjCxtB/I/WX6QybAmZXuv8mftDcIyAHmX0=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=LYZtaBP+5h0WKkYQ1UPyQUrncojypa2ETmC9J3Zs0GYMZayn7fnA7jTlvcpHe+MdCU8icvnjXBbD5sxp5EqVRf7usbIV7s58JWfL+ZgajxAM39otcjhLBL8Dupk8f2yhAxxNtnOdJykEl5oJBOkypjgwH3uf/1JhnIIoWXyFU/uTBAbtmgLGiIzcy4uyf/g9xYxb8XQj+FMTu10W/ZeyDkxbRX2vVpFBLd9xH4xTqQI9H1LRYdM0+m8XP7m+x41ZElBU68d7495LyUglItnK1LUvPVaewpGUobIVLD+BLgE4+tM3P12+STsxXFQ6uBstSL1w+qtvAc6ZPJaTun0PKA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=W6ti0xpR; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775894555;\n\tbh=4+W1kd8ovvTGg2a+x1mXoEZZdmh6JcYJxVFeZ3Yu0xQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=W6ti0xpRbuKzeGReO+1yu9MNEg0/ssxI8ndwhH89aUR2pZvrm+Hzf9jXo9RBl8m6+\n\t DVLnytiGA+zzwlFrJOOgpEJKodfue9xRonZTTv6wjBJrgNxuV5ssxeMgnhCqaN15W+\n\t JtXogcrOmdr1c5Wlg6WCl3C7rSwByygvuAtmxteZZXugIF6bK7rjCivXrrpF5siZ3k\n\t tXB0GagfGt/V6nfPBZI5LPVhaPycgvvii9kat0SZNLeUMDYb/u0d4OHlzOyuvVMwx3\n\t nXlVzMwqONChr8vyoMMmFwZnBP9NBaueMG197WrTyej0NOcxrRmKs0teomzvSlyTQ9\n\t l7gsh7dKK+qIg==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v4 12/24] alpha/PCI: Use BAR index in sysfs attr->private\n instead of resource pointer","Date":"Sat, 11 Apr 2026 08:01:36 +0000","Message-ID":"<20260411080148.471335-13-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260411080148.471335-1-kwilczynski@kernel.org>","References":"<20260411080148.471335-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, Alpha's pci_create_one_attr() stores a resource pointer in\nattr->private, and pci_mmap_resource() loops through all BARs to find\nthe matching index.\n\nThus, store the BAR index directly in attr->private and retrieve the\nresource via pci_resource_n(). This eliminates the loop and aligns\nwith the convention used by the generic PCI sysfs code.\n\nWhile at it, add parentheses around the bitwise flag test in\npci_mmap_resource() to make the precedence explicit, and to\nmatch the preferred style.\n\nThe PCI core change was first added in the commit dca40b186b75 (\"PCI:\nUse BAR index in sysfs attr->private instead of resource pointer\").\n\nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 17 ++++++-----------\n 1 file changed, 6 insertions(+), 11 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2324720c3e83..c84867ce31f5 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -69,25 +69,20 @@ static int pci_mmap_resource(struct kobject *kobj,\n \t\t\t struct vm_area_struct *vma, int sparse)\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n-\tstruct resource *res = attr->private;\n+\tint barno = (unsigned long)attr->private;\n+\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n-\tint i, ret;\n+\tint ret;\n \n \tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n \tif (ret)\n \t\treturn ret;\n \n-\tfor (i = 0; i < PCI_STD_NUM_BARS; i++)\n-\t\tif (res == &pdev->resource[i])\n-\t\t\tbreak;\n-\tif (i >= PCI_STD_NUM_BARS)\n-\t\treturn -ENODEV;\n-\n-\tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n+\tif ((res->flags & IORESOURCE_MEM) && iomem_is_exclusive(res->start))\n \t\treturn -EINVAL;\n \n-\tif (!__pci_mmap_fits(pdev, i, vma, sparse))\n+\tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n \tpcibios_resource_to_bus(pdev->bus, &bar, res);\n@@ -170,7 +165,7 @@ static int pci_create_one_attr(struct pci_dev *pdev, int num, char *name,\n \tres_attr->attr.name = name;\n \tres_attr->attr.mode = S_IRUSR | S_IWUSR;\n \tres_attr->size = sparse ? size << 5 : size;\n-\tres_attr->private = &pdev->resource[num];\n+\tres_attr->private = (void *)(unsigned long)num;\n \treturn sysfs_create_bin_file(&pdev->dev.kobj, res_attr);\n }\n \n","prefixes":["v4","12/24"]}