{"id":2222262,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222262/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411022618.2136588-7-kshk@linux.ibm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260411022618.2136588-7-kshk@linux.ibm.com>","list_archive_url":null,"date":"2026-04-11T02:26:09","name":"[v2,06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from S390PCIIOMMU","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a7bafae41bde8fe2c352986dcd966a16ecd07feb","submitter":{"id":90249,"url":"http://patchwork.ozlabs.org/api/1.2/people/90249/?format=json","name":"Konstantin Shkolnyy","email":"kshk@linux.ibm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260411022618.2136588-7-kshk@linux.ibm.com/mbox/","series":[{"id":499525,"url":"http://patchwork.ozlabs.org/api/1.2/series/499525/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=499525","date":"2026-04-11T02:26:13","name":"s390x/pci: Implement migration for emulated devices","version":2,"mbox":"http://patchwork.ozlabs.org/series/499525/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222262/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222262/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=RDHVnJmI;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsyKy36SLz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 11 Apr 2026 12:29:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wBO3u-00025v-2B; Fri, 10 Apr 2026 22:27:06 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kshk@linux.ibm.com>)\n id 1wBO3s-000237-Hu; Fri, 10 Apr 2026 22:27:04 -0400","from mx0b-001b2d01.pphosted.com ([148.163.158.5])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <kshk@linux.ibm.com>)\n id 1wBO3p-0000MQ-Pa; Fri, 10 Apr 2026 22:27:04 -0400","from pps.filterd (m0356516.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63B2OexH2497353; Sat, 11 Apr 2026 02:26:57 GMT","from ppma23.wdc07v.mail.ibm.com\n (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfbqk87f0-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2026 02:26:57 +0000 (GMT)","from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63B0Cfc0013882;\n Sat, 11 Apr 2026 02:26:56 GMT","from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74])\n by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4dcmf4k1r3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Sat, 11 Apr 2026 02:26:56 +0000","from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63B2QtsJ2294326\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Sat, 11 Apr 2026 02:26:55 GMT","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id 679795805A;\n Sat, 11 Apr 2026 02:26:55 +0000 (GMT)","from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id CE3F358054;\n Sat, 11 Apr 2026 02:26:54 +0000 (GMT)","from WIN-DU0DFC9G5VV.ibm.com (unknown [9.61.252.248])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Sat, 11 Apr 2026 02:26:54 +0000 (GMT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n :content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=pp1; bh=W0304v40uMg9cvp2E\n 1tL4dSTvNqIXAhMIqxF4i8Fq+s=; b=RDHVnJmIyWF2EaH9N4ewhOSxu1OUKFmUG\n mYJT1RRgHLMQeysIDJDOO4k719a6wUi8FTL96TmDJ9gZToU5qO4z5IUT95QN0Ywq\n 7OgQ9RTtbuMkU8rAYoyCv67/gC9q9dq3lXLNp6vJnizq3BNk31UO4UcZH14dsAqr\n C8CiKRo71iDkCCapT0NY+LI9toKXJ7ZeEZYBML2gGy5aE2Zxr1vg7SjJgjHjSN0e\n tb/MXbaySOKdSPJ4Xk7ukAQ1qJjPO6JOVjmWNZBo3w40YAuHNnc4q9fQDHK1OZTR\n L+Kpa3CMN7E5lQVc9dQTZRY7CSKXGNPBxWrqKWb+Euam2h5iVRU6Q==","From":"Konstantin Shkolnyy <kshk@linux.ibm.com>","To":"mjrosato@linux.ibm.com","Cc":"alifm@linux.ibm.com, richard.henderson@linaro.org, iii@linux.ibm.com,\n david@kernel.org, cohuck@redhat.com, pasic@linux.ibm.com,\n borntraeger@linux.ibm.com, qemu-s390x@nongnu.org,\n qemu-devel@nongnu.org, Konstantin Shkolnyy <kshk@linux.ibm.com>","Subject":"[PATCH v2 06/15] s390x/pci: Remove a ptr to S390PCIBusDevice from\n S390PCIIOMMU","Date":"Fri, 10 Apr 2026 21:26:09 -0500","Message-Id":"<20260411022618.2136588-7-kshk@linux.ibm.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20260411022618.2136588-1-kshk@linux.ibm.com>","References":"<20260411022618.2136588-1-kshk@linux.ibm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-TM-AS-GCONF":"00","X-Authority-Analysis":"v=2.4 cv=I+9Vgtgg c=1 sm=1 tr=0 ts=69d9b171 cx=c_pps\n a=3Bg1Hr4SwmMryq2xdFQyZA==:117 a=3Bg1Hr4SwmMryq2xdFQyZA==:17\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22\n a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VnNF1IyMAAAA:8 a=yINFAIt2aqTEABBYJGoA:9","X-Proofpoint-GUID":"eSKuwzQSKqDHCAXXvpKXFYxN5XFhPe-W","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDExMDAxNiBTYWx0ZWRfXyrzGzXsZmgku\n w53xQ7YiwdodnC8HIk13Y/nDplZpqOTLTE7nlcYYQ820pgT6V1xZpA1nIJHrhmG+l7qaFL380JX\n Zz2cdMKeCTPZMwDP2AyrKCbTzTAE3414EN93f9WY11lWT88a29UOCJAhhw4NNBgv1mFHROTIXrX\n GAmbG6qKIAaDjEqUhd4l/vZXd1isnuzaACJHFYfVzh/0O0t+Hw5/DhTO3PbvPQPllIx6EyaB0x4\n wfeAaERiGMFHdIYc8Jj9bdMNlTnVU443hP+l1QfGWf+IFZNRUzPz9xbVj5hIbZx6AMY6hx2HZmw\n NK221rg2LbBJTjZxSgLAZT2JGvGJO3PQVO95sYnX/r25tSh4Mc4t+2ygfkz1dp3mDxLBND5M+pF\n nYKJWIob71oax/iuZeB6syqcwOrqbtMTL3TprGtjlQUN3iALFVfBtjHHn24xQjK82sOsxgu4Yy/\n GUYMwx73wvRG6DtZPJw==","X-Proofpoint-ORIG-GUID":"eSKuwzQSKqDHCAXXvpKXFYxN5XFhPe-W","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-10_07,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 adultscore=0\n lowpriorityscore=0 spamscore=0 malwarescore=0 clxscore=1015 phishscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604110016","Received-SPF":"pass client-ip=148.163.158.5; envelope-from=kshk@linux.ibm.com;\n helo=mx0b-001b2d01.pphosted.com","X-Spam_score_int":"-26","X-Spam_score":"-2.7","X-Spam_bar":"--","X-Spam_report":"(-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7,\n RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"This pointer is no longer used, after fields were moved from S390PCIIOMMU\nto S390PCIBusDevice.\n\nSigned-off-by: Konstantin Shkolnyy <kshk@linux.ibm.com>\n---\n hw/s390x/s390-pci-bus.c         | 15 +++++++--------\n include/hw/s390x/s390-pci-bus.h |  1 -\n 2 files changed, 7 insertions(+), 9 deletions(-)","diff":"diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c\nindex 3f3123e62a..83e9ca99f3 100644\n--- a/hw/s390x/s390-pci-bus.c\n+++ b/hw/s390x/s390-pci-bus.c\n@@ -551,7 +551,7 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,\n         .perm = IOMMU_NONE,\n     };\n \n-    switch (iommu->pbdev->state) {\n+    switch (pbdev->state) {\n     case ZPCI_FS_ENABLED:\n     case ZPCI_FS_BLOCKED:\n         if (!iommu->enabled) {\n@@ -586,9 +586,9 @@ static IOMMUTLBEntry s390_translate_iommu(IOMMUMemoryRegion *mr, hwaddr addr,\n     }\n err:\n     if (error) {\n-        iommu->pbdev->state = ZPCI_FS_ERROR;\n-        s390_pci_generate_error_event(error, iommu->pbdev->fh,\n-                                      iommu->pbdev->fid, addr, 0);\n+        pbdev->state = ZPCI_FS_ERROR;\n+        s390_pci_generate_error_event(error, pbdev->fh,\n+                                      pbdev->fid, addr, 0);\n     }\n     return ret;\n }\n@@ -767,7 +767,7 @@ void s390_pci_iommu_enable(S390PCIBusDevice *pbdev)\n      * so the smallest IOMMU region we can define runs from 0 to the end\n      * of the PCI address space.\n      */\n-    char *name = g_strdup_printf(\"iommu-s390-%04x\", iommu->pbdev->uid);\n+    char *name = g_strdup_printf(\"iommu-s390-%04x\", pbdev->uid);\n     memory_region_init_iommu(&pbdev->iommu_mr, sizeof(pbdev->iommu_mr),\n                              TYPE_S390_IOMMU_MEMORY_REGION, OBJECT(&iommu->mr),\n                              name, iommu->pal + 1);\n@@ -788,14 +788,14 @@ void s390_pci_iommu_direct_map_enable(S390PCIBusDevice *pbdev)\n      * IOVA X + SDMA.  VFIO will handle pinning via its memory listener.\n      */\n     g_autofree char *name = g_strdup_printf(\"iommu-dm-s390-%04x\",\n-                                            iommu->pbdev->uid);\n+                                            pbdev->uid);\n \n     pbdev->dm_mr = g_malloc0(sizeof(*pbdev->dm_mr));\n     memory_region_init_alias(pbdev->dm_mr, OBJECT(&iommu->mr), name,\n                              get_system_memory(), 0,\n                              s390_get_memory_limit(s390ms));\n     iommu->enabled = true;\n-    memory_region_add_subregion(&iommu->mr, iommu->pbdev->zpci_fn.sdma,\n+    memory_region_add_subregion(&iommu->mr, pbdev->zpci_fn.sdma,\n                                 pbdev->dm_mr);\n }\n \n@@ -1187,7 +1187,6 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_dev, DeviceState *dev,\n \n         pbdev->pdev = pdev;\n         pbdev->iommu = s390_pci_get_iommu(s, pci_get_bus(pdev), pdev->devfn);\n-        pbdev->iommu->pbdev = pbdev;\n         pbdev->state = ZPCI_FS_DISABLED;\n         set_pbdev_info(pbdev);\n \ndiff --git a/include/hw/s390x/s390-pci-bus.h b/include/hw/s390x/s390-pci-bus.h\nindex d9bafd6859..fcaaf19512 100644\n--- a/include/hw/s390x/s390-pci-bus.h\n+++ b/include/hw/s390x/s390-pci-bus.h\n@@ -273,7 +273,6 @@ typedef struct S390PCIDMACount {\n \n struct S390PCIIOMMU {\n     Object parent_obj;\n-    S390PCIBusDevice *pbdev;\n     AddressSpace as;\n     MemoryRegion mr;\n     bool enabled;\n","prefixes":["v2","06/15"]}