{"id":2222237,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2222237/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260411003959.30959-2-emil.s.tantilov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260411003959.30959-2-emil.s.tantilov@intel.com>","list_archive_url":null,"date":"2026-04-11T00:39:58","name":"[iwl-next,1/2] idpf: remove conditonal MBX deinit from idpf_vc_core_deinit()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ddcba813320dbe08ec54006f64074a35edac7547","submitter":{"id":1670,"url":"http://patchwork.ozlabs.org/api/1.2/people/1670/?format=json","name":"Tantilov, Emil S","email":"emil.s.tantilov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260411003959.30959-2-emil.s.tantilov@intel.com/mbox/","series":[{"id":499519,"url":"http://patchwork.ozlabs.org/api/1.2/series/499519/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=499519","date":"2026-04-11T00:39:57","name":"Introduce IDPF PCI callbacks","version":1,"mbox":"http://patchwork.ozlabs.org/series/499519/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2222237/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2222237/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Pq+sRtpC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsvvl5Bcdz1yCx\n\tfor ; Sat, 11 Apr 2026 10:40:03 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 93BD1405A2;\n\tSat, 11 Apr 2026 00:39:57 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id J1RFxb0WsEBi; Sat, 11 Apr 2026 00:39:55 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id D28344025C;\n\tSat, 11 Apr 2026 00:39:55 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 66EEE194\n for ; Sat, 11 Apr 2026 00:39:54 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 44D81414BE\n for ; Sat, 11 Apr 2026 00:39:53 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bWqgO8luptE9 for ;\n Sat, 11 Apr 2026 00:39:52 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.16])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 939DA41753\n for ; Sat, 11 Apr 2026 00:39:52 +0000 (UTC)","from orviesa010.jf.intel.com ([10.64.159.150])\n by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 17:39:51 -0700","from estantil-desk.jf.intel.com ([10.166.241.24])\n by orviesa010.jf.intel.com with ESMTP; 10 Apr 2026 17:39:51 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org D28344025C","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 939DA41753"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775867995;\n\tbh=ompqMLO0FpOnjSJ67voGfooRZTz61clLZLJwY7an6Gs=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Pq+sRtpC9k85Q6w96mTOVBMQTfWBbhzO0VvtwJsBzgMjKzvEZRI+Bx3VLBuTHmYPs\n\t 8cY3CpJktOli4H5bY/yuaz/aLWNoPTJj/iCk+bt48JXCeBARcPvNWSoHNh4GHnUdLi\n\t Pw0D4DnAraYY1UzSUE6e+49iD41YMbKzVgdjug4+zMurQ9PUsUcpYhKVhgYYjAzg1K\n\t hurFvQuu6ojxxXqHCRYUczuysJpi/BGHOabDAI14/pVoRgHE8OgtemSVEaE+WUpwXG\n\t pthL9tDbMT3WIsCNxGf9LA94dQoxLcaUqc08nru60VscIC4zA4hbEUh9Yt7oVFLkdp\n\t eTZ947bwt+bww==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.16;\n helo=mgamail.intel.com; envelope-from=emil.s.tantilov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 939DA41753","X-CSE-ConnectionGUID":["nXm5T178R1WAa2ZAXZ8iyg==","PiUauI7oSXq01LAz3hPfzA=="],"X-CSE-MsgGUID":["SW+fjpEcRsq0oYsgeUnzAA==","Iot3WUGkQ42RCe3vJhrIdg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11755\"; a=\"64423725\"","E=Sophos;i=\"6.23,172,1770624000\"; d=\"scan'208\";a=\"64423725\"","E=Sophos;i=\"6.23,172,1770624000\"; d=\"scan'208\";a=\"228392490\""],"X-ExtLoop1":"1","From":"Emil Tantilov ","To":"intel-wired-lan@lists.osuosl.org","Cc":"netdev@vger.kernel.org, przemyslaw.kitszel@intel.com, jay.bhat@intel.com,\n ivan.d.barrera@intel.com, aleksandr.loktionov@intel.com,\n larysa.zaremba@intel.com, anthony.l.nguyen@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com, aleksander.lobakin@intel.com,\n linux-pci@vger.kernel.org, madhu.chittim@intel.com, decot@google.com,\n willemb@google.com, sheenamo@google.com","Date":"Fri, 10 Apr 2026 17:39:58 -0700","Message-Id":"<20260411003959.30959-2-emil.s.tantilov@intel.com>","X-Mailer":"git-send-email 2.17.2","In-Reply-To":"<20260411003959.30959-1-emil.s.tantilov@intel.com>","References":"<20260411003959.30959-1-emil.s.tantilov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775867992; x=1807403992;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references;\n bh=fJ+x0FuS4kfTxKVTAiQAsAjahv+Ub5YWK+sKz1QUweY=;\n b=RVqJbQ9247ijNadt2FgiEdROBGGqofwFenttURyCIFwTRbQkUwwnRIvg\n vXsbHts7IYQahtXnhmfyikgiHiRA/6dxme2P8YlJB/GM7rRYP1gkhChzy\n FnFC38fneWTCV/QFnEcn3GKFCCVxY05EOdA374CTNb0ufqDA06uRYQT8z\n UE9JnwmN/JdnRG95/6qMCOiYk9FiNC8A8RrjGT+f39CA4ll3yey1RM2zM\n tR4tDQB477575lSsceSITFVJ9mFcZIlzTU9V0KcFxqh3MTbFL9F8at6a8\n vJ8Uru1ts/fds0bmuHybP83gOFZkXh7crhdAsqirKxOivcJEvR0WHYsKj\n A==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=RVqJbQ92"],"Subject":"[Intel-wired-lan] [PATCH iwl-next 1/2] idpf: remove conditonal MBX\n deinit from idpf_vc_core_deinit()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Previously it was assumed that idpf_vc_core_deinit() is always being\ncalled during reset handling, with remove being an exception. Ideally\nthe driver needs to communicate the changes to FW in all instances where\nthe MBX is not already disabled. Remove the remove_in_prog check from\nidpf_vc_core_deinit() as the MBX was already disabled while handling the\nreset via libie_ctlq_xn_shutdown() by the service task. This is also\nneeded by the following patch, introducing PCI callbacks support.\n\nSigned-off-by: Emil Tantilov \nReviewed-by: Jay Bhat \nReviewed-by: Madhu Chittim \n---\n drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 11 +----------\n 1 file changed, 1 insertion(+), 10 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\nindex 129c8f6b0faa..fceaf3ec1cd4 100644\n--- a/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n+++ b/drivers/net/ethernet/intel/idpf/idpf_virtchnl.c\n@@ -3229,24 +3229,15 @@ int idpf_vc_core_init(struct idpf_adapter *adapter)\n */\n void idpf_vc_core_deinit(struct idpf_adapter *adapter)\n {\n-\tbool remove_in_prog;\n-\n \tif (!test_bit(IDPF_VC_CORE_INIT, adapter->flags))\n \t\treturn;\n \n-\t/* Avoid transaction timeouts when called during reset */\n-\tremove_in_prog = test_bit(IDPF_REMOVE_IN_PROG, adapter->flags);\n-\tif (!remove_in_prog)\n-\t\tidpf_deinit_dflt_mbx(adapter);\n-\n \tidpf_ptp_release(adapter);\n \tidpf_deinit_task(adapter);\n \tidpf_idc_deinit_core_aux_device(adapter);\n \tidpf_rel_rx_pt_lkup(adapter);\n \tidpf_intr_rel(adapter);\n-\n-\tif (remove_in_prog)\n-\t\tidpf_deinit_dflt_mbx(adapter);\n+\tidpf_deinit_dflt_mbx(adapter);\n \n \tcancel_delayed_work_sync(&adapter->serv_task);\n \n","prefixes":["iwl-next","1/2"]}